[edk2-devel] [PATCH edk2-platforms 0/5] Platform,Silicon: drop use of PcdArmArchTimerFreqInHz

[edk2-devel] [PATCH edk2-platforms 0/5] Platform,Silicon: drop use of PcdArmArchTimerFreqInHz

[Leif Lindholm]

Related to https://github.com/tianocore/edk2/pull/5797

PcdArmArchTimerFreqInHz is about to be removed, as it is now obsolete.
Its functionality has been partially broken, and mostly ignored, for
all AArch64 platforms since December 2020.

This set cleans up some broken line endings in .dsc* files, then
drops all non-invasive references to the Pcd:
- .dsc* files setting it to 0 (which is the default in the definition,
  and means "just read it from the system register instead")
- .inf files declaring a dependency that is in fact not there in
  current code.

Finally, it drops the setting of the Pcd for platforms that set it to
non-0. This has *never* done the right thing on these platforms since
they are all AArch64, but it may affect timer timeout, so deserves
deeper testing.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Chuong Tran <chuong@os.amperecomputing.com>
Cc: Graeme Gregory <graeme@xora.org.uk>
Cc: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Cc: Marcin Wojtas <marcin.s.wojtas@gmail.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Cc: Narinder Dhillon <ndhillon@marvell.com>
Cc: Nhi Pham <nhi@os.amperecomputing.com>
Cc: Rebecca Cran <rebecca@os.amperecomputing.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Thomas Abraham <thomas.abraham@arm.com>
Cc: Wenyi Xie <xiewenyi2@huawei.com>

Leif Lindholm (5):
  Platform/SbsaQemu: fix .dsc line endings
  Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz
  Platform/ARM: drop use of PcdArmArchTimerFreqInHz
  Platform/Hisilicon: drop D05 use of PcdArmArchTimerFreqInHz
  Silicon/Marvell: drop use of PcdArmArchTimerFreqInHz

 Platform/ARM/Morello/MorelloPlatform.dsc.inc                                   | 4 +---
 Platform/ARM/SgiPkg/SgiPlatform.dsc.inc                                        | 2 --
 Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc                           | 7 +------
 Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc                                  | 4 +---
 Silicon/NXP/NxpQoriqLs.dsc.inc                                                 | 5 +----
 Platform/ARM/JunoPkg/ArmJuno.dsc                                               | 6 ------
 Platform/ARM/N1Sdp/N1SdpPlatform.dsc                                           | 2 --
 Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc                           | 6 ------
 Platform/Hisilicon/D03/D03.dsc                                                 | 8 --------
 Platform/Hisilicon/D05/D05.dsc                                                 | 6 ------
 Platform/Hisilicon/D06/D06.dsc                                                 | 8 --------
 Platform/Qemu/SbsaQemu/SbsaQemu.dsc                                            | 7 +------
 Platform/Hisilicon/D03/Library/HisiOemMiscLib2P/HisiOemMiscLib2PHi1610.inf     | 1 -
 Platform/Hisilicon/D05/Library/HisiOemMiscLibD05/HisiOemMiscLibD05.inf         | 1 -
 Platform/Hisilicon/D06/Library/HisiOemMiscLibD06/HisiOemMiscLibD06.inf         | 1 -
 Silicon/AMD/Styx/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf               | 1 -
 Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf | 1 -
 17 files changed, 5 insertions(+), 65 deletions(-)

-- 
2.39.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119653): https://edk2.groups.io/g/devel/message/119653
Mute This Topic: https://groups.io/mt/106780872/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH edk2-platforms 1/5] Platform/SbsaQemu: fix .dsc line endings

[Leif Lindholm]

A patch adding a mapping for ImagePropertiesRecordLib introduced a bunch of
LF line endings in otherwise CRLF files, so clean that up.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Chuong Tran <chuong@os.amperecomputing.com>
Cc: Graeme Gregory <graeme@xora.org.uk>
Cc: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Cc: Marcin Wojtas <marcin.s.wojtas@gmail.com>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Cc: Narinder Dhillon <ndhillon@marvell.com>
Cc: Nhi Pham <nhi@os.amperecomputing.com>
Cc: Rebecca Cran <rebecca@os.amperecomputing.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Thomas Abraham <thomas.abraham@arm.com>
Signed-off-by: Leif Lindholm <quic_llindhol@quicinc.com>
---
 Platform/ARM/Morello/MorelloPlatform.dsc.inc         | 2 +-
 Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 2 +-
 Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc        | 2 +-
 Silicon/NXP/NxpQoriqLs.dsc.inc                       | 2 +-
 Platform/Qemu/SbsaQemu/SbsaQemu.dsc                  | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/Platform/ARM/Morello/MorelloPlatform.dsc.inc b/Platform/ARM/Morello/MorelloPlatform.dsc.inc
index 660fd6cb2f17..e7f4b6d0dde8 100644
--- a/Platform/ARM/Morello/MorelloPlatform.dsc.inc
+++ b/Platform/ARM/Morello/MorelloPlatform.dsc.inc
@@ -13,7 +13,7 @@ [LibraryClasses.common]
   BasePathLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
   HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
   TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
-  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
+  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
 
   # Ramdisk Support
   FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
index 23579497661d..eb6caf37a3c5 100644
--- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
+++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
@@ -46,7 +46,7 @@ [LibraryClasses.common]
   HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
   UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
   UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
-  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
+  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
 
   #
   # Allow dynamic PCDs
diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
index a7a4f47ef3d5..ab719f360eda 100644
--- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
+++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
@@ -71,7 +71,7 @@ [LibraryClasses.common]
   UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
   VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
-  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
+  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
 
   PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
 
diff --git a/Silicon/NXP/NxpQoriqLs.dsc.inc b/Silicon/NXP/NxpQoriqLs.dsc.inc
index da76bd6b1de5..920d2f6c4ddf 100644
--- a/Silicon/NXP/NxpQoriqLs.dsc.inc
+++ b/Silicon/NXP/NxpQoriqLs.dsc.inc
@@ -98,7 +98,7 @@ [LibraryClasses.common]
   NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
   ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
   UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
-  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
+  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
 
   I2cLib|Silicon/NXP/Library/I2cLib/I2cLib.inf
   ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
index 221322cca030..4fea9a0d6380 100644
--- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
+++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
@@ -78,7 +78,7 @@ [LibraryClasses.common]
   SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
   ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
   FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf
-  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
+  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
 
   UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
   OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
-- 
2.39.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119654): https://edk2.groups.io/g/devel/message/119654
Mute This Topic: https://groups.io/mt/106780873/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH edk2-platforms 2/5] Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz

[Leif Lindholm]

PcdArmArchTimerFreqInHz is about to be removed, as it is now obsolete.
Some platforms already explicitly set it to 0, which is the default.
And some modules reference it in their .inf without actually ever
using it.

Drop these redundant uses first.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Chuong Tran <chuong@os.amperecomputing.com>
Cc: Graeme Gregory <graeme@xora.org.uk>
Cc: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Cc: Nhi Pham <nhi@os.amperecomputing.com>
Cc: Rebecca Cran <rebecca@os.amperecomputing.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Thomas Abraham <thomas.abraham@arm.com>
Cc: Wenyi Xie <xiewenyi2@huawei.com>
Signed-off-by: Leif Lindholm <quic_llindhol@quicinc.com>
---
 Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc                           | 5 -----
 Silicon/NXP/NxpQoriqLs.dsc.inc                                                 | 3 ---
 Platform/ARM/JunoPkg/ArmJuno.dsc                                               | 6 ------
 Platform/Hisilicon/D03/D03.dsc                                                 | 8 --------
 Platform/Hisilicon/D06/D06.dsc                                                 | 8 --------
 Platform/Qemu/SbsaQemu/SbsaQemu.dsc                                            | 5 -----
 Platform/Hisilicon/D03/Library/HisiOemMiscLib2P/HisiOemMiscLib2PHi1610.inf     | 1 -
 Platform/Hisilicon/D05/Library/HisiOemMiscLibD05/HisiOemMiscLibD05.inf         | 1 -
 Platform/Hisilicon/D06/Library/HisiOemMiscLibD06/HisiOemMiscLibD06.inf         | 1 -
 Silicon/AMD/Styx/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf               | 1 -
 Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf | 1 -
 11 files changed, 40 deletions(-)

diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
index eb6caf37a3c5..1f705c68579a 100644
--- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
+++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
@@ -458,11 +458,6 @@ [PcdsFixedAtBuild.common]
   gArmTokenSpaceGuid.PcdGicDistributorBase|0x100100000000
   gArmTokenSpaceGuid.PcdGicRedistributorsBase|0x100100140000
 
-  #
-  # ARM Architectural Timer Frequency
-  #
-  # Set it to 0 so that the code will read frequence from register
-  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|0
   gEmbeddedTokenSpaceGuid.PcdMetronomeTickPeriod|1000
 
   #
diff --git a/Silicon/NXP/NxpQoriqLs.dsc.inc b/Silicon/NXP/NxpQoriqLs.dsc.inc
index 920d2f6c4ddf..21549dc20aa7 100644
--- a/Silicon/NXP/NxpQoriqLs.dsc.inc
+++ b/Silicon/NXP/NxpQoriqLs.dsc.inc
@@ -290,9 +290,6 @@ [PcdsFixedAtBuild.common]
   gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate|115200
   gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4
 
-  # Timer
-  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|0
-
   # We want to use the Shell Libraries but don't want it to initialise
   # automatically. We initialise the libraries when the command is called by the
   # Shell.
diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc
index 1ca43b9e7dba..93ec9f129972 100644
--- a/Platform/ARM/JunoPkg/ArmJuno.dsc
+++ b/Platform/ARM/JunoPkg/ArmJuno.dsc
@@ -191,12 +191,6 @@ [PcdsFixedAtBuild.common]
   # List of Device Paths that support BootMonFs
   gArmBootMonFsTokenSpaceGuid.PcdBootMonFsSupportedDevicePaths|L"VenHw(DE6AE758-D662-4E17-A97C-4C5964DA4C41,00)"
 
-  #
-  # ARM Architectural Timer Frequency
-  #
-  # Set to 0 so ArmArchTimerLib will read its value from CNTFRQ_EL0
-  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|0
-
   gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
 
   #
diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc
index 66c2bb31a5ef..e70dc97ee894 100644
--- a/Platform/Hisilicon/D03/D03.dsc
+++ b/Platform/Hisilicon/D03/D03.dsc
@@ -191,14 +191,6 @@ [PcdsFixedAtBuild.common]
   gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0xFE000000
   gArmTokenSpaceGuid.PcdGicRedistributorsBase|0x4D100000
 
-  #
-  # ARM Architectual Timer Frequency
-  #
-  # Set it to 0 so that the code will read frequence from register and be
-  # adapted to 66M and 50M boards
-  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|0
-
-
   gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
   gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
 
diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc
index f8a8dad01a0e..6e0fcf633404 100644
--- a/Platform/Hisilicon/D06/D06.dsc
+++ b/Platform/Hisilicon/D06/D06.dsc
@@ -167,14 +167,6 @@ [PcdsFixedAtBuild.common]
   gArmTokenSpaceGuid.PcdGicRedistributorsBase|0xAE100000
   gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0x9B000000
 
-
-
-  #
-  # ARM Architectual Timer Frequency
-  #
-  # Set it to 0 so that the code will read frequency from register and be
-  # adapted to 100M and 50M boards
-  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|0
   gEmbeddedTokenSpaceGuid.PcdTimerPeriod|10000
 
 
diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
index 4fea9a0d6380..9306986bf7c0 100644
--- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
+++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
@@ -415,11 +415,6 @@ [PcdsFixedAtBuild.common]
   ## 0-PCANSI, 1-VT100, 2-VT00+, 3-UTF8, 4-TTYTERM
   gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4
 
-  #
-  # ARM Virtual Architectural Timer -- fetch frequency from QEMU (TCG) or KVM
-  #
-  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|0
-
   gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
 
   gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
diff --git a/Platform/Hisilicon/D03/Library/HisiOemMiscLib2P/HisiOemMiscLib2PHi1610.inf b/Platform/Hisilicon/D03/Library/HisiOemMiscLib2P/HisiOemMiscLib2PHi1610.inf
index a91444c71dcb..59887f2b1029 100644
--- a/Platform/Hisilicon/D03/Library/HisiOemMiscLib2P/HisiOemMiscLib2PHi1610.inf
+++ b/Platform/Hisilicon/D03/Library/HisiOemMiscLib2P/HisiOemMiscLib2PHi1610.inf
@@ -39,7 +39,6 @@ [Ppis]
 
 [Pcd]
   gHisiTokenSpaceGuid.PcdTrustedFirmwareEnable
-  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz
 
 [FixedPcd.common]
 
diff --git a/Platform/Hisilicon/D05/Library/HisiOemMiscLibD05/HisiOemMiscLibD05.inf b/Platform/Hisilicon/D05/Library/HisiOemMiscLibD05/HisiOemMiscLibD05.inf
index f223097ba8d4..b635dde51f7d 100644
--- a/Platform/Hisilicon/D05/Library/HisiOemMiscLibD05/HisiOemMiscLibD05.inf
+++ b/Platform/Hisilicon/D05/Library/HisiOemMiscLibD05/HisiOemMiscLibD05.inf
@@ -38,7 +38,6 @@ [Ppis]
   gEfiPeiReadOnlyVariable2PpiGuid   ## SOMETIMES_CONSUMES
 
 [Pcd]
-  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz
   gHisiTokenSpaceGuid.PcdIsMPBoot
   gHisiTokenSpaceGuid.PcdSocketMask
   gHisiTokenSpaceGuid.PcdTrustedFirmwareEnable
diff --git a/Platform/Hisilicon/D06/Library/HisiOemMiscLibD06/HisiOemMiscLibD06.inf b/Platform/Hisilicon/D06/Library/HisiOemMiscLibD06/HisiOemMiscLibD06.inf
index 0d030950ee54..01ff51feb9f2 100644
--- a/Platform/Hisilicon/D06/Library/HisiOemMiscLibD06/HisiOemMiscLibD06.inf
+++ b/Platform/Hisilicon/D06/Library/HisiOemMiscLibD06/HisiOemMiscLibD06.inf
@@ -39,7 +39,6 @@ [Ppis]
   gEfiPeiReadOnlyVariable2PpiGuid   ## SOMETIMES_CONSUMES
 
 [Pcd]
-  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz
   gHisiTokenSpaceGuid.PcdIsMPBoot
   gHisiTokenSpaceGuid.PcdSocketMask
   gHisiTokenSpaceGuid.PcdTrustedFirmwareEnable
diff --git a/Silicon/AMD/Styx/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf b/Silicon/AMD/Styx/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf
index 4b6609a66f50..43c596169fdd 100644
--- a/Silicon/AMD/Styx/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf
+++ b/Silicon/AMD/Styx/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.inf
@@ -45,7 +45,6 @@ [Guids]
 
 [FixedPcd]
   gArmPlatformTokenSpaceGuid.PcdCoreCount
-  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz
 
 [Depex]
   gEfiSmbiosProtocolGuid AND
diff --git a/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf b/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf
index 895d72fc040f..433720f12900 100644
--- a/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf
+++ b/Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf
@@ -47,7 +47,6 @@ [Protocols]
 
 [Pcd]
   gHisiTokenSpaceGuid.PcdCPUInfo
-  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz
 
 [Guids]
 
-- 
2.39.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119656): https://edk2.groups.io/g/devel/message/119656
Mute This Topic: https://groups.io/mt/106780877/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH edk2-platforms 3/5] Platform/ARM: drop use of PcdArmArchTimerFreqInHz

[Leif Lindholm]

Some Arm ltd. platforms explicitly set PcdArmArchTimerFreqInHz, however
the intended effect of that is not possible from AArch64 EL2/1, and has
never been performed unless built for ARM.

The Pcd is now being deleted, so drop the setting.

This has however affected timer timout calculations, so could lead to a
change in platform behaviour.

Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Thomas Abraham <thomas.abraham@arm.com>
Signed-off-by: Leif Lindholm <quic_llindhol@quicinc.com>
---
 Platform/ARM/Morello/MorelloPlatform.dsc.inc         | 2 --
 Platform/ARM/SgiPkg/SgiPlatform.dsc.inc              | 2 --
 Platform/ARM/N1Sdp/N1SdpPlatform.dsc                 | 2 --
 Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 6 ------
 4 files changed, 12 deletions(-)

diff --git a/Platform/ARM/Morello/MorelloPlatform.dsc.inc b/Platform/ARM/Morello/MorelloPlatform.dsc.inc
index e7f4b6d0dde8..d2f885d1c10f 100644
--- a/Platform/ARM/Morello/MorelloPlatform.dsc.inc
+++ b/Platform/ARM/Morello/MorelloPlatform.dsc.inc
@@ -110,8 +110,6 @@ [PcdsFixedAtBuild.common]
   # PL031 RealTimeClock
   gArmPlatformTokenSpaceGuid.PcdPL031RtcBase|0x1C100000
 
-  # ARM Architectural Timer Frequency
-  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|50000000
   gEmbeddedTokenSpaceGuid.PcdMetronomeTickPeriod|1000
   gEmbeddedTokenSpaceGuid.PcdTimerPeriod|1000
 
diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
index 107a5311b666..1090fbe2a1fc 100644
--- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
+++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
@@ -178,8 +178,6 @@ [PcdsFixedAtBuild.common]
   # ARM OS Loader
   gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3
 
-  # ARM Architectural Timer Frequency
-  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|100000000
   gEmbeddedTokenSpaceGuid.PcdMetronomeTickPeriod|1000
   gEmbeddedTokenSpaceGuid.PcdTimerPeriod|1000
 
diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc
index 743c2e647b76..b14ece1b8f61 100644
--- a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc
+++ b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc
@@ -149,8 +149,6 @@ [PcdsFixedAtBuild.common]
   # ARM OS Loader
   gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|0
 
-  # ARM Architectural Timer Frequency
-  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|100000000
   gEmbeddedTokenSpaceGuid.PcdMetronomeTickPeriod|1000
   gEmbeddedTokenSpaceGuid.PcdTimerPeriod|1000
 
diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
index c5fcf74b4e0a..60556f6661c4 100644
--- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
+++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
@@ -213,12 +213,6 @@ [PcdsFixedAtBuild.common]
   gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0x40000000
   gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseSize|0x10000000
 
-  #
-  # ARM Architectural Timer Frequency
-  #
-  # Set tick frequency value to 100Mhz
-  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|100000000
-
   #
   # ACPI Table Version
   #
-- 
2.39.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119657): https://edk2.groups.io/g/devel/message/119657
Mute This Topic: https://groups.io/mt/106780878/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH edk2-platforms 4/5] Platform/Hisilicon: drop D05 use of PcdArmArchTimerFreqInHz

[Leif Lindholm]

The D05 platform explicitly sets PcdArmArchTimerFreqInHz, however the
intended effect of that is not possible from AArch64 EL2/1, and has
never been performed unless built for ARM.

The Pcd is now being deleted, so drop the setting.

This has however affected timer timout calculations, so could lead to a
change in platform behaviour.

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Wenyi Xie <xiewenyi2@huawei.com>
Signed-off-by: Leif Lindholm <quic_llindhol@quicinc.com>
---
 Platform/Hisilicon/D05/D05.dsc | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc
index d247e67e92fc..0cd98d54ddb3 100644
--- a/Platform/Hisilicon/D05/D05.dsc
+++ b/Platform/Hisilicon/D05/D05.dsc
@@ -198,12 +198,6 @@ [PcdsFixedAtBuild.common]
   gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0xFE000000
 
 
-  #
-  # ARM Architectual Timer Frequency
-  #
-  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|50000000
-
-
   gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
 
   gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
-- 
2.39.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119655): https://edk2.groups.io/g/devel/message/119655
Mute This Topic: https://groups.io/mt/106780876/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH edk2-platforms 5/5] Silicon/Marvell: drop use of PcdArmArchTimerFreqInHz

[Leif Lindholm]

Armada7k8k.dsc.inc, used by several platforms, explicitly sets
PcdArmArchTimerFreqInHz, however the intended effect of that is not possible
from AArch64 EL2/1, and has never been performed unless built for ARM.

The Pcd is now being deleted, so drop the setting.

This has however affected timer timout calculations, so could lead to a
change in platform behaviour.

Cc: Marcin Wojtas <marcin.s.wojtas@gmail.com>
Cc: Narinder Dhillon <ndhillon@marvell.com>
Signed-off-by: Leif Lindholm <quic_llindhol@quicinc.com>
---
 Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
index ab719f360eda..a7a19f5d4381 100644
--- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
+++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
@@ -280,8 +280,6 @@ [PcdsFixedAtBuild.common]
   #
   gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase|0xF022F000
 
-  # ARM Architectural Timer Support
-  gArmTokenSpaceGuid.PcdArmArchTimerFreqInHz|25000000
   gEmbeddedTokenSpaceGuid.PcdMetronomeTickPeriod|1000
 
   # ARM SBSA Watchdog
-- 
2.39.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119658): https://edk2.groups.io/g/devel/message/119658
Mute This Topic: https://groups.io/mt/106780879/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 1/5] Platform/SbsaQemu: fix .dsc line endings

[Leif Lindholm]

Obvs I forgot to update the subject when I squashed a bunch of line 
ending fixups. I'll do that before I push if anyone gives me an R-b on this.

/
     Leif

On 2024-06-20 15:32, Leif Lindholm wrote:
> A patch adding a mapping for ImagePropertiesRecordLib introduced a bunch of
> LF line endings in otherwise CRLF files, so clean that up.
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Chuong Tran <chuong@os.amperecomputing.com>
> Cc: Graeme Gregory <graeme@xora.org.uk>
> Cc: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> Cc: Marcin Wojtas <marcin.s.wojtas@gmail.com>
> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Cc: Narinder Dhillon <ndhillon@marvell.com>
> Cc: Nhi Pham <nhi@os.amperecomputing.com>
> Cc: Rebecca Cran <rebecca@os.amperecomputing.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Thomas Abraham <thomas.abraham@arm.com>
> Signed-off-by: Leif Lindholm <quic_llindhol@quicinc.com>
> ---
>   Platform/ARM/Morello/MorelloPlatform.dsc.inc         | 2 +-
>   Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 2 +-
>   Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc        | 2 +-
>   Silicon/NXP/NxpQoriqLs.dsc.inc                       | 2 +-
>   Platform/Qemu/SbsaQemu/SbsaQemu.dsc                  | 2 +-
>   5 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Platform/ARM/Morello/MorelloPlatform.dsc.inc b/Platform/ARM/Morello/MorelloPlatform.dsc.inc
> index 660fd6cb2f17..e7f4b6d0dde8 100644
> --- a/Platform/ARM/Morello/MorelloPlatform.dsc.inc
> +++ b/Platform/ARM/Morello/MorelloPlatform.dsc.inc
> @@ -13,7 +13,7 @@ [LibraryClasses.common]
>     BasePathLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>     HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
>     TimerLib|ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.inf
> -  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
> +  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
>   
>     # Ramdisk Support
>     FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
> diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
> index 23579497661d..eb6caf37a3c5 100644
> --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
> +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
> @@ -46,7 +46,7 @@ [LibraryClasses.common]
>     HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
>     UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
>     UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> -  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
> +  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
>   
>     #
>     # Allow dynamic PCDs
> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> index a7a4f47ef3d5..ab719f360eda 100644
> --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> @@ -71,7 +71,7 @@ [LibraryClasses.common]
>     UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
>     VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
>     VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
> -  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
> +  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
>   
>     PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
>   
> diff --git a/Silicon/NXP/NxpQoriqLs.dsc.inc b/Silicon/NXP/NxpQoriqLs.dsc.inc
> index da76bd6b1de5..920d2f6c4ddf 100644
> --- a/Silicon/NXP/NxpQoriqLs.dsc.inc
> +++ b/Silicon/NXP/NxpQoriqLs.dsc.inc
> @@ -98,7 +98,7 @@ [LibraryClasses.common]
>     NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
>     ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
>     UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
> -  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
> +  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
>   
>     I2cLib|Silicon/NXP/Library/I2cLib/I2cLib.inf
>     ResetSystemLib|ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
> diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> index 221322cca030..4fea9a0d6380 100644
> --- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
> @@ -78,7 +78,7 @@ [LibraryClasses.common]
>     SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
>     ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
>     FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf
> -  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
> +  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
>   
>     UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
>     OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119659): https://edk2.groups.io/g/devel/message/119659
Mute This Topic: https://groups.io/mt/106781002/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 0/5] Platform,Silicon: drop use of PcdArmArchTimerFreqInHz

[Ard Biesheuvel]

On Thu, 20 Jun 2024 at 16:33, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
>
> Related to https://github.com/tianocore/edk2/pull/5797
>
> PcdArmArchTimerFreqInHz is about to be removed, as it is now obsolete.
> Its functionality has been partially broken, and mostly ignored, for
> all AArch64 platforms since December 2020.
>
> This set cleans up some broken line endings in .dsc* files, then
> drops all non-invasive references to the Pcd:
> - .dsc* files setting it to 0 (which is the default in the definition,
>   and means "just read it from the system register instead")
> - .inf files declaring a dependency that is in fact not there in
>   current code.
>
> Finally, it drops the setting of the Pcd for platforms that set it to
> non-0. This has *never* done the right thing on these platforms since
> they are all AArch64, but it may affect timer timeout, so deserves
> deeper testing.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Chuong Tran <chuong@os.amperecomputing.com>
> Cc: Graeme Gregory <graeme@xora.org.uk>
> Cc: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> Cc: Marcin Wojtas <marcin.s.wojtas@gmail.com>
> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Cc: Narinder Dhillon <ndhillon@marvell.com>
> Cc: Nhi Pham <nhi@os.amperecomputing.com>
> Cc: Rebecca Cran <rebecca@os.amperecomputing.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Thomas Abraham <thomas.abraham@arm.com>
> Cc: Wenyi Xie <xiewenyi2@huawei.com>
>
> Leif Lindholm (5):
>   Platform/SbsaQemu: fix .dsc line endings
>   Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz
>   Platform/ARM: drop use of PcdArmArchTimerFreqInHz
>   Platform/Hisilicon: drop D05 use of PcdArmArchTimerFreqInHz
>   Silicon/Marvell: drop use of PcdArmArchTimerFreqInHz
>

Looks fine to me

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119660): https://edk2.groups.io/g/devel/message/119660
Mute This Topic: https://groups.io/mt/106780872/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 1/5] Platform/SbsaQemu: fix .dsc line endings

[Marcin Juszkiewicz]

W dniu 20.06.2024 o 16:32, Leif Lindholm pisze:
> A patch adding a mapping for ImagePropertiesRecordLib introduced a bunch of
> LF line endings in otherwise CRLF files, so clean that up.
> 
> Cc: Ard Biesheuvel<ardb+tianocore@kernel.org>
> Cc: Chuong Tran<chuong@os.amperecomputing.com>
> Cc: Graeme Gregory<graeme@xora.org.uk>
> Cc: Marcin Juszkiewicz<marcin.juszkiewicz@linaro.org>
> Cc: Marcin Wojtas<marcin.s.wojtas@gmail.com>
> Cc: Meenakshi Aggarwal<meenakshi.aggarwal@nxp.com>
> Cc: Narinder Dhillon<ndhillon@marvell.com>
> Cc: Nhi Pham<nhi@os.amperecomputing.com>
> Cc: Rebecca Cran<rebecca@os.amperecomputing.com>
> Cc: Sami Mujawar<sami.mujawar@arm.com>
> Cc: Thomas Abraham<thomas.abraham@arm.com>
> Signed-off-by: Leif Lindholm<quic_llindhol@quicinc.com>

I hate line endings in EDK2. Having them sorted out is good.

Reviewed-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119661): https://edk2.groups.io/g/devel/message/119661
Mute This Topic: https://groups.io/mt/106780873/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 2/5] Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz

[Nhi Pham via groups.io]

Thanks for the cleanup.

For Ampere Altra,

Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119663): https://edk2.groups.io/g/devel/message/119663
Mute This Topic: https://groups.io/mt/106780877/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 0/5] Platform,Silicon: drop use of PcdArmArchTimerFreqInHz

[Leif Lindholm]

On Thu, Jun 20, 2024 at 16:43:00 +0200, Ard Biesheuvel wrote:
> On Thu, 20 Jun 2024 at 16:33, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
> >
> > Related to https://github.com/tianocore/edk2/pull/5797
> >
> > PcdArmArchTimerFreqInHz is about to be removed, as it is now obsolete.
> > Its functionality has been partially broken, and mostly ignored, for
> > all AArch64 platforms since December 2020.
> >
> > This set cleans up some broken line endings in .dsc* files, then
> > drops all non-invasive references to the Pcd:
> > - .dsc* files setting it to 0 (which is the default in the definition,
> >   and means "just read it from the system register instead")
> > - .inf files declaring a dependency that is in fact not there in
> >   current code.
> >
> > Finally, it drops the setting of the Pcd for platforms that set it to
> > non-0. This has *never* done the right thing on these platforms since
> > they are all AArch64, but it may affect timer timeout, so deserves
> > deeper testing.
> >
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Chuong Tran <chuong@os.amperecomputing.com>
> > Cc: Graeme Gregory <graeme@xora.org.uk>
> > Cc: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> > Cc: Marcin Wojtas <marcin.s.wojtas@gmail.com>
> > Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> > Cc: Narinder Dhillon <ndhillon@marvell.com>
> > Cc: Nhi Pham <nhi@os.amperecomputing.com>
> > Cc: Rebecca Cran <rebecca@os.amperecomputing.com>
> > Cc: Sami Mujawar <sami.mujawar@arm.com>
> > Cc: Thomas Abraham <thomas.abraham@arm.com>
> > Cc: Wenyi Xie <xiewenyi2@huawei.com>
> >
> > Leif Lindholm (5):
> >   Platform/SbsaQemu: fix .dsc line endings
> >   Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz
> >   Platform/ARM: drop use of PcdArmArchTimerFreqInHz
> >   Platform/Hisilicon: drop D05 use of PcdArmArchTimerFreqInHz
> >   Silicon/Marvell: drop use of PcdArmArchTimerFreqInHz
> >
> 
> Looks fine to me
> 
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

Thanks!

Since 1-2 are just cleanup, I have now pushed those two commits,
with R-b:s given, as 3f08401365d6..b29e69a688d6.

I am tempted to now merge https://github.com/tianocore/edk2/pull/5797,
at which point the platforms affected by 3-5 will break.

Any objection?

/
    Leif


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119670): https://edk2.groups.io/g/devel/message/119670
Mute This Topic: https://groups.io/mt/106780872/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 3/5] Platform/ARM: drop use of PcdArmArchTimerFreqInHz

[Sami Mujawar]

[-- Attachment #1: Type: text/plain, Size: 519 bytes --]

Hi Leif,

Thank you for this patch.

These changes look good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119678): https://edk2.groups.io/g/devel/message/119678
Mute This Topic: https://groups.io/mt/106780878/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 977 bytes --]

Re: [edk2-devel] [PATCH edk2-platforms 0/5] Platform,Silicon: drop use of PcdArmArchTimerFreqInHz

[Sami Mujawar]

[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]

Hi Leif,

On Fri, Jun 21, 2024 at 04:37 AM, Leif Lindholm wrote:

> 
> Since 1-2 are just cleanup, I have now pushed those two commits,
> with R-b:s given, as 3f08401365d6..b29e69a688d6.
> 
> I am tempted to now merge https://github.com/tianocore/edk2/pull/5797 ,

The patch series at https://github.com/tianocore/edk2/pull/5797 looks good to me.

> 
> at which point the platforms affected by 3-5 will break.

I have build tested platforms under edk2-platforms/Platforms/ARM/...  and can confirm patch 3/5 " Platform/ARM: drop use of PcdArmArchTimerFreqInHz " fixes the build break.

> 
> Any objection?

I do not have any objection from 'Platforms/ARM' perspective for merging these patches.

Regards,

Sami Mujawar

> 
> /
> Leif


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119679): https://edk2.groups.io/g/devel/message/119679
Mute This Topic: https://groups.io/mt/106780872/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 2471 bytes --]

Re: [edk2-devel] [PATCH edk2-platforms 3/5] Platform/ARM: drop use of PcdArmArchTimerFreqInHz

[Leif Lindholm]

On Sat, Jun 22, 2024 at 21:53:02 -0700, Sami Mujawar wrote:
> Hi Leif,
> 
> Thank you for this patch.
> 
> These changes look good to me.
> 
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Thanks!
3/5 pushed as d9bcbf86b03f.



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119684): https://edk2.groups.io/g/devel/message/119684
Mute This Topic: https://groups.io/mt/106780878/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-