From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8B71C941A84 for ; Thu, 27 Jun 2024 14:22:23 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=0j+q2lUmagn8QBaEKwLHMywRg1lswv0Ujupf4ZLDM9Y=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1719498143; v=1; b=UMuWsgpFf7FoYJAiFXm25zhFZOycPLjEujyFPiZVU4UEpEWOPTB64TSxfDYCAUHjzXCBrgjO 38D/CbBhq8JYpCtmx+PHdTGM5a7l4d1do3UxDzKtCl0ZUcF/uso2wJbd7K1hrZi18TK71h/C0fW gRW5VeKXVIAu1m+49f3bJq1do6pJVGDkl07aRMDYfKOBTRKo/0+L/s5MrNQm0Y2d0dJ00/75MyG wcdQtul0rKOPQDGP5l+e2SBONjmnebYU/9hXH33bn06Sr1N4/6BZhA5IngN7a7q/drG9joZeSF0 vVXuLz/1h0Ui7OD5R2j/jBXmhUf/g95ilXekR4w5xIQTA== X-Received: by 127.0.0.2 with SMTP id VFySYY7687511x76Psb3XkI2; Thu, 27 Jun 2024 07:22:21 -0700 X-Received: from muminek.juszkiewicz.com.pl (muminek.juszkiewicz.com.pl [213.251.184.221]) by mx.groups.io with SMTP id smtpd.web10.9158.1719498140929447823 for ; Thu, 27 Jun 2024 07:22:21 -0700 X-Received: from localhost (localhost [127.0.0.1]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTP id CFDA8260052; Thu, 27 Jun 2024 16:22:18 +0200 (CEST) X-Virus-Scanned: Debian amavis at juszkiewicz.com.pl X-Received: from muminek.juszkiewicz.com.pl ([127.0.0.1]) by localhost (muminek.juszkiewicz.com.pl [127.0.0.1]) (amavis, port 10024) with ESMTP id ripCoEXk7_wI; Thu, 27 Jun 2024 16:22:16 +0200 (CEST) X-Received: from applejack.lan (83.8.74.165.ipv4.supernova.orange.pl [83.8.74.165]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTPSA id 91838260885; Thu, 27 Jun 2024 16:22:16 +0200 (CEST) From: "Marcin Juszkiewicz" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Marcin Juszkiewicz Subject: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: use FEAT_RNG for EFI_RNG_PROTOCOL Date: Thu, 27 Jun 2024 16:22:12 +0200 Message-ID: <20240627142212.408917-2-marcin.juszkiewicz@linaro.org> In-Reply-To: <20240627142212.408917-1-marcin.juszkiewicz@linaro.org> References: <20240627142212.408917-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 27 Jun 2024 07:22:21 -0700 Resent-From: marcin.juszkiewicz@linaro.org Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: qGF60x7wxzbijEX7Uh9G9MA6x7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=UMuWsgpF; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io By default we have Neoverse-N2 cpu which supports FEAT_RNG feature. Commit 5de5e230a80bed083360da95ba16a2c4a001620d (in EDK2) enabled that fo= r ArmVirt platform. RNDR is implemented by both Neoverse-N2 and 'max' cpu implemented by QEMU= . Other cpu models lack it which prevents the RngDxe driver from running, resulting in the same situation as before. TRNG is not implemented in TCG mode but is required by RngDxe to run. Signed-off-by: Marcin Juszkiewicz --- Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 6 +++++- Platform/Qemu/SbsaQemu/SbsaQemu.fdf | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu= /SbsaQemu.dsc index 9306986bf7c0..3463e5c7a635 100644 --- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc @@ -148,7 +148,9 @@ [LibraryClasses.common] # IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf - RngLib|MdeModulePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf + RngLib|MdePkg/Library/BaseRngLib/BaseRngLib.inf + ArmTrngLib|ArmPkg/Library/ArmTrngLib/ArmTrngLib.inf + ArmMonitorLib|ArmPkg/Library/ArmMonitorLib/ArmMonitorLib.inf BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf =20 # @@ -660,6 +662,8 @@ [Components.common] OvmfPkg/VirtNorFlashDxe/VirtNorFlashDxe.inf MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuHighMemDxe/SbsaQemuHighMemDxe.in= f + SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf + =20 # # FAT filesystem + GPT/MBR partitioning diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf b/Platform/Qemu/SbsaQemu= /SbsaQemu.fdf index b35f42e11aa4..51a1ef8519f9 100644 --- a/Platform/Qemu/SbsaQemu/SbsaQemu.fdf +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.fdf @@ -192,6 +192,7 @@ [FV.FvMain] INF ArmPkg/Drivers/TimerDxe/TimerDxe.inf INF OvmfPkg/VirtNorFlashDxe/VirtNorFlashDxe.inf INF MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf + INF SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf =20 # # FAT filesystem + GPT/MBR partitioning + UDF filesystem --=20 2.45.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119724): https://edk2.groups.io/g/devel/message/119724 Mute This Topic: https://groups.io/mt/106909459/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-