[edk2-devel] How do debug tianocore.PatchCheck failed?

[edk2-devel] How do debug tianocore.PatchCheck failed?

[joeyli via groups.io]

Hi EDK2 experts,

I was filed a submit request on github for
"[PATCH] EmbeddedPkg/VirtualRealTimeClockLib: Support SOURCE_DATE_EPOCH". But
I got a Azure Pipelines/tianocore.PatchCheck failed:

https://github.com/tianocore/edk2/pull/5550/checks?check_run_id=24185647984

	Check failure on line 26 in Build log
	@azure-pipelines azure-pipelines / tianocore.PatchCheck
	Build log #L26
	Bash exited with code '255'.

The patch only change one line as following bash script:

--- a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf
+++ b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf
@@ -34,4 +34,4 @@
 
 # Current usage of this library expects GCC in a UNIX-like shell environment with the date command
 [BuildOptions]
-  GCC:*_*_*_CC_FLAGS = -DBUILD_EPOCH=`date +%s`
+  GCC:*_*_*_CC_FLAGS = -DBUILD_EPOCH=`printenv SOURCE_DATE_EPOCH || date +%s`^M

This change works on openSUSE/SLE, and it also passed
PlatformCI_ArmVirtPkg_Ubuntu_GCC5_PR test. 

My question is:
What's the platform of "Azure Pipelines/tianocore.PatchCheck" ? Is it a
virtual machine? Where can I find the platform for debugging my change? 

Thank a lot!
Joey Lee


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119754): https://edk2.groups.io/g/devel/message/119754
Mute This Topic: https://groups.io/mt/106995552/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] How do debug tianocore.PatchCheck failed?

[Leif Lindholm]

Hi Joey,

On 2024-07-02 07:42, joeyli via groups.io wrote:
> Hi EDK2 experts,
> 
> I was filed a submit request on github for
> "[PATCH] EmbeddedPkg/VirtualRealTimeClockLib: Support SOURCE_DATE_EPOCH". But
> I got a Azure Pipelines/tianocore.PatchCheck failed:
> 
> https://github.com/tianocore/edk2/pull/5550/checks?check_run_id=24185647984
> 
> 	Check failure on line 26 in Build log
> 	@azure-pipelines azure-pipelines / tianocore.PatchCheck
> 	Build log #L26
> 	Bash exited with code '255'.

The CI system is a bit "beware of the leopard" with regards to finding 
the failures.

If I go to the link above, I see the message you're copying, but below 
that there is a link "View more details on Azure Pipelines". Clicking 
that takes me to a page that says "build not found" - since the logs 
have been purged since the test was run 2 months ago. Otherwise you'd be 
able to find logs there explaining the failure.

> The patch only change one line as following bash script:
> 
> --- a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf
> +++ b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf
> @@ -34,4 +34,4 @@
>   
>   # Current usage of this library expects GCC in a UNIX-like shell environment with the date command
>   [BuildOptions]
> -  GCC:*_*_*_CC_FLAGS = -DBUILD_EPOCH=`date +%s`
> +  GCC:*_*_*_CC_FLAGS = -DBUILD_EPOCH=`printenv SOURCE_DATE_EPOCH || date +%s`^M

This looks fine.

If I was to guess, from looking at the PR, I would say PatchCheck.py is 
unhappy over the merge commit that has been introduced.
If you rebase your change on top of current master branch and force push 
an update, that will trigger a new CI run, which I'm thinking would pass.

Best Regards,

Leif

> 
> This change works on openSUSE/SLE, and it also passed
> PlatformCI_ArmVirtPkg_Ubuntu_GCC5_PR test.
> 
> My question is:
> What's the platform of "Azure Pipelines/tianocore.PatchCheck" ? Is it a
> virtual machine? Where can I find the platform for debugging my change?
> 
> Thank a lot!
> Joey Lee
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119756): https://edk2.groups.io/g/devel/message/119756
Mute This Topic: https://groups.io/mt/106995552/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] How do debug tianocore.PatchCheck failed?

[joeyli via groups.io]

Hi Leif, 

Thanks for your response!

On Tue, Jul 02, 2024 at 11:32:06AM +0100, Leif Lindholm wrote:
> Hi Joey,
> 
> On 2024-07-02 07:42, joeyli via groups.io wrote:
> > Hi EDK2 experts,
> > 
> > I was filed a submit request on github for
> > "[PATCH] EmbeddedPkg/VirtualRealTimeClockLib: Support SOURCE_DATE_EPOCH". But
> > I got a Azure Pipelines/tianocore.PatchCheck failed:
> > 
> > https://github.com/tianocore/edk2/pull/5550/checks?check_run_id=24185647984
> > 
> > 	Check failure on line 26 in Build log
> > 	@azure-pipelines azure-pipelines / tianocore.PatchCheck
> > 	Build log #L26
> > 	Bash exited with code '255'.
> 
> The CI system is a bit "beware of the leopard" with regards to finding the
> failures.
> 
> If I go to the link above, I see the message you're copying, but below that
> there is a link "View more details on Azure Pipelines". Clicking that takes
> me to a page that says "build not found" - since the logs have been purged
> since the test was run 2 months ago. Otherwise you'd be able to find logs
> there explaining the failure.
>

Actually I didn't aware my submission is failed because I moved to work on
other bugs.   
 
> > The patch only change one line as following bash script:
> > 
> > --- a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf
> > +++ b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf
> > @@ -34,4 +34,4 @@
> >   # Current usage of this library expects GCC in a UNIX-like shell environment with the date command
> >   [BuildOptions]
> > -  GCC:*_*_*_CC_FLAGS = -DBUILD_EPOCH=`date +%s`
> > +  GCC:*_*_*_CC_FLAGS = -DBUILD_EPOCH=`printenv SOURCE_DATE_EPOCH || date +%s`^M
> 
> This looks fine.
> 
> If I was to guess, from looking at the PR, I would say PatchCheck.py is
> unhappy over the merge commit that has been introduced.
> If you rebase your change on top of current master branch and force push an
> update, that will trigger a new CI run, which I'm thinking would pass.
> 
> Best Regards,
> 
> Leif

Thanks for your suggest! I will rebase my change and submit a new merge
request.

Joey Lee

> 
> > 
> > This change works on openSUSE/SLE, and it also passed
> > PlatformCI_ArmVirtPkg_Ubuntu_GCC5_PR test.
> > 
> > My question is:
> > What's the platform of "Azure Pipelines/tianocore.PatchCheck" ? Is it a
> > virtual machine? Where can I find the platform for debugging my change?
> > 
> > Thank a lot!
> > Joey Lee
> > 
> > 
> > 
> > 
> > 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119761): https://edk2.groups.io/g/devel/message/119761
Mute This Topic: https://groups.io/mt/106995552/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-