* [edk2-devel] [PATCH 0/3] Fix boot failure when use secure boot supported (-D SECURE_BOOT_ENABLE=TRUE) OVMF packages
@ 2024-07-14 12:19 wojiaohanliyang
0 siblings, 0 replies; 3+ messages in thread
From: wojiaohanliyang @ 2024-07-14 12:19 UTC (permalink / raw)
To: devel
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4807
This patch series provides fixes for boot VM when use secure boot
supported (-D SECURE_BOOT_ENABLE=TRUE) OVMF packages.
- Detect FlashNvVarStore before calls PlaformValidateNvVarStore in PlatformInitLib
and skip the validation process if the FlashNvVarStore doesn't exist. Since the
PlatformValidateNvVarStore will return false if the FlashNvVarStore doesn't
exist, this will trigger ASSERT (FALSE) and prevent the guest from moving
forward.
- Init the whole range of EmuVariableNvStore before copy content from the
FlashNvVarStore to EmuVariableNvStore. If the Ftw (Fault Tolerant Write) part
of the EmuVariableNvStore isn't initialized, the FaultToleranteWriteDxe will
use scrambled address to access memory and leads to crash if the VM is a
SEV guest.
- Fix the mapping for FlashNvVarStore. If launch a SEV VM with only OVMF.fd,
the address range for FlashNvVarStore should be mapped as encrypted before
access FlashNvVarStore in PlatformValidateNvVarStore. If launch a SEV VM with
both OVMF_CODE.fd and OVMF_VARS.fd, the address range for FlashNvVarStore
should be mapped as decrypted before access FlashNvVarStore in
PlatformValidateNvVarStore.
---
These patches based on commit:
d4dbe5e101dc ("SecurityPkg/Tcg2Acpi: Revise debug print")
Han Liyang (3):
OvmfPkg/PlatformPei: Update mapping of FlashNvVarStore before validate it
OvmfPkg/PlatformInitLib: Init the EmuVariableNvStore before copy data
OvmfPkg/PlatformInitLib: Detect FlashNvVarStore before validate it
OvmfPkg/Library/PlatformInitLib/Platform.c | 67 +++++++++++
OvmfPkg/Library/PlatformInitLib/PlatformInitLib.inf | 1 +
OvmfPkg/PlatformPei/AmdSev.c | 105 ++++++++++++++++++
OvmfPkg/PlatformPei/Platform.c | 6 +
OvmfPkg/PlatformPei/Platform.h | 6 +
OvmfPkg/PlatformPei/PlatformPei.inf | 1 +
6 files changed, 186 insertions(+)
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119921): https://edk2.groups.io/g/devel/message/119921
Mute This Topic: https://groups.io/mt/107212891/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 3+ messages in thread
* [edk2-devel] [PATCH 0/3] Fix boot failure when use secure boot supported (-D SECURE_BOOT_ENABLE=TRUE) OVMF packages
@ 2024-07-14 12:22 wojiaohanliyang
0 siblings, 0 replies; 3+ messages in thread
From: wojiaohanliyang @ 2024-07-14 12:22 UTC (permalink / raw)
To: devel
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4807
This patch series provides fixes for boot VM when use secure boot
supported (-D SECURE_BOOT_ENABLE=TRUE) OVMF packages.
- Detect FlashNvVarStore before calls PlaformValidateNvVarStore in PlatformInitLib
and skip the validation process if the FlashNvVarStore doesn't exist. Since the
PlatformValidateNvVarStore will return false if the FlashNvVarStore doesn't
exist, this will trigger ASSERT (FALSE) and prevent the guest from moving
forward.
- Init the whole range of EmuVariableNvStore before copy content from the
FlashNvVarStore to EmuVariableNvStore. If the Ftw (Fault Tolerant Write) part
of the EmuVariableNvStore isn't initialized, the FaultToleranteWriteDxe will
use scrambled address to access memory and leads to crash if the VM is a
SEV guest.
- Fix the mapping for FlashNvVarStore. If launch a SEV VM with only OVMF.fd,
the address range for FlashNvVarStore should be mapped as encrypted before
access FlashNvVarStore in PlatformValidateNvVarStore. If launch a SEV VM with
both OVMF_CODE.fd and OVMF_VARS.fd, the address range for FlashNvVarStore
should be mapped as decrypted before access FlashNvVarStore in
PlatformValidateNvVarStore.
---
These patches based on commit:
d4dbe5e101dc ("SecurityPkg/Tcg2Acpi: Revise debug print")
Han Liyang (3):
OvmfPkg/PlatformPei: Update mapping of FlashNvVarStore before validate it
OvmfPkg/PlatformInitLib: Init the EmuVariableNvStore before copy data
OvmfPkg/PlatformInitLib: Detect FlashNvVarStore before validate it
OvmfPkg/Library/PlatformInitLib/Platform.c | 67 +++++++++++
OvmfPkg/Library/PlatformInitLib/PlatformInitLib.inf | 1 +
OvmfPkg/PlatformPei/AmdSev.c | 105 ++++++++++++++++++
OvmfPkg/PlatformPei/Platform.c | 6 +
OvmfPkg/PlatformPei/Platform.h | 6 +
OvmfPkg/PlatformPei/PlatformPei.inf | 1 +
6 files changed, 186 insertions(+)
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119924): https://edk2.groups.io/g/devel/message/119924
Mute This Topic: https://groups.io/mt/107212891/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 3+ messages in thread
* [edk2-devel] [PATCH 0/3] Fix boot failure when use secure boot supported (-D SECURE_BOOT_ENABLE=TRUE) OVMF packages
@ 2024-07-14 12:24 wojiaohanliyang
0 siblings, 0 replies; 3+ messages in thread
From: wojiaohanliyang @ 2024-07-14 12:24 UTC (permalink / raw)
To: devel; +Cc: erdemaktas, jejb, jiewen.yao, min.m.xu, thomas.lendacky, kraxel
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4807
This patch series provides fixes for boot VM when use secure boot
supported (-D SECURE_BOOT_ENABLE=TRUE) OVMF packages.
- Detect FlashNvVarStore before calls PlaformValidateNvVarStore in PlatformInitLib
and skip the validation process if the FlashNvVarStore doesn't exist. Since the
PlatformValidateNvVarStore will return false if the FlashNvVarStore doesn't
exist, this will trigger ASSERT (FALSE) and prevent the guest from moving
forward.
- Init the whole range of EmuVariableNvStore before copy content from the
FlashNvVarStore to EmuVariableNvStore. If the Ftw (Fault Tolerant Write) part
of the EmuVariableNvStore isn't initialized, the FaultToleranteWriteDxe will
use scrambled address to access memory and leads to crash if the VM is a
SEV guest.
- Fix the mapping for FlashNvVarStore. If launch a SEV VM with only OVMF.fd,
the address range for FlashNvVarStore should be mapped as encrypted before
access FlashNvVarStore in PlatformValidateNvVarStore. If launch a SEV VM with
both OVMF_CODE.fd and OVMF_VARS.fd, the address range for FlashNvVarStore
should be mapped as decrypted before access FlashNvVarStore in
PlatformValidateNvVarStore.
---
These patches based on commit:
d4dbe5e101dc ("SecurityPkg/Tcg2Acpi: Revise debug print")
Han Liyang (3):
OvmfPkg/PlatformPei: Update mapping of FlashNvVarStore before validate it
OvmfPkg/PlatformInitLib: Init the EmuVariableNvStore before copy data
OvmfPkg/PlatformInitLib: Detect FlashNvVarStore before validate it
OvmfPkg/Library/PlatformInitLib/Platform.c | 67 +++++++++++
OvmfPkg/Library/PlatformInitLib/PlatformInitLib.inf | 1 +
OvmfPkg/PlatformPei/AmdSev.c | 105 ++++++++++++++++++
OvmfPkg/PlatformPei/Platform.c | 6 +
OvmfPkg/PlatformPei/Platform.h | 6 +
OvmfPkg/PlatformPei/PlatformPei.inf | 1 +
6 files changed, 186 insertions(+)
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119926): https://edk2.groups.io/g/devel/message/119926
Mute This Topic: https://groups.io/mt/107212891/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-14 12:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-14 12:19 [edk2-devel] [PATCH 0/3] Fix boot failure when use secure boot supported (-D SECURE_BOOT_ENABLE=TRUE) OVMF packages wojiaohanliyang
-- strict thread matches above, loose matches on Subject: below --
2024-07-14 12:22 wojiaohanliyang
2024-07-14 12:24 wojiaohanliyang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox