[edk2-devel] [edk2-libc Patch 0/1] add github workflow to build python uefi with VS2022

[edk2-devel] [edk2-libc Patch 0/1] add github workflow to build python uefi with VS2022

[Jayaprakash, N]

This patch request adds support for building Python uefi interpreter
with VS2022 tool chain. A new workflow file has been added to build
python uefi interpreter using VS2022. The edk2-libc repo is already
enabled building with this tool chain.

Jayaprakash N (1):
  edk2-libc: add github workflow to build python uefi with VS2022

 .../workflows/build-python-uefi-vs2022.yaml   | 84 +++++++++++++++++++
 1 file changed, 84 insertions(+)
 create mode 100644 .github/workflows/build-python-uefi-vs2022.yaml

-- 
2.45.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120002): https://edk2.groups.io/g/devel/message/120002
Mute This Topic: https://groups.io/mt/107481169/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-libc Patch 1/1] edk2-libc: add github workflow to build python uefi with VS2022

[Jayaprakash, N]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4815

edk2-libc has already been enabled to compile with VS2022 tool chain.
This commit adds a new workflow file to enable building python uefi
with VS2022 compiler tool chain.

Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Jayaprakash N <n.jayaprakash@intel.com>
Signed-off-by: Jayaprakash N <n.jayaprakash@intel.com>
---
 .../workflows/build-python-uefi-vs2022.yaml   | 84 +++++++++++++++++++
 1 file changed, 84 insertions(+)
 create mode 100644 .github/workflows/build-python-uefi-vs2022.yaml

diff --git a/.github/workflows/build-python-uefi-vs2022.yaml b/.github/workflows/build-python-uefi-vs2022.yaml
new file mode 100644
index 0000000..4e36f09
--- /dev/null
+++ b/.github/workflows/build-python-uefi-vs2022.yaml
@@ -0,0 +1,84 @@
+# GitHub actions workflow to build python uefi using VS2022
+#
+# Copyright (c) 2023 - 2024, Intel Corporation. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+
+name: Build Python Interpreter for UEFI using VS2022
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    runs-on: windows-latest
+    env:
+      NASM_PREFIX: "C:\\Program Files\\NASM\\"
+    defaults:
+      run:
+        shell: cmd
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v4
+
+    - name: Setup Python
+      uses: actions/setup-python@v5
+      with:
+        python-version: '3.10'
+
+    - name: Install NASM
+      run: choco install nasm
+
+    - name: VSWhere
+      run: |
+        "C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe" -products * -latest -requires Microsoft.Component.MSBuild -property installationPath
+
+    - name: Setup environment for Visual Studio 2022 Build Tools
+      run: |
+        "C:\Program Files\Microsoft Visual Studio\2022\BuildTools\VC\Auxiliary\Build\vcvarsall.bat" x86
+        set
+
+    - name: Clone EDK2
+      run: |
+        git clone https://github.com/tianocore/edk2.git
+        cd edk2
+        git submodule update --init
+
+    - name: Build EDK2 Base Tools
+      run: |
+        cd edk2
+        dir
+        edksetup.bat ForceRebuild
+
+    - name: Run srcprep.py
+      run: |
+        echo switching to AppPkg\Applications\Python\Python-3.6.8\
+        cd AppPkg\Applications\Python\Python-3.6.8\
+        dir
+        echo run srcprep.py file
+        python srcprep.py
+
+    - name: Build Python UEFI
+      run: |
+        set PACKAGES_PATH=%CD%\edk2;%CD%;
+        set EDK2_LIBC_PATH=%CD%
+        cd edk2
+        call edksetup.bat
+        build -t VS2022 -a X64 -b RELEASE -p %EDK2_LIBC_PATH%\AppPkg\AppPkg.dsc -D BUILD_PYTHON368
+
+    - name: Create Python UEFI package
+      run: |
+        set WORKSPACE=%CD%\edk2
+        set EDK2_LIBC_PATH=%CD%
+        dir
+        call AppPkg\Applications\Python\Python-3.6.8\create_python_pkg.bat VS2022 RELEASE X64 myUEFIPy
+
+    - name: List build artifacts
+      run: |
+        dir /S edk2\myUEFIPy
+
+    - name: Upload build output as artifact
+      uses: actions/upload-artifact@v4
+      with:
+        name: myUEFIPy-build-VS2022-output
+        path: edk2\myUEFIPy\**\*
-- 
2.45.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120003): https://edk2.groups.io/g/devel/message/120003
Mute This Topic: https://groups.io/mt/107481170/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: add github workflow to build python uefi with VS2022

[Michael D Kinney]

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jayaprakash, N
> Sent: Monday, July 22, 2024 12:09 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N <n.jayaprakash@intel.com>; Rebecca Cran
> <rebecca@bsdio.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: add github workflow to
> build python uefi with VS2022
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4815
> 
> edk2-libc has already been enabled to compile with VS2022 tool chain.
> This commit adds a new workflow file to enable building python uefi
> with VS2022 compiler tool chain.
> 
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Jayaprakash N <n.jayaprakash@intel.com>
> Signed-off-by: Jayaprakash N <n.jayaprakash@intel.com>
> ---
>  .../workflows/build-python-uefi-vs2022.yaml   | 84 +++++++++++++++++++
>  1 file changed, 84 insertions(+)
>  create mode 100644 .github/workflows/build-python-uefi-vs2022.yaml
> 
> diff --git a/.github/workflows/build-python-uefi-vs2022.yaml
> b/.github/workflows/build-python-uefi-vs2022.yaml
> new file mode 100644
> index 0000000..4e36f09
> --- /dev/null
> +++ b/.github/workflows/build-python-uefi-vs2022.yaml
> @@ -0,0 +1,84 @@
> +# GitHub actions workflow to build python uefi using VS2022
> +#
> +# Copyright (c) 2023 - 2024, Intel Corporation. All rights reserved.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +
> +name: Build Python Interpreter for UEFI using VS2022
> +
> +on: [push, pull_request]
> +
> +jobs:
> +  build:
> +    runs-on: windows-latest
> +    env:
> +      NASM_PREFIX: "C:\\Program Files\\NASM\\"
> +    defaults:
> +      run:
> +        shell: cmd
> +
> +    steps:
> +    - name: Checkout repository
> +      uses: actions/checkout@v4
> +
> +    - name: Setup Python
> +      uses: actions/setup-python@v5
> +      with:
> +        python-version: '3.10'
> +
> +    - name: Install NASM
> +      run: choco install nasm
> +
> +    - name: VSWhere
> +      run: |
> +        "C:\Program Files (x86)\Microsoft Visual
> Studio\Installer\vswhere.exe" -products * -latest -requires
> Microsoft.Component.MSBuild -property installationPath
> +
> +    - name: Setup environment for Visual Studio 2022 Build Tools
> +      run: |
> +        "C:\Program Files\Microsoft Visual
> Studio\2022\BuildTools\VC\Auxiliary\Build\vcvarsall.bat" x86
> +        set
> +

I though edksetup performs these steps above???

> +    - name: Clone EDK2
> +      run: |
> +        git clone https://github.com/tianocore/edk2.git
> +        cd edk2
> +        git submodule update --init
> +
> +    - name: Build EDK2 Base Tools
> +      run: |
> +        cd edk2
> +        dir
> +        edksetup.bat ForceRebuild
> +
> +    - name: Run srcprep.py
> +      run: |
> +        echo switching to AppPkg\Applications\Python\Python-3.6.8\
> +        cd AppPkg\Applications\Python\Python-3.6.8\
> +        dir
> +        echo run srcprep.py file
> +        python srcprep.py
> +
> +    - name: Build Python UEFI
> +      run: |
> +        set PACKAGES_PATH=%CD%\edk2;%CD%;
> +        set EDK2_LIBC_PATH=%CD%
> +        cd edk2
> +        call edksetup.bat
> +        build -t VS2022 -a X64 -b RELEASE -p
> %EDK2_LIBC_PATH%\AppPkg\AppPkg.dsc -D BUILD_PYTHON368
> +
> +    - name: Create Python UEFI package
> +      run: |
> +        set WORKSPACE=%CD%\edk2
> +        set EDK2_LIBC_PATH=%CD%
> +        dir
> +        call AppPkg\Applications\Python\Python-3.6.8\create_python_pkg.bat
> VS2022 RELEASE X64 myUEFIPy
> +
> +    - name: List build artifacts
> +      run: |
> +        dir /S edk2\myUEFIPy
> +
> +    - name: Upload build output as artifact
> +      uses: actions/upload-artifact@v4
> +      with:
> +        name: myUEFIPy-build-VS2022-output
> +        path: edk2\myUEFIPy\**\*
> --
> 2.45.1.windows.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120007): https://edk2.groups.io/g/devel/message/120007
Mute This Topic: https://groups.io/mt/107481170/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: add github workflow to build python uefi with VS2022

[Jayaprakash, N]

Thanks Mike.

I have always been running the build commands from the x86 / x64 native visual studio command line.
So, created the workflow accordingly. 

Let me check and make any changes if required.

Regards,
JP

-----Original Message-----
From: Kinney, Michael D <michael.d.kinney@intel.com> 
Sent: Monday, July 22, 2024 11:26 PM
To: devel@edk2.groups.io; Jayaprakash, N <n.jayaprakash@intel.com>
Cc: Rebecca Cran <rebecca@bsdio.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: add github workflow to build python uefi with VS2022



> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of 
> Jayaprakash, N
> Sent: Monday, July 22, 2024 12:09 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N <n.jayaprakash@intel.com>; Rebecca Cran 
> <rebecca@bsdio.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: add github 
> workflow to build python uefi with VS2022
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4815
> 
> edk2-libc has already been enabled to compile with VS2022 tool chain.
> This commit adds a new workflow file to enable building python uefi 
> with VS2022 compiler tool chain.
> 
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Jayaprakash N <n.jayaprakash@intel.com>
> Signed-off-by: Jayaprakash N <n.jayaprakash@intel.com>
> ---
>  .../workflows/build-python-uefi-vs2022.yaml   | 84 +++++++++++++++++++
>  1 file changed, 84 insertions(+)
>  create mode 100644 .github/workflows/build-python-uefi-vs2022.yaml
> 
> diff --git a/.github/workflows/build-python-uefi-vs2022.yaml
> b/.github/workflows/build-python-uefi-vs2022.yaml
> new file mode 100644
> index 0000000..4e36f09
> --- /dev/null
> +++ b/.github/workflows/build-python-uefi-vs2022.yaml
> @@ -0,0 +1,84 @@
> +# GitHub actions workflow to build python uefi using VS2022 # # 
> +Copyright (c) 2023 - 2024, Intel Corporation. All rights reserved.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent #
> +
> +name: Build Python Interpreter for UEFI using VS2022
> +
> +on: [push, pull_request]
> +
> +jobs:
> +  build:
> +    runs-on: windows-latest
> +    env:
> +      NASM_PREFIX: "C:\\Program Files\\NASM\\"
> +    defaults:
> +      run:
> +        shell: cmd
> +
> +    steps:
> +    - name: Checkout repository
> +      uses: actions/checkout@v4
> +
> +    - name: Setup Python
> +      uses: actions/setup-python@v5
> +      with:
> +        python-version: '3.10'
> +
> +    - name: Install NASM
> +      run: choco install nasm
> +
> +    - name: VSWhere
> +      run: |
> +        "C:\Program Files (x86)\Microsoft Visual
> Studio\Installer\vswhere.exe" -products * -latest -requires 
> Microsoft.Component.MSBuild -property installationPath
> +
> +    - name: Setup environment for Visual Studio 2022 Build Tools
> +      run: |
> +        "C:\Program Files\Microsoft Visual
> Studio\2022\BuildTools\VC\Auxiliary\Build\vcvarsall.bat" x86
> +        set
> +

I though edksetup performs these steps above???

> +    - name: Clone EDK2
> +      run: |
> +        git clone https://github.com/tianocore/edk2.git
> +        cd edk2
> +        git submodule update --init
> +
> +    - name: Build EDK2 Base Tools
> +      run: |
> +        cd edk2
> +        dir
> +        edksetup.bat ForceRebuild
> +
> +    - name: Run srcprep.py
> +      run: |
> +        echo switching to AppPkg\Applications\Python\Python-3.6.8\
> +        cd AppPkg\Applications\Python\Python-3.6.8\
> +        dir
> +        echo run srcprep.py file
> +        python srcprep.py
> +
> +    - name: Build Python UEFI
> +      run: |
> +        set PACKAGES_PATH=%CD%\edk2;%CD%;
> +        set EDK2_LIBC_PATH=%CD%
> +        cd edk2
> +        call edksetup.bat
> +        build -t VS2022 -a X64 -b RELEASE -p
> %EDK2_LIBC_PATH%\AppPkg\AppPkg.dsc -D BUILD_PYTHON368
> +
> +    - name: Create Python UEFI package
> +      run: |
> +        set WORKSPACE=%CD%\edk2
> +        set EDK2_LIBC_PATH=%CD%
> +        dir
> +        call 
> + AppPkg\Applications\Python\Python-3.6.8\create_python_pkg.bat
> VS2022 RELEASE X64 myUEFIPy
> +
> +    - name: List build artifacts
> +      run: |
> +        dir /S edk2\myUEFIPy
> +
> +    - name: Upload build output as artifact
> +      uses: actions/upload-artifact@v4
> +      with:
> +        name: myUEFIPy-build-VS2022-output
> +        path: edk2\myUEFIPy\**\*
> --
> 2.45.1.windows.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120010): https://edk2.groups.io/g/devel/message/120010
Mute This Topic: https://groups.io/mt/107481170/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: add github workflow to build python uefi with VS2022

[Jayaprakash, N]

I verified that edksetup performs the necessary compiler environment setup and hence removed steps related to that from the workflow file and sent an updated patch v2 for review.

Regards,
JP
-----Original Message-----
From: Jayaprakash, N 
Sent: Tuesday, July 23, 2024 7:52 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
Cc: Rebecca Cran <rebecca@bsdio.com>
Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: add github workflow to build python uefi with VS2022

Thanks Mike.

I have always been running the build commands from the x86 / x64 native visual studio command line.
So, created the workflow accordingly. 

Let me check and make any changes if required.

Regards,
JP

-----Original Message-----
From: Kinney, Michael D <michael.d.kinney@intel.com> 
Sent: Monday, July 22, 2024 11:26 PM
To: devel@edk2.groups.io; Jayaprakash, N <n.jayaprakash@intel.com>
Cc: Rebecca Cran <rebecca@bsdio.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: add github workflow to build python uefi with VS2022



> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of 
> Jayaprakash, N
> Sent: Monday, July 22, 2024 12:09 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N <n.jayaprakash@intel.com>; Rebecca Cran 
> <rebecca@bsdio.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: add github 
> workflow to build python uefi with VS2022
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4815
> 
> edk2-libc has already been enabled to compile with VS2022 tool chain.
> This commit adds a new workflow file to enable building python uefi 
> with VS2022 compiler tool chain.
> 
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Jayaprakash N <n.jayaprakash@intel.com>
> Signed-off-by: Jayaprakash N <n.jayaprakash@intel.com>
> ---
>  .../workflows/build-python-uefi-vs2022.yaml   | 84 +++++++++++++++++++
>  1 file changed, 84 insertions(+)
>  create mode 100644 .github/workflows/build-python-uefi-vs2022.yaml
> 
> diff --git a/.github/workflows/build-python-uefi-vs2022.yaml
> b/.github/workflows/build-python-uefi-vs2022.yaml
> new file mode 100644
> index 0000000..4e36f09
> --- /dev/null
> +++ b/.github/workflows/build-python-uefi-vs2022.yaml
> @@ -0,0 +1,84 @@
> +# GitHub actions workflow to build python uefi using VS2022 # # 
> +Copyright (c) 2023 - 2024, Intel Corporation. All rights reserved.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent #
> +
> +name: Build Python Interpreter for UEFI using VS2022
> +
> +on: [push, pull_request]
> +
> +jobs:
> +  build:
> +    runs-on: windows-latest
> +    env:
> +      NASM_PREFIX: "C:\\Program Files\\NASM\\"
> +    defaults:
> +      run:
> +        shell: cmd
> +
> +    steps:
> +    - name: Checkout repository
> +      uses: actions/checkout@v4
> +
> +    - name: Setup Python
> +      uses: actions/setup-python@v5
> +      with:
> +        python-version: '3.10'
> +
> +    - name: Install NASM
> +      run: choco install nasm
> +
> +    - name: VSWhere
> +      run: |
> +        "C:\Program Files (x86)\Microsoft Visual
> Studio\Installer\vswhere.exe" -products * -latest -requires 
> Microsoft.Component.MSBuild -property installationPath
> +
> +    - name: Setup environment for Visual Studio 2022 Build Tools
> +      run: |
> +        "C:\Program Files\Microsoft Visual
> Studio\2022\BuildTools\VC\Auxiliary\Build\vcvarsall.bat" x86
> +        set
> +

I though edksetup performs these steps above???

> +    - name: Clone EDK2
> +      run: |
> +        git clone https://github.com/tianocore/edk2.git
> +        cd edk2
> +        git submodule update --init
> +
> +    - name: Build EDK2 Base Tools
> +      run: |
> +        cd edk2
> +        dir
> +        edksetup.bat ForceRebuild
> +
> +    - name: Run srcprep.py
> +      run: |
> +        echo switching to AppPkg\Applications\Python\Python-3.6.8\
> +        cd AppPkg\Applications\Python\Python-3.6.8\
> +        dir
> +        echo run srcprep.py file
> +        python srcprep.py
> +
> +    - name: Build Python UEFI
> +      run: |
> +        set PACKAGES_PATH=%CD%\edk2;%CD%;
> +        set EDK2_LIBC_PATH=%CD%
> +        cd edk2
> +        call edksetup.bat
> +        build -t VS2022 -a X64 -b RELEASE -p
> %EDK2_LIBC_PATH%\AppPkg\AppPkg.dsc -D BUILD_PYTHON368
> +
> +    - name: Create Python UEFI package
> +      run: |
> +        set WORKSPACE=%CD%\edk2
> +        set EDK2_LIBC_PATH=%CD%
> +        dir
> +        call 
> + AppPkg\Applications\Python\Python-3.6.8\create_python_pkg.bat
> VS2022 RELEASE X64 myUEFIPy
> +
> +    - name: List build artifacts
> +      run: |
> +        dir /S edk2\myUEFIPy
> +
> +    - name: Upload build output as artifact
> +      uses: actions/upload-artifact@v4
> +      with:
> +        name: myUEFIPy-build-VS2022-output
> +        path: edk2\myUEFIPy\**\*
> --
> 2.45.1.windows.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120013): https://edk2.groups.io/g/devel/message/120013
Mute This Topic: https://groups.io/mt/107481170/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-