* [edk2-devel] [PATCH edk2-platforms v2 0/1] Move to the GitHub Pull Request workflow @ 2024-07-27 20:31 Rebecca Cran 2024-07-27 20:31 ` [edk2-devel] [PATCH edk2-platforms v2 1/1] " Rebecca Cran 2024-07-30 10:49 ` [edk2-devel] [PATCH edk2-platforms v2 0/1] " Rebecca Cran 0 siblings, 2 replies; 7+ messages in thread From: Rebecca Cran @ 2024-07-27 20:31 UTC (permalink / raw) To: devel, Leif Lindholm, Michael D Kinney; +Cc: Rebecca Cran Changes from v1 to v2: Added .github/workflows/AssignReviewers.yml to actually reviewers to a PR based on the content of the REVIEWERS file. Updated leftover references to Maintainers.txt in Readme.md. Updated some wording in CODEOWNERS, REVIEWERS and CONTRIBUTORS.md. Updated my entry in CONTRIBUTORS.md to delete the second email address. Updated the commit message to indicate that this change is to enable the GitHub PR workflow, not just in preparation for it. Rebecca Cran (1): Move to the GitHub Pull Request workflow .github/workflows/AssignReviewers.yml | 28 ++ CODEOWNERS | 146 +++++++ CONTRIBUTORS.md | 68 +++ Maintainers.txt | 445 -------------------- REVIEWERS | 92 ++++ Readme.md | 32 +- 6 files changed, 361 insertions(+), 450 deletions(-) create mode 100644 .github/workflows/AssignReviewers.yml create mode 100644 CODEOWNERS create mode 100644 CONTRIBUTORS.md delete mode 100644 Maintainers.txt create mode 100644 REVIEWERS -- 2.45.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120055): https://edk2.groups.io/g/devel/message/120055 Mute This Topic: https://groups.io/mt/107583540/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 7+ messages in thread
* [edk2-devel] [PATCH edk2-platforms v2 1/1] Move to the GitHub Pull Request workflow 2024-07-27 20:31 [edk2-devel] [PATCH edk2-platforms v2 0/1] Move to the GitHub Pull Request workflow Rebecca Cran @ 2024-07-27 20:31 ` Rebecca Cran 2024-08-01 9:45 ` Leif Lindholm 2024-07-30 10:49 ` [edk2-devel] [PATCH edk2-platforms v2 0/1] " Rebecca Cran 1 sibling, 1 reply; 7+ messages in thread From: Rebecca Cran @ 2024-07-27 20:31 UTC (permalink / raw) To: devel, Leif Lindholm, Michael D Kinney; +Cc: Rebecca Cran [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset=ASCII, Size: 36129 bytes --] Migrate data from Maintainers.txt to the GitHub standard CODEOWNERS files plus REVIEWERS and CONTRIBUTORS.md. The latter file contains mappings from name to email address and GitHub usernames, which will help people who want to email maintainers instead of using GitHub. Add .github/workflows/AssignReviewers.yml which adds reviewers to a Pull Request based on the content of the REVIEWERS file. Signed-off-by: Rebecca Cran <rebecca@bsdio.com> --- .github/workflows/AssignReviewers.yml | 28 ++ CODEOWNERS | 146 +++++++ CONTRIBUTORS.md | 68 +++ Maintainers.txt | 445 -------------------- REVIEWERS | 92 ++++ Readme.md | 32 +- 6 files changed, 361 insertions(+), 450 deletions(-) diff --git a/.github/workflows/AssignReviewers.yml b/.github/workflows/AssignReviewers.yml new file mode 100644 index 000000000000..8ee95edbb2c1 --- /dev/null +++ b/.github/workflows/AssignReviewers.yml @@ -0,0 +1,28 @@ +## @file +# Assign reviewers from a REVIEWERS file using CODEOWNERS syntax +# +# Copyright (c) 2022, Intel Corporation. All rights reserved.<BR> +# SPDX-License-Identifier: BSD-2-Clause-Patent +## + +name: Assign reviewers from a REVIEWERS file using CODEOWNERS syntax + +on: + pull_request_target: + types: [opened, synchronize, reopened, ready_for_review] + branches: + - main + +jobs: + assign_reviewers: + if: github.event.pull_request.draft == false + runs-on: ubuntu-latest + permissions: + pull-requests: write + steps: + - name: Checkout Pull Request Target + uses: actions/checkout@v2 + - name: Assign Reviewers + uses: mdkinney/github-action-assign-reviewers@main + with: + token: ${{secrets.GITHUB_TOKEN}} diff --git a/CODEOWNERS b/CODEOWNERS new file mode 100644 index 000000000000..bc86dd113398 --- /dev/null +++ b/CODEOWNERS @@ -0,0 +1,146 @@ +# This file contains the list of maintainers (i.e. people who own the +# packages and can commit changes) for various parts of edk2-platforms. + +# EDK II Platforms maintainers +# ============================ +* @leiflindholm @mdkinney + +# EDK II Platforms Packages +# ========================= + +/Platform/96Boards/** @ardbiesheuvel @leiflindholm + +/Platform/AMD/** @changab @abdattar @pbgrimes + +/Platform/AMD/AgesaModulePkg/** @changab @abdattar @pbgrimes +/Platform/AMD/AgesaPkg/** @changab @abdattar @pbgrimes +/Platform/AMD/AmdCbsPkg/** @changab @abdattar @pbgrimes +/Platform/AMD/AmdCpmPkg/** @changab @abdattar @pbgrimes + +# AMD Seattle platforms +/Platform/AMD/OverdriveBoard/** @changab @abdattar @pbgrimes @ardbiesheuvel @leiflindholm +/Silicon/AMD/Styx/** @changab @abdattar @pbgrimes @ardbiesheuvel @leiflindholm +/Platform/LeMaker/CelloBoard/** @ardbiesheuvel @leiflindholm +/Platform/SoftIron/ @ardbiesheuvel @leiflindholm + +# AMD VanGoghBoard +/Platform/AMD/VanGoghBoard/** @changab @abdattar @pbgrimes @exinghr + +# Ampere Computing +/Platform/Ampere/** @nhivp +/Silicon/Ampere/** @nhivp + +# ARM +/Platform/ARM/** @samimujawar +/Silicon/ARM/** @samimujawar + +# BeagleBoard: +/Platform/BeagleBoard/** @ardbiesheuvel @leiflindholm +/Silicon/TexasInstruments/** @ardbiesheuvel @leiflindholm + +# OptionRomPkg +# https://github.com/tianocore/tianocore.github.io/wiki/OptionRomPkg +/Drivers/OptionRomPkg/** @niruiyu + +# StandAloneMMPkg for OP-TEE +/Platform/StandaloneMm/PlatformStandaloneMmPkg/** @apalos @samimujawar + +# DisplayLink +/Drivers/DisplayLink/** @leiflindholm @ardbiesheuvel + +# HiSilicon +/Platform/Hisilicon/** @leiflindholm +/Silicon/Hisilicon/** @leiflindholm + +/Features/Ext4Pkg/** @heatd + +/Features/Intel/** @nate-desimone @SaiChaganty +/Features/Intel/Debugging/** @ydong10 @nate-desimone @SaiChaganty +/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/** @nate-desimone @SaiChaganty +/Features/Intel/UserInterface/** @dandanbi @nate-desimone @SaiChaganty + +/Features/ManageabilityPkg/** @changab + +/Platform/Intel/** @nate-desimone @SaiChaganty +/Platform/Intel/QuarkPlatformPkg/** @mdkinney @nate-desimone @SaiChaganty +/Platform/Intel/Vlv2TbltDevicePkg/** @zailiangsun @yqian4 @nate-desimone @SaiChaganty +/Platform/Intel/BoardModulePkg/** @ydong10 @nate-desimone @SaiChaganty +/Platform/Intel/KabylakeOpenBoardPkg/** @ChaselChiu @nate-desimone @SaiChaganty +/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/** @benjamindoron @nate-desimone @SaiChaganty +/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/** @jackpot51 +/Platform/Intel/MinPlatformPkg/** @ChaselChiu @nate-desimone @SaiChaganty +/Platform/Intel/PurleyOpenBoardPkg/** @nate-desimone @ChaselChiu @SaiChaganty +/Platform/Intel/WhiskeylakeOpenBoardPkg/** @nate-desimone @SaiChaganty @ChaselChiu +/Platform/Intel/CometlakeOpenBoardPkg/** @ChaselChiu @nate-desimone @SaiChaganty +/Platform/Intel/TigerlakeOpenBoardPkg/** @SaiChaganty @nate-desimone +/Platform/Intel/AlderlakeOpenBoardPkg/** @nate-desimone @SaiChaganty +/Platform/Intel/WhitleyOpenBoardPkg/** @ChaselChiu @nate-desimone @SaiChaganty +/Platform/Intel/SimicsOpenBoardPkg/** @nate-desimone @SaiChaganty +/Platform/Intel/Tools/** @BobCF @lgao4 @nate-desimone @SaiChaganty + +/Platform/RISC-V/PlatformPkg/** @vlsunil + +/Platform/SiFive/U5SeriesPkg/** @JohnAZoidberg + +/Silicon/Intel/** @nate-desimone @SaiChaganty +/Silicon/Intel/IntelSiliconPkg/** @niruiyu @nate-desimone @SaiChaganty +/Silicon/Intel/QuarkSocPkg/** @mdkinney @nate-desimone @SaiChaganty +/Silicon/Intel/Vlv2DeviceRefCodePkg/** @zailiangsun @yqian4 @nate-desimone @SaiChaganty +/Silicon/Intel/CoffeelakeSiliconPkg/** @ChaselChiu @SaiChaganty @nate-desimone +/Silicon/Intel/KabylakeSiliconPkg/** @ChaselChiu @SaiChaganty @nate-desimone +/Silicon/Intel/PurleyRefreshSiliconPkg/** @ChaselChiu @nate-desimone @SaiChaganty +/Silicon/Intel/TigerlakeSiliconPkg/** @SaiChaganty @nate-desimone +/Silicon/Intel/AlderlakeSiliconPkg/** @SaiChaganty @nate-desimone +/Silicon/Intel/WhitleySiliconPkg/** @nate-desimone @ChaselChiu @SaiChaganty +/Silicon/Intel/SimicsX58SktPkg/** @nate-desimone @SaiChaganty +/Silicon/Intel/SimicsIch10Pkg/** @nate-desimone @SaiChaganty +/Silicon/Intel/Tools/** @BobCF @lgao4 @nate-desimone @SaiChaganty + +# Loongson platforms +# Add Bibo Mao, Xianglai li and Chao Li +# /Platform/Loongson/** + +# Marvell platforms and silicon +/Platform/Marvell/** @wojtas-marcin @ndhillonm +/Platform/SolidRun/** @wojtas-marcin @ndhillonm +/Silicon/Marvell/** @wojtas-marcin @ndhillonm + +# Miscellaneous drivers +/Silicon/Atmel/** @leiflindholm +/Silicon/Openmoko/** @leiflindholm +/Silicon/Synopsys/DesignWare/** @leiflindholm + +# NXP platforms and silicon +/Platform/NXP/** @leiflindholm +/Silicon/NXP/** @leiflindholm + +# QEMU EDK II Minimum Platform Specification implementation +/Platform/Qemu/QemuOpenBoardPkg/** @heatd + +# QEMU sbsa-ref platform +/Platform/Qemu/SbsaQemu/** @ardbiesheuvel @leiflindholm @hrw +/Silicon/Qemu/SbsaQemu/** @ardbiesheuvel @leiflindholm @hrw + +# Raspberry Pi platforms and silicon +/Platform/RaspberryPi/** @ardbiesheuvel @leiflindholm +/Silicon/Broadcom/** @ardbiesheuvel @leiflindholm + +# RPMB driver for OP-TEE +/Drivers/OpTee/OpteeRpmbPkg/** @apalos @samimujawar + +# Socionext platforms and silicon +/Platform/Socionext/** @ardbiesheuvel @leiflindholm +/Silicon/NXP/Library/Pcf8563RealTimeClockLib/** @ardbiesheuvel @leiflindholm +/Silicon/Socionext/** @ardbiesheuvel @leiflindholm + +/Silicon/RISC-V/ProcessorPkg/** @vlsunil + +/Silicon/SiFive/** @JohnAZoidberg + +# Phytium platforms and silicon +/Platform/Phytium/** @leiflindholm +/Silicon/Phytium/** @leiflindholm + +# Sophgo platforms and silicon +/Platform/Sophgo/** @vlsunil +/Silicon/Sophgo/SG2042Pkg/** @vlsunil diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md new file mode 100644 index 000000000000..84882bcab2fa --- /dev/null +++ b/CONTRIBUTORS.md @@ -0,0 +1,68 @@ +EDK II Platforms Maintainers and Reviewers +========================================================= + +This file provides information about the people who maintain and review +code for EDK II Platforms. For information about who from this file +maintains (i.e. owns and can commit changes) and who reviews changes in +various parts of the repo, see the CODEOWNERS and REVIEWERS files. + +| Name | e-mail address | Github username | +|------------------------|----------------------------------|------------------------------------------------------| +| Leif Lindholm | quic_llindhol@quicinc.com | [@leiflindholm](https://github.com/leiflindholm) | +| Michael D Kinney | michael.d.kinney@intel.com | [@mdkinney](https://github.com/mdkinney) | +| Ard Biesheuvel | ardb+tianocore@kernel.org | [@ardbiesheuvel](https://github.com/ardbiesheuvel) | +| Abner Chang | abner.chang@amd.com | [@changab](https://github.com/changab) | +| Abdul Lateef Attar | AbdulLateef.Attar@amd.com | [@abdattar](https://github.com/abdattar) | +| Paul Grimes | paul.grimes@amd.com | [@pbgrimes](https://github.com/pbgrimes) | +| Eric Xing | eric.xing@amd.com | [@exinghr](https://github.com/exinghr) | +| Ken Yao | ken.yao@amd.com | [@YSHRong](https://github.com/YSHRong) | +| Duke Zhai | duke.zhai@amd.com | [@mingxzha](https://github.com/mingxzha) | +| Igniculus Fu | igniculus.fu@amd.com | [@fhh200000](https://github.com/fhh200000) | +| Nhi Pham | nhi@os.amperecomputing.com | [@nhivp](https://github.com/nhivp) | +| Chuong Tran | chuong@os.amperecomputing.com | [@chuongtranle](https://github.com/chuongtranle) | +| Rebecca Cran | rebecca@os.amperecomputing.com | [bcran](https://github.com/bcran) | +| Thomas Abraham | thomas.abraham@arm.com | | +| Sami Mujawar | sami.mujawar@arm.com | [@samimujawar](https://github.com/) | +| Ray Ni | ray.ni@intel.com | [@niruiyu](https://github.com/niruiyu) | +| Ilias Apalodimas | ilias.apalodimas@linaro.org | [@apalos](https://github.com/apalos) | +| Wenyi Xie | xiewenyi2@huawei.com | | +| Pedro Falcato | pedro.falcato@gmail.com | [@heatd](https://github.com/heatd) | +| Marvin Häuser | mhaeuser@posteo.de | [@mhaeuser](https://github.com/mhaeuser) | +| Sai Chaganty | rangasai.v.chaganty@intel.com | [@SaiChaganty](https://github.com/SaiChaganty) | +| Nate DeSimone | nathaniel.l.desimone@intel.com | [@nate-desimone](https://github.com/nate-desimone) | +| Liming Gao | gaoliming@byosoft.com.cn | [@lgao4](https://github.com/lgao4) | +| Eric Dong | eric.dong@intel.com | [@ydong10](https://github.com/ydong10) | +| Dandan Bi | dandan.bi@intel.com | [@dandanbi](https://github.com/dandanbi) | +| Nickle Wang | nicklew@nvidia.com | [@nicklela](https://github.com/nicklela) | +| Zailiang Sun | zailiang.sun@intel.com | [@zailiangsun](https://github.com/zailiangsun) | +| Yi Qian | yi.qian@intel.com | [@yqian4](https://github.com/yqian4) | +| Chasel Chiu | chasel.chiu@intel.com | [@ChaselChiu](https://github.com/ChaselChiu) | +| Benjamin Doron | benjamin.doron00@gmail.com | [@benjamindoron](https://github.com/benjamindoron) | +| Jeremy Soller | jeremy@system76.com | [@jackpot51](https://github.com/jackpot51) | +| Deepika Kethi Reddy | deepika.kethi.reddy@intel.com | [@dkethire](https://github.com/dkethire) | +| Kathappan Esakkithevar | kathappan.esakkithevar@intel.com | [@kesakkit](https://github.com/kesakkit) | +| Heng Luo | heng.luo@intel.com | | +| Rosen Chuang | rosen.chuang@intel.com | [@rbitw](https://github.com/rbitw) | +| Saloni Kasbekar | saloni.kasbekar@intel.com | [@SaloniKasbekar](https://github.com/SaloniKasbekar) | +| Bob Feng | bob.c.feng@intel.com | [@BobCF](https://github.com/BobCF) | +| Yuwei Chen | yuwei.chen@intel.com | [@YuweiChen1110](https://github.com/YuweiChen1110) | +| Sunil V L | sunilvl@ventanamicro.com | [@vlsunil](https://github.com/vlsunil) | +| Daniel Schaefer | git@danielschaefer.me | [@JohnAZoidberg](https://github.com/JohnAZoidberg) | +| Ashraf Ali S | ashraf.ali.s@intel.com | [@AshrafAliS](https://github.com/AshrafAliS) | +| Bibo Mao | maobibo@loongson.cn | | +| Xianglai li | lixianglai@loongson.cn | | +| Chao Li | lichao@loongson.cn | | +| Marcin Wojtas | marcin.s.wojtas@gmail.com | [@wojtas-marcin](https://github.com/wojtas-marcin) | +| Narinder Dhillon | ndhillon@marvell.com | [@ndhillonm](https://github.com/ndhillonm) | +| Meenakshi Aggarwal | meenakshi.aggarwal@nxp.com | [@Meenakshi88](https://github.com/Meenakshi88) | +| Theo Jehl | theojehl76@gmail.com | [@theomacx86](https://github.com/theomacx86) | +| Marcin Juszkiewicz | marcin.juszkiewicz@linaro.org | [@hrw](https://github.com/hrw) | +| Graeme Gregory | graeme@xora.org.uk | | +| Jeremy Linton | jeremy.linton@arm.com | [@jlinton](https://github.com/jlinton) | +| Peng Xie | xiepeng@phytium.com.cn | | +| Ling Jia | jialing@phytium.com.cn | | +| Yiqi Shu | shuyiqi@phytium.com.cn | | +| dahogn | dahogn@hotmail.com | [@dahogn](https://github.com/dahogn) | +| meng-cz | mengcz1126@gmail.com | [@meng-cz](https://github.com/meng-cz) | +| caiyuqing379 | caiyuqing_hz@outlook.com | [@caiyuqing379](https://github.com/caiyuqing379) | +| USER0FISH | libing1202@outlook.com | [@USER0FISH](https://github.com/USER0FISH) | diff --git a/Maintainers.txt b/Maintainers.txt deleted file mode 100644 index 824838486072..000000000000 --- a/Maintainers.txt +++ /dev/null @@ -1,445 +0,0 @@ -EDK II Platforms Maintainers -============================ - -This file provides information about the primary maintainers for -EDK II Platforms. - -In general, you should not privately email the maintainer. You should -email the edk2-devel list, and Cc the package maintainers and -reviewers. - -If the package maintainer wants to hand over the role to other people, -the package maintainer should send the patch to update Maintainers.txt -with new maintainer, and the new maintainer should follow up with -an Acked-by or a Reviewed-by. - -Descriptions of section entries: - - L: Mailing list that is relevant to this area (default is edk2-devel) - Patches and questions should be sent to the email list. - M: Package Maintainer: Cc address for patches and questions. Responsible - for reviewing and pushing package changes to source control. - R: Package Reviewer: Cc address for patches and questions. Reviewers help - maintainers review code, but don't have push access. A designated Package - Reviewer is reasonably familiar with the Package (or some modules - thereof), and/or provides testing or regression testing for the Package - (or some modules thereof), in certain platforms and environments. - W: Web-page with status/info - T: SCM tree type and location. Type is one of: git, svn. - S: Status, one of the following: - Supported: Someone is actually paid to look after this. - Maintained: Someone actually looks after it. - Odd Fixes: It has a maintainer but they don't have time to do - much other than throw the odd patch in. See below. - Orphan: No current maintainer [but maybe you could take the - role as you write your new code]. - Obsolete: Old code. Something tagged obsolete generally means - it has been replaced by a better system and you - should be using that. - F: Files and directories with wildcard patterns. - A trailing slash includes all files and subdirectory files. - F: MdeModulePkg/ all files in and below MdeModulePkg - F: MdeModulePkg/* all files in MdeModulePkg, but not below - F: */Pci/* all files in a directory called Pci, at any depth in - the hierarchy, but not below - One pattern per line. Multiple F: lines per section acceptable. - X: Files and directories that are NOT maintained, same rules as F: - Files exclusions are tested after file matches. - Can be useful for excluding a specific subdirectory, for instance: - F: NetworkPkg/ - X: NetworkPkg/Ip6Dxe/ - matches all files in and below NetworkPkg excluding NetworkPkg/Ip6Dxe/ - Filenames not caught by any F: rule get matched as being located in the top- - level directory. (Internally, the script looks for a match called '<default>', - so please don't add a file called that in the top-level directory.) - - -EDK II Platforms ----------------- -W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II -L: https://edk2.groups.io/g/devel/ -T: git - https://github.com/tianocore/edk2-platforms.git - -All patches CC:d here -L: devel@edk2.groups.io -F: * -F: */ - -EDK II Platforms maintainers ----------------------------- -F: * -M: Leif Lindholm <quic_llindhol@quicinc.com> -M: Michael D Kinney <michael.d.kinney@intel.com> - -Responsible Disclosure, Reporting Security Issues -------------------------------------------------- -W: https://github.com/tianocore/tianocore.github.io/wiki/Security - -EDK II Platforms Packages: --------------------------- - -96Boards -F: Platform/96Boards/ -M: Ard Biesheuvel <ardb+tianocore@kernel.org> -M: Leif Lindholm <quic_llindhol@quicinc.com> - -AMD -F: Platform/AMD -M: Abner Chang <abner.chang@amd.com> -M: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> -M: Paul Grimes <paul.grimes@amd.com> - -F: Platform/AMD/AgesaModulePkg -F: Platform/AMD/AgesaPkg -F: Platform/AMD/AmdCbsPkg -M: Paul Grimes <paul.grimes@amd.com> -R: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> -R: Abner Chang <abner.chang@amd.com> - -F: Platform/AMD/AmdCpmPkg -M: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> -R: Paul Grimes <paul.grimes@amd.com> -R: Abner Chang <abner.chang@amd.com> - -AMD Seattle -F: Platform/AMD/OverdriveBoard/ -F: Platform/LeMaker/CelloBoard/ -F: Platform/SoftIron/ -F: Silicon/AMD/Styx/ -M: Ard Biesheuvel <ardb+tianocore@kernel.org> -M: Leif Lindholm <quic_llindhol@quicinc.com> - -AMD VanGoghBoard -F: Platform/AMD/VanGoghBoard -F: Silicon/AMD/VanGoghBoard -M: Eric Xing <eric.xing@amd.com> -R: Ken Yao <ken.yao@amd.com> -R: Duke Zhai <duke.zhai@amd.com> -R: Igniculus Fu <igniculus.fu@amd.com> - -Ampere Computing -F: Platform/Ampere -F: Silicon/Ampere -M: Nhi Pham <nhi@os.amperecomputing.com> -R: Chuong Tran <chuong@os.amperecomputing.com> -R: Leif Lindholm <quic_llindhol@quicinc.com> -R: Rebecca Cran <rebecca@os.amperecomputing.com> - -ARM -F: Platform/ARM/ -F: Silicon/ARM/ -R: Thomas Abraham <thomas.abraham@arm.com> -M: Sami Mujawar <sami.mujawar@arm.com> - -BeagleBoard: -F: Platform/BeagleBoard/ -F: Silicon/TexasInstruments/ -R: Ard Biesheuvel <ardb+tianocore@kernel.org> -M: Leif Lindholm <quic_llindhol@quicinc.com> - -OptionRomPkg -F: Drivers/OptionRomPkg/ -W: https://github.com/tianocore/tianocore.github.io/wiki/OptionRomPkg -M: Ray Ni <ray.ni@intel.com> - -StandAloneMMPkg for OP-TEE -F: Platform/StandaloneMm/PlatformStandaloneMmPkg/ -M: Sami Mujawar <sami.mujawar@arm.com> -M: Ilias Apalodimas <ilias.apalodimas@linaro.org> - -DisplayLink -F: Drivers/DisplayLink/ -M: Leif Lindholm <quic_llindhol@quicinc.com> -M: Ard Biesheuvel <ardb+tianocore@kernel.org> -R: Andy Hayes <andy.hayes@displaylink.com> - -HiSilicon -F: Platform/Hisilicon/ -F: Silicon/Hisilicon/ -M: Leif Lindholm <quic_llindhol@quicinc.com> -R: Ard Biesheuvel <ardb+tianocore@kernel.org> -R: Wenyi Xie <xiewenyi2@huawei.com> - -Features/Ext4Pkg -F: Features/Ext4Pkg/ -M: Pedro Falcato <pedro.falcato@gmail.com> -R: Marvin Häuser <mhaeuser@posteo.de> - -Features/Intel -F: Features/Intel/ -M: Sai Chaganty <rangasai.v.chaganty@intel.com> -M: Nate DeSimone <nathaniel.l.desimone@intel.com> -R: Liming Gao <gaoliming@byosoft.com.cn> - -Features/Intel/Debugging -F: Features/Intel/Debugging/ -M: Eric Dong <eric.dong@intel.com> -R: Liming Gao <gaoliming@byosoft.com.cn> - -Features/Intel/OutOfBandManagement/IpmiFeaturePkg -F: Features/Intel/OutOfBandManagement/IpmiFeaturePkg -M: Nate DeSimone <nathaniel.l.desimone@intel.com> -R: Liming Gao <gaoliming@byosoft.com.cn> - -Features/Intel/UserInterface -F: Features/Intel/UserInterface/ -M: Dandan Bi <dandan.bi@intel.com> -R: Liming Gao <gaoliming@byosoft.com.cn> - -Features/ManageabilityPkg -F: Features/ManageabilityPkg/ -M: Abner Chang <abner.chang@amd.com> -R: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> -R: Nickle Wang <nicklew@nvidia.com> - -Platform/Intel -F: Platform/Intel/ -M: Sai Chaganty <rangasai.v.chaganty@intel.com> -M: Nate DeSimone <nathaniel.l.desimone@intel.com> - -Platform/Intel/QuarkPlatformPkg -F: Platform/Intel/QuarkPlatformPkg/ -M: Michael D Kinney <michael.d.kinney@intel.com> -M: Kelly Steele <kelly.steele@intel.com> -R: Nate DeSimone <nathaniel.l.desimone@intel.com> - -Platform/Intel/Vlv2TbltDevicePkg -F: Platform/Intel/Vlv2TbltDevicePkg/ -M: Zailiang Sun <zailiang.sun@intel.com> -M: Yi Qian <yi.qian@intel.com> -R: Nate DeSimone <nathaniel.l.desimone@intel.com> - -Platform/Intel/BoardModulePkg -F: Platform/Intel/BoardModulePkg/ -M: Eric Dong <eric.dong@intel.com> -R: Liming Gao <gaoliming@byosoft.com.cn> - -Platform/Intel/KabylakeOpenBoardPkg -F: Platform/Intel/KabylakeOpenBoardPkg/ -M: Chasel Chiu <chasel.chiu@intel.com> -M: Nate DeSimone <nathaniel.l.desimone@intel.com> - -Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G -F: Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/ -R: Benjamin Doron <benjamin.doron00@gmail.com> - -Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3 -F: Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/ -R: Jeremy Soller <jeremy@system76.com> - -Platform/Intel/MinPlatformPkg -F: Platform/Intel/MinPlatformPkg/ -M: Chasel Chiu <chasel.chiu@intel.com> -M: Nate DeSimone <nathaniel.l.desimone@intel.com> -R: Liming Gao <gaoliming@byosoft.com.cn> -R: Eric Dong <eric.dong@intel.com> - -Platform/Intel/PurleyOpenBoardPkg -F: Platform/Intel/PurleyOpenBoardPkg/ -M: Nate DeSimone <nathaniel.l.desimone@intel.com> -M: Chasel Chiu <chasel.chiu@intel.com> - -Platform/Intel/WhiskeylakeOpenBoardPkg -F: Platform/Intel/WhiskeylakeOpenBoardPkg/ -M: Chasel Chiu <chasel.chiu@intel.com> -M: Nate DeSimone <nathaniel.l.desimone@intel.com> - -Platform/Intel/CometlakeOpenBoardPkg -F: Platform/Intel/CometlakeOpenBoardPkg/ -M: Chasel Chiu <chasel.chiu@intel.com> -M: Nate DeSimone <nathaniel.l.desimone@intel.com> -M: Rangasai V Chaganty <rangasai.v.chaganty@intel.com> -R: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com> -R: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com> - -Platform/Intel/TigerlakeOpenBoardPkg -F: Platform/Intel/TigerlakeOpenBoardPkg/ -M: Sai Chaganty <rangasai.v.chaganty@intel.com> -M: Nate DeSimone <nathaniel.l.desimone@intel.com> -R: Heng Luo <heng.luo@intel.com> - -Platform/Intel/AlderlakeOpenBoardPkg -F: Platform/Intel/AlderlakeOpenBoardPkg/ -M: Sai Chaganty <rangasai.v.chaganty@intel.com> -M: Nate DeSimone <nathaniel.l.desimone@intel.com> -R: Rosen Chuang <rosen.chuang@intel.com> -R: Saloni Kasbekar <saloni.kasbekar@intel.com> - -Platform/Intel/WhitleyOpenBoardPkg -F: Platform/Intel/WhitleyOpenBoardPkg/ -M: Nate DeSimone <nathaniel.l.desimone@intel.com> -M: Chasel Chiu <chasel.chiu@intel.com> - -Platform/Intel/SimicsOpenBoardPkg -F: Platform/Intel/SimicsOpenBoardPkg/ -M: Nate DeSimone <nathaniel.l.desimone@intel.com> - -Platform/Intel/Tools -F: Platform/Intel/Tools/ -M: Bob Feng <bob.c.feng@intel.com> -M: Liming Gao <gaoliming@byosoft.com.cn> -R: Yuwei Chen <yuwei.chen@intel.com> - -Platform/RISC-V/PlatformPkg -F: Platform/RISC-V/PlatformPkg/ -M: Sunil V L <sunilvl@ventanamicro.com> -R: Daniel Schaefer <git@danielschaefer.me> - -Platform/SiFive/U5SeriesPkg -F: Platform/SiFive/U5SeriesPkg/ -M: Daniel Schaefer <git@danielschaefer.me> - -Silicon/Intel -F: Silicon/Intel/ -M: Rangasai V Chaganty <rangasai.v.chaganty@intel.com> -M: Nate DeSimone <nathaniel.l.desimone@intel.com> - -Silicon/Intel/IntelSiliconPkg -F: Silicon/Intel/IntelSiliconPkg/ -M: Ray Ni <ray.ni@intel.com> -M: Rangasai V Chaganty <rangasai.v.chaganty@intel.com> -R: Ashraf Ali S <ashraf.ali.s@intel.com> - -Silicon/Intel/QuarkSocPkg -F: Silicon/Intel/QuarkSocPkg/ -M: Michael D Kinney <michael.d.kinney@intel.com> -M: Kelly Steele <kelly.steele@intel.com> -R: Nate DeSimone <nathaniel.l.desimone@intel.com> - -Silicon/Intel/Vlv2DeviceRefCodePkg -F: Silicon/Intel/Vlv2DeviceRefCodePkg/ -M: Zailiang Sun <zailiang.sun@intel.com> -M: Yi Qian <yi.qian@intel.com> -R: Nate DeSimone <nathaniel.l.desimone@intel.com> - -Silicon/Intel/CoffeelakeSiliconPkg -F: Silicon/Intel/CoffeelakeSiliconPkg/ -M: Chasel Chiu <chasel.chiu@intel.com> -M: Sai Chaganty <rangasai.v.chaganty@intel.com> - -Silicon/Intel/KabylakeSiliconPkg -F: Silicon/Intel/KabylakeSiliconPkg/ -M: Chasel Chiu <chasel.chiu@intel.com> -M: Sai Chaganty <rangasai.v.chaganty@intel.com> - -Silicon/Intel/PurleyRefreshSiliconPkg -F: Silicon/Intel/PurleyRefreshSiliconPkg/ -M: Chasel Chiu <chasel.chiu@intel.com> -M: Nate DeSimone <nathaniel.l.desimone@intel.com> - -Silicon/Intel/TigerlakeSiliconPkg -F: Silicon/Intel/TigerlakeSiliconPkg/ -M: Sai Chaganty <rangasai.v.chaganty@intel.com> -M: Nate DeSimone <nathaniel.l.desimone@intel.com> -R: Heng Luo <heng.luo@intel.com> - -Platform/Intel/AlderlakeSiliconPkg -F: Platform/Intel/AlderlakeSiliconPkg/ -M: Sai Chaganty <rangasai.v.chaganty@intel.com> -M: Nate DeSimone <nathaniel.l.desimone@intel.com> -R: Rosen Chuang <rosen.chuang@intel.com> -R: Saloni Kasbekar <saloni.kasbekar@intel.com> - -Silicon/Intel/WhitleySiliconPkg -F: Silicon/Intel/WhitleySiliconPkg/ -M: Nate DeSimone <nathaniel.l.desimone@intel.com> -M: Chasel Chiu <chasel.chiu@intel.com> - -Silicon/Intel/SimicsX58SktPkg -F: Silicon/Intel/SimicsX58SktPkg/ -M: Nate DeSimone <nathaniel.l.desimone@intel.com> - -Silicon/Intel/SimicsIch10Pkg -F: Silicon/Intel/SimicsIch10Pkg/ -M: Nate DeSimone <nathaniel.l.desimone@intel.com> - -Silicon/Intel/Tools -F: Silicon/Intel/Tools/ -M: Bob Feng <bob.c.feng@intel.com> -M: Liming Gao <gaoliming@byosoft.com.cn> -R: Yuwei Chen <yuwei.chen@intel.com> - -Loongson platforms -F: Platform/Loongson/ -M: Bibo Mao <maobibo@loongson.cn> -M: Xianglai li <lixianglai@loongson.cn> -M: Chao Li <lichao@loongson.cn> - -Marvell platforms and silicon -F: Platform/Marvell/ -F: Platform/SolidRun/ -F: Silicon/Marvell/ -M: Marcin Wojtas <marcin.s.wojtas@gmail.com> [wojtas-marcin] -M: Narinder Dhillon <ndhillon@marvell.com> [ndhillonm] -R: Leif Lindholm <quic_llindhol@quicinc.com> [leiflindholm] - -Miscellaneous drivers -F: Silicon/Atmel/ -F: Silicon/Openmoko/ -F: Silicon/Synopsys/DesignWare/ -R: Ard Biesheuvel <ardb+tianocore@kernel.org> -M: Leif Lindholm <quic_llindhol@quicinc.com> - -NXP platforms and silicon -F: Platform/NXP/ -F: Silicon/NXP/ -M: Leif Lindholm <quic_llindhol@quicinc.com> -R: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com> - -QEMU EDK II Minimum Platform Specification implementation -F: Platform/Qemu/QemuOpenBoardPkg/ -M: Pedro Falcato <pedro.falcato@gmail.com> -R: Theo Jehl <theojehl76@gmail.com> - -QEMU sbsa-ref platform -F: Platform/Qemu/SbsaQemu/ -F: Silicon/Qemu/SbsaQemu/ -M: Ard Biesheuvel <ardb+tianocore@kernel.org> -M: Leif Lindholm <quic_llindhol@quicinc.com> -M: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> [hrw] -R: Graeme Gregory <graeme@xora.org.uk> - -Raspberry Pi platforms and silicon -F: Platform/RaspberryPi/ -F: Silicon/Broadcom/ -M: Ard Biesheuvel <ardb+tianocore@kernel.org> -M: Leif Lindholm <quic_llindhol@quicinc.com> -R: Jeremy Linton <jeremy.linton@arm.com> - -RPMB driver for OP-TEE -F: Drivers/OpTee/OpteeRpmbPkg/ -M: Sami Mujawar <sami.mujawar@arm.com> -M: Ilias Apalodimas <ilias.apalodimas@linaro.org> - -Socionext platforms and silicon -F: Platform/Socionext/ -F: Silicon/NXP/Library/Pcf8563RealTimeClockLib/ -F: Silicon/Socionext/ -M: Ard Biesheuvel <ardb+tianocore@kernel.org> -M: Leif Lindholm <quic_llindhol@quicinc.com> - -Silicon/RISC-V/ProcessorPkg -F: Silicon/RISC-V/ProcessorPkg/ -M: Sunil V L <sunilvl@ventanamicro.com> -R: Daniel Schaefer <git@danielschaefer.me> - -Silicon/SiFive -F: Silicon/SiFive/ -M: Daniel Schaefer <git@danielschaefer.me> - -Phytium platforms and silicon -F: Platform/Phytium/ -F: Silicon/Phytium/ -M: Leif Lindholm <quic_llindhol@quicinc.com> -R: Peng Xie <xiepeng@phytium.com.cn> -R: Ling Jia <jialing@phytium.com.cn> -R: Yiqi Shu <shuyiqi@phytium.com.cn> - -Sophgo platforms and silicon -F: Platform/Sophgo/ -F: Silicon/Sophgo/SG2042Pkg/ -M: Sunil V L <sunilvl@ventanamicro.com> -R: dahogn <dahogn@hotmail.com> -R: meng-cz <mengcz1126@gmail.com> -R: caiyuqing379 <caiyuqing_hz@outlook.com> -R: USER0FISH <libing1202@outlook.com> diff --git a/REVIEWERS b/REVIEWERS new file mode 100644 index 000000000000..4b1a491b1061 --- /dev/null +++ b/REVIEWERS @@ -0,0 +1,92 @@ +# This file contains the list of reviewers (i.e. people who can +# review changes, but don't own the packages and can't commit changes) +# for various parts of edk2-platforms. + +# AMD VanGoghBoard +/Platform/AMD/VanGoghBoard/** @YSHRong @mingxzha @fhh200000 + +# Ampere +/Platform/Ampere/** @chuongtranle @leiflindholm @bcran +/Silicon/Ampere/** @chuongtranle @leiflindholm @bcran + +# ARM +# Add Tomas Abraham +# /Platform/ARM/** + +# BeagleBoard: +/Platform/BeagleBoard/** @ardbiesheuvel +/Silicon/TexasInstruments/** @ardbiesheuvel + +# Hisilicon +# Add Wenyi Xie +/Platform/Hisilicon/** @ardbiesheuvel +/Silicon/Hisilicon/** @ardbiesheuvel + +/Features/Ext4Pkg/** @mhaeuser + +/Features/Intel/** @lgao4 +/Features/Intel/Debugging/** @lgao4 +/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/** @lgao4 +/Features/Intel/UserInterface/** @lgao4 + +/Features/ManageabilityPkg/** @abdattar @nicklela + +/Platform/Intel/QuarkPlatformPkg/** @nate-desimone +/Platform/Intel/Vlv2TbltDevicePkg/** @nate-desimone +/Platform/Intel/BoardModulePkg/** @lgao4 +/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/** @jackpot5 +/Platform/Intel/MinPlatformPkg/** @lgao4 @ydong10 +/Platform/Intel/WhiskeylakeOpenBoardPkg/** @ChaselChiu +/Platform/Intel/CometlakeOpenBoardPkg/** @dkethire @kesakkit +# Add Heng Luo +# /Platform/Intel/TigerlakeOpenBoardPkg/** +/Platform/Intel/AlderlakeOpenBoardPkg/** @rbitw @SaloniKasbekar +/Platform/Intel/Tools/** @YuweiChen1110 + +/Platform/RISC-V/PlatformPkg/** @JohnAZoidberg + +/Silicon/Intel/IntelSiliconPkg/** @AshrafAliS +/Silicon/Intel/QuarkSocPkg/** @nate-desimone +/Silicon/Intel/Vlv2DeviceRefCodePkg/** @nate-desimone + +# Add Heng Luo +# /Silicon/Intel/TigerlakeSiliconPkg/** + +/Silicon/Intel/AlderlakeSiliconPkg/** @rbitw @SaloniKasbekar + +/Silicon/Intel/Tools/** @YuweiChen1110 + +/Platform/Marvell/** @leiflindholm +/Platform/SolidRun/** @leiflindholm +/Silicon/Marvell/** @leiflindholm + +# Miscellaneous Drivers +/Silicon/Atmel/** @ardbiesheuvel +/Silicon/Openmoko/** @ardbiesheuvel +/Silicon/Synopsys/DesignWare/** @ardbiesheuvel + +/Platform/NXP/** @Meenakshi88 +/Silicon/NXP/** @Meenakshi88 + +# QEMU EDK II Minimum Platform Specification implementation +/Platform/Qemu/QemuOpenBoardPkg/** @theomacx86 + +# Add Graeme Gregory +# /Platform/Qemu/SbsaQemu/** +# /Silicon/Qemu/SbsaQemu/** + +# Raspberry Pi platforms and silicon +/Platform/RaspberryPi/** @jlinton +/Silicon/Broadcom/** @jlinton + +/Silicon/RISC-V/ProcessorPkg/** @JohnAZoidberg + +# Phytium platforms and silicon +# Add Peng Xie, Ling Jia and Yiqi Shu +# /Platform/Phytium/** +# /Silicon/Phytium/** + +# Sophgo platforms and silicon +/Platform/Sophgo/** @dahogn @meng-cz @caiyiqing379 @USER0FISH +/Silicon/Sophgo/SG2042Pkg/** @dahogn @meng-cz @caiyiqing379 @USER0FISH + diff --git a/Readme.md b/Readme.md index 8de9eaa7cfbb..7b43e803fccd 100644 --- a/Readme.md +++ b/Readme.md @@ -32,10 +32,32 @@ Many platforms require additional image processing beyond the EDK2 build. Any such steps should be documented (as a Readme.md), and any necessary helper scripts be contained, under said platform directory. -Any contributions to this branch should be submitted via email to the -edk2-devel mailing list with a subject prefix of `[platforms]`. See -[Laszlo's excellent guide](https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers) for details -on how to do this successfully. +Any contributions to this branch should be submitted via GitHub Pull Request, +or email to the edk2-devel mailing list with a subject prefix of `[platforms]`. See +[Laszlo's excellent guide](https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers) for details on how to do this successfully. + +For details of who owns code in certain parts of the repo, see the CODEOWNERS and +REVIEWERS files. Look in CONTRIBUTORS.md to find out people's names and their +email addresses. + +In general, you should not privately email the maintainer. You should +email the edk2-devel list, and Cc the package maintainers and +reviewers. + +If the package maintainer wants to hand over the role to other people, +the package maintainer should create a PR on GitHub to update CODEOWNERS, +REVIEWERS and CONTRIBUTORS.md with new maintainer, and the new maintainer +should review the PR and approve it. + +EDK II Platforms +---------------- +W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II +L: https://edk2.groups.io/g/devel/ +T: git - https://github.com/tianocore/edk2-platforms.git + +Responsible Disclosure, Reporting Security Issues +------------------------------------------------- +W: https://github.com/tianocore/tianocore.github.io/wiki/Security # How to build (Linux Environment) @@ -294,7 +316,7 @@ For more information, see the # Maintainers -See [Maintainers.txt](Maintainers.txt). +See [CONTRIBUTORS.md](CONTRIBUTORS.md), [CODEOWNERS](CODEOWNERS) and [REVIEWERS](REVIEWERS). # Submodules -- 2.45.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120056): https://edk2.groups.io/g/devel/message/120056 Mute This Topic: https://groups.io/mt/107583542/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] Move to the GitHub Pull Request workflow 2024-07-27 20:31 ` [edk2-devel] [PATCH edk2-platforms v2 1/1] " Rebecca Cran @ 2024-08-01 9:45 ` Leif Lindholm 2024-08-01 12:49 ` Rebecca Cran 0 siblings, 1 reply; 7+ messages in thread From: Leif Lindholm @ 2024-08-01 9:45 UTC (permalink / raw) To: Rebecca Cran; +Cc: devel, Michael D Kinney On Sat, Jul 27, 2024 at 14:31:56 -0600, Rebecca Cran wrote: > Migrate data from Maintainers.txt to the GitHub standard CODEOWNERS > files plus REVIEWERS and CONTRIBUTORS.md. The latter file contains > mappings from name to email address and GitHub usernames, which will > help people who want to email maintainers instead of using GitHub. > > Add .github/workflows/AssignReviewers.yml which adds reviewers to a > Pull Request based on the content of the REVIEWERS file. > > Signed-off-by: Rebecca Cran <rebecca@bsdio.com> > --- > .github/workflows/AssignReviewers.yml | 28 ++ > CODEOWNERS | 146 +++++++ > CONTRIBUTORS.md | 68 +++ > Maintainers.txt | 445 -------------------- > REVIEWERS | 92 ++++ > Readme.md | 32 +- > 6 files changed, 361 insertions(+), 450 deletions(-) > > diff --git a/.github/workflows/AssignReviewers.yml b/.github/workflows/AssignReviewers.yml > new file mode 100644 > index 000000000000..8ee95edbb2c1 > --- /dev/null > +++ b/.github/workflows/AssignReviewers.yml > @@ -0,0 +1,28 @@ > +## @file > +# Assign reviewers from a REVIEWERS file using CODEOWNERS syntax If we're starting to do manual copying around of files between repositories, can we add a manual audit trail? I.e., full URL of repository, path inside repository, and commit hash? I think my preference would be in this file header. > +# > +# Copyright (c) 2022, Intel Corporation. All rights reserved.<BR> > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > + > +name: Assign reviewers from a REVIEWERS file using CODEOWNERS syntax > + > +on: > + pull_request_target: > + types: [opened, synchronize, reopened, ready_for_review] > + branches: > + - main > + > +jobs: > + assign_reviewers: > + if: github.event.pull_request.draft == false > + runs-on: ubuntu-latest > + permissions: > + pull-requests: write > + steps: > + - name: Checkout Pull Request Target > + uses: actions/checkout@v2 > + - name: Assign Reviewers > + uses: mdkinney/github-action-assign-reviewers@main > + with: > + token: ${{secrets.GITHUB_TOKEN}} > diff --git a/CODEOWNERS b/CODEOWNERS > new file mode 100644 > index 000000000000..bc86dd113398 > --- /dev/null > +++ b/CODEOWNERS > @@ -0,0 +1,146 @@ > +# This file contains the list of maintainers (i.e. people who own the > +# packages and can commit changes) for various parts of edk2-platforms. > + > +# EDK II Platforms maintainers > +# ============================ > +* @leiflindholm @mdkinney > + > +# EDK II Platforms Packages > +# ========================= > + > +/Platform/96Boards/** @ardbiesheuvel @leiflindholm > + > +/Platform/AMD/** @changab @abdattar @pbgrimes > + > +/Platform/AMD/AgesaModulePkg/** @changab @abdattar @pbgrimes > +/Platform/AMD/AgesaPkg/** @changab @abdattar @pbgrimes > +/Platform/AMD/AmdCbsPkg/** @changab @abdattar @pbgrimes > +/Platform/AMD/AmdCpmPkg/** @changab @abdattar @pbgrimes > + > +# AMD Seattle platforms > +/Platform/AMD/OverdriveBoard/** @changab @abdattar @pbgrimes @ardbiesheuvel @leiflindholm > +/Silicon/AMD/Styx/** @changab @abdattar @pbgrimes @ardbiesheuvel @leiflindholm > +/Platform/LeMaker/CelloBoard/** @ardbiesheuvel @leiflindholm > +/Platform/SoftIron/ @ardbiesheuvel @leiflindholm > + > +# AMD VanGoghBoard > +/Platform/AMD/VanGoghBoard/** @changab @abdattar @pbgrimes @exinghr > + > +# Ampere Computing > +/Platform/Ampere/** @nhivp > +/Silicon/Ampere/** @nhivp > + > +# ARM > +/Platform/ARM/** @samimujawar > +/Silicon/ARM/** @samimujawar > + > +# BeagleBoard: > +/Platform/BeagleBoard/** @ardbiesheuvel @leiflindholm > +/Silicon/TexasInstruments/** @ardbiesheuvel @leiflindholm > + > +# OptionRomPkg > +# https://github.com/tianocore/tianocore.github.io/wiki/OptionRomPkg > +/Drivers/OptionRomPkg/** @niruiyu > + > +# StandAloneMMPkg for OP-TEE > +/Platform/StandaloneMm/PlatformStandaloneMmPkg/** @apalos @samimujawar > + > +# DisplayLink > +/Drivers/DisplayLink/** @leiflindholm @ardbiesheuvel > + > +# HiSilicon > +/Platform/Hisilicon/** @leiflindholm > +/Silicon/Hisilicon/** @leiflindholm > + > +/Features/Ext4Pkg/** @heatd > + > +/Features/Intel/** @nate-desimone @SaiChaganty > +/Features/Intel/Debugging/** @ydong10 @nate-desimone @SaiChaganty > +/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/** @nate-desimone @SaiChaganty > +/Features/Intel/UserInterface/** @dandanbi @nate-desimone @SaiChaganty > + > +/Features/ManageabilityPkg/** @changab > + > +/Platform/Intel/** @nate-desimone @SaiChaganty > +/Platform/Intel/QuarkPlatformPkg/** @mdkinney @nate-desimone @SaiChaganty > +/Platform/Intel/Vlv2TbltDevicePkg/** @zailiangsun @yqian4 @nate-desimone @SaiChaganty > +/Platform/Intel/BoardModulePkg/** @ydong10 @nate-desimone @SaiChaganty > +/Platform/Intel/KabylakeOpenBoardPkg/** @ChaselChiu @nate-desimone @SaiChaganty > +/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/** @benjamindoron @nate-desimone @SaiChaganty > +/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/** @jackpot51 > +/Platform/Intel/MinPlatformPkg/** @ChaselChiu @nate-desimone @SaiChaganty > +/Platform/Intel/PurleyOpenBoardPkg/** @nate-desimone @ChaselChiu @SaiChaganty > +/Platform/Intel/WhiskeylakeOpenBoardPkg/** @nate-desimone @SaiChaganty @ChaselChiu > +/Platform/Intel/CometlakeOpenBoardPkg/** @ChaselChiu @nate-desimone @SaiChaganty > +/Platform/Intel/TigerlakeOpenBoardPkg/** @SaiChaganty @nate-desimone > +/Platform/Intel/AlderlakeOpenBoardPkg/** @nate-desimone @SaiChaganty > +/Platform/Intel/WhitleyOpenBoardPkg/** @ChaselChiu @nate-desimone @SaiChaganty > +/Platform/Intel/SimicsOpenBoardPkg/** @nate-desimone @SaiChaganty > +/Platform/Intel/Tools/** @BobCF @lgao4 @nate-desimone @SaiChaganty > + > +/Platform/RISC-V/PlatformPkg/** @vlsunil > + > +/Platform/SiFive/U5SeriesPkg/** @JohnAZoidberg > + > +/Silicon/Intel/** @nate-desimone @SaiChaganty > +/Silicon/Intel/IntelSiliconPkg/** @niruiyu @nate-desimone @SaiChaganty > +/Silicon/Intel/QuarkSocPkg/** @mdkinney @nate-desimone @SaiChaganty > +/Silicon/Intel/Vlv2DeviceRefCodePkg/** @zailiangsun @yqian4 @nate-desimone @SaiChaganty > +/Silicon/Intel/CoffeelakeSiliconPkg/** @ChaselChiu @SaiChaganty @nate-desimone > +/Silicon/Intel/KabylakeSiliconPkg/** @ChaselChiu @SaiChaganty @nate-desimone > +/Silicon/Intel/PurleyRefreshSiliconPkg/** @ChaselChiu @nate-desimone @SaiChaganty > +/Silicon/Intel/TigerlakeSiliconPkg/** @SaiChaganty @nate-desimone > +/Silicon/Intel/AlderlakeSiliconPkg/** @SaiChaganty @nate-desimone > +/Silicon/Intel/WhitleySiliconPkg/** @nate-desimone @ChaselChiu @SaiChaganty > +/Silicon/Intel/SimicsX58SktPkg/** @nate-desimone @SaiChaganty > +/Silicon/Intel/SimicsIch10Pkg/** @nate-desimone @SaiChaganty > +/Silicon/Intel/Tools/** @BobCF @lgao4 @nate-desimone @SaiChaganty > + > +# Loongson platforms > +# Add Bibo Mao, Xianglai li and Chao Li > +# /Platform/Loongson/** > + > +# Marvell platforms and silicon > +/Platform/Marvell/** @wojtas-marcin @ndhillonm > +/Platform/SolidRun/** @wojtas-marcin @ndhillonm > +/Silicon/Marvell/** @wojtas-marcin @ndhillonm > + > +# Miscellaneous drivers > +/Silicon/Atmel/** @leiflindholm > +/Silicon/Openmoko/** @leiflindholm > +/Silicon/Synopsys/DesignWare/** @leiflindholm > + > +# NXP platforms and silicon > +/Platform/NXP/** @leiflindholm > +/Silicon/NXP/** @leiflindholm > + > +# QEMU EDK II Minimum Platform Specification implementation > +/Platform/Qemu/QemuOpenBoardPkg/** @heatd > + > +# QEMU sbsa-ref platform > +/Platform/Qemu/SbsaQemu/** @ardbiesheuvel @leiflindholm @hrw > +/Silicon/Qemu/SbsaQemu/** @ardbiesheuvel @leiflindholm @hrw > + > +# Raspberry Pi platforms and silicon > +/Platform/RaspberryPi/** @ardbiesheuvel @leiflindholm > +/Silicon/Broadcom/** @ardbiesheuvel @leiflindholm > + > +# RPMB driver for OP-TEE > +/Drivers/OpTee/OpteeRpmbPkg/** @apalos @samimujawar > + > +# Socionext platforms and silicon > +/Platform/Socionext/** @ardbiesheuvel @leiflindholm > +/Silicon/NXP/Library/Pcf8563RealTimeClockLib/** @ardbiesheuvel @leiflindholm > +/Silicon/Socionext/** @ardbiesheuvel @leiflindholm > + > +/Silicon/RISC-V/ProcessorPkg/** @vlsunil > + > +/Silicon/SiFive/** @JohnAZoidberg > + > +# Phytium platforms and silicon > +/Platform/Phytium/** @leiflindholm > +/Silicon/Phytium/** @leiflindholm > + > +# Sophgo platforms and silicon > +/Platform/Sophgo/** @vlsunil > +/Silicon/Sophgo/SG2042Pkg/** @vlsunil Not super important, but if we're doing this change it would be an opportunity to re-sort the areas alphabetically, since that broke somewhere along the way. > diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md > new file mode 100644 > index 000000000000..84882bcab2fa > --- /dev/null > +++ b/CONTRIBUTORS.md > @@ -0,0 +1,68 @@ > +EDK II Platforms Maintainers and Reviewers > +========================================================= > + > +This file provides information about the people who maintain and review > +code for EDK II Platforms. For information about who from this file > +maintains (i.e. owns and can commit changes) and who reviews changes in > +various parts of the repo, see the CODEOWNERS and REVIEWERS files. > + > +| Name | e-mail address | Github username | > +|------------------------|----------------------------------|------------------------------------------------------| > +| Leif Lindholm | quic_llindhol@quicinc.com | [@leiflindholm](https://github.com/leiflindholm) | > +| Michael D Kinney | michael.d.kinney@intel.com | [@mdkinney](https://github.com/mdkinney) | > +| Ard Biesheuvel | ardb+tianocore@kernel.org | [@ardbiesheuvel](https://github.com/ardbiesheuvel) | > +| Abner Chang | abner.chang@amd.com | [@changab](https://github.com/changab) | > +| Abdul Lateef Attar | AbdulLateef.Attar@amd.com | [@abdattar](https://github.com/abdattar) | > +| Paul Grimes | paul.grimes@amd.com | [@pbgrimes](https://github.com/pbgrimes) | > +| Eric Xing | eric.xing@amd.com | [@exinghr](https://github.com/exinghr) | > +| Ken Yao | ken.yao@amd.com | [@YSHRong](https://github.com/YSHRong) | > +| Duke Zhai | duke.zhai@amd.com | [@mingxzha](https://github.com/mingxzha) | > +| Igniculus Fu | igniculus.fu@amd.com | [@fhh200000](https://github.com/fhh200000) | > +| Nhi Pham | nhi@os.amperecomputing.com | [@nhivp](https://github.com/nhivp) | > +| Chuong Tran | chuong@os.amperecomputing.com | [@chuongtranle](https://github.com/chuongtranle) | > +| Rebecca Cran | rebecca@os.amperecomputing.com | [bcran](https://github.com/bcran) | > +| Thomas Abraham | thomas.abraham@arm.com | | > +| Sami Mujawar | sami.mujawar@arm.com | [@samimujawar](https://github.com/) | > +| Ray Ni | ray.ni@intel.com | [@niruiyu](https://github.com/niruiyu) | > +| Ilias Apalodimas | ilias.apalodimas@linaro.org | [@apalos](https://github.com/apalos) | > +| Wenyi Xie | xiewenyi2@huawei.com | | > +| Pedro Falcato | pedro.falcato@gmail.com | [@heatd](https://github.com/heatd) | > +| Marvin H??user | mhaeuser@posteo.de | [@mhaeuser](https://github.com/mhaeuser) | Is this charset corruption only in the email? > +| Sai Chaganty | rangasai.v.chaganty@intel.com | [@SaiChaganty](https://github.com/SaiChaganty) | > +| Nate DeSimone | nathaniel.l.desimone@intel.com | [@nate-desimone](https://github.com/nate-desimone) | > +| Liming Gao | gaoliming@byosoft.com.cn | [@lgao4](https://github.com/lgao4) | > +| Eric Dong | eric.dong@intel.com | [@ydong10](https://github.com/ydong10) | > +| Dandan Bi | dandan.bi@intel.com | [@dandanbi](https://github.com/dandanbi) | > +| Nickle Wang | nicklew@nvidia.com | [@nicklela](https://github.com/nicklela) | > +| Zailiang Sun | zailiang.sun@intel.com | [@zailiangsun](https://github.com/zailiangsun) | > +| Yi Qian | yi.qian@intel.com | [@yqian4](https://github.com/yqian4) | > +| Chasel Chiu | chasel.chiu@intel.com | [@ChaselChiu](https://github.com/ChaselChiu) | > +| Benjamin Doron | benjamin.doron00@gmail.com | [@benjamindoron](https://github.com/benjamindoron) | > +| Jeremy Soller | jeremy@system76.com | [@jackpot51](https://github.com/jackpot51) | > +| Deepika Kethi Reddy | deepika.kethi.reddy@intel.com | [@dkethire](https://github.com/dkethire) | > +| Kathappan Esakkithevar | kathappan.esakkithevar@intel.com | [@kesakkit](https://github.com/kesakkit) | > +| Heng Luo | heng.luo@intel.com | | > +| Rosen Chuang | rosen.chuang@intel.com | [@rbitw](https://github.com/rbitw) | > +| Saloni Kasbekar | saloni.kasbekar@intel.com | [@SaloniKasbekar](https://github.com/SaloniKasbekar) | > +| Bob Feng | bob.c.feng@intel.com | [@BobCF](https://github.com/BobCF) | > +| Yuwei Chen | yuwei.chen@intel.com | [@YuweiChen1110](https://github.com/YuweiChen1110) | > +| Sunil V L | sunilvl@ventanamicro.com | [@vlsunil](https://github.com/vlsunil) | > +| Daniel Schaefer | git@danielschaefer.me | [@JohnAZoidberg](https://github.com/JohnAZoidberg) | > +| Ashraf Ali S | ashraf.ali.s@intel.com | [@AshrafAliS](https://github.com/AshrafAliS) | > +| Bibo Mao | maobibo@loongson.cn | | > +| Xianglai li | lixianglai@loongson.cn | | > +| Chao Li | lichao@loongson.cn | | > +| Marcin Wojtas | marcin.s.wojtas@gmail.com | [@wojtas-marcin](https://github.com/wojtas-marcin) | > +| Narinder Dhillon | ndhillon@marvell.com | [@ndhillonm](https://github.com/ndhillonm) | > +| Meenakshi Aggarwal | meenakshi.aggarwal@nxp.com | [@Meenakshi88](https://github.com/Meenakshi88) | > +| Theo Jehl | theojehl76@gmail.com | [@theomacx86](https://github.com/theomacx86) | > +| Marcin Juszkiewicz | marcin.juszkiewicz@linaro.org | [@hrw](https://github.com/hrw) | > +| Graeme Gregory | graeme@xora.org.uk | | > +| Jeremy Linton | jeremy.linton@arm.com | [@jlinton](https://github.com/jlinton) | > +| Peng Xie | xiepeng@phytium.com.cn | | > +| Ling Jia | jialing@phytium.com.cn | | > +| Yiqi Shu | shuyiqi@phytium.com.cn | | > +| dahogn | dahogn@hotmail.com | [@dahogn](https://github.com/dahogn) | > +| meng-cz | mengcz1126@gmail.com | [@meng-cz](https://github.com/meng-cz) | > +| caiyuqing379 | caiyuqing_hz@outlook.com | [@caiyuqing379](https://github.com/caiyuqing379) | > +| USER0FISH | libing1202@outlook.com | [@USER0FISH](https://github.com/USER0FISH) | Likewise, could we sort this alphabetically by name string? (If that's annoying, can you push it to a branch where I could pull it down and sort it?) > diff --git a/Maintainers.txt b/Maintainers.txt > deleted file mode 100644 > index 824838486072..000000000000 > --- a/Maintainers.txt > +++ /dev/null > @@ -1,445 +0,0 @@ > -EDK II Platforms Maintainers > -============================ > - > -This file provides information about the primary maintainers for > -EDK II Platforms. > - > -In general, you should not privately email the maintainer. You should > -email the edk2-devel list, and Cc the package maintainers and > -reviewers. > - > -If the package maintainer wants to hand over the role to other people, > -the package maintainer should send the patch to update Maintainers.txt > -with new maintainer, and the new maintainer should follow up with > -an Acked-by or a Reviewed-by. > - > -Descriptions of section entries: > - > - L: Mailing list that is relevant to this area (default is edk2-devel) > - Patches and questions should be sent to the email list. > - M: Package Maintainer: Cc address for patches and questions. Responsible > - for reviewing and pushing package changes to source control. > - R: Package Reviewer: Cc address for patches and questions. Reviewers help > - maintainers review code, but don't have push access. A designated Package > - Reviewer is reasonably familiar with the Package (or some modules > - thereof), and/or provides testing or regression testing for the Package > - (or some modules thereof), in certain platforms and environments. > - W: Web-page with status/info > - T: SCM tree type and location. Type is one of: git, svn. > - S: Status, one of the following: > - Supported: Someone is actually paid to look after this. > - Maintained: Someone actually looks after it. > - Odd Fixes: It has a maintainer but they don't have time to do > - much other than throw the odd patch in. See below. > - Orphan: No current maintainer [but maybe you could take the > - role as you write your new code]. > - Obsolete: Old code. Something tagged obsolete generally means > - it has been replaced by a better system and you > - should be using that. > - F: Files and directories with wildcard patterns. > - A trailing slash includes all files and subdirectory files. > - F: MdeModulePkg/ all files in and below MdeModulePkg > - F: MdeModulePkg/* all files in MdeModulePkg, but not below > - F: */Pci/* all files in a directory called Pci, at any depth in > - the hierarchy, but not below > - One pattern per line. Multiple F: lines per section acceptable. > - X: Files and directories that are NOT maintained, same rules as F: > - Files exclusions are tested after file matches. > - Can be useful for excluding a specific subdirectory, for instance: > - F: NetworkPkg/ > - X: NetworkPkg/Ip6Dxe/ > - matches all files in and below NetworkPkg excluding NetworkPkg/Ip6Dxe/ > - Filenames not caught by any F: rule get matched as being located in the top- > - level directory. (Internally, the script looks for a match called '<default>', > - so please don't add a file called that in the top-level directory.) > - > - > -EDK II Platforms > ----------------- > -W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II > -L: https://edk2.groups.io/g/devel/ > -T: git - https://github.com/tianocore/edk2-platforms.git > - > -All patches CC:d here > -L: devel@edk2.groups.io > -F: * > -F: */ > - > -EDK II Platforms maintainers > ----------------------------- > -F: * > -M: Leif Lindholm <quic_llindhol@quicinc.com> > -M: Michael D Kinney <michael.d.kinney@intel.com> > - > -Responsible Disclosure, Reporting Security Issues > -------------------------------------------------- > -W: https://github.com/tianocore/tianocore.github.io/wiki/Security > - > -EDK II Platforms Packages: > --------------------------- > - > -96Boards > -F: Platform/96Boards/ > -M: Ard Biesheuvel <ardb+tianocore@kernel.org> > -M: Leif Lindholm <quic_llindhol@quicinc.com> > - > -AMD > -F: Platform/AMD > -M: Abner Chang <abner.chang@amd.com> > -M: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> > -M: Paul Grimes <paul.grimes@amd.com> > - > -F: Platform/AMD/AgesaModulePkg > -F: Platform/AMD/AgesaPkg > -F: Platform/AMD/AmdCbsPkg > -M: Paul Grimes <paul.grimes@amd.com> > -R: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> > -R: Abner Chang <abner.chang@amd.com> > - > -F: Platform/AMD/AmdCpmPkg > -M: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> > -R: Paul Grimes <paul.grimes@amd.com> > -R: Abner Chang <abner.chang@amd.com> > - > -AMD Seattle > -F: Platform/AMD/OverdriveBoard/ > -F: Platform/LeMaker/CelloBoard/ > -F: Platform/SoftIron/ > -F: Silicon/AMD/Styx/ > -M: Ard Biesheuvel <ardb+tianocore@kernel.org> > -M: Leif Lindholm <quic_llindhol@quicinc.com> > - > -AMD VanGoghBoard > -F: Platform/AMD/VanGoghBoard > -F: Silicon/AMD/VanGoghBoard > -M: Eric Xing <eric.xing@amd.com> > -R: Ken Yao <ken.yao@amd.com> > -R: Duke Zhai <duke.zhai@amd.com> > -R: Igniculus Fu <igniculus.fu@amd.com> > - > -Ampere Computing > -F: Platform/Ampere > -F: Silicon/Ampere > -M: Nhi Pham <nhi@os.amperecomputing.com> > -R: Chuong Tran <chuong@os.amperecomputing.com> > -R: Leif Lindholm <quic_llindhol@quicinc.com> > -R: Rebecca Cran <rebecca@os.amperecomputing.com> > - > -ARM > -F: Platform/ARM/ > -F: Silicon/ARM/ > -R: Thomas Abraham <thomas.abraham@arm.com> > -M: Sami Mujawar <sami.mujawar@arm.com> > - > -BeagleBoard: > -F: Platform/BeagleBoard/ > -F: Silicon/TexasInstruments/ > -R: Ard Biesheuvel <ardb+tianocore@kernel.org> > -M: Leif Lindholm <quic_llindhol@quicinc.com> > - > -OptionRomPkg > -F: Drivers/OptionRomPkg/ > -W: https://github.com/tianocore/tianocore.github.io/wiki/OptionRomPkg > -M: Ray Ni <ray.ni@intel.com> > - > -StandAloneMMPkg for OP-TEE > -F: Platform/StandaloneMm/PlatformStandaloneMmPkg/ > -M: Sami Mujawar <sami.mujawar@arm.com> > -M: Ilias Apalodimas <ilias.apalodimas@linaro.org> > - > -DisplayLink > -F: Drivers/DisplayLink/ > -M: Leif Lindholm <quic_llindhol@quicinc.com> > -M: Ard Biesheuvel <ardb+tianocore@kernel.org> > -R: Andy Hayes <andy.hayes@displaylink.com> > - > -HiSilicon > -F: Platform/Hisilicon/ > -F: Silicon/Hisilicon/ > -M: Leif Lindholm <quic_llindhol@quicinc.com> > -R: Ard Biesheuvel <ardb+tianocore@kernel.org> > -R: Wenyi Xie <xiewenyi2@huawei.com> > - > -Features/Ext4Pkg > -F: Features/Ext4Pkg/ > -M: Pedro Falcato <pedro.falcato@gmail.com> > -R: Marvin H??user <mhaeuser@posteo.de> > - > -Features/Intel > -F: Features/Intel/ > -M: Sai Chaganty <rangasai.v.chaganty@intel.com> > -M: Nate DeSimone <nathaniel.l.desimone@intel.com> > -R: Liming Gao <gaoliming@byosoft.com.cn> > - > -Features/Intel/Debugging > -F: Features/Intel/Debugging/ > -M: Eric Dong <eric.dong@intel.com> > -R: Liming Gao <gaoliming@byosoft.com.cn> > - > -Features/Intel/OutOfBandManagement/IpmiFeaturePkg > -F: Features/Intel/OutOfBandManagement/IpmiFeaturePkg > -M: Nate DeSimone <nathaniel.l.desimone@intel.com> > -R: Liming Gao <gaoliming@byosoft.com.cn> > - > -Features/Intel/UserInterface > -F: Features/Intel/UserInterface/ > -M: Dandan Bi <dandan.bi@intel.com> > -R: Liming Gao <gaoliming@byosoft.com.cn> > - > -Features/ManageabilityPkg > -F: Features/ManageabilityPkg/ > -M: Abner Chang <abner.chang@amd.com> > -R: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> > -R: Nickle Wang <nicklew@nvidia.com> > - > -Platform/Intel > -F: Platform/Intel/ > -M: Sai Chaganty <rangasai.v.chaganty@intel.com> > -M: Nate DeSimone <nathaniel.l.desimone@intel.com> > - > -Platform/Intel/QuarkPlatformPkg > -F: Platform/Intel/QuarkPlatformPkg/ > -M: Michael D Kinney <michael.d.kinney@intel.com> > -M: Kelly Steele <kelly.steele@intel.com> > -R: Nate DeSimone <nathaniel.l.desimone@intel.com> > - > -Platform/Intel/Vlv2TbltDevicePkg > -F: Platform/Intel/Vlv2TbltDevicePkg/ > -M: Zailiang Sun <zailiang.sun@intel.com> > -M: Yi Qian <yi.qian@intel.com> > -R: Nate DeSimone <nathaniel.l.desimone@intel.com> > - > -Platform/Intel/BoardModulePkg > -F: Platform/Intel/BoardModulePkg/ > -M: Eric Dong <eric.dong@intel.com> > -R: Liming Gao <gaoliming@byosoft.com.cn> > - > -Platform/Intel/KabylakeOpenBoardPkg > -F: Platform/Intel/KabylakeOpenBoardPkg/ > -M: Chasel Chiu <chasel.chiu@intel.com> > -M: Nate DeSimone <nathaniel.l.desimone@intel.com> > - > -Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G > -F: Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/ > -R: Benjamin Doron <benjamin.doron00@gmail.com> > - > -Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3 > -F: Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/ > -R: Jeremy Soller <jeremy@system76.com> > - > -Platform/Intel/MinPlatformPkg > -F: Platform/Intel/MinPlatformPkg/ > -M: Chasel Chiu <chasel.chiu@intel.com> > -M: Nate DeSimone <nathaniel.l.desimone@intel.com> > -R: Liming Gao <gaoliming@byosoft.com.cn> > -R: Eric Dong <eric.dong@intel.com> > - > -Platform/Intel/PurleyOpenBoardPkg > -F: Platform/Intel/PurleyOpenBoardPkg/ > -M: Nate DeSimone <nathaniel.l.desimone@intel.com> > -M: Chasel Chiu <chasel.chiu@intel.com> > - > -Platform/Intel/WhiskeylakeOpenBoardPkg > -F: Platform/Intel/WhiskeylakeOpenBoardPkg/ > -M: Chasel Chiu <chasel.chiu@intel.com> > -M: Nate DeSimone <nathaniel.l.desimone@intel.com> > - > -Platform/Intel/CometlakeOpenBoardPkg > -F: Platform/Intel/CometlakeOpenBoardPkg/ > -M: Chasel Chiu <chasel.chiu@intel.com> > -M: Nate DeSimone <nathaniel.l.desimone@intel.com> > -M: Rangasai V Chaganty <rangasai.v.chaganty@intel.com> > -R: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com> > -R: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com> > - > -Platform/Intel/TigerlakeOpenBoardPkg > -F: Platform/Intel/TigerlakeOpenBoardPkg/ > -M: Sai Chaganty <rangasai.v.chaganty@intel.com> > -M: Nate DeSimone <nathaniel.l.desimone@intel.com> > -R: Heng Luo <heng.luo@intel.com> > - > -Platform/Intel/AlderlakeOpenBoardPkg > -F: Platform/Intel/AlderlakeOpenBoardPkg/ > -M: Sai Chaganty <rangasai.v.chaganty@intel.com> > -M: Nate DeSimone <nathaniel.l.desimone@intel.com> > -R: Rosen Chuang <rosen.chuang@intel.com> > -R: Saloni Kasbekar <saloni.kasbekar@intel.com> > - > -Platform/Intel/WhitleyOpenBoardPkg > -F: Platform/Intel/WhitleyOpenBoardPkg/ > -M: Nate DeSimone <nathaniel.l.desimone@intel.com> > -M: Chasel Chiu <chasel.chiu@intel.com> > - > -Platform/Intel/SimicsOpenBoardPkg > -F: Platform/Intel/SimicsOpenBoardPkg/ > -M: Nate DeSimone <nathaniel.l.desimone@intel.com> > - > -Platform/Intel/Tools > -F: Platform/Intel/Tools/ > -M: Bob Feng <bob.c.feng@intel.com> > -M: Liming Gao <gaoliming@byosoft.com.cn> > -R: Yuwei Chen <yuwei.chen@intel.com> > - > -Platform/RISC-V/PlatformPkg > -F: Platform/RISC-V/PlatformPkg/ > -M: Sunil V L <sunilvl@ventanamicro.com> > -R: Daniel Schaefer <git@danielschaefer.me> > - > -Platform/SiFive/U5SeriesPkg > -F: Platform/SiFive/U5SeriesPkg/ > -M: Daniel Schaefer <git@danielschaefer.me> > - > -Silicon/Intel > -F: Silicon/Intel/ > -M: Rangasai V Chaganty <rangasai.v.chaganty@intel.com> > -M: Nate DeSimone <nathaniel.l.desimone@intel.com> > - > -Silicon/Intel/IntelSiliconPkg > -F: Silicon/Intel/IntelSiliconPkg/ > -M: Ray Ni <ray.ni@intel.com> > -M: Rangasai V Chaganty <rangasai.v.chaganty@intel.com> > -R: Ashraf Ali S <ashraf.ali.s@intel.com> > - > -Silicon/Intel/QuarkSocPkg > -F: Silicon/Intel/QuarkSocPkg/ > -M: Michael D Kinney <michael.d.kinney@intel.com> > -M: Kelly Steele <kelly.steele@intel.com> > -R: Nate DeSimone <nathaniel.l.desimone@intel.com> > - > -Silicon/Intel/Vlv2DeviceRefCodePkg > -F: Silicon/Intel/Vlv2DeviceRefCodePkg/ > -M: Zailiang Sun <zailiang.sun@intel.com> > -M: Yi Qian <yi.qian@intel.com> > -R: Nate DeSimone <nathaniel.l.desimone@intel.com> > - > -Silicon/Intel/CoffeelakeSiliconPkg > -F: Silicon/Intel/CoffeelakeSiliconPkg/ > -M: Chasel Chiu <chasel.chiu@intel.com> > -M: Sai Chaganty <rangasai.v.chaganty@intel.com> > - > -Silicon/Intel/KabylakeSiliconPkg > -F: Silicon/Intel/KabylakeSiliconPkg/ > -M: Chasel Chiu <chasel.chiu@intel.com> > -M: Sai Chaganty <rangasai.v.chaganty@intel.com> > - > -Silicon/Intel/PurleyRefreshSiliconPkg > -F: Silicon/Intel/PurleyRefreshSiliconPkg/ > -M: Chasel Chiu <chasel.chiu@intel.com> > -M: Nate DeSimone <nathaniel.l.desimone@intel.com> > - > -Silicon/Intel/TigerlakeSiliconPkg > -F: Silicon/Intel/TigerlakeSiliconPkg/ > -M: Sai Chaganty <rangasai.v.chaganty@intel.com> > -M: Nate DeSimone <nathaniel.l.desimone@intel.com> > -R: Heng Luo <heng.luo@intel.com> > - > -Platform/Intel/AlderlakeSiliconPkg > -F: Platform/Intel/AlderlakeSiliconPkg/ > -M: Sai Chaganty <rangasai.v.chaganty@intel.com> > -M: Nate DeSimone <nathaniel.l.desimone@intel.com> > -R: Rosen Chuang <rosen.chuang@intel.com> > -R: Saloni Kasbekar <saloni.kasbekar@intel.com> > - > -Silicon/Intel/WhitleySiliconPkg > -F: Silicon/Intel/WhitleySiliconPkg/ > -M: Nate DeSimone <nathaniel.l.desimone@intel.com> > -M: Chasel Chiu <chasel.chiu@intel.com> > - > -Silicon/Intel/SimicsX58SktPkg > -F: Silicon/Intel/SimicsX58SktPkg/ > -M: Nate DeSimone <nathaniel.l.desimone@intel.com> > - > -Silicon/Intel/SimicsIch10Pkg > -F: Silicon/Intel/SimicsIch10Pkg/ > -M: Nate DeSimone <nathaniel.l.desimone@intel.com> > - > -Silicon/Intel/Tools > -F: Silicon/Intel/Tools/ > -M: Bob Feng <bob.c.feng@intel.com> > -M: Liming Gao <gaoliming@byosoft.com.cn> > -R: Yuwei Chen <yuwei.chen@intel.com> > - > -Loongson platforms > -F: Platform/Loongson/ > -M: Bibo Mao <maobibo@loongson.cn> > -M: Xianglai li <lixianglai@loongson.cn> > -M: Chao Li <lichao@loongson.cn> > - > -Marvell platforms and silicon > -F: Platform/Marvell/ > -F: Platform/SolidRun/ > -F: Silicon/Marvell/ > -M: Marcin Wojtas <marcin.s.wojtas@gmail.com> [wojtas-marcin] > -M: Narinder Dhillon <ndhillon@marvell.com> [ndhillonm] > -R: Leif Lindholm <quic_llindhol@quicinc.com> [leiflindholm] > - > -Miscellaneous drivers > -F: Silicon/Atmel/ > -F: Silicon/Openmoko/ > -F: Silicon/Synopsys/DesignWare/ > -R: Ard Biesheuvel <ardb+tianocore@kernel.org> > -M: Leif Lindholm <quic_llindhol@quicinc.com> > - > -NXP platforms and silicon > -F: Platform/NXP/ > -F: Silicon/NXP/ > -M: Leif Lindholm <quic_llindhol@quicinc.com> > -R: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com> > - > -QEMU EDK II Minimum Platform Specification implementation > -F: Platform/Qemu/QemuOpenBoardPkg/ > -M: Pedro Falcato <pedro.falcato@gmail.com> > -R: Theo Jehl <theojehl76@gmail.com> > - > -QEMU sbsa-ref platform > -F: Platform/Qemu/SbsaQemu/ > -F: Silicon/Qemu/SbsaQemu/ > -M: Ard Biesheuvel <ardb+tianocore@kernel.org> > -M: Leif Lindholm <quic_llindhol@quicinc.com> > -M: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> [hrw] > -R: Graeme Gregory <graeme@xora.org.uk> > - > -Raspberry Pi platforms and silicon > -F: Platform/RaspberryPi/ > -F: Silicon/Broadcom/ > -M: Ard Biesheuvel <ardb+tianocore@kernel.org> > -M: Leif Lindholm <quic_llindhol@quicinc.com> > -R: Jeremy Linton <jeremy.linton@arm.com> > - > -RPMB driver for OP-TEE > -F: Drivers/OpTee/OpteeRpmbPkg/ > -M: Sami Mujawar <sami.mujawar@arm.com> > -M: Ilias Apalodimas <ilias.apalodimas@linaro.org> > - > -Socionext platforms and silicon > -F: Platform/Socionext/ > -F: Silicon/NXP/Library/Pcf8563RealTimeClockLib/ > -F: Silicon/Socionext/ > -M: Ard Biesheuvel <ardb+tianocore@kernel.org> > -M: Leif Lindholm <quic_llindhol@quicinc.com> > - > -Silicon/RISC-V/ProcessorPkg > -F: Silicon/RISC-V/ProcessorPkg/ > -M: Sunil V L <sunilvl@ventanamicro.com> > -R: Daniel Schaefer <git@danielschaefer.me> > - > -Silicon/SiFive > -F: Silicon/SiFive/ > -M: Daniel Schaefer <git@danielschaefer.me> > - > -Phytium platforms and silicon > -F: Platform/Phytium/ > -F: Silicon/Phytium/ > -M: Leif Lindholm <quic_llindhol@quicinc.com> > -R: Peng Xie <xiepeng@phytium.com.cn> > -R: Ling Jia <jialing@phytium.com.cn> > -R: Yiqi Shu <shuyiqi@phytium.com.cn> > - > -Sophgo platforms and silicon > -F: Platform/Sophgo/ > -F: Silicon/Sophgo/SG2042Pkg/ > -M: Sunil V L <sunilvl@ventanamicro.com> > -R: dahogn <dahogn@hotmail.com> > -R: meng-cz <mengcz1126@gmail.com> > -R: caiyuqing379 <caiyuqing_hz@outlook.com> > -R: USER0FISH <libing1202@outlook.com> > diff --git a/REVIEWERS b/REVIEWERS > new file mode 100644 > index 000000000000..4b1a491b1061 > --- /dev/null > +++ b/REVIEWERS > @@ -0,0 +1,92 @@ > +# This file contains the list of reviewers (i.e. people who can > +# review changes, but don't own the packages and can't commit changes) > +# for various parts of edk2-platforms. > + > +# AMD VanGoghBoard > +/Platform/AMD/VanGoghBoard/** @YSHRong @mingxzha @fhh200000 > + > +# Ampere > +/Platform/Ampere/** @chuongtranle @leiflindholm @bcran > +/Silicon/Ampere/** @chuongtranle @leiflindholm @bcran > + > +# ARM > +# Add Tomas Abraham > +# /Platform/ARM/** > + > +# BeagleBoard: > +/Platform/BeagleBoard/** @ardbiesheuvel > +/Silicon/TexasInstruments/** @ardbiesheuvel > + > +# Hisilicon > +# Add Wenyi Xie > +/Platform/Hisilicon/** @ardbiesheuvel > +/Silicon/Hisilicon/** @ardbiesheuvel > + > +/Features/Ext4Pkg/** @mhaeuser > + > +/Features/Intel/** @lgao4 > +/Features/Intel/Debugging/** @lgao4 > +/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/** @lgao4 > +/Features/Intel/UserInterface/** @lgao4 > + > +/Features/ManageabilityPkg/** @abdattar @nicklela > + > +/Platform/Intel/QuarkPlatformPkg/** @nate-desimone > +/Platform/Intel/Vlv2TbltDevicePkg/** @nate-desimone > +/Platform/Intel/BoardModulePkg/** @lgao4 > +/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/** @jackpot5 > +/Platform/Intel/MinPlatformPkg/** @lgao4 @ydong10 > +/Platform/Intel/WhiskeylakeOpenBoardPkg/** @ChaselChiu > +/Platform/Intel/CometlakeOpenBoardPkg/** @dkethire @kesakkit > +# Add Heng Luo > +# /Platform/Intel/TigerlakeOpenBoardPkg/** > +/Platform/Intel/AlderlakeOpenBoardPkg/** @rbitw @SaloniKasbekar > +/Platform/Intel/Tools/** @YuweiChen1110 > + > +/Platform/RISC-V/PlatformPkg/** @JohnAZoidberg > + > +/Silicon/Intel/IntelSiliconPkg/** @AshrafAliS > +/Silicon/Intel/QuarkSocPkg/** @nate-desimone > +/Silicon/Intel/Vlv2DeviceRefCodePkg/** @nate-desimone > + > +# Add Heng Luo > +# /Silicon/Intel/TigerlakeSiliconPkg/** > + > +/Silicon/Intel/AlderlakeSiliconPkg/** @rbitw @SaloniKasbekar > + > +/Silicon/Intel/Tools/** @YuweiChen1110 > + > +/Platform/Marvell/** @leiflindholm > +/Platform/SolidRun/** @leiflindholm > +/Silicon/Marvell/** @leiflindholm > + > +# Miscellaneous Drivers > +/Silicon/Atmel/** @ardbiesheuvel > +/Silicon/Openmoko/** @ardbiesheuvel > +/Silicon/Synopsys/DesignWare/** @ardbiesheuvel > + > +/Platform/NXP/** @Meenakshi88 > +/Silicon/NXP/** @Meenakshi88 > + > +# QEMU EDK II Minimum Platform Specification implementation > +/Platform/Qemu/QemuOpenBoardPkg/** @theomacx86 > + > +# Add Graeme Gregory > +# /Platform/Qemu/SbsaQemu/** > +# /Silicon/Qemu/SbsaQemu/** > + > +# Raspberry Pi platforms and silicon > +/Platform/RaspberryPi/** @jlinton > +/Silicon/Broadcom/** @jlinton > + > +/Silicon/RISC-V/ProcessorPkg/** @JohnAZoidberg > + > +# Phytium platforms and silicon > +# Add Peng Xie, Ling Jia and Yiqi Shu > +# /Platform/Phytium/** > +# /Silicon/Phytium/** > + > +# Sophgo platforms and silicon > +/Platform/Sophgo/** @dahogn @meng-cz @caiyiqing379 @USER0FISH > +/Silicon/Sophgo/SG2042Pkg/** @dahogn @meng-cz @caiyiqing379 @USER0FISH > + > diff --git a/Readme.md b/Readme.md > index 8de9eaa7cfbb..7b43e803fccd 100644 > --- a/Readme.md > +++ b/Readme.md > @@ -32,10 +32,32 @@ Many platforms require additional image processing beyond the EDK2 build. > Any such steps should be documented (as a Readme.md), and any necessary helper > scripts be contained, under said platform directory. > > -Any contributions to this branch should be submitted via email to the > -edk2-devel mailing list with a subject prefix of `[platforms]`. See > -[Laszlo's excellent guide](https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers) for details > -on how to do this successfully. > +Any contributions to this branch should be submitted via GitHub Pull Request, > +or email to the edk2-devel mailing list with a subject prefix of `[platforms]`. See > +[Laszlo's excellent guide](https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers) for details on how to do this successfully. Can you put back this line break? > + > +For details of who owns code in certain parts of the repo, see the CODEOWNERS and > +REVIEWERS files. Look in CONTRIBUTORS.md to find out people's names and their > +email addresses. > + > +In general, you should not privately email the maintainer. You should > +email the edk2-devel list, and Cc the package maintainers and > +reviewers. > + > +If the package maintainer wants to hand over the role to other people, Strictly speaking, the maintainership areas aren't broken up on a package granularity here. / Leif > +the package maintainer should create a PR on GitHub to update CODEOWNERS, > +REVIEWERS and CONTRIBUTORS.md with new maintainer, and the new maintainer > +should review the PR and approve it. > + > +EDK II Platforms > +---------------- > +W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II > +L: https://edk2.groups.io/g/devel/ > +T: git - https://github.com/tianocore/edk2-platforms.git > + > +Responsible Disclosure, Reporting Security Issues > +------------------------------------------------- > +W: https://github.com/tianocore/tianocore.github.io/wiki/Security > > # How to build (Linux Environment) > > @@ -294,7 +316,7 @@ For more information, see the > > # Maintainers > > -See [Maintainers.txt](Maintainers.txt). > +See [CONTRIBUTORS.md](CONTRIBUTORS.md), [CODEOWNERS](CODEOWNERS) and [REVIEWERS](REVIEWERS). > > # Submodules > > -- > 2.45.2 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120168): https://edk2.groups.io/g/devel/message/120168 Mute This Topic: https://groups.io/mt/107583542/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] Move to the GitHub Pull Request workflow 2024-08-01 9:45 ` Leif Lindholm @ 2024-08-01 12:49 ` Rebecca Cran 2024-08-01 14:51 ` Leif Lindholm 0 siblings, 1 reply; 7+ messages in thread From: Rebecca Cran @ 2024-08-01 12:49 UTC (permalink / raw) To: Leif Lindholm; +Cc: devel, Michael D Kinney Replies inline. On 8/1/24 3:45 AM, Leif Lindholm wrote: > On Sat, Jul 27, 2024 at 14:31:56 -0600, Rebecca Cran wrote: >> Migrate data from Maintainers.txt to the GitHub standard CODEOWNERS >> files plus REVIEWERS and CONTRIBUTORS.md. The latter file contains >> mappings from name to email address and GitHub usernames, which will >> help people who want to email maintainers instead of using GitHub. >> >> Add .github/workflows/AssignReviewers.yml which adds reviewers to a >> Pull Request based on the content of the REVIEWERS file. >> >> Signed-off-by: Rebecca Cran <rebecca@bsdio.com> >> --- >> .github/workflows/AssignReviewers.yml | 28 ++ >> CODEOWNERS | 146 +++++++ >> CONTRIBUTORS.md | 68 +++ >> Maintainers.txt | 445 -------------------- >> REVIEWERS | 92 ++++ >> Readme.md | 32 +- >> 6 files changed, 361 insertions(+), 450 deletions(-) >> >> diff --git a/.github/workflows/AssignReviewers.yml b/.github/workflows/AssignReviewers.yml >> new file mode 100644 >> index 000000000000..8ee95edbb2c1 >> --- /dev/null >> +++ b/.github/workflows/AssignReviewers.yml >> @@ -0,0 +1,28 @@ >> +## @file >> +# Assign reviewers from a REVIEWERS file using CODEOWNERS syntax > If we're starting to do manual copying around of files between > repositories, can we add a manual audit trail? > > I.e., full URL of repository, path inside repository, and commit hash? > > I think my preference would be in this file header. I'm not sure I understand. This file came from https://github.com/mdkinney/github-action-assign-reviewers/blob/main/.github/workflows/AssignReviewers.yml. Would you like me to add a note to .github/workflows/AssignReviewers.yml to say that's where it came from? >> diff --git a/CODEOWNERS b/CODEOWNERS >> new file mode 100644 >> index 000000000000..bc86dd113398 >> --- /dev/null >> +++ b/CODEOWNERS >> @@ -0,0 +1,146 @@ >> ... >> +# Sophgo platforms and silicon >> +/Platform/Sophgo/** @vlsunil >> +/Silicon/Sophgo/SG2042Pkg/** @vlsunil > Not super important, but if we're doing this change it would be an > opportunity to re-sort the areas alphabetically, since that broke > somewhere along the way. Fixed. >> diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md >> new file mode 100644 >> index 000000000000..84882bcab2fa >> --- /dev/null >> +++ b/CONTRIBUTORS.md >> @@ -0,0 +1,68 @@ >> +EDK II Platforms Maintainers and Reviewers >> +========================================================= >> + >> +This file provides information about the people who maintain and review >> +code for EDK II Platforms. For information about who from this file >> +maintains (i.e. owns and can commit changes) and who reviews changes in >> +various parts of the repo, see the CODEOWNERS and REVIEWERS files. >> + >> +| Name | e-mail address | Github username | >> +|------------------------|----------------------------------|------------------------------------------------------| >> +| Leif Lindholm | quic_llindhol@quicinc.com | [@leiflindholm](https://github.com/leiflindholm) | >> +| Michael D Kinney | michael.d.kinney@intel.com | [@mdkinney](https://github.com/mdkinney) | >> +| Ard Biesheuvel | ardb+tianocore@kernel.org | [@ardbiesheuvel](https://github.com/ardbiesheuvel) | >> +| Abner Chang | abner.chang@amd.com | [@changab](https://github.com/changab) | >> +| Abdul Lateef Attar | AbdulLateef.Attar@amd.com | [@abdattar](https://github.com/abdattar) | >> +| Paul Grimes | paul.grimes@amd.com | [@pbgrimes](https://github.com/pbgrimes) | >> +| Eric Xing | eric.xing@amd.com | [@exinghr](https://github.com/exinghr) | >> +| Ken Yao | ken.yao@amd.com | [@YSHRong](https://github.com/YSHRong) | >> +| Duke Zhai | duke.zhai@amd.com | [@mingxzha](https://github.com/mingxzha) | >> +| Igniculus Fu | igniculus.fu@amd.com | [@fhh200000](https://github.com/fhh200000) | >> +| Nhi Pham | nhi@os.amperecomputing.com | [@nhivp](https://github.com/nhivp) | >> +| Chuong Tran | chuong@os.amperecomputing.com | [@chuongtranle](https://github.com/chuongtranle) | >> +| Rebecca Cran | rebecca@os.amperecomputing.com | [bcran](https://github.com/bcran) | >> +| Thomas Abraham | thomas.abraham@arm.com | | >> +| Sami Mujawar | sami.mujawar@arm.com | [@samimujawar](https://github.com/) | >> +| Ray Ni | ray.ni@intel.com | [@niruiyu](https://github.com/niruiyu) | >> +| Ilias Apalodimas | ilias.apalodimas@linaro.org | [@apalos](https://github.com/apalos) | >> +| Wenyi Xie | xiewenyi2@huawei.com | | >> +| Pedro Falcato | pedro.falcato@gmail.com | [@heatd](https://github.com/heatd) | >> +| Marvin H??user | mhaeuser@posteo.de | [@mhaeuser](https://github.com/mhaeuser) | > Is this charset corruption only in the email? Yes. See https://github.com/bcran/edk2-platforms/blob/github-pr/CONTRIBUTORS.md . >> +| Sai Chaganty | rangasai.v.chaganty@intel.com | [@SaiChaganty](https://github.com/SaiChaganty) | >> +| Nate DeSimone | nathaniel.l.desimone@intel.com | [@nate-desimone](https://github.com/nate-desimone) | >> +| Liming Gao | gaoliming@byosoft.com.cn | [@lgao4](https://github.com/lgao4) | >> +| Eric Dong | eric.dong@intel.com | [@ydong10](https://github.com/ydong10) | >> +| Dandan Bi | dandan.bi@intel.com | [@dandanbi](https://github.com/dandanbi) | >> +| Nickle Wang | nicklew@nvidia.com | [@nicklela](https://github.com/nicklela) | >> +| Zailiang Sun | zailiang.sun@intel.com | [@zailiangsun](https://github.com/zailiangsun) | >> +| Yi Qian | yi.qian@intel.com | [@yqian4](https://github.com/yqian4) | >> +| Chasel Chiu | chasel.chiu@intel.com | [@ChaselChiu](https://github.com/ChaselChiu) | >> +| Benjamin Doron | benjamin.doron00@gmail.com | [@benjamindoron](https://github.com/benjamindoron) | >> +| Jeremy Soller | jeremy@system76.com | [@jackpot51](https://github.com/jackpot51) | >> +| Deepika Kethi Reddy | deepika.kethi.reddy@intel.com | [@dkethire](https://github.com/dkethire) | >> +| Kathappan Esakkithevar | kathappan.esakkithevar@intel.com | [@kesakkit](https://github.com/kesakkit) | >> +| Heng Luo | heng.luo@intel.com | | >> +| Rosen Chuang | rosen.chuang@intel.com | [@rbitw](https://github.com/rbitw) | >> +| Saloni Kasbekar | saloni.kasbekar@intel.com | [@SaloniKasbekar](https://github.com/SaloniKasbekar) | >> +| Bob Feng | bob.c.feng@intel.com | [@BobCF](https://github.com/BobCF) | >> +| Yuwei Chen | yuwei.chen@intel.com | [@YuweiChen1110](https://github.com/YuweiChen1110) | >> +| Sunil V L | sunilvl@ventanamicro.com | [@vlsunil](https://github.com/vlsunil) | >> +| Daniel Schaefer | git@danielschaefer.me | [@JohnAZoidberg](https://github.com/JohnAZoidberg) | >> +| Ashraf Ali S | ashraf.ali.s@intel.com | [@AshrafAliS](https://github.com/AshrafAliS) | >> +| Bibo Mao | maobibo@loongson.cn | | >> +| Xianglai li | lixianglai@loongson.cn | | >> +| Chao Li | lichao@loongson.cn | | >> +| Marcin Wojtas | marcin.s.wojtas@gmail.com | [@wojtas-marcin](https://github.com/wojtas-marcin) | >> +| Narinder Dhillon | ndhillon@marvell.com | [@ndhillonm](https://github.com/ndhillonm) | >> +| Meenakshi Aggarwal | meenakshi.aggarwal@nxp.com | [@Meenakshi88](https://github.com/Meenakshi88) | >> +| Theo Jehl | theojehl76@gmail.com | [@theomacx86](https://github.com/theomacx86) | >> +| Marcin Juszkiewicz | marcin.juszkiewicz@linaro.org | [@hrw](https://github.com/hrw) | >> +| Graeme Gregory | graeme@xora.org.uk | | >> +| Jeremy Linton | jeremy.linton@arm.com | [@jlinton](https://github.com/jlinton) | >> +| Peng Xie | xiepeng@phytium.com.cn | | >> +| Ling Jia | jialing@phytium.com.cn | | >> +| Yiqi Shu | shuyiqi@phytium.com.cn | | >> +| dahogn | dahogn@hotmail.com | [@dahogn](https://github.com/dahogn) | >> +| meng-cz | mengcz1126@gmail.com | [@meng-cz](https://github.com/meng-cz) | >> +| caiyuqing379 | caiyuqing_hz@outlook.com | [@caiyuqing379](https://github.com/caiyuqing379) | >> +| USER0FISH | libing1202@outlook.com | [@USER0FISH](https://github.com/USER0FISH) | > Likewise, could we sort this alphabetically by name string? > (If that's annoying, can you push it to a branch where I could pull it > down and sort it?) Done. Took about 30 seconds (column select mode, copy lines to a file, run through `sort`) :) >> diff --git a/Maintainers.txt b/Maintainers.txt >> deleted file mode 100644 >> index 824838486072..000000000000 >> --- a/Maintainers.txt >> +++ /dev/null >> @@ -1,445 +0,0 @@ >> ,,, >> -Any contributions to this branch should be submitted via email to the >> -edk2-devel mailing list with a subject prefix of `[platforms]`. See >> -[Laszlo's excellent guide](https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers) for details >> -on how to do this successfully. >> +Any contributions to this branch should be submitted via GitHub Pull Request, >> +or email to the edk2-devel mailing list with a subject prefix of `[platforms]`. See >> +[Laszlo's excellent guide](https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers) for details on how to do this successfully. > Can you put back this line break? Fixed. >> + >> +For details of who owns code in certain parts of the repo, see the CODEOWNERS and >> +REVIEWERS files. Look in CONTRIBUTORS.md to find out people's names and their >> +email addresses. >> + >> +In general, you should not privately email the maintainer. You should >> +email the edk2-devel list, and Cc the package maintainers and >> +reviewers. >> + >> +If the package maintainer wants to hand over the role to other people, > Strictly speaking, the maintainership areas aren't broken up on a > package granularity here. I've dropped the 'package' wording in favor of "area". -- Rebecca -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120172): https://edk2.groups.io/g/devel/message/120172 Mute This Topic: https://groups.io/mt/107583542/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] Move to the GitHub Pull Request workflow 2024-08-01 12:49 ` Rebecca Cran @ 2024-08-01 14:51 ` Leif Lindholm 2024-08-01 15:47 ` Rebecca Cran 0 siblings, 1 reply; 7+ messages in thread From: Leif Lindholm @ 2024-08-01 14:51 UTC (permalink / raw) To: Rebecca Cran; +Cc: devel, Michael D Kinney On 2024-08-01 13:49, Rebecca Cran wrote: > Replies inline. > > On 8/1/24 3:45 AM, Leif Lindholm wrote: >> On Sat, Jul 27, 2024 at 14:31:56 -0600, Rebecca Cran wrote: >>> Migrate data from Maintainers.txt to the GitHub standard CODEOWNERS >>> files plus REVIEWERS and CONTRIBUTORS.md. The latter file contains >>> mappings from name to email address and GitHub usernames, which will >>> help people who want to email maintainers instead of using GitHub. >>> >>> Add .github/workflows/AssignReviewers.yml which adds reviewers to a >>> Pull Request based on the content of the REVIEWERS file. >>> >>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com> >>> --- >>> .github/workflows/AssignReviewers.yml | 28 ++ >>> CODEOWNERS | 146 +++++++ >>> CONTRIBUTORS.md | 68 +++ >>> Maintainers.txt | 445 -------------------- >>> REVIEWERS | 92 ++++ >>> Readme.md | 32 +- >>> 6 files changed, 361 insertions(+), 450 deletions(-) >>> >>> diff --git a/.github/workflows/AssignReviewers.yml >>> b/.github/workflows/AssignReviewers.yml >>> new file mode 100644 >>> index 000000000000..8ee95edbb2c1 >>> --- /dev/null >>> +++ b/.github/workflows/AssignReviewers.yml >>> @@ -0,0 +1,28 @@ >>> +## @file >>> +# Assign reviewers from a REVIEWERS file using CODEOWNERS syntax >> If we're starting to do manual copying around of files between >> repositories, can we add a manual audit trail? >> >> I.e., full URL of repository, path inside repository, and commit hash? >> >> I think my preference would be in this file header. > > I'm not sure I understand. This file came from > https://github.com/mdkinney/github-action-assign-reviewers/blob/main/.github/workflows/AssignReviewers.yml. > > Would you like me to add a note to .github/workflows/AssignReviewers.yml > to say that's where it came from? I'd like to see it added *somewhere*. Where it came from and the (short) commit hash at the version you picked. If we add it here, then it becomes immediately visible as something to update if someone later on copies a newer version on top of it. Ultimately we might want to add things like this to a common repository either directly referenced by CI/codeforge or imported as submodules, so that we aren't needing to copy code arounbd between repositories. But that's not for this patch to resolve. >>> diff --git a/CODEOWNERS b/CODEOWNERS >>> new file mode 100644 >>> index 000000000000..bc86dd113398 >>> --- /dev/null >>> +++ b/CODEOWNERS >>> @@ -0,0 +1,146 @@ >>> ... >>> +# Sophgo platforms and silicon >>> +/Platform/Sophgo/** @vlsunil >>> +/Silicon/Sophgo/SG2042Pkg/** @vlsunil >> Not super important, but if we're doing this change it would be an >> opportunity to re-sort the areas alphabetically, since that broke >> somewhere along the way. > > Fixed. Thanks! >>> diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md >>> new file mode 100644 >>> index 000000000000..84882bcab2fa >>> --- /dev/null >>> +++ b/CONTRIBUTORS.md >>> @@ -0,0 +1,68 @@ >>> +EDK II Platforms Maintainers and Reviewers >>> +========================================================= >>> + >>> +This file provides information about the people who maintain and review >>> +code for EDK II Platforms. For information about who from this file >>> +maintains (i.e. owns and can commit changes) and who reviews changes in >>> +various parts of the repo, see the CODEOWNERS and REVIEWERS files. >>> + >>> +| Name | e-mail address | Github >>> username | >>> +|------------------------|----------------------------------|------------------------------------------------------| >>> +| Leif Lindholm | quic_llindhol@quicinc.com | >>> [@leiflindholm](https://github.com/leiflindholm) | ... >>> +| Marvin H??user | mhaeuser@posteo.de | >>> [@mhaeuser](https://github.com/mhaeuser) | >> Is this charset corruption only in the email? > > Yes. See > https://github.com/bcran/edk2-platforms/blob/github-pr/CONTRIBUTORS.md . Cool, no issue then. >>> +| Sai Chaganty | rangasai.v.chaganty@intel.com | ... >>> +| USER0FISH | libing1202@outlook.com | >>> [@USER0FISH](https://github.com/USER0FISH) | >> Likewise, could we sort this alphabetically by name string? >> (If that's annoying, can you push it to a branch where I could pull it >> down and sort it?) > > Done. Took about 30 seconds (column select mode, copy lines to a file, > run through `sort`) :) Excellent, thanks! >>> diff --git a/Maintainers.txt b/Maintainers.txt >>> deleted file mode 100644 >>> index 824838486072..000000000000 >>> --- a/Maintainers.txt >>> +++ /dev/null >>> @@ -1,445 +0,0 @@ >>> ,,, >>> -Any contributions to this branch should be submitted via email to the >>> -edk2-devel mailing list with a subject prefix of `[platforms]`. See >>> -[Laszlo's excellent >>> guide](https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers) for details >>> -on how to do this successfully. >>> +Any contributions to this branch should be submitted via GitHub Pull >>> Request, >>> +or email to the edk2-devel mailing list with a subject prefix of >>> `[platforms]`. See >>> +[Laszlo's excellent >>> guide](https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers) for details on how to do this successfully. >> Can you put back this line break? > Fixed. > >>> + >>> +For details of who owns code in certain parts of the repo, see the >>> CODEOWNERS and >>> +REVIEWERS files. Look in CONTRIBUTORS.md to find out people's names >>> and their >>> +email addresses. >>> + >>> +In general, you should not privately email the maintainer. You should >>> +email the edk2-devel list, and Cc the package maintainers and >>> +reviewers. >>> + >>> +If the package maintainer wants to hand over the role to other people, >> Strictly speaking, the maintainership areas aren't broken up on a >> package granularity here. > > I've dropped the 'package' wording in favor of "area". That works. / Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120178): https://edk2.groups.io/g/devel/message/120178 Mute This Topic: https://groups.io/mt/107583542/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] Move to the GitHub Pull Request workflow 2024-08-01 14:51 ` Leif Lindholm @ 2024-08-01 15:47 ` Rebecca Cran 0 siblings, 0 replies; 7+ messages in thread From: Rebecca Cran @ 2024-08-01 15:47 UTC (permalink / raw) To: Leif Lindholm; +Cc: devel, Michael D Kinney On 8/1/24 8:51 AM, Leif Lindholm wrote: > On 2024-08-01 13:49, Rebecca Cran wrote: >> Would you like me to add a note to >> .github/workflows/AssignReviewers.yml to say that's where it came from? > > I'd like to see it added *somewhere*. Where it came from and the > (short) commit hash at the version you picked. My only hesitation is that I think Mike's copy was more a temporary POC, so I'd consider the copy in edk2-platforms to be the official version. > Ultimately we might want to add things like this to a common > repository either directly referenced by CI/codeforge or imported as > submodules, so that we aren't needing to copy code arounbd between > repositories. > But that's not for this patch to resolve. Agreed. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120189): https://edk2.groups.io/g/devel/message/120189 Mute This Topic: https://groups.io/mt/107583542/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH edk2-platforms v2 0/1] Move to the GitHub Pull Request workflow 2024-07-27 20:31 [edk2-devel] [PATCH edk2-platforms v2 0/1] Move to the GitHub Pull Request workflow Rebecca Cran 2024-07-27 20:31 ` [edk2-devel] [PATCH edk2-platforms v2 1/1] " Rebecca Cran @ 2024-07-30 10:49 ` Rebecca Cran 1 sibling, 0 replies; 7+ messages in thread From: Rebecca Cran @ 2024-07-30 10:49 UTC (permalink / raw) To: devel, Leif Lindholm, Michael D Kinney I know it's only been a couple of days, but would it be possible to get some reviews on this please? I have a new platform (Platform/Ampere/ComHpcAltPkg) plus fixes to JadePkg that are waiting for the switchover to the PR workflow so I'm eager to get this committed. -- Rebecca Cran On 7/27/24 2:31 PM, Rebecca Cran wrote: > Changes from v1 to v2: > > Added .github/workflows/AssignReviewers.yml to actually reviewers > to a PR based on the content of the REVIEWERS file. > > Updated leftover references to Maintainers.txt in Readme.md. > > Updated some wording in CODEOWNERS, REVIEWERS and CONTRIBUTORS.md. > > Updated my entry in CONTRIBUTORS.md to delete the second email address. > > Updated the commit message to indicate that this change is to enable the > GitHub PR workflow, not just in preparation for it. > > Rebecca Cran (1): > Move to the GitHub Pull Request workflow > > .github/workflows/AssignReviewers.yml | 28 ++ > CODEOWNERS | 146 +++++++ > CONTRIBUTORS.md | 68 +++ > Maintainers.txt | 445 -------------------- > REVIEWERS | 92 ++++ > Readme.md | 32 +- > 6 files changed, 361 insertions(+), 450 deletions(-) > create mode 100644 .github/workflows/AssignReviewers.yml > create mode 100644 CODEOWNERS > create mode 100644 CONTRIBUTORS.md > delete mode 100644 Maintainers.txt > create mode 100644 REVIEWERS > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120074): https://edk2.groups.io/g/devel/message/120074 Mute This Topic: https://groups.io/mt/107583540/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-08-01 15:47 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-07-27 20:31 [edk2-devel] [PATCH edk2-platforms v2 0/1] Move to the GitHub Pull Request workflow Rebecca Cran 2024-07-27 20:31 ` [edk2-devel] [PATCH edk2-platforms v2 1/1] " Rebecca Cran 2024-08-01 9:45 ` Leif Lindholm 2024-08-01 12:49 ` Rebecca Cran 2024-08-01 14:51 ` Leif Lindholm 2024-08-01 15:47 ` Rebecca Cran 2024-07-30 10:49 ` [edk2-devel] [PATCH edk2-platforms v2 0/1] " Rebecca Cran
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox