From: "Ard Biesheuvel via groups.io" <ardb+git=google.com@groups.io>
To: devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb@kernel.org>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Rebecca Cran <rebecca@os.amperecomputing.com>,
Nhi Pham <nhi@os.amperecomputing.com>,
Chuong Tran <chuong@os.amperecomputing.com>,
Wenyi Xie <xiewenyi2@huawei.com>,
Peng Xie <xiepeng@phytium.com.cn>,
Ling Jia <jialing@phytium.com.cn>,
Yiqi Shu <shuyiqi@phytium.com.cn>
Subject: [edk2-devel] [PATCH RFC edk2-platforms 3/5] Platform/Ampere: Switch to unicore SEC implementation
Date: Mon, 29 Jul 2024 14:22:13 +0200 [thread overview]
Message-ID: <20240729122215.400402-4-ardb+git@google.com> (raw)
In-Reply-To: <20240729122215.400402-1-ardb+git@google.com>
From: Ard Biesheuvel <ardb@kernel.org>
Spec adherent AArch64 systems use PSCI to manage secondary CPUs, and
only enter the execution level where UEFI and the OS live using a single
CPU.
This means using a SEC implementation of the MPCore variety is never
needed, and in practice, those drivers don't work correctly unless an
older version of the GIC is used (v2), which only supports up to 8 CPUs
and is therefore rare on server silicon.
So switch to the UniCore flavor, which should be functionally equivalent
if only a single CPU runs the UEFI firmware.
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 6 +-----
Platform/Ampere/JadePkg/Jade.fdf | 2 +-
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
index 977e4c4c238d..bec743e2c453 100644
--- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
+++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
@@ -390,12 +390,8 @@ [PcdsFixedAtBuild.common]
gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800
- #
- # Stacks for MPCores in Normal World
- #
gArmPlatformTokenSpaceGuid.PcdCPUCoresStackBase|0x91100000
gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize|0x20000
- gArmPlatformTokenSpaceGuid.PcdCPUCoreSecondaryStackSize|0x1000
#
# Maximum memory region that fits into the 32bit address space
@@ -525,7 +521,7 @@ [Components.common]
#
# PEI Phase modules
#
- ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
+ ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
MdeModulePkg/Core/Pei/PeiMain.inf
MdeModulePkg/Universal/PCD/Pei/Pcd.inf {
<LibraryClasses>
diff --git a/Platform/Ampere/JadePkg/Jade.fdf b/Platform/Ampere/JadePkg/Jade.fdf
index 127e4401f69b..6d1af3570287 100644
--- a/Platform/Ampere/JadePkg/Jade.fdf
+++ b/Platform/Ampere/JadePkg/Jade.fdf
@@ -148,7 +148,7 @@ [FV.FVMAIN_COMPACT]
INF MdeModulePkg/Universal/StatusCodeHandler/Pei/StatusCodeHandlerPei.inf
}
- INF ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
+ INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
INF MdeModulePkg/Core/Pei/PeiMain.inf
INF UefiCpuPkg/CpuIoPei/CpuIoPei.inf
INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf
--
2.46.0.rc1.232.g9752f9e123-goog
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120112): https://edk2.groups.io/g/devel/message/120112
Mute This Topic: https://groups.io/mt/107628986/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-07-30 15:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 12:22 [edk2-devel] [PATCH RFC edk2-platforms 0/5] Phase out MPCore SEC drivers Ard Biesheuvel via groups.io
2024-07-29 12:22 ` [edk2-devel] [PATCH RFC edk2-platforms 1/5] Platform AARCH64: Drop leftover references to deleted timer PCD Ard Biesheuvel via groups.io
2024-07-29 12:22 ` [edk2-devel] [PATCH RFC edk2-platforms 2/5] Platform AARCH64: Remove bogus references to MPCore stack Ard Biesheuvel via groups.io
2024-07-30 19:16 ` Sami Mujawar
2024-07-29 12:22 ` Ard Biesheuvel via groups.io [this message]
2024-07-31 8:21 ` [edk2-devel] [PATCH RFC edk2-platforms 3/5] Platform/Ampere: Switch to unicore SEC implementation Nhi Pham via groups.io
2024-07-29 12:22 ` [edk2-devel] [PATCH RFC edk2-platforms 4/5] Platform/Durian: " Ard Biesheuvel via groups.io
2024-07-29 12:22 ` [edk2-devel] [PATCH RFC edk2-platforms 5/5] Platform/HiSilicon/D0x: " Ard Biesheuvel via groups.io
2024-07-30 12:42 ` [edk2-devel] [PATCH RFC edk2-platforms 0/5] Phase out MPCore SEC drivers Leif Lindholm
2024-07-30 14:30 ` Rebecca Cran
2024-07-30 14:48 ` Leif Lindholm
2024-07-30 15:00 ` Ard Biesheuvel
2024-07-30 15:09 ` Leif Lindholm
2024-07-30 15:18 ` Ard Biesheuvel
2024-07-30 15:34 ` Leif Lindholm
2024-07-30 14:18 ` Rebecca Cran via groups.io
2024-07-30 15:48 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240729122215.400402-4-ardb+git@google.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox