From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 46C73AC185A for ; Tue, 30 Jul 2024 15:08:30 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=2mLa9A8qBigpGLRNxlNOFWj3RafoCI+17vrWFPriVig=; c=relaxed/simple; d=groups.io; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1722352110; v=1; b=pMVXhFQs5KnuimH6FwUPEMb6SUD1mZzxzU/4VtBHTlhS+T4xfhmdVaBVyL7gsH8rPpURilHW q1QQlt24a+qKhkPg61P4OzotvwtzUpeLUTKOtdgjXkyGIAoKjXumsPLdKpVCNy/s3SPc+YNq+y8 7urJkzRTjJqCwDG1S0bRPsM/73NTmsWWGH5PhjDWN2tP2qKDXfa1e7hp8CcmZo/xvN84jTPNSGt flQzUl6rdbhJrW2uaWL6ygzC3nU2CzqsYmyNVLeNiD1f4P9lQYJPSF3lFp9g4JYq+j1DQZNtfbG Buc604QOLMIV9dkLeKcjIaFt/uf+0ELncMieG4p/0UELg== X-Received: by 127.0.0.2 with SMTP id 9uIrYY7687511xv5zEZYVyiV; Tue, 30 Jul 2024 08:08:28 -0700 X-Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by mx.groups.io with SMTP id smtpd.web10.54711.1722255753525840417 for ; Mon, 29 Jul 2024 05:22:33 -0700 X-Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-e0353b731b8so3602264276.2 for ; Mon, 29 Jul 2024 05:22:33 -0700 (PDT) X-Gm-Message-State: jEjaTLTNgYeVLaj9cwulbVvBx7686176AA= X-Google-Smtp-Source: AGHT+IE99kDcZ3ELLWpIelPX/BAo1Umxlw1gyTGR+ny7KWMTCjlYNpK27cg337YIvHM8gsHEldz7FBag X-Received: from palermo.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:118a]) (user=ardb job=sendgmr) by 2002:a05:6902:120b:b0:e0b:4dd5:397e with SMTP id 3f1490d57ef6-e0b5455c058mr12585276.7.1722255752170; Mon, 29 Jul 2024 05:22:32 -0700 (PDT) Date: Mon, 29 Jul 2024 14:22:13 +0200 In-Reply-To: <20240729122215.400402-1-ardb+git@google.com> Mime-Version: 1.0 References: <20240729122215.400402-1-ardb+git@google.com> Message-ID: <20240729122215.400402-4-ardb+git@google.com> Subject: [edk2-devel] [PATCH RFC edk2-platforms 3/5] Platform/Ampere: Switch to unicore SEC implementation From: "Ard Biesheuvel via groups.io" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Rebecca Cran , Nhi Pham , Chuong Tran , Wenyi Xie , Peng Xie , Ling Jia , Yiqi Shu Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 30 Jul 2024 08:08:18 -0700 Resent-From: ardb+git@google.com Reply-To: devel@edk2.groups.io,ardb+git@google.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=pMVXhFQs; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io From: Ard Biesheuvel Spec adherent AArch64 systems use PSCI to manage secondary CPUs, and only enter the execution level where UEFI and the OS live using a single CPU. This means using a SEC implementation of the MPCore variety is never needed, and in practice, those drivers don't work correctly unless an older version of the GIC is used (v2), which only supports up to 8 CPUs and is therefore rare on server silicon. So switch to the UniCore flavor, which should be functionally equivalent if only a single CPU runs the UEFI firmware. Signed-off-by: Ard Biesheuvel --- Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 6 +----- Platform/Ampere/JadePkg/Jade.fdf | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc index 977e4c4c238d..bec743e2c453 100644 --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc @@ -390,12 +390,8 @@ [PcdsFixedAtBuild.common] gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800 - # - # Stacks for MPCores in Normal World - # gArmPlatformTokenSpaceGuid.PcdCPUCoresStackBase|0x91100000 gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize|0x20000 - gArmPlatformTokenSpaceGuid.PcdCPUCoreSecondaryStackSize|0x1000 # # Maximum memory region that fits into the 32bit address space @@ -525,7 +521,7 @@ [Components.common] # # PEI Phase modules # - ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf + ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf MdeModulePkg/Core/Pei/PeiMain.inf MdeModulePkg/Universal/PCD/Pei/Pcd.inf { diff --git a/Platform/Ampere/JadePkg/Jade.fdf b/Platform/Ampere/JadePkg/Jade.fdf index 127e4401f69b..6d1af3570287 100644 --- a/Platform/Ampere/JadePkg/Jade.fdf +++ b/Platform/Ampere/JadePkg/Jade.fdf @@ -148,7 +148,7 @@ [FV.FVMAIN_COMPACT] INF MdeModulePkg/Universal/StatusCodeHandler/Pei/StatusCodeHandlerPei.inf } - INF ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf + INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf INF MdeModulePkg/Core/Pei/PeiMain.inf INF UefiCpuPkg/CpuIoPei/CpuIoPei.inf INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf -- 2.46.0.rc1.232.g9752f9e123-goog -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120112): https://edk2.groups.io/g/devel/message/120112 Mute This Topic: https://groups.io/mt/107628986/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-