From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id E7102AC14DF for ; Tue, 30 Jul 2024 15:08:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=XUlm4eAW1emyITatuNv+ilbbAUJQilIjLkSUXkedOiM=; c=relaxed/simple; d=groups.io; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1722352108; v=1; b=dJsRpg/1mKr6+9oXRG38LHfvAYUNTkE4+q1e2xZM4DPPosirn2oV5nK18k770BrjhnO0fz/d amC6f5bB8y007YRDRis4EarNL51sbv+mVLafqnBDNDaflutub9/JNZfqyCEmN7uKm2GPkqKlYuF q2QX7AvOyyjm6FvAc5eGXorbWTFOLjPSJboenzv13QOyIFODIfGFSTWs5UApxTw7kNln+qd+4/y YojqzkIW0Cs3Ow/RR5lbjuHhhkWJaiQIhPfIWggfWxi0/DHzX/l7NZ1g85BssMsR9D2GmSoS5kP fhI6+gAsv8crDUxIQ77mbhk7WKLSaPeJPGxFyZwuSkw8w== X-Received: by 127.0.0.2 with SMTP id RpGbYY7687511xItOK8O3na6; Tue, 30 Jul 2024 08:08:27 -0700 X-Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by mx.groups.io with SMTP id smtpd.web10.54717.1722255758264216464 for ; Mon, 29 Jul 2024 05:22:38 -0700 X-Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-42816aacabcso14877355e9.1 for ; Mon, 29 Jul 2024 05:22:38 -0700 (PDT) X-Gm-Message-State: 0W32Kbsll85yXEdjvyp6Syxwx7686176AA= X-Google-Smtp-Source: AGHT+IGzCvdtGMil16stMUncBjvgzG6tblWPGm9S+0I4jlMizdwiu6KVWlcKjZEw5OYjMlrx6uh64lFE X-Received: from palermo.c.googlers.com ([fda3:e722:ac3:cc00:28:9cb1:c0a8:118a]) (user=ardb job=sendgmr) by 2002:a05:600c:b85:b0:428:1c13:9381 with SMTP id 5b1f17b1804b1-4281c139612mr132895e9.6.1722255756683; Mon, 29 Jul 2024 05:22:36 -0700 (PDT) Date: Mon, 29 Jul 2024 14:22:15 +0200 In-Reply-To: <20240729122215.400402-1-ardb+git@google.com> Mime-Version: 1.0 References: <20240729122215.400402-1-ardb+git@google.com> Message-ID: <20240729122215.400402-6-ardb+git@google.com> Subject: [edk2-devel] [PATCH RFC edk2-platforms 5/5] Platform/HiSilicon/D0x: Switch to unicore SEC implementation From: "Ard Biesheuvel via groups.io" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Rebecca Cran , Nhi Pham , Chuong Tran , Wenyi Xie , Peng Xie , Ling Jia , Yiqi Shu Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 30 Jul 2024 08:08:18 -0700 Resent-From: ardb+git@google.com Reply-To: devel@edk2.groups.io,ardb+git@google.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="dJsRpg/1"; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io From: Ard Biesheuvel Spec adherent AArch64 systems use PSCI to manage secondary CPUs, and only enter the execution level where UEFI and the OS live using a single CPU. This means using a SEC implementation of the MPCore variety is never needed, and in practice, those drivers don't work correctly unless an older version of the GIC is used (v2), which only supports up to 8 CPUs and is therefore rare on server silicon. So switch to the UniCore flavor, which should be functionally equivalent if only a single CPU runs the UEFI firmware. Signed-off-by: Ard Biesheuvel --- Platform/Hisilicon/D03/D03.dsc | 3 +-- Platform/Hisilicon/D05/D05.dsc | 3 +-- Platform/Hisilicon/D06/D06.dsc | 3 +-- Platform/Hisilicon/D03/D03.fdf | 2 +- Platform/Hisilicon/D05/D05.fdf | 2 +- Platform/Hisilicon/D06/D06.fdf | 2 +- 6 files changed, 6 insertions(+), 9 deletions(-) diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc index e70dc97ee894..458004830fd8 100644 --- a/Platform/Hisilicon/D03/D03.dsc +++ b/Platform/Hisilicon/D03/D03.dsc @@ -128,7 +128,6 @@ [PcdsFixedAtBuild.common] gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 - # Stacks for MPCores in Normal World gArmPlatformTokenSpaceGuid.PcdCPUCoresStackBase|0x81000000 gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize|0xFF00 @@ -283,7 +282,7 @@ [Components.common] # # PEI Phase modules # - ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf + ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf MdeModulePkg/Core/Pei/PeiMain.inf MdeModulePkg/Universal/PCD/Pei/Pcd.inf { diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc index 0231f3188321..37e826fda3d0 100644 --- a/Platform/Hisilicon/D05/D05.dsc +++ b/Platform/Hisilicon/D05/D05.dsc @@ -131,7 +131,6 @@ [PcdsFixedAtBuild.common] gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 - # Stacks for MPCores in Normal World gArmPlatformTokenSpaceGuid.PcdCPUCoresStackBase|0xE1000000 gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize|0xFF00 @@ -416,7 +415,7 @@ [Components.common] # # PEI Phase modules # - ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf + ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf MdeModulePkg/Core/Pei/PeiMain.inf MdeModulePkg/Universal/PCD/Pei/Pcd.inf Platform/Hisilicon/D05/Drivers/Ipmi/IpmiInterfacePei/IpmiInterfacePei.inf diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc index 6e0fcf633404..2bc7206438f1 100644 --- a/Platform/Hisilicon/D06/D06.dsc +++ b/Platform/Hisilicon/D06/D06.dsc @@ -117,7 +117,6 @@ [PcdsFixedAtBuild.common] gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 - # Stacks for MPCores in Normal World gArmPlatformTokenSpaceGuid.PcdCPUCoresStackBase|0xA0E88000 gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize|0x40000 @@ -231,7 +230,7 @@ [Components.common] # # PEI Phase modules # - ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf + ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf MdeModulePkg/Core/Pei/PeiMain.inf MdeModulePkg/Universal/PCD/Pei/Pcd.inf diff --git a/Platform/Hisilicon/D03/D03.fdf b/Platform/Hisilicon/D03/D03.fdf index ac311b915426..0545961d64e3 100644 --- a/Platform/Hisilicon/D03/D03.fdf +++ b/Platform/Hisilicon/D03/D03.fdf @@ -303,7 +303,7 @@ [FV.FVMAIN_COMPACT] READ_LOCK_CAP = TRUE READ_LOCK_STATUS = TRUE - INF ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf + INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf INF MdeModulePkg/Core/Pei/PeiMain.inf INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf diff --git a/Platform/Hisilicon/D05/D05.fdf b/Platform/Hisilicon/D05/D05.fdf index 8e22dd767ebc..547d86ade0ee 100644 --- a/Platform/Hisilicon/D05/D05.fdf +++ b/Platform/Hisilicon/D05/D05.fdf @@ -312,7 +312,7 @@ [FV.FVMAIN_COMPACT] APRIORI PEI { INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf } - INF ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf + INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf INF MdeModulePkg/Core/Pei/PeiMain.inf INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf diff --git a/Platform/Hisilicon/D06/D06.fdf b/Platform/Hisilicon/D06/D06.fdf index a20540c9dcfc..4d796f6ece2f 100644 --- a/Platform/Hisilicon/D06/D06.fdf +++ b/Platform/Hisilicon/D06/D06.fdf @@ -302,7 +302,7 @@ [FV.FVMAIN_COMPACT] APRIORI PEI { INF MdeModulePkg/Universal/PCD/Pei/Pcd.inf } - INF ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf + INF ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf INF MdeModulePkg/Core/Pei/PeiMain.inf INF ArmPlatformPkg/PlatformPei/PlatformPeim.inf -- 2.46.0.rc1.232.g9752f9e123-goog -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120114): https://edk2.groups.io/g/devel/message/120114 Mute This Topic: https://groups.io/mt/107628988/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-