public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-devel] [edk2-libc Patch 0/1] remove gitmodules added through accidental commit
@ 2024-07-30 16:17 Jayaprakash, N
  2024-07-30 16:17 ` [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: remove gitmodules file " Jayaprakash, N
  0 siblings, 1 reply; 5+ messages in thread
From: Jayaprakash, N @ 2024-07-30 16:17 UTC (permalink / raw)
  To: devel; +Cc: Jayaprakash N

This patch removes the gitmodules file and the submodule added
accidentally to the edk2-libc repo.

Jayaprakash N (1):
  edk2-libc: remove gitmodules file added through accidental commit

 .gitmodules                  | 3 ---
 AppPkg/CommonCode/SetupFiles | 1 -
 2 files changed, 4 deletions(-)
 delete mode 100644 .gitmodules
 delete mode 160000 AppPkg/CommonCode/SetupFiles

-- 
2.45.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120123): https://edk2.groups.io/g/devel/message/120123
Mute This Topic: https://groups.io/mt/107630354/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: remove gitmodules file added through accidental commit
  2024-07-30 16:17 [edk2-devel] [edk2-libc Patch 0/1] remove gitmodules added through accidental commit Jayaprakash, N
@ 2024-07-30 16:17 ` Jayaprakash, N
  2024-07-30 16:32   ` Rebecca Cran
  0 siblings, 1 reply; 5+ messages in thread
From: Jayaprakash, N @ 2024-07-30 16:17 UTC (permalink / raw)
  To: devel; +Cc: Jayaprakash N, Rebecca Cran, Michael D Kinney

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4822

Due to an accidental commit went into edk2-libc while
experimenting with some inner-source repos lead to the addition
of gitmodules file and a submodule. This commit is undoing
this change by removing the gitmodules file and the submodule.

Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Jayaprakash N <n.jayaprakash@intel.com>
Signed-off-by: Jayaprakash N <n.jayaprakash@intel.com>
---
 .gitmodules                  | 3 ---
 AppPkg/CommonCode/SetupFiles | 1 -
 2 files changed, 4 deletions(-)
 delete mode 100644 .gitmodules
 delete mode 160000 AppPkg/CommonCode/SetupFiles

diff --git a/.gitmodules b/.gitmodules
deleted file mode 100644
index 04db1ef..0000000
--- a/.gitmodules
+++ /dev/null
@@ -1,3 +0,0 @@
-[submodule "AppPkg/CommonCode/SetupFiles"]
-	path = AppPkg/CommonCode/SetupFiles
-	url = https://github.com/intel-innersource/applications.validation.advancedsystemtools.products.setup-files.git
diff --git a/AppPkg/CommonCode/SetupFiles b/AppPkg/CommonCode/SetupFiles
deleted file mode 160000
index 8fa0030..0000000
--- a/AppPkg/CommonCode/SetupFiles
+++ /dev/null
@@ -1 +0,0 @@
-Subproject commit 8fa00308a6e22df94094c47dc4d650b0466e78ea
-- 
2.45.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120124): https://edk2.groups.io/g/devel/message/120124
Mute This Topic: https://groups.io/mt/107630356/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: remove gitmodules file added through accidental commit
  2024-07-30 16:17 ` [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: remove gitmodules file " Jayaprakash, N
@ 2024-07-30 16:32   ` Rebecca Cran
  2024-07-30 17:03     ` Jayaprakash, N
  0 siblings, 1 reply; 5+ messages in thread
From: Rebecca Cran @ 2024-07-30 16:32 UTC (permalink / raw)
  To: Jayaprakash N, devel; +Cc: Michael D Kinney

Reviewed-by: Rebecca Cran <rebecca@bsdio.com>


On 7/30/24 10:17 AM, Jayaprakash N wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4822
>
> Due to an accidental commit went into edk2-libc while
> experimenting with some inner-source repos lead to the addition
> of gitmodules file and a submodule. This commit is undoing
> this change by removing the gitmodules file and the submodule.
>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Jayaprakash N <n.jayaprakash@intel.com>
> Signed-off-by: Jayaprakash N <n.jayaprakash@intel.com>
> ---
>   .gitmodules                  | 3 ---
>   AppPkg/CommonCode/SetupFiles | 1 -
>   2 files changed, 4 deletions(-)
>   delete mode 100644 .gitmodules
>   delete mode 160000 AppPkg/CommonCode/SetupFiles
>
> diff --git a/.gitmodules b/.gitmodules
> deleted file mode 100644
> index 04db1ef..0000000
> --- a/.gitmodules
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -[submodule "AppPkg/CommonCode/SetupFiles"]
> -	path = AppPkg/CommonCode/SetupFiles
> -	url = https://github.com/intel-innersource/applications.validation.advancedsystemtools.products.setup-files.git
> diff --git a/AppPkg/CommonCode/SetupFiles b/AppPkg/CommonCode/SetupFiles
> deleted file mode 160000
> index 8fa0030..0000000
> --- a/AppPkg/CommonCode/SetupFiles
> +++ /dev/null
> @@ -1 +0,0 @@
> -Subproject commit 8fa00308a6e22df94094c47dc4d650b0466e78ea


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120125): https://edk2.groups.io/g/devel/message/120125
Mute This Topic: https://groups.io/mt/107630356/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: remove gitmodules file added through accidental commit
  2024-07-30 16:32   ` Rebecca Cran
@ 2024-07-30 17:03     ` Jayaprakash, N
  2024-07-30 17:23       ` Michael D Kinney
  0 siblings, 1 reply; 5+ messages in thread
From: Jayaprakash, N @ 2024-07-30 17:03 UTC (permalink / raw)
  To: Rebecca Cran, devel@edk2.groups.io; +Cc: Kinney, Michael D

Thanks Rebecca for your quick response.

Regards,
JP

-----Original Message-----
From: Rebecca Cran <rebecca@bsdio.com> 
Sent: Tuesday, July 30, 2024 10:03 PM
To: Jayaprakash, N <n.jayaprakash@intel.com>; devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>
Subject: Re: [edk2-libc Patch 1/1] edk2-libc: remove gitmodules file added through accidental commit

Reviewed-by: Rebecca Cran <rebecca@bsdio.com>


On 7/30/24 10:17 AM, Jayaprakash N wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4822
>
> Due to an accidental commit went into edk2-libc while experimenting 
> with some inner-source repos lead to the addition of gitmodules file 
> and a submodule. This commit is undoing this change by removing the 
> gitmodules file and the submodule.
>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Jayaprakash N <n.jayaprakash@intel.com>
> Signed-off-by: Jayaprakash N <n.jayaprakash@intel.com>
> ---
>   .gitmodules                  | 3 ---
>   AppPkg/CommonCode/SetupFiles | 1 -
>   2 files changed, 4 deletions(-)
>   delete mode 100644 .gitmodules
>   delete mode 160000 AppPkg/CommonCode/SetupFiles
>
> diff --git a/.gitmodules b/.gitmodules deleted file mode 100644 index 
> 04db1ef..0000000
> --- a/.gitmodules
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -[submodule "AppPkg/CommonCode/SetupFiles"]
> -	path = AppPkg/CommonCode/SetupFiles
> -	url = https://github.com/intel-innersource/applications.validation.advancedsystemtools.products.setup-files.git
> diff --git a/AppPkg/CommonCode/SetupFiles 
> b/AppPkg/CommonCode/SetupFiles deleted file mode 160000 index 
> 8fa0030..0000000
> --- a/AppPkg/CommonCode/SetupFiles
> +++ /dev/null
> @@ -1 +0,0 @@
> -Subproject commit 8fa00308a6e22df94094c47dc4d650b0466e78ea


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120130): https://edk2.groups.io/g/devel/message/120130
Mute This Topic: https://groups.io/mt/107630356/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: remove gitmodules file added through accidental commit
  2024-07-30 17:03     ` Jayaprakash, N
@ 2024-07-30 17:23       ` Michael D Kinney
  0 siblings, 0 replies; 5+ messages in thread
From: Michael D Kinney @ 2024-07-30 17:23 UTC (permalink / raw)
  To: Jayaprakash, N, Rebecca Cran, devel@edk2.groups.io; +Cc: Kinney, Michael D

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: Jayaprakash, N <n.jayaprakash@intel.com>
> Sent: Tuesday, July 30, 2024 10:03 AM
> To: Rebecca Cran <rebecca@bsdio.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [edk2-libc Patch 1/1] edk2-libc: remove gitmodules file added
> through accidental commit
> 
> Thanks Rebecca for your quick response.
> 
> Regards,
> JP
> 
> -----Original Message-----
> From: Rebecca Cran <rebecca@bsdio.com>
> Sent: Tuesday, July 30, 2024 10:03 PM
> To: Jayaprakash, N <n.jayaprakash@intel.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-libc Patch 1/1] edk2-libc: remove gitmodules file added
> through accidental commit
> 
> Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
> 
> 
> On 7/30/24 10:17 AM, Jayaprakash N wrote:
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4822
> >
> > Due to an accidental commit went into edk2-libc while experimenting
> > with some inner-source repos lead to the addition of gitmodules file
> > and a submodule. This commit is undoing this change by removing the
> > gitmodules file and the submodule.
> >
> > Cc: Rebecca Cran <rebecca@bsdio.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Jayaprakash N <n.jayaprakash@intel.com>
> > Signed-off-by: Jayaprakash N <n.jayaprakash@intel.com>
> > ---
> >   .gitmodules                  | 3 ---
> >   AppPkg/CommonCode/SetupFiles | 1 -
> >   2 files changed, 4 deletions(-)
> >   delete mode 100644 .gitmodules
> >   delete mode 160000 AppPkg/CommonCode/SetupFiles
> >
> > diff --git a/.gitmodules b/.gitmodules deleted file mode 100644 index
> > 04db1ef..0000000
> > --- a/.gitmodules
> > +++ /dev/null
> > @@ -1,3 +0,0 @@
> > -[submodule "AppPkg/CommonCode/SetupFiles"]
> > -	path = AppPkg/CommonCode/SetupFiles
> > -	url = https://github.com/intel-
> innersource/applications.validation.advancedsystemtools.products.setup-
> files.git
> > diff --git a/AppPkg/CommonCode/SetupFiles
> > b/AppPkg/CommonCode/SetupFiles deleted file mode 160000 index
> > 8fa0030..0000000
> > --- a/AppPkg/CommonCode/SetupFiles
> > +++ /dev/null
> > @@ -1 +0,0 @@
> > -Subproject commit 8fa00308a6e22df94094c47dc4d650b0466e78ea


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120131): https://edk2.groups.io/g/devel/message/120131
Mute This Topic: https://groups.io/mt/107630356/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-07-30 17:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-30 16:17 [edk2-devel] [edk2-libc Patch 0/1] remove gitmodules added through accidental commit Jayaprakash, N
2024-07-30 16:17 ` [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: remove gitmodules file " Jayaprakash, N
2024-07-30 16:32   ` Rebecca Cran
2024-07-30 17:03     ` Jayaprakash, N
2024-07-30 17:23       ` Michael D Kinney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox