[edk2-devel] [PATCH edk2-platform v1 0/2] Add HobPrintLib for StandaloneMm in Arm Platform

[edk2-devel] [PATCH edk2-platform v1 0/2] Add HobPrintLib for StandaloneMm in Arm Platform

[levi.yun]

commit: d5b03d5fba30d ("MdeModulePkg: Add HobPrintLib instance")
adds HobPinrtLib which causes build failure for StandaloneMm
To fix build failure, add HobPrintLib for StandaloneMm.

Levi Yun (1):
  ARM/SgiPkg: Add HobPrintLib in StandaloneMm

levi.yun (1):
  ARM/VExpressPkg: Add HobPrintLib in StandaloneMm

 Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc         | 1 +
 Platform/ARM/VExpressPkg/PlatformStandaloneMm.dsc | 1 +
 2 files changed, 2 insertions(+)

--
Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120223): https://edk2.groups.io/g/devel/message/120223
Mute This Topic: https://groups.io/mt/107730604/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH edk2-platform v1 1/2] ARM/VExpressPkg: Add HobPrintLib in StandaloneMm

[levi.yun]

From: "levi.yun" <yeoreum.yun@arm.com>

commit: d5b03d5fba30d ("MdeModulePkg: Add HobPrintLib instance")
adds HobPinrtLib which causes build failure for StandaloneMm
To fix build failure, add HobPrintLib for StandaloneMm.

Signed-off-by: Levi Yun <yeoreum.yun@arm.com>
---
 Platform/ARM/VExpressPkg/PlatformStandaloneMm.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/ARM/VExpressPkg/PlatformStandaloneMm.dsc b/Platform/ARM/VExpressPkg/PlatformStandaloneMm.dsc
index a0a9d9a21a1b6682ff43d23ee82245219155c941..127b1e3bb729a563b8e0fe03b95b92673695a9a3 100644
--- a/Platform/ARM/VExpressPkg/PlatformStandaloneMm.dsc
+++ b/Platform/ARM/VExpressPkg/PlatformStandaloneMm.dsc
@@ -55,6 +55,7 @@ [LibraryClasses]
   ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
   FvLib|StandaloneMmPkg/Library/FvLib/FvLib.inf
   HobLib|StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.inf
+  HobPrintLib|MdeModulePkg/Library/HobPrintLib/HobPrintLib.inf
   IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
   MemLib|StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf
   MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf
--
Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120224): https://edk2.groups.io/g/devel/message/120224
Mute This Topic: https://groups.io/mt/107730605/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH edk2-platform v1 2/2] ARM/SgiPkg: Add HobPrintLib in StandaloneMm

[levi.yun]

commit: d5b03d5fba30d ("MdeModulePkg: Add HobPrintLib instance")
adds HobPinrtLib which causes build failure for StandaloneMm
To fix build failure, add HobPrintLib for StandaloneMm.

Signed-off-by: Levi Yun <yeoreum.yun@arm.com>
---
 Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
index 19fd08dd781744e2efe4ff5a2e7ffb9dffab551b..f4fe1b3f69cca038ba675526f47c4d49fff333f5 100644
--- a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
+++ b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
@@ -22,6 +22,7 @@ [LibraryClasses]
   ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
   FvLib|StandaloneMmPkg/Library/FvLib/FvLib.inf
   HobLib|StandaloneMmPkg/Library/StandaloneMmCoreHobLib/StandaloneMmCoreHobLib.inf
+  HobPrintLib|MdeModulePkg/Library/HobPrintLib/HobPrintLib.inf
   IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
   MemLib|StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf
   MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf
--
Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120225): https://edk2.groups.io/g/devel/message/120225
Mute This Topic: https://groups.io/mt/107730606/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platform v1 1/2] ARM/VExpressPkg: Add HobPrintLib in StandaloneMm

[PierreGondois]

Hello Levi,
NIT:
I think it's commit 049e12c03d27 ("StandaloneMmPkg/Core: Dump all HOB info in entrypoint")
which breaks the build (whenever StandaloneMmPkg/Core/StandaloneMmCore.inf is used).

The following platforms should have the same modification I think:
- Platform/Socionext/DeveloperBox/DeveloperBoxMm.dsc
- Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc

Regards,
Pierre

On 8/5/24 14:30, Levi Yun wrote:
> From: "levi.yun" <yeoreum.yun@arm.com>
> 
> commit: d5b03d5fba30d ("MdeModulePkg: Add HobPrintLib instance")
> adds HobPinrtLib which causes build failure for StandaloneMm
> To fix build failure, add HobPrintLib for StandaloneMm.
> 
> Signed-off-by: Levi Yun <yeoreum.yun@arm.com>
> ---
>   Platform/ARM/VExpressPkg/PlatformStandaloneMm.dsc | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Platform/ARM/VExpressPkg/PlatformStandaloneMm.dsc b/Platform/ARM/VExpressPkg/PlatformStandaloneMm.dsc
> index a0a9d9a21a1b6682ff43d23ee82245219155c941..127b1e3bb729a563b8e0fe03b95b92673695a9a3 100644
> --- a/Platform/ARM/VExpressPkg/PlatformStandaloneMm.dsc
> +++ b/Platform/ARM/VExpressPkg/PlatformStandaloneMm.dsc
> @@ -55,6 +55,7 @@ [LibraryClasses]
>     ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
>     FvLib|StandaloneMmPkg/Library/FvLib/FvLib.inf
>     HobLib|StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.inf
> +  HobPrintLib|MdeModulePkg/Library/HobPrintLib/HobPrintLib.inf
>     IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
>     MemLib|StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.inf
>     MemoryAllocationLib|StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf
> --
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120292): https://edk2.groups.io/g/devel/message/120292
Mute This Topic: https://groups.io/mt/107730605/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platform v1 0/2] Add HobPrintLib for StandaloneMm in Arm Platform

[Sami Mujawar]

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

Hi Levi,

Thank you for these fixes.
These changes look good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120232): https://edk2.groups.io/g/devel/message/120232
Mute This Topic: https://groups.io/mt/107730604/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 1070 bytes --]