[edk2-devel] [edk2-platforms][PATCH 3/3] AmpereAltraPkg/SystemFirmwareInterfaceLib: Remove unused MailboxMsgTurboConfig()

["Nhi Pham via groups.io" <nhi=os.amperecomputing.com@groups.io>]

Since configuring the max frequency is unnecessary, its configuration
functions is unused, so remove it.

Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
---
 Silicon/Ampere/AmpereAltraPkg/Include/Library/SystemFirmwareInterfaceLib.h                    | 25 ------------
 Silicon/Ampere/AmpereAltraPkg/Library/SystemFirmwareInterfaceLib/SystemFirmwareInterfaceLib.c | 43 --------------------
 2 files changed, 68 deletions(-)

diff --git a/Silicon/Ampere/AmpereAltraPkg/Include/Library/SystemFirmwareInterfaceLib.h b/Silicon/Ampere/AmpereAltraPkg/Include/Library/SystemFirmwareInterfaceLib.h
index ce96c2a6b4b6..b91b7c1f862f 100644
--- a/Silicon/Ampere/AmpereAltraPkg/Include/Library/SystemFirmwareInterfaceLib.h
+++ b/Silicon/Ampere/AmpereAltraPkg/Include/Library/SystemFirmwareInterfaceLib.h
@@ -153,14 +153,6 @@
 #define MAILBOX_BOOT_PROGRESS_COMMAND_SET 1
 #define MAILBOX_BOOT_PROGRESS_STAGE_UEFI  8
 
-//
-// Parameters for Set Configuration
-//   Param0: Configuration type
-//     20: Turbo configuration
-//   Param1: Unused
-//
-#define MAILBOX_SET_CONFIGURATION_TURBO 20
-
 /**
   Read a register which is not accessible from the non-secure world
   by sending a mailbox message to the SMpro processor.
@@ -262,21 +254,4 @@ MailboxMsgSetBootProgress (
   IN UINT32  Checkpoint
   );
 
-/**
-  Configure the Turbo (Max Performance) mode.
-
-  @param[in]  Socket           Active socket index.
-  @param[in]  Enable           Enable/Disable the Turbo (Max performance) mode.
-
-  @retval EFI_SUCCESS           Configure the Turbo successfully.
-  @retval EFI_INVALID_PARAMETER A parameter is invalid.
-  @retval Otherwise             Errors returned from the MailboxWrite() functions.
-**/
-EFI_STATUS
-EFIAPI
-MailboxMsgTurboConfig (
-  IN UINT8   Socket,
-  IN BOOLEAN Enable
-  );
-
 #endif /* SYSTEM_FIRMWARE_INTERFACE_LIB_H_ */
diff --git a/Silicon/Ampere/AmpereAltraPkg/Library/SystemFirmwareInterfaceLib/SystemFirmwareInterfaceLib.c b/Silicon/Ampere/AmpereAltraPkg/Library/SystemFirmwareInterfaceLib/SystemFirmwareInterfaceLib.c
index 9cab653418fb..dacfd36d1691 100644
--- a/Silicon/Ampere/AmpereAltraPkg/Library/SystemFirmwareInterfaceLib/SystemFirmwareInterfaceLib.c
+++ b/Silicon/Ampere/AmpereAltraPkg/Library/SystemFirmwareInterfaceLib/SystemFirmwareInterfaceLib.c
@@ -283,46 +283,3 @@ MailboxMsgSetBootProgress (
 
   return Status;
 }
-
-/**
-  Configure the Turbo (Max Performance) mode.
-
-  @param[in]  Socket           Active socket index.
-  @param[in]  Enable           Enable/Disable the Turbo (Max performance) mode.
-
-  @retval EFI_SUCCESS           Configure the Turbo successfully.
-  @retval EFI_INVALID_PARAMETER A parameter is invalid.
-  @retval Otherwise             Errors returned from the MailboxWrite() functions.
-**/
-EFI_STATUS
-EFIAPI
-MailboxMsgTurboConfig (
-  IN UINT8   Socket,
-  IN BOOLEAN Enable
-  )
-{
-  EFI_STATUS           Status;
-  MAILBOX_MESSAGE_DATA Message;
-
-  if (Socket >= GetNumberOfSupportedSockets ()) {
-    return EFI_INVALID_PARAMETER;
-  }
-
-  Message.Data = MAILBOX_USER_MESSAGE_ENCODE (
-                   MAILBOX_USER_MESSAGE_SUBTYPE_SET_CONFIGURATION,
-                   MAILBOX_SET_CONFIGURATION_TURBO,
-                   0
-                   );
-
-  //
-  // The Turbo configuration is written into the extended data 0.
-  // The extended data 1 is unused.
-  //
-  Message.ExtendedData[0] = Enable ? 1 : 0;
-  Message.ExtendedData[1] = 0;
-
-  Status = MailboxWrite (Socket, PMproDoorbellChannel1, &Message);
-  ASSERT_EFI_ERROR (Status);
-
-  return Status;
-}
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120350): https://edk2.groups.io/g/devel/message/120350
Mute This Topic: https://groups.io/mt/107909938/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-