From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2B84D740034 for ; Thu, 15 Aug 2024 07:14:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6+QaZbT1IuZgLR1ofqDTrhGblFWtC1QTCjbmPAvytLc=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20240206; t=1723706066; v=1; b=Gg8fEAj1FmYxFcRARNd6UQdUWAxoCxVd76B+HbGBYGFuS3SEuNPtQfjsxpIffd0vNXV7E4Yh xKKlI3KzLmXwjv7vfY11zSHg2+oDVweawtPh3weZrG89waSREDAwWBDy+psmr7MSEdhY1IRNdNn tbsbaRcfmHMbqecSUVnSn6EGuW356pGkYor/QJSO99wHcs/KsU0NDHZggqGlnTIkWrThEPFGZmr wuPq6cKzcEMJmHGRWm7X+MbqNvLwPQHexXMKUir2Rr81hs/UNZLlC9bbkyY4R1LQCT2K0V5LUJC uKTOiv4Ko4Ir1Hes1rQk3LZSqExeBM/hDl+5EB1dKF6yw== X-Received: by 127.0.0.2 with SMTP id 0JdmYY7687511x6qRXg1r4HT; Thu, 15 Aug 2024 00:14:25 -0700 X-Received: from DM5PR21CU001.outbound.protection.outlook.com (DM5PR21CU001.outbound.protection.outlook.com [52.101.62.116]) by mx.groups.io with SMTP id smtpd.web10.117731.1723706064886925504 for ; Thu, 15 Aug 2024 00:14:25 -0700 X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by CH3PR01MB8490.prod.exchangelabs.com (2603:10b6:610:197::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.18; Thu, 15 Aug 2024 07:14:20 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc79:e629:93aa:8b8f]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc79:e629:93aa:8b8f%3]) with mapi id 15.20.7875.018; Thu, 15 Aug 2024 07:14:20 +0000 From: "Nhi Pham via groups.io" To: devel@edk2.groups.io CC: quic_llindhol@quicinc.com, chuong@os.amperecomputing.com, rebecca@os.amperecomputing.com, nhi@os.amperecomputing.com Subject: [edk2-devel] [edk2-platforms][PATCH 3/3] AmpereAltraPkg/SystemFirmwareInterfaceLib: Remove unused MailboxMsgTurboConfig() Date: Thu, 15 Aug 2024 14:12:34 +0700 Message-ID: <20240815071234.3807473-4-nhi@os.amperecomputing.com> In-Reply-To: <20240815071234.3807473-1-nhi@os.amperecomputing.com> References: <20240815071234.3807473-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SI2PR01CA0024.apcprd01.prod.exchangelabs.com (2603:1096:4:192::20) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7287:EE_|CH3PR01MB8490:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b442b54-7456-4991-f4e5-08dcbcf9e1e7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?P+cB54mfPVcacx6CKvU2xxO5JAadlGxhGWsnwbRGgWFLSxC7KugnMpy5EqHY?= =?us-ascii?Q?OqO312dj4e3lK4FjUuAFe/xrnCVbz6J3Q/De2AlC/10q59eIttfoAtHUK6/l?= =?us-ascii?Q?hOCyDwg1b4Xp7ZuJOi0dx46/zYn8USIuIo3IQ/BYVf/rdRwykeWBTiFKFbh7?= =?us-ascii?Q?sBf19pDdEuLRIvUssMHHJTbR7RKwTWrc6ojKskRP1XtIHKRaG4c3f0pGzW2U?= =?us-ascii?Q?junVnKwLRtWg5+NfDDbXHjKq9+Eek+2a+CSjFPOuRx2SUDySiBwc+zJB+Toa?= =?us-ascii?Q?PZP+eEBovY2iHYUO2K/Ze8W7AQVkmspm9pSegnDkQZnpkAay2DfLOPbREGqS?= =?us-ascii?Q?denra47lYcPJO4VY+IsHfAba/BpK4GEUTIJjGxiAmSUaOhx4/nV3HLkze107?= =?us-ascii?Q?QHyKCO/n8DKKaOX8Wo/xiV67NmRd9cxNA3vS42xLYiYpFTAoeKpVAc4oNZiA?= =?us-ascii?Q?Rh0W5JuWmCsVcZinH37E1NXpX45y2dE00l5ySBPIZ4qQFFk+ZIOB48W1ilpr?= =?us-ascii?Q?O8rclleAgjnbD+FiVC2CjFL/EsN1JuEAbDl4MQm9ibgnFuM+wR8bZQx5La4C?= =?us-ascii?Q?pt+9C66bx2pF27gtl+u6gj7ZhZ2tX2a2871ltIOSgc0MG2NEHQaP373nO8hH?= =?us-ascii?Q?p7USyQ3Fwfp0wwNoaA3H1OAHPpxml47y0Xpmg1BJQLQGnnO7SyIHm3+EkJMX?= =?us-ascii?Q?MWXWdtK31SvFlDYyBQS7UiyKliMLUv+hMvgWw+zKZJGLV5B3i/KNgKCLg7De?= =?us-ascii?Q?wnZIVERWxnlvydKN475o+oeRLlFrHT5qfoit618yRaSAzbAhzRmXiCTCnnD3?= =?us-ascii?Q?uAfibEAGefMgHDZAWqPt9f4X0Sdwh63VgOuiZWSs8f75t/4rZF3rj41KtcGj?= =?us-ascii?Q?e4WIx77t2vEjF/KrxAjF6ION4GqQ/GvP953e39FDFOSm4r0JOCPAntjUhJXr?= =?us-ascii?Q?4RJyy2cy+1oEySx+uFMT5Q4xZBTDVSn0tbO6L3CvGONeyN35vAes55szfrwy?= =?us-ascii?Q?AOXl6BJ+sf2UabHu5Ct6nCTLDV/YGLwDDWo0OecEMytkFwDtNZeY2PpRSBtc?= =?us-ascii?Q?J4matv0Y3rThpuY0AOiCMiiM9I9pVn8YV+n9PfdwcBik5Irxv8xiNicCkhzG?= =?us-ascii?Q?0QTbqVdAYuKuDmwGlGt4YspIF/jVkpHGfwJd2DHS3g1HHAWTQo9KkVQBUTj4?= =?us-ascii?Q?enJYPbD5dgoOoA4OXVn8FNtVHU1j1VM4zso7qvvCqEuT4dQ+ADQ1rzK0VhN5?= =?us-ascii?Q?HYuYQYEaKzsNzwWaVKpXsGC59SglfinHf/KTkR/2pw/SqMJJ5cJ49mMDdeJK?= =?us-ascii?Q?oiJKqjh8FydQwHARA36cgINFVXxoBzMtCFmJMJaCUFasKkfxN1KnttOzuaJO?= =?us-ascii?Q?cU6RGEGfb5T+CKtjinybBgywaXmGYlEkoQIH4sesY9F9nlSGow=3D=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pIse5E2n66mxYi+VgqqkxJ/iK6CizQa0uAiKeRmdPmzrQRyiW7BSVfBU2mVs?= =?us-ascii?Q?SWRpLycO36ln2WWfdb77cFzL5uvyoXTTzFT9t4vEvMgKhP1XlmTJWHjiRyvZ?= =?us-ascii?Q?6vNdrhW+pohmPAzecJ6X1Qtsuk4OjsPbPpYMhsblQqlEH8X+GJighGObBTAF?= =?us-ascii?Q?IGscF9chTsrihxYGz/R8ecUPsMYU6QeSFXdazH8ahbwS4ZZWhcEqDHZty5zc?= =?us-ascii?Q?WslvsYVupjbgLGSvFgXrD/S6p11JIjCZsvys3s3uEmzG5+PFCjDHmhGN89Md?= =?us-ascii?Q?R+h2CIMT53+whd6f610XKQ71Wg8PfgYYMtAjvzNcu1H9f05TJJ+VGtJypZ7p?= =?us-ascii?Q?KtDWGQiCmPmSw4pldeqyxJQoCnVt3WkILb2MfwrjY+m5VLgLhV/OhJBTUyus?= =?us-ascii?Q?KqtcVne2vFUI0fnMLP0SaBkQFgJXatTpzQuGp1W5LMxol/v6MZGStYucKwqs?= =?us-ascii?Q?GmwvPjVTMiziSOMMLSQZMUDH5qrsv02fQGvDfpfpYkIzkFniZ6dXndvwQYmU?= =?us-ascii?Q?s9ALy7XYDf9IqkFowV8AN/zDnvG13/arJyWxfHKSqzRZdaPWDUEnn1ivPt2V?= =?us-ascii?Q?YZGRg+6Siz9+FHXZ0gih48/6dOc2w/RX234/JHFwXdhRUKFlLPdJvzTtHS8x?= =?us-ascii?Q?Z3hYzW3sFtdYZsrogSpwBlZ11WHSeBuuoJ06eUFU1f5314N5gM6jRE6uUfUO?= =?us-ascii?Q?I/9WeBWD4W9tfTsOOpkv8bAq71dmLW8YSke6yG/X4W6Mq/frNJRado9FBizs?= =?us-ascii?Q?y/SPjtZqH3TyoYoxkmNtyLraUYLFUpHTa3fmiCDiYhXuqg9/jbrbZPQDrrrB?= =?us-ascii?Q?QfjH4afeCAJzxzyThV6TB19Twu0gd2mWqTkN2Fna5eImSYmeAtAReNhRd3B3?= =?us-ascii?Q?1lgURgJqh7b5XMfWsuIGiaqWo0R+rNIH1SkfB/uyMTDf2Olo2hFkLe8H08/L?= =?us-ascii?Q?K8nb5iZqZK7rlT5wFL3tKurNuZHXNkEkkyjXL3badvk4N6cxJr/VHSczzmbQ?= =?us-ascii?Q?25P3UkqYwEFcUvkNu1Z6BL7QYaYMPj0kOfyp/EcWPRQSPvzqO+86Sfl4nkSD?= =?us-ascii?Q?4QzyDtS3+QPjW91sVOYDie5ozheY6BavWXHal7miKUMuYY0dgwzAGdqlRl/l?= =?us-ascii?Q?FjjDtbsgN2RokgAZTjx0XC8D6TOUUmIsDvbQ1B9Dy0+tsxr/V877G8uqa1cL?= =?us-ascii?Q?epsPetwMxh3tAZ8lhKQm+E6pgE5QPra7+zHnqGCYJOFbVDVJhfvhtpOBkgJn?= =?us-ascii?Q?BGB+7VzZcpb8HaDyP2sYeau+sP97DegeCTHqSfRBZ9KUZSrogPcCTPc0Ne8Y?= =?us-ascii?Q?0GB3XEfhVKz+4DdNW8gDrOtE1nirpapSpMj/W0DSpGBlUVpgz5vfh1z/iFQC?= =?us-ascii?Q?0SPhOK2U+HnJrD0orqwSpR34MrB5eRZyxYdsnXKE9scHxMKFgIGmecxSfVOT?= =?us-ascii?Q?MrlW8ToqMT8t+1BsraRIfF/6fbH/OkrAb67S4tfNyEtPv9ThGaGR7xcVmm0h?= =?us-ascii?Q?ZLdYvMtdkd02lGo588lPYFeINKk5baPdWlKI54P/sjFi9BXMLbU1uCY0LvQY?= =?us-ascii?Q?3slG9gBQnvBliun2a//SzdmynHWZminRw588giUyH3l40BxvrwOabxz44+oc?= =?us-ascii?Q?cizVQ12PgchdtPsslTebY1g=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b442b54-7456-4991-f4e5-08dcbcf9e1e7 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2024 07:14:20.5648 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5B7+3XKcWAHGQpG0Zb+5ZqHLuB9Mmtx06GZAxQx5ta2JxlOAy5BkBhJXg2vta45/0+o4xuIo+Db0KuWlAFZHjvgPxpWiiQI3nkjv9gM69yc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR01MB8490 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 15 Aug 2024 00:14:25 -0700 Resent-From: nhi@os.amperecomputing.com Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: bSONw4OaSAZGwuQ4M5qMNWxXx7686176AA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=Gg8fEAj1; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Since configuring the max frequency is unnecessary, its configuration functions is unused, so remove it. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereAltraPkg/Include/Library/SystemFirmwareInterfaceLib.h= | 25 ------------ Silicon/Ampere/AmpereAltraPkg/Library/SystemFirmwareInterfaceLib/SystemFir= mwareInterfaceLib.c | 43 -------------------- 2 files changed, 68 deletions(-) diff --git a/Silicon/Ampere/AmpereAltraPkg/Include/Library/SystemFirmwareIn= terfaceLib.h b/Silicon/Ampere/AmpereAltraPkg/Include/Library/SystemFirmware= InterfaceLib.h index ce96c2a6b4b6..b91b7c1f862f 100644 --- a/Silicon/Ampere/AmpereAltraPkg/Include/Library/SystemFirmwareInterface= Lib.h +++ b/Silicon/Ampere/AmpereAltraPkg/Include/Library/SystemFirmwareInterface= Lib.h @@ -153,14 +153,6 @@ #define MAILBOX_BOOT_PROGRESS_COMMAND_SET 1 #define MAILBOX_BOOT_PROGRESS_STAGE_UEFI 8 =20 -// -// Parameters for Set Configuration -// Param0: Configuration type -// 20: Turbo configuration -// Param1: Unused -// -#define MAILBOX_SET_CONFIGURATION_TURBO 20 - /** Read a register which is not accessible from the non-secure world by sending a mailbox message to the SMpro processor. @@ -262,21 +254,4 @@ MailboxMsgSetBootProgress ( IN UINT32 Checkpoint ); =20 -/** - Configure the Turbo (Max Performance) mode. - - @param[in] Socket Active socket index. - @param[in] Enable Enable/Disable the Turbo (Max performance) = mode. - - @retval EFI_SUCCESS Configure the Turbo successfully. - @retval EFI_INVALID_PARAMETER A parameter is invalid. - @retval Otherwise Errors returned from the MailboxWrite() fu= nctions. -**/ -EFI_STATUS -EFIAPI -MailboxMsgTurboConfig ( - IN UINT8 Socket, - IN BOOLEAN Enable - ); - #endif /* SYSTEM_FIRMWARE_INTERFACE_LIB_H_ */ diff --git a/Silicon/Ampere/AmpereAltraPkg/Library/SystemFirmwareInterfaceL= ib/SystemFirmwareInterfaceLib.c b/Silicon/Ampere/AmpereAltraPkg/Library/Sys= temFirmwareInterfaceLib/SystemFirmwareInterfaceLib.c index 9cab653418fb..dacfd36d1691 100644 --- a/Silicon/Ampere/AmpereAltraPkg/Library/SystemFirmwareInterfaceLib/Syst= emFirmwareInterfaceLib.c +++ b/Silicon/Ampere/AmpereAltraPkg/Library/SystemFirmwareInterfaceLib/Syst= emFirmwareInterfaceLib.c @@ -283,46 +283,3 @@ MailboxMsgSetBootProgress ( =20 return Status; } - -/** - Configure the Turbo (Max Performance) mode. - - @param[in] Socket Active socket index. - @param[in] Enable Enable/Disable the Turbo (Max performance) = mode. - - @retval EFI_SUCCESS Configure the Turbo successfully. - @retval EFI_INVALID_PARAMETER A parameter is invalid. - @retval Otherwise Errors returned from the MailboxWrite() fu= nctions. -**/ -EFI_STATUS -EFIAPI -MailboxMsgTurboConfig ( - IN UINT8 Socket, - IN BOOLEAN Enable - ) -{ - EFI_STATUS Status; - MAILBOX_MESSAGE_DATA Message; - - if (Socket >=3D GetNumberOfSupportedSockets ()) { - return EFI_INVALID_PARAMETER; - } - - Message.Data =3D MAILBOX_USER_MESSAGE_ENCODE ( - MAILBOX_USER_MESSAGE_SUBTYPE_SET_CONFIGURATION, - MAILBOX_SET_CONFIGURATION_TURBO, - 0 - ); - - // - // The Turbo configuration is written into the extended data 0. - // The extended data 1 is unused. - // - Message.ExtendedData[0] =3D Enable ? 1 : 0; - Message.ExtendedData[1] =3D 0; - - Status =3D MailboxWrite (Socket, PMproDoorbellChannel1, &Message); - ASSERT_EFI_ERROR (Status); - - return Status; -} --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120350): https://edk2.groups.io/g/devel/message/120350 Mute This Topic: https://groups.io/mt/107909938/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-