From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 201C6AC10B4 for ; Fri, 30 Aug 2024 10:59:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=wjXBNdIV41Dj69EcEm+ETYgRdNIIOAK16cwIAKZngBI=; c=relaxed/simple; d=groups.io; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References:Organization:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20240206; t=1725015598; v=1; b=tjW4QemDCECTMLVxQ/SGA0NvodyZONsx2bocRmSagHucTL80aiZTwjQDXiojCiYFftY5OGqd e9RHt9rvuUUuUCbf/ICGP66eSmt0mrjRkl6yvcxmz1UEUpfIq3UlwgI/w9DiO6QofK+tk8CPxiu qJX2lO+PHxXkwA/1gzq0fe3gQ0u2MPXCshBWCcg8pf04gV1TGfsOup13+QUNLi9Csphrk5+jS2F sn1du8n/KEG24xiNtspc6wXF7lLiM8REelgvwn+dGE00R/VNOW5/1+L9nnq/51+yltPvaQwQ8PE eVllL5gkXNOKjOKrLMT6PDRhMy9koxQ74rG2CtstUOM6w== X-Received: by 127.0.0.2 with SMTP id xVzhYY7687511x2WzD9U0omg; Fri, 30 Aug 2024 03:59:57 -0700 X-Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by mx.groups.io with SMTP id smtpd.web10.10543.1725015595692643264 for ; Fri, 30 Aug 2024 03:59:56 -0700 X-Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WwFS10mYbz6K6WT; Fri, 30 Aug 2024 18:55:45 +0800 (CST) X-Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id A2BB1140CF4; Fri, 30 Aug 2024 18:59:52 +0800 (CST) X-Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 30 Aug 2024 11:59:52 +0100 Date: Fri, 30 Aug 2024 11:59:51 +0100 From: "Jonathan Cameron via groups.io" To: Yuquan Wang CC: , , , , , , , , Subject: Re: [edk2-devel] [RFC PATCH edk2-platforms 1/2] SbsaQemu: Add acpi0016 & acpi0017 objects into DSDT Message-ID: <20240830115951.0000783b@Huawei.com> In-Reply-To: <20240830031545.548789-2-wangyuquan1236@phytium.com.cn> References: <20240830031545.548789-1-wangyuquan1236@phytium.com.cn> <20240830031545.548789-2-wangyuquan1236@phytium.com.cn> Organization: Huawei Technologies Research and Development (UK) Ltd. MIME-Version: 1.0 X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To lhrpeml500005.china.huawei.com (7.191.163.240) Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 30 Aug 2024 03:59:56 -0700 Resent-From: jonathan.cameron@huawei.com Reply-To: devel@edk2.groups.io,jonathan.cameron@huawei.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 2cilLmYPvuLGd7T6neF6khe4x7686176AA= Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=tjW4QemD; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, 30 Aug 2024 11:15:44 +0800 Yuquan Wang wrote: > This adds relevant definitions and descriptions of acpi0016 and > acpi0017 to support CXL. >=20 > With the implementation of pxb-cxl on the original pcie host bridge, > the previous space layout of mmio32 & mmio64 have to be divided to > provide the mmio space for cxl host bridge. >=20 > I'm not sure if the new space layout would bring a series of bad > influence, but it seems that the base address and size of cxl host > bridge is ok. >=20 > Signed-off-by: Yuquan Wang I'll go as far as saying this looks about right to me, but needs some more eyes to be more certain.=20 Trivial comments inline. Jonathan > diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl b/Silicon/Qemu/Sbs= aQemu/AcpiTables/Dsdt.asl > index c134fb66e860..94d0b2cbb118 100644 > --- a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl > +++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl > @@ -483,5 +849,45 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", > } > } // End _OSC > } > + > + Scope (\_SB) > + { > + // CXL Root for OS Driver > + Device (CXLM) > + { > + Name (_HID, "ACPI0017") // _HID: Hardware ID > + Method (_STA, 0, NotSerialized) // _STA: Status > + { > + Return (0x0B) > + } > + > + Method (_DSM, 4, Serialized) // _DSM: Device-Specific Metho= d > + { > + If ((Arg0 =3D=3D ToUUID ("f365f9a6-a7de-4071-a66a-b40c0b= 4f8e52") /* Unknown UUID */)) Name that UUID in the comment. I was thinking you didn't have QTG querying= supported because oddly I can't remember the uuid :) > + { > + If ((Arg2 =3D=3D Zero)) > + { > + Return (Buffer (One) > + { > + 0x01 = // . > + }) > + } > + > + If ((Arg2 =3D=3D One)) > + { > + Return (Package (0x02) > + { > + One, > + Package (0x02) > + { > + Zero, > + One Hmm. I probably have this wrong in the qemu code, but it should be safe. This is saying QTG 0 default with fallback to 1. We don't have anything in group 1. Ah well never mind. =20 > + } > + }) > + } > + } > + } > + } > + } > } // Scope (_SB) > } -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120446): https://edk2.groups.io/g/devel/message/120446 Mute This Topic: https://groups.io/mt/108173684/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-