public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Richard Lyu via groups.io" <richard.lyu=suse.com@groups.io>
To: devel@edk2.groups.io
Cc: richard.lyu@suse.com
Subject: [edk2-devel] [RFC PATCH] OvmfPkg/Include: Remove NETWORK_ENABLE check in ShellComponents.dsc.inc
Date: Mon,  9 Sep 2024 21:05:57 +0800	[thread overview]
Message-ID: <20240909130557.22287-2-richard.lyu@suse.com> (raw)

I tried to fix the build error that occurred after commit 7f17a155640a. I have found that 
even when NETWORK_ENABLE=0, VirtioNet.inf is still being included. This causes errors by 
including network-related modules, but I’m not sure if there are other reasons. Does anyone 
have any ideas or suggestions on how to resolve this issue? Otherwise, the only solution 
would be to use this patch to remove the NETWORK_ENABLE check.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4829

The `NETWORK_ENABLE` condition in `ShellComponents.dsc.inc` causes
build errors. This change removes the check, ensuring `TftpDynamicCommand`
and `VariablePolicyDynamicCommand` are always included in the build.

Signed-off-by: Richard Lyu <richard.lyu@suse.com>
---
 OvmfPkg/Include/Dsc/ShellComponents.dsc.inc | 2 --
 1 file changed, 2 deletions(-)

diff --git a/OvmfPkg/Include/Dsc/ShellComponents.dsc.inc b/OvmfPkg/Include/Dsc/ShellComponents.dsc.inc
index 4075688e41..8e4385282e 100644
--- a/OvmfPkg/Include/Dsc/ShellComponents.dsc.inc
+++ b/OvmfPkg/Include/Dsc/ShellComponents.dsc.inc
@@ -5,7 +5,6 @@
 !if $(BUILD_SHELL) == TRUE

 

 !if $(TOOL_CHAIN_TAG) != "XCODE5"

-!if $(NETWORK_ENABLE) == TRUE

   ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf {

     <PcdsFixedAtBuild>

       gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE

@@ -14,7 +13,6 @@
     <PcdsFixedAtBuild>

       gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE

   }

-!endif

   ShellPkg/DynamicCommand/VariablePolicyDynamicCommand/VariablePolicyDynamicCommand.inf {

     <PcdsFixedAtBuild>

       gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE

-- 
2.43.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120533): https://edk2.groups.io/g/devel/message/120533
Mute This Topic: https://groups.io/mt/108361994/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



             reply	other threads:[~2024-09-09 19:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-09 13:05 Richard Lyu via groups.io [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-09-10  5:38 [edk2-devel][RFC PATCH] OvmfPkg/Include: Remove NETWORK_ENABLE check in ShellComponents.dsc.inc Richard Lyu via groups.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240909130557.22287-2-richard.lyu@suse.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox