From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6D4ABAC0BF7 for ; Mon, 9 Sep 2024 19:44:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=lOQ0cbJBIMexI0zw4nBv1azVWgFy5pGXny5GdWePXYY=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20240830; t=1725911085; v=1; x=1726170283; b=sUjAWh0eMCiQyJ+ajHcrqyHsdA6s7hcfEurB0XwdHGs5oFYV4sW3M1rAnPFsuqSKNlUjvJmp 0PzPD2qtwBUIZ3dcXanife1NQUuH/+E4ot83fOK7SJGwZTd9GgMgyZLhp0gUnfBIgTBkmF3o6ly +CkodmIeX93oHiM+lpH6O3kek+GGCDqmTQjG9aH/8VVKJvAJowq8SHbSdCCTRgVj5vvlqql2eAj DygZDpaYeRGdCyW0dBmZdkrp/MVW9yyZjiLVe+eV4zKLQVEiOcYjr024X6rfoRcvGdgjArYtlT9 x/Jwza8OHvmY688CiWThyt3N02FSRDNfM6jp7cyZoa0Gg== X-Received: by 127.0.0.2 with SMTP id Od6XYY7687511xmxrBhuGiNt; Mon, 09 Sep 2024 12:44:43 -0700 X-Received: from localhost.localdomain (localhost.localdomain [118.168.204.67]) by mx.groups.io with SMTP id smtpd.web10.52622.1725887552208050012 for ; Mon, 09 Sep 2024 06:12:32 -0700 X-Received: by localhost.localdomain (Postfix, from userid 1000) id 30D2545BA39; Mon, 9 Sep 2024 21:12:28 +0800 (CST) From: "Richard Lyu via groups.io" To: devel@edk2.groups.io Cc: richard.lyu@suse.com Subject: [edk2-devel] [RFC PATCH] OvmfPkg/Include: Remove NETWORK_ENABLE check in ShellComponents.dsc.inc Date: Mon, 9 Sep 2024 21:05:57 +0800 Message-ID: <20240909130557.22287-2-richard.lyu@suse.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 09 Sep 2024 12:44:43 -0700 Resent-From: richard.lyu@suse.com Reply-To: devel@edk2.groups.io,richard.lyu@suse.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: tn1xTDkDOksa7R0MIjRszdypx7686176AA= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=sUjAWh0e; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io I tried to fix the build error that occurred after commit 7f17a155640a. I h= ave found that=20 even when NETWORK_ENABLE=3D0, VirtioNet.inf is still being included. This c= auses errors by=20 including network-related modules, but I=E2=80=99m not sure if there are ot= her reasons. Does anyone=20 have any ideas or suggestions on how to resolve this issue? Otherwise, the = only solution=20 would be to use this patch to remove the NETWORK_ENABLE check. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4829 The `NETWORK_ENABLE` condition in `ShellComponents.dsc.inc` causes build errors. This change removes the check, ensuring `TftpDynamicCommand` and `VariablePolicyDynamicCommand` are always included in the build. Signed-off-by: Richard Lyu --- OvmfPkg/Include/Dsc/ShellComponents.dsc.inc | 2 -- 1 file changed, 2 deletions(-) diff --git a/OvmfPkg/Include/Dsc/ShellComponents.dsc.inc b/OvmfPkg/Include/= Dsc/ShellComponents.dsc.inc index 4075688e41..8e4385282e 100644 --- a/OvmfPkg/Include/Dsc/ShellComponents.dsc.inc +++ b/OvmfPkg/Include/Dsc/ShellComponents.dsc.inc @@ -5,7 +5,6 @@ !if $(BUILD_SHELL) =3D=3D TRUE =20 !if $(TOOL_CHAIN_TAG) !=3D "XCODE5" -!if $(NETWORK_ENABLE) =3D=3D TRUE ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf { gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE @@ -14,7 +13,6 @@ gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE } -!endif ShellPkg/DynamicCommand/VariablePolicyDynamicCommand/VariablePolicyDynam= icCommand.inf { gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE --=20 2.43.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120533): https://edk2.groups.io/g/devel/message/120533 Mute This Topic: https://groups.io/mt/108361994/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-