From: Breno Leitao <leitao@debian.org>
To: Usama Arif <usamaarif642@gmail.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
ardb@kernel.org, linux-efi@vger.kernel.org,
kexec@lists.infradead.org, bhe@redhat.com, vgoyal@redhat.com,
devel@edk2.groups.io, rppt@kernel.org, gourry@gourry.net,
rmikey@meta.com, tglx@linutronix.de
Subject: Re: [edk2-devel] EFI table being corrupted during Kexec
Date: Tue, 10 Sep 2024 09:09:21 -0700 [thread overview]
Message-ID: <20240910-strong-dancing-rottweiler-aaed51@devvm32600> (raw)
In-Reply-To: <9b024f7d-e326-46eb-bd88-71a16151fcf0@gmail.com>
hello Usama,
On Tue, Sep 10, 2024 at 04:46:15PM +0100, Usama Arif wrote:
> --- a/drivers/firmware/efi/tpm.c
> +++ b/drivers/firmware/efi/tpm.c
> @@ -60,7 +60,9 @@ int __init efi_tpm_eventlog_init(void)
> }
>
> tbl_size = sizeof(*log_tbl) + log_tbl->size;
> - memblock_reserve(efi.tpm_log, tbl_size);
> + if (!memblock_reserve(efi.tpm_log, tbl_size)) {
> + arch_update_firmware_area(efi.tpm_log, tbl_size);
> + }
Shouldn't you reserve the region into 8250 independently of
memblock_reserve() return value?
Thanks for the patch,
--breno
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120545): https://edk2.groups.io/g/devel/message/120545
Mute This Topic: https://groups.io/mt/108376671/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-09-10 16:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 13:58 [edk2-devel] EFI table being corrupted during Kexec Breno Leitao
[not found] ` <87ed5rd1qf.fsf@email.froward.int.ebiederm.org>
2024-09-10 15:13 ` Breno Leitao
2024-09-10 15:46 ` Usama Arif
2024-09-10 16:09 ` Breno Leitao [this message]
2024-09-10 16:14 ` Gregory Price
2024-09-11 10:58 ` Usama Arif
2024-09-10 15:44 ` Andrew Fish via groups.io
2024-09-11 8:44 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910-strong-dancing-rottweiler-aaed51@devvm32600 \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox