From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3EA4D74003A for ; Tue, 10 Sep 2024 16:14:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=OLEeoIQkZGCNxnWT8nkPXNmLFER2CGn0bo1gsysDc18=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240830; t=1725984868; v=1; x=1726244067; b=srACg5STKQFcTlv7sK0e5bdnLcTahU5OX03bk5UYn8a7cKfFClDodubfRQEQYJiyoAxWt5x9 eEv1sgGXUlX4836lt4Z/eSDScUBCknIzr2mGUoG5KOHfHyX6Y+kLTmZkqNFY3ylp3eqLO/9OwQW xAODruy8pHISopRcHAjrAhnsKDjNYCVQhv3AUCj/P8p+6fkAEPXJEUUPAt/Kzc4IdCOQpCxbxqV r0VySDpiKEZv/idxWQ9LNswTQjFVOd1zPMy8fgt63PjAUpZ3DYcCPqBNYcbI6HhA0NKTkV21wg1 BufaH2d/JWSzltBKyDvR9hBFHLG7TneR47NpjP7U277BA== X-Received: by 127.0.0.2 with SMTP id otnpYY7687511x4yQSN14kL1; Tue, 10 Sep 2024 09:14:27 -0700 X-Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by mx.groups.io with SMTP id smtpd.web11.200.1725984573660568845 for ; Tue, 10 Sep 2024 09:09:33 -0700 X-Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a8ce5db8668so8304366b.1 for ; Tue, 10 Sep 2024 09:09:33 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUIAtBHlVdXzCRP/4ULbewYU7z/QZRcdZC0sqR+mQgFf7WiXqOW3iIUjLXc++r3VCTwh7Zz4Q==@edk2.groups.io X-Gm-Message-State: PXxk3KViB8FjQBK91Ny0kaNMx7686176AA= X-Google-Smtp-Source: AGHT+IGNrkxiR+3Iqt74NRnDw9jegrN1LNQi6QH6ygQSAS6+yyvwbVZ0/uE5DBfWEfyrmIMzBTFiUQ== X-Received: by 2002:a17:906:730a:b0:a86:68a1:6a08 with SMTP id a640c23a62f3a-a8ffab8346amr133085166b.29.1725984571286; Tue, 10 Sep 2024 09:09:31 -0700 (PDT) X-Received: from gmail.com (fwdproxy-lla-116.fbsv.net. [2a03:2880:30ff:74::face:b00c]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8d25d65742sm497575366b.216.2024.09.10.09.09.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Sep 2024 09:09:24 -0700 (PDT) Date: Tue, 10 Sep 2024 09:09:21 -0700 From: Breno Leitao To: Usama Arif Cc: "Eric W. Biederman" , ardb@kernel.org, linux-efi@vger.kernel.org, kexec@lists.infradead.org, bhe@redhat.com, vgoyal@redhat.com, devel@edk2.groups.io, rppt@kernel.org, gourry@gourry.net, rmikey@meta.com, tglx@linutronix.de Subject: Re: [edk2-devel] EFI table being corrupted during Kexec Message-ID: <20240910-strong-dancing-rottweiler-aaed51@devvm32600> References: <20240910-juicy-festive-sambar-9ad23a@devvm32600> <87ed5rd1qf.fsf@email.froward.int.ebiederm.org> <9b024f7d-e326-46eb-bd88-71a16151fcf0@gmail.com> MIME-Version: 1.0 In-Reply-To: <9b024f7d-e326-46eb-bd88-71a16151fcf0@gmail.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 10 Sep 2024 09:14:27 -0700 Resent-From: leitao@debian.org Reply-To: devel@edk2.groups.io,leitao@debian.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=srACg5ST; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io hello Usama, On Tue, Sep 10, 2024 at 04:46:15PM +0100, Usama Arif wrote: > --- a/drivers/firmware/efi/tpm.c > +++ b/drivers/firmware/efi/tpm.c > @@ -60,7 +60,9 @@ int __init efi_tpm_eventlog_init(void) > } > > tbl_size = sizeof(*log_tbl) + log_tbl->size; > - memblock_reserve(efi.tpm_log, tbl_size); > + if (!memblock_reserve(efi.tpm_log, tbl_size)) { > + arch_update_firmware_area(efi.tpm_log, tbl_size); > + } Shouldn't you reserve the region into 8250 independently of memblock_reserve() return value? Thanks for the patch, --breno -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120545): https://edk2.groups.io/g/devel/message/120545 Mute This Topic: https://groups.io/mt/108376671/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-