From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id AF4B5740032 for ; Fri, 13 Sep 2024 01:28:38 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ah0O/96qMiC2hrpIKXBK1UaPUbJ2THCxmDMTi0BOrho=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:User-Agent:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition:Content-Transfer-Encoding; s=20240830; t=1726190918; v=1; x=1726450117; b=Wd/ghxVNx25ajHXn/X8TMQtNhe3q+6Z1G14P/qPMANzxeiOSxbNVlO76yxFKQNMzgJlWcUYm ZdTZwVfDSqofTAML3WakFJ2oQwEU3YPO7xlq13g515zTfiP9E9sAx5BnMvew3XUt6D/1Q49iri2 JgVPYrcVmp98W31OZSjKwQyRp2ugfRY/HnUCLD+D1OMIhlQICIg0m0np2OlEMq7K+zyh0n2Jx3A 8ybCsB2hN6Hz+7gN8dQOtarau3or90hV44hO4y/80L9p3iZcsW99G/VQCotCgN3NIRE427criCK no/5kFdpa2BauJl5PshZ4pHpviqrd0kHt/jy2H2Jz7IeA== X-Received: by 127.0.0.2 with SMTP id PwZQYY7687511xZVklgZgZnU; Thu, 12 Sep 2024 18:28:37 -0700 X-Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mx.groups.io with SMTP id smtpd.web10.63723.1726190916033949946 for ; Thu, 12 Sep 2024 18:28:36 -0700 X-Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-42cb9a0c300so14395195e9.0 for ; Thu, 12 Sep 2024 18:28:35 -0700 (PDT) X-Gm-Message-State: BHiITCwBCtOAQFZYiXh7haWax7686176AA= X-Google-Smtp-Source: AGHT+IEkBL+r2FTbF9+G5zTh6SOX/H3c84Qfy0JgE5EH9XDEaziNGbJcqiEZoUwIJMUKBeg6geJ0Ew== X-Received: by 2002:adf:cd8b:0:b0:371:79f2:3d5c with SMTP id ffacd0b85a97d-378c2d1283amr2648367f8f.31.1726190913592; Thu, 12 Sep 2024 18:28:33 -0700 (PDT) X-Received: from linux-l9pv.suse ([124.11.22.254]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2076af44f91sm19575605ad.63.2024.09.12.18.28.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Sep 2024 18:28:33 -0700 (PDT) Date: Fri, 13 Sep 2024 09:28:29 +0800 From: "joeyli via groups.io" To: devel@edk2.groups.io, gaoliming@byosoft.com.cn Cc: joeyli.kernel@gmail.com, 'Zhiguang Liu' , 'Michael D Kinney' Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSF0gTWRlUGtnIERlYnVnTGliOiBFbmFibGUgRklMRSBOQU1FIGFzIERFQlVHIEFTU0VSVCBmb3IgR0NDMTI=?= Message-ID: <20240913012829.GB3296@linux-l9pv.suse> References: <20240912065209.12517-1-jlee@suse.com> <01ee01db0577$e7e763f0$b7b62bd0$@byosoft.com.cn> MIME-Version: 1.0 In-Reply-To: <01ee01db0577$e7e763f0$b7b62bd0$@byosoft.com.cn> User-Agent: Mutt/1.11.4 (2019-03-13) Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 12 Sep 2024 18:28:36 -0700 Resent-From: jlee@suse.com Reply-To: devel@edk2.groups.io,jlee@suse.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b="Wd/ghxVN"; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi gaoliming, Thanks for your review! I have sent pull request to edk2 github: https://github.com/tianocore/edk2/pull/6193 Joey Lee On Fri, Sep 13, 2024 at 08:57:26AM +0800, gaoliming via groups.io wrote: > Please submit it in Github Edk2 as pull request. I agree this is a good > change. > > > -----邮件原件----- > > 发件人: devel@edk2.groups.io 代表 Chun-Yi Lee > > 发送时间: 2024年9月12日 14:52 > > 收件人: devel@edk2.groups.io > > 抄送: Zhiguang Liu ; Michael D Kinney > > ; Chun-Yi Lee > > 主题: [edk2-devel] [PATCH] MdePkg DebugLib: Enable FILE NAME as DEBUG > > ASSERT for GCC12 > > > > Using __FILE_NAME__ is useful for reducing the size of debug image and > > it's also good for reproducable builds. The gcc-12 also supported this > > macro. > > > > Ref: > > https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=1a9b3f04c11eb467a8dc504a3 > > 7dad57a371a0d4c > > > > This patch removed the checking of __clang__ when using __FILE_NAME__. > > > > Cc: Zhiguang Liu > > Cc: Michael D Kinney > > Signed-off-by: Chun-Yi Lee > > --- > > MdePkg/Include/Library/DebugLib.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/MdePkg/Include/Library/DebugLib.h > > b/MdePkg/Include/Library/DebugLib.h > > index 0db3b78e..fc5c8346 100644 > > --- a/MdePkg/Include/Library/DebugLib.h > > +++ b/MdePkg/Include/Library/DebugLib.h > > @@ -342,13 +342,13 @@ UnitTestDebugAssert ( > > #if defined (_ASSERT) > > #undef _ASSERT > > #endif > > - #if defined (__clang__) && defined (__FILE_NAME__) > > + #if defined (__FILE_NAME__) > > #define _ASSERT(Expression) UnitTestDebugAssert (__FILE_NAME__, > > DEBUG_LINE_NUMBER, DEBUG_EXPRESSION_STRING (Expression)) > > #else > > #define _ASSERT(Expression) UnitTestDebugAssert (__FILE__, > > DEBUG_LINE_NUMBER, DEBUG_EXPRESSION_STRING (Expression)) > > #endif > > #else > > - #if defined (__clang__) && defined (__FILE_NAME__) > > + #if defined (__FILE_NAME__) > > #define _ASSERT(Expression) DebugAssert (__FILE_NAME__, > > DEBUG_LINE_NUMBER, DEBUG_EXPRESSION_STRING (Expression)) > > #else > > #define _ASSERT(Expression) DebugAssert (__FILE__, > > DEBUG_LINE_NUMBER, DEBUG_EXPRESSION_STRING (Expression)) > > -- > > 2.35.3 > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120561): https://edk2.groups.io/g/devel/message/120561 Mute This Topic: https://groups.io/mt/108424554/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-