public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Heinrich Schuchardt" <heinrich.schuchardt@canonical.com>
To: Zhichao Gao <zhichao.gao@intel.com>
Cc: EDK II Development <devel@edk2.groups.io>,
	Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Subject: [edk2-devel] [PATCH 1/1] ShellPkg: add missing linefeed in reset message
Date: Fri, 13 Sep 2024 10:21:18 +0200	[thread overview]
Message-ID: <20240913082118.43865-1-heinrich.schuchardt@canonical.com> (raw)

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4850

When running 'reset -s' no lineffeed is printed. This results in the Linux
command line prompt not being printed at the start of a new line:

    Shell> reset -s
    Reset with <null string> (0 bytes)user@workstation:/tmp$

Add the missing linefeed.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 ShellPkg/Library/UefiShellLevel2CommandsLib/Reset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Reset.c b/ShellPkg/Library/UefiShellLevel2CommandsLib/Reset.c
index 361c47e43059..cab9a1da3091 100644
--- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Reset.c
+++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Reset.c
@@ -138,7 +138,7 @@ ShellCommandRunReset (
         } else {
           String = ShellCommandLineGetValue (Package, L"-s");
           DEBUG_CODE (
-            ShellPrintEx (-1, -1, L"Reset with %s (%d bytes)", String, String != NULL ? StrSize (String) : 0);
+            ShellPrintEx (-1, -1, L"Reset with %s (%d bytes)\n", String, String != NULL ? StrSize (String) : 0);
             );
           if (String != NULL) {
             gRT->ResetSystem (EfiResetShutdown, EFI_SUCCESS, StrSize (String), (VOID *)String);
-- 
2.45.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120562): https://edk2.groups.io/g/devel/message/120562
Mute This Topic: https://groups.io/mt/108428477/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



                 reply	other threads:[~2024-09-13  8:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240913082118.43865-1-heinrich.schuchardt@canonical.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox