* [edk2-devel] [PATCH v1 0/1] *** SUBJECT HERE ***
@ 2024-10-22 20:29 G Edhaya Chandran
2024-10-22 20:29 ` [edk2-devel] [PATCH v1 1/1] edk2-test: uefi-sct Increase the waiting time in the SCT GetStatus_Func test G Edhaya Chandran
0 siblings, 1 reply; 2+ messages in thread
From: G Edhaya Chandran @ 2024-10-22 20:29 UTC (permalink / raw)
To: devel
*** BLURB HERE ***
G Edhaya Chandran (1):
edk2-test: uefi-sct Increase the waiting time in the SCT
GetStatus_Func test
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestFunction.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* [edk2-devel] [PATCH v1 1/1] edk2-test: uefi-sct Increase the waiting time in the SCT GetStatus_Func test
2024-10-22 20:29 [edk2-devel] [PATCH v1 0/1] *** SUBJECT HERE *** G Edhaya Chandran
@ 2024-10-22 20:29 ` G Edhaya Chandran
0 siblings, 0 replies; 2+ messages in thread
From: G Edhaya Chandran @ 2024-10-22 20:29 UTC (permalink / raw)
To: devel
The current time delay in the SCT GetStatus_Func test is 5 milliseconds, which caused false positives with some platforms
This time delay is increased to 500 miliseconds with reference to
similar values in https://github.com/tianocore/edk2/blob/master/NetworkPkg/Include/Library/NetLib.h#L265
Signed-off-by: G Edhaya Chandran <edhaya.chandran@arm.com>
Co-authored-by: Sunny Wang <sunny.wang@arm.com>
---
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestFunction.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestFunction.c
index 31c3590cd620..c077bfb29e52 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestFunction.c
@@ -1870,7 +1870,7 @@ BBTestGetStatusFunctionTest (
StatCode = gtBS->SetTimer (
TimeoutEvent,
TimerRelative,
- 50000); /* 5 milliseconds */
+ 5000000); /* 500 milliseconds. This value is increased from old value 5 milliseconds to due false positives on some platforms */
if (EFI_ERROR(StatCode)) {
StandardLib->RecordAssertion (
StandardLib,
@@ -2196,7 +2196,7 @@ BBTestTransmitFunctionTest (
StatCode = gtBS->SetTimer (
TimeoutEvent,
TimerRelative,
- 50000); /* 5 milliseconds */
+ 5000000); /* 500 milliseconds. This value is increased from old value 5 milliseconds to due false positives on some platforms */
if (EFI_ERROR(StatCode)) {
StandardLib->RecordAssertion (
StandardLib,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-22 20:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-22 20:29 [edk2-devel] [PATCH v1 0/1] *** SUBJECT HERE *** G Edhaya Chandran
2024-10-22 20:29 ` [edk2-devel] [PATCH v1 1/1] edk2-test: uefi-sct Increase the waiting time in the SCT GetStatus_Func test G Edhaya Chandran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox