public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "G Edhaya Chandran" <edhaya.chandran@arm.com>
To: devel@edk2.groups.io
Subject: [edk2-devel] [PATCH v2 1/1] edk2-test: uefi-sct Increase the waiting time in the SCT GetStatus_Func test
Date: Wed, 23 Oct 2024 03:24:59 +0530	[thread overview]
Message-ID: <20241022215459.3524736-1-edhaya.chandran@arm.com> (raw)

The current time delay in the SCT GetStatus_Func test is 5 milliseconds, which caused false positives with some platforms
This time delay is increased to 500 miliseconds with reference to
similar values in https://github.com/tianocore/edk2/blob/master/NetworkPkg/Include/Library/NetLib.h#L265

Signed-off-by: G Edhaya Chandran <edhaya.chandran@arm.com>
Co-authored-by: Sunny Wang <sunny.wang@arm.com>
---
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestFunction.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestFunction.c
index 31c3590cd620..c077bfb29e52 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleNetwork/BlackBoxTest/SimpleNetworkBBTestFunction.c
@@ -1870,7 +1870,7 @@ BBTestGetStatusFunctionTest (
     StatCode = gtBS->SetTimer (
                        TimeoutEvent,
                        TimerRelative,
-                       50000);  /* 5 milliseconds */
+                       5000000);  /* 500 milliseconds. This value is increased from old value 5 milliseconds to due false positives on some platforms */
     if (EFI_ERROR(StatCode)) {
       StandardLib->RecordAssertion (
                      StandardLib,
@@ -2196,7 +2196,7 @@ BBTestTransmitFunctionTest (
     StatCode = gtBS->SetTimer (
         TimeoutEvent,
         TimerRelative,
-        50000);  /* 5 milliseconds */
+        5000000);  /* 500 milliseconds. This value is increased from old value 5 milliseconds to due false positives on some platforms */
     if (EFI_ERROR(StatCode)) {
       StandardLib->RecordAssertion (
                      StandardLib,
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120655): https://edk2.groups.io/g/devel/message/120655
Mute This Topic: https://groups.io/mt/109160778/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



             reply	other threads:[~2024-10-22 21:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-22 21:54 G Edhaya Chandran [this message]
2024-10-23 14:42 ` [edk2-devel] [PATCH v2 1/1] edk2-test: uefi-sct Increase the waiting time in the SCT GetStatus_Func test Sunny Wang
2024-11-07 20:12 ` G Edhaya Chandran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241022215459.3524736-1-edhaya.chandran@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox