From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id A22E4941005 for ; Wed, 23 Oct 2024 03:36:49 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=tDXC0bWPfYV5bjvT4U/Pi6WcP1Oxz6VByF5mMgblOhQ=; c=relaxed/simple; d=groups.io; h=From:To:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240830; t=1729654609; v=1; x=1729913807; b=NBwFx6MHEaCCSIDD+MEmJ1kDPJRtemK0YKO91zERs02Lssh8OH4QC+JBROsh7KC5HHVC4Uy6 041C4Z3c6Rh8OKFaa4vekbrdvsXpzznSAkAY91r13jRqqLr2t+Ql6PLzP9vfTdOrQxhagjM5FL9 0PpJ+RHXH8EAGmL22/QUo8Tr6bjxUrWlfNi605sfJWONZxmE+wd19kVdr0taNdJ+QVCBD7vrYBv 8r95GYKLPYMSQXETuvW7icfYjzjI50KzAy5BXZoDaqaXhvm/AZ9DmM115bGwG86dzF1Vf9KHh4R eRbj18THgY3ruJtXRle+XgALOrbHlRJNs+6q3aEOmFoeQ== X-Received: by 127.0.0.2 with SMTP id uNtCYY7687511xQla6hsKRmB; Tue, 22 Oct 2024 20:36:47 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.903.1729654606773863002 for ; Tue, 22 Oct 2024 20:36:47 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B7E5F339 for ; Tue, 22 Oct 2024 20:37:15 -0700 (PDT) X-Received: from a076520.blr.arm.com (a076520.arm.com [10.162.2.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3ABED3F73B for ; Tue, 22 Oct 2024 20:36:44 -0700 (PDT) From: "G Edhaya Chandran" To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH v2 2/2] edk2-test: uefi-sct: Correct the vlanId check in DevicePath Test Date: Wed, 23 Oct 2024 09:06:42 +0530 Message-Id: <20241023033642.3556349-1-edhaya.chandran@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 22 Oct 2024 20:36:47 -0700 Resent-From: edhaya.chandran@arm.com Reply-To: devel@edk2.groups.io,edhaya.chandran@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: EF8GNlDkhbLUdQ2mZVCU9OQYx7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=NBwFx6MH; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io The DevicePathBBTest wrongly flags the failure for a valid VLAN device path node. For e.g. value 4040 The range check for vlanId is corrected to fix this issue. https://bugzilla.tianocore.org/show_bug.cgi?id=3D4710 Signed-off-by: G Edhaya Chandran --- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DeviceP= athBBTestFunction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBox= Test/DevicePathBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protoco= l/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c index c8757e958a22..21c286ea4096 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/De= vicePathBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/De= vicePathBBTestFunction.c @@ -682,7 +682,7 @@ BBTestDevicePathNodeConformanceAutoTest ( //=0D else if ((Type =3D=3D 3) && (SubType =3D=3D 20)) {=0D Vlan =3D (VLAN_DEVICE_PATH *) DevicePath;=0D - if (Vlan->VlanId > 4094 || Vlan->VlanId) {=0D + if (Vlan->VlanId > 4094) {=0D AssertionType =3D EFI_TEST_ASSERTION_FAILED;=0D } else {=0D AssertionType =3D EFI_TEST_ASSERTION_PASSED;=0D --=20 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120661): https://edk2.groups.io/g/devel/message/120661 Mute This Topic: https://groups.io/mt/109165242/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-