From: "G Edhaya Chandran" <edhaya.chandran@arm.com>
To: devel@edk2.groups.io
Subject: [edk2-devel] [PATCH v3 1/1] edk2-test: uefi-sct: Correct the vlanId check in DevicePath Test
Date: Fri, 8 Nov 2024 02:16:33 +0530 [thread overview]
Message-ID: <20241107204633.164804-1-edhaya.chandran@arm.com> (raw)
The DevicePathBBTest wrongly flags the failure for a valid VLAN device
path node. For e.g. value 4040
The range check for vlanId is corrected to fix this issue.
https://bugzilla.tianocore.org/show_bug.cgi?id=4710
Signed-off-by: G Edhaya Chandran <edhaya.chandran@arm.com>
---
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c
index c8757e958a22..dbf39b77dd01 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c
@@ -682,7 +682,7 @@ BBTestDevicePathNodeConformanceAutoTest (
//
else if ((Type == 3) && (SubType == 20)) {
Vlan = (VLAN_DEVICE_PATH *) DevicePath;
- if (Vlan->VlanId > 4094 || Vlan->VlanId) {
+ if (Vlan->VlanId > 4094 || Vlan->VlanId < 1) {
AssertionType = EFI_TEST_ASSERTION_FAILED;
} else {
AssertionType = EFI_TEST_ASSERTION_PASSED;
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120757): https://edk2.groups.io/g/devel/message/120757
Mute This Topic: https://groups.io/mt/109452250/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
reply other threads:[~2024-11-07 20:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107204633.164804-1-edhaya.chandran@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox