From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id A6D0D7803CF for ; Thu, 7 Nov 2024 20:46:40 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=S0JQc8IO4xtIwE7h2nU2TdwZypfLnNPm++fPg5sINak=; c=relaxed/simple; d=groups.io; h=From:To:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240830; t=1731012400; v=1; x=1731271598; b=F3c8VNoON3xNThZ6FvuTWF8jmzSP+hBsUTBE9F2et9KhFLJPc56TQZst++zAYjpHN3XeUDA+ vfdGdl/6os6rxlyvBqyhwRgj1+zfVpOeWpRSKfgik5BhkqFzz9jBEjOHcVmfNFXEs82ZPTBukLz bN3DAT3rncaA2Z+Qz2Mcsko50OF7nlRlquuKebiTw8cCrS7A8pNQY2BBzyBOjVseDEeymc2vpJp g3SYXn9jhnU35MyCahMDXhTLKcOYmEU2a6uViRwjXW3Xse14znSkMp28Ebo75H17ZZXbGlH2t7r Bd1WuVp4smOZz5LHSEzXbcXuZs+8pLCAmN+2v4r3cCo+Q== X-Received: by 127.0.0.2 with SMTP id iMYcYY7687511xyDqXv19UWt; Thu, 07 Nov 2024 12:46:38 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.2987.1731012398029349561 for ; Thu, 07 Nov 2024 12:46:38 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E5BC5497 for ; Thu, 7 Nov 2024 12:47:06 -0800 (PST) X-Received: from a076520.blr.arm.com (a076520.arm.com [10.162.2.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4C5BE3F528 for ; Thu, 7 Nov 2024 12:46:36 -0800 (PST) From: "G Edhaya Chandran" To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH v3 1/1] edk2-test: uefi-sct: Correct the vlanId check in DevicePath Test Date: Fri, 8 Nov 2024 02:16:33 +0530 Message-Id: <20241107204633.164804-1-edhaya.chandran@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 07 Nov 2024 12:46:38 -0800 Resent-From: edhaya.chandran@arm.com Reply-To: devel@edk2.groups.io,edhaya.chandran@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: QKZEz5OzCzJqI7WKWH2gG0AOx7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=F3c8VNoO; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io The DevicePathBBTest wrongly flags the failure for a valid VLAN device path node. For e.g. value 4040 The range check for vlanId is corrected to fix this issue. https://bugzilla.tianocore.org/show_bug.cgi?id=3D4710 Signed-off-by: G Edhaya Chandran --- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DeviceP= athBBTestFunction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBox= Test/DevicePathBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protoco= l/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c index c8757e958a22..dbf39b77dd01 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/De= vicePathBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/De= vicePathBBTestFunction.c @@ -682,7 +682,7 @@ BBTestDevicePathNodeConformanceAutoTest ( //=0D else if ((Type =3D=3D 3) && (SubType =3D=3D 20)) {=0D Vlan =3D (VLAN_DEVICE_PATH *) DevicePath;=0D - if (Vlan->VlanId > 4094 || Vlan->VlanId) {=0D + if (Vlan->VlanId > 4094 || Vlan->VlanId < 1) {=0D AssertionType =3D EFI_TEST_ASSERTION_FAILED;=0D } else {=0D AssertionType =3D EFI_TEST_ASSERTION_PASSED;=0D --=20 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120757): https://edk2.groups.io/g/devel/message/120757 Mute This Topic: https://groups.io/mt/109452250/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-