* [edk2-devel] [PATCH v3 1/1] edk2-test: uefi-sct: Correct the vlanId check in DevicePath Test
@ 2024-11-07 20:46 G Edhaya Chandran
0 siblings, 0 replies; only message in thread
From: G Edhaya Chandran @ 2024-11-07 20:46 UTC (permalink / raw)
To: devel
The DevicePathBBTest wrongly flags the failure for a valid VLAN device
path node. For e.g. value 4040
The range check for vlanId is corrected to fix this issue.
https://bugzilla.tianocore.org/show_bug.cgi?id=4710
Signed-off-by: G Edhaya Chandran <edhaya.chandran@arm.com>
---
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c
index c8757e958a22..dbf39b77dd01 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c
@@ -682,7 +682,7 @@ BBTestDevicePathNodeConformanceAutoTest (
//
else if ((Type == 3) && (SubType == 20)) {
Vlan = (VLAN_DEVICE_PATH *) DevicePath;
- if (Vlan->VlanId > 4094 || Vlan->VlanId) {
+ if (Vlan->VlanId > 4094 || Vlan->VlanId < 1) {
AssertionType = EFI_TEST_ASSERTION_FAILED;
} else {
AssertionType = EFI_TEST_ASSERTION_PASSED;
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120757): https://edk2.groups.io/g/devel/message/120757
Mute This Topic: https://groups.io/mt/109452250/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2024-11-07 20:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-07 20:46 [edk2-devel] [PATCH v3 1/1] edk2-test: uefi-sct: Correct the vlanId check in DevicePath Test G Edhaya Chandran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox