* Re: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: ExtractConfig allows EFI_ACCESS_DENIED with a warning
2024-11-15 14:18 ` [edk2-devel] [PATCH v1 1/1] " Ann Cheng via groups.io
@ 2024-11-18 16:59 ` G Edhaya Chandran via groups.io
2024-12-17 19:16 ` G Edhaya Chandran via groups.io
2024-11-20 16:15 ` Sunny Wang via groups.io
1 sibling, 1 reply; 5+ messages in thread
From: G Edhaya Chandran via groups.io @ 2024-11-18 16:59 UTC (permalink / raw)
To: Ann Cheng, devel@edk2.groups.io; +Cc: Barton Gao, Carolyn Gjertsen
Reviewed-by: G Edhaya Chandran <edhaya.chandran@arm.com>
The changes are reviewed OK.
Thank you, Ann for the solution.
With Warm Regards,
Edhay
> -----Original Message-----
> From: Ann Cheng <Ann.Cheng@arm.com>
> Sent: 15 November 2024 08:19
> To: devel@edk2.groups.io
> Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao
> <gaojie@byosoft.com.cn>; Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>
> Subject: [PATCH v1 1/1] uefi-sct/SctPkg: ExtractConfig allows
> EFI_ACCESS_DENIED with a warning
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4847
>
> EFI_ACCESS_DENIED (The action violated a system policy) is an acceptable
> status for ExtractConfig in UEFI specification.
>
> SCT now marks the test case as a warning instead of failure, when
> EFI_ACCESS_DENIED is returned.
>
> Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>
> Cc: Barton Gao <gaojie@byosoft.com.cn>
> Cc: Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>
> Signed-off-by: Ann Cheng <ann.cheng@arm.com>
> ---
> uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfi
> gAccessBBTestFunction.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfi
> gAccessBBTestFunction.c b/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfi
> gAccessBBTestFunction.c
> index fedccb382f81..b1419bed36dc 100644
> --- a/uefi-
> sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfi
> gAccessBBTestFunction.c
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBo
> +++ xTest/HIIConfigAccessBBTestFunction.c
> @@ -328,8 +328,8 @@ BBTestExtractConfigFunctionTestCheckpoint1 (
> } else {
> gtBS->FreePool (Results);
> }
> - } else if (EFI_OUT_OF_RESOURCES == Status) {
> - AssertionType = EFI_TEST_ASSERTION_WARNING;
> + } else if ( (EFI_OUT_OF_RESOURCES == Status) || (EFI_ACCESS_DENIED ==
> Status) ) {
> + AssertionType = EFI_TEST_ASSERTION_WARNING;
> }else {
> AssertionType = EFI_TEST_ASSERTION_FAILED;
> }
> @@ -385,7 +385,7 @@ BBTestExtractConfigFunctionTestCheckpoint1 (
> }
> gtBS->FreePool (Results);
> }
> - } else if (EFI_OUT_OF_RESOURCES == Status) {
> + } else if ( (EFI_OUT_OF_RESOURCES == Status) || (EFI_ACCESS_DENIED ==
> + Status) ) {
> AssertionType = EFI_TEST_ASSERTION_WARNING;
> }else {
> AssertionType = EFI_TEST_ASSERTION_FAILED; @@ -445,7 +445,7 @@
> BBTestExtractConfigFunctionTestCheckpoint2 (
> &Results
> );
>
> - if (EFI_OUT_OF_RESOURCES == Status) {
> + if ( (EFI_OUT_OF_RESOURCES == Status) || (EFI_ACCESS_DENIED ==
> + Status) ) {
> AssertionType = EFI_TEST_ASSERTION_WARNING;
> } else if ((EFI_NOT_FOUND == Status) && (Progress == NULL) && (Results ==
> NULL)) {
> AssertionType = EFI_TEST_ASSERTION_PASSED;
> --
> 2.34.1
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120784): https://edk2.groups.io/g/devel/message/120784
Mute This Topic: https://groups.io/mt/109648112/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: ExtractConfig allows EFI_ACCESS_DENIED with a warning
2024-11-15 14:18 ` [edk2-devel] [PATCH v1 1/1] " Ann Cheng via groups.io
2024-11-18 16:59 ` G Edhaya Chandran via groups.io
@ 2024-11-20 16:15 ` Sunny Wang via groups.io
1 sibling, 0 replies; 5+ messages in thread
From: Sunny Wang via groups.io @ 2024-11-20 16:15 UTC (permalink / raw)
To: devel@edk2.groups.io, Ann Cheng
Cc: G Edhaya Chandran, Barton Gao, Carolyn Gjertsen, Sunny Wang
Looks good to me. Thanks for fixing this, Ann.
Reviewed-by: Sunny Wang <sunny.wang@arm.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ann Cheng via groups.io
Sent: Friday, November 15, 2024 8:19 AM
To: devel@edk2.groups.io
Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>
Subject: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: ExtractConfig allows EFI_ACCESS_DENIED with a warning
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4847
EFI_ACCESS_DENIED (The action violated a system policy)
is an acceptable status for ExtractConfig in UEFI specification.
SCT now marks the test case as a warning instead of failure,
when EFI_ACCESS_DENIED is returned.
Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>
Cc: Barton Gao <gaojie@byosoft.com.cn>
Cc: Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>
Signed-off-by: Ann Cheng <ann.cheng@arm.com>
---
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestFunction.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestFunction.c
index fedccb382f81..b1419bed36dc 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestFunction.c
@@ -328,8 +328,8 @@ BBTestExtractConfigFunctionTestCheckpoint1 (
} else {
gtBS->FreePool (Results);
}
- } else if (EFI_OUT_OF_RESOURCES == Status) {
- AssertionType = EFI_TEST_ASSERTION_WARNING;
+ } else if ( (EFI_OUT_OF_RESOURCES == Status) || (EFI_ACCESS_DENIED == Status) ) {
+ AssertionType = EFI_TEST_ASSERTION_WARNING;
}else {
AssertionType = EFI_TEST_ASSERTION_FAILED;
}
@@ -385,7 +385,7 @@ BBTestExtractConfigFunctionTestCheckpoint1 (
}
gtBS->FreePool (Results);
}
- } else if (EFI_OUT_OF_RESOURCES == Status) {
+ } else if ( (EFI_OUT_OF_RESOURCES == Status) || (EFI_ACCESS_DENIED == Status) ) {
AssertionType = EFI_TEST_ASSERTION_WARNING;
}else {
AssertionType = EFI_TEST_ASSERTION_FAILED;
@@ -445,7 +445,7 @@ BBTestExtractConfigFunctionTestCheckpoint2 (
&Results
);
- if (EFI_OUT_OF_RESOURCES == Status) {
+ if ( (EFI_OUT_OF_RESOURCES == Status) || (EFI_ACCESS_DENIED == Status) ) {
AssertionType = EFI_TEST_ASSERTION_WARNING;
} else if ((EFI_NOT_FOUND == Status) && (Progress == NULL) && (Results == NULL)) {
AssertionType = EFI_TEST_ASSERTION_PASSED;
--
2.34.1
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120806): https://edk2.groups.io/g/devel/message/120806
Mute This Topic: https://groups.io/mt/109648112/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 5+ messages in thread