* [edk2-devel] [PATCH v1 0/1] *** Add BaseRiscVFpuLib.inf in SG2042.dsc ***
@ 2024-11-15 2:36 DennisDing2003 via groups.io
0 siblings, 0 replies; 4+ messages in thread
From: DennisDing2003 via groups.io @ 2024-11-15 2:36 UTC (permalink / raw)
To: devel; +Cc: dahogn, caiyuqing379, meng-cz, USER0FISH
*** BLURB HERE ***
DennisDing2003 (1):
Add BaseRiscVFpuLib.inf in SG2042.dsc it is necessary to build
SG2042.fv
Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc | 1 +
1 file changed, 1 insertion(+)
Cc: dahogn <dahogn@hotmail.com>
Cc: caiyuqing379 <caiyuqing_hz@outlook.com>
Cc: meng-cz <mengcz1126@gmail.com>
Cc: USER0FISH <libing1202@outlook.com>
Signed-off-by: DennisDing2003 <18669755080@163.com>
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
--
2.47.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [edk2-devel] [PATCH v1 0/1] *** Add BaseRiscVFpuLib.inf in SG2042.dsc ***
@ 2024-11-18 15:20 DennisDing2003 via groups.io
2024-11-18 15:20 ` [edk2-devel] [PATCH v1 1/1] Add BaseRiscVFpuLib.inf in SG2042.dsc it is necessary to build SG2042.fv DennisDing2003 via groups.io
0 siblings, 1 reply; 4+ messages in thread
From: DennisDing2003 via groups.io @ 2024-11-18 15:20 UTC (permalink / raw)
To: devel; +Cc: dahogn, caiyuqing379, meng-cz, USER0FISH
*** BLURB HERE ***
DennisDing2003 (1):
Add BaseRiscVFpuLib.inf in SG2042.dsc it is necessary to build
SG2042.fv
Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc | 1 +
1 file changed, 1 insertion(+)
Cc: dahogn <dahogn@hotmail.com>
Cc: caiyuqing379 <caiyuqing_hz@outlook.com>
Cc: meng-cz <mengcz1126@gmail.com>
Cc: USER0FISH <libing1202@outlook.com>
Signed-off-by: DennisDing2003 <blacktang482@gmail.com>
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
--
2.47.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [edk2-devel] [PATCH v1 1/1] Add BaseRiscVFpuLib.inf in SG2042.dsc it is necessary to build SG2042.fv
2024-11-18 15:20 [edk2-devel] [PATCH v1 0/1] *** Add BaseRiscVFpuLib.inf in SG2042.dsc *** DennisDing2003 via groups.io
@ 2024-11-18 15:20 ` DennisDing2003 via groups.io
2024-11-19 4:05 ` Sunil V L
0 siblings, 1 reply; 4+ messages in thread
From: DennisDing2003 via groups.io @ 2024-11-18 15:20 UTC (permalink / raw)
To: devel; +Cc: dahogn, caiyuqing379, meng-cz, USER0FISH
Cc: dahogn <dahogn@hotmail.com>
Cc: caiyuqing379 <caiyuqing_hz@outlook.com>
Cc: meng-cz <mengcz1126@gmail.com>
Cc: USER0FISH <libing1202@outlook.com>
Signed-off-by: DennisDing2003 <blacktang482@gmail.com>
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
---
Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
index 8825c8233ba2..6773868aa7df 100644
--- a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
+++ b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
@@ -144,6 +144,7 @@ [LibraryClasses.common]
# RISC-V Architectural Libraries
RiscVSbiLib|MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.inf
+ RiscVFpuLib|UefiCpuPkg/Library/BaseRiscVFpuLib/BaseRiscVFpuLib.inf
RiscVMmuLib|UefiCpuPkg/Library/BaseRiscVMmuLib/BaseRiscVMmuLib.inf
CpuExceptionHandlerLib|UefiCpuPkg/Library/BaseRiscV64CpuExceptionHandlerLib/BaseRiscV64CpuExceptionHandlerLib.inf
--
2.47.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] Add BaseRiscVFpuLib.inf in SG2042.dsc it is necessary to build SG2042.fv
2024-11-18 15:20 ` [edk2-devel] [PATCH v1 1/1] Add BaseRiscVFpuLib.inf in SG2042.dsc it is necessary to build SG2042.fv DennisDing2003 via groups.io
@ 2024-11-19 4:05 ` Sunil V L
0 siblings, 0 replies; 4+ messages in thread
From: Sunil V L @ 2024-11-19 4:05 UTC (permalink / raw)
To: devel, blacktang482; +Cc: dahogn, caiyuqing379, meng-cz, USER0FISH
Hi,
On Mon, Nov 18, 2024 at 11:20:21PM +0800, DennisDing2003 via groups.io wrote:
> Cc: dahogn <dahogn@hotmail.com>
> Cc: caiyuqing379 <caiyuqing_hz@outlook.com>
> Cc: meng-cz <mengcz1126@gmail.com>
> Cc: USER0FISH <libing1202@outlook.com>
> Signed-off-by: DennisDing2003 <blacktang482@gmail.com>
> Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
Please add this tag only after some reviewer actually gives this. In
this case, I didn't review it before this.
Anyway, the change looks good. Please raise a github PR.
Thanks,
Sunil
> ---
> Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
> index 8825c8233ba2..6773868aa7df 100644
> --- a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
> +++ b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
> @@ -144,6 +144,7 @@ [LibraryClasses.common]
>
> # RISC-V Architectural Libraries
> RiscVSbiLib|MdePkg/Library/BaseRiscVSbiLib/BaseRiscVSbiLib.inf
> + RiscVFpuLib|UefiCpuPkg/Library/BaseRiscVFpuLib/BaseRiscVFpuLib.inf
> RiscVMmuLib|UefiCpuPkg/Library/BaseRiscVMmuLib/BaseRiscVMmuLib.inf
> CpuExceptionHandlerLib|UefiCpuPkg/Library/BaseRiscV64CpuExceptionHandlerLib/BaseRiscV64CpuExceptionHandlerLib.inf
>
> --
> 2.47.0
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120799): https://edk2.groups.io/g/devel/message/120799
Mute This Topic: https://groups.io/mt/109651227/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-11-19 4:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-18 15:20 [edk2-devel] [PATCH v1 0/1] *** Add BaseRiscVFpuLib.inf in SG2042.dsc *** DennisDing2003 via groups.io
2024-11-18 15:20 ` [edk2-devel] [PATCH v1 1/1] Add BaseRiscVFpuLib.inf in SG2042.dsc it is necessary to build SG2042.fv DennisDing2003 via groups.io
2024-11-19 4:05 ` Sunil V L
-- strict thread matches above, loose matches on Subject: below --
2024-11-15 2:36 [edk2-devel] [PATCH v1 0/1] *** Add BaseRiscVFpuLib.inf in SG2042.dsc *** DennisDing2003 via groups.io
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox