Re: [edk2-devel] [RFC PATCH edk2-platforms v4 0/1] add basic support for CXL on sbsa-ref

["Jonathan Cameron via groups.io" <jonathan.cameron=huawei.com@groups.io>]

On Wed, 18 Dec 2024 11:23:53 +0800
"Yuquan Wang" <wangyuquan1236@phytium.com.cn> wrote:

> On Thu, Dec 12, 2024 at 11:51:54AM +0800, Yuquan Wang wrote:
> > On Wed, Dec 11, 2024 at 03:40:03PM +0000, Alejandro Lucero Palau wrote:  
> > > 
> > > On 12/10/24 10:36, Yuquan Wang wrote:  
> > > > v3 -> v4:
> > > > - Align base addresses of CXL relevant Windows
> > > > 
> > > > v2 -> v3:
> > > > - PCDs values of pio, mmio32, mmio64 & ecam space for the independent cxl host
> > > > - CXL Bus range: 0x00 ~ 0xff
> > > > - Mcfg ecam structure for cxl
> > > > - Iort RC node for cxl
> > > > 
> > > > RFC because
> > > > - Many contents are ported from Jonathan' patch on qemu virt design
> > > > 
> > > > - Bring plenty of PCDs values
> > > > 
> > > > - Less experience and not particularly confident in ACPI area
> > > > 
> > > > This series leverages Jonathan's patches[1] to add acpi0016 & acpi0017 objects into the
> > > > previous DSDT table of sbsa-ref. Since my latest acpi0016 implementation model on qemu
> > > > side is a new host bridge qemu object rather than pxb-cxl, the cxl host(Segment 0001)
> > > > would have its own ECAM sapce. Meanwhile, this adds exclusive pio, mmio32 & mmio64 space
> > > > for cxl host.  
> > > 
> > > 
> > > Hi Yuquan,
> > > 
> > > 
> > > Is there a roadmap for edk2 supporting other CXL features?
> > >   
> > Hi, Alejandro
> > 
> > Emmm. I have not find such edk2 roadmap (docs/webs/blog) yet. According to
> > what I've learnd, the edk2 upstream only support some head files which
> > define cxl registers structs and no cxl drivers have merged into upstream
> > now, and mostly system software's work haved been done in linux kernel.
> > 
> > Regard to cxl patches in edk2, there is a series of patches in reviewing to
> > support enabling cxl-type3 device as memory expander on Arm/RD platform[1].
> > 
> > Link:
> > [1]: https://edk2.groups.io/g/devel/message/109488  
> > > 
> > > I have noticed UEFI extensions are not supported yet, specifically
> > > EFI_ADAPTER_INFO_CDAT_TYPE_GUID as an instance of
> > > EFI_ADAPTER_INFORMATION_PROTOCOL.
> > > 
> > > 
> > > Any feedback would be welcome.
> > > 
> > > 
> > > Thanks
> > > 
> > >   
> >  
> Hi, Jonathan & Ben
> 
> Recently I am trying to test EINJ for cxl error on sbsa-ref based on Ben
> Cheatham's patches, but there seems no sample for cxl EINJ table in edk2.
> Hence, I manage to write the EINJ table by what I have learnd in ACPI
> SPEC, but I am struggling with which error injection actions need me to
> build.
> 
> Do you know some limitations on this mechanism in QEMU or any suggestions?
Sorry no idea.

For error injection I've always focused on doing it from QEMU, not in firmware
and on arm/virt not sbsa-ref so I have complete control of the ACPI tables.

Not sure what's needed to make the EDK2 / SBSAref version work.

Jonathan

> 
> Many thanks
> Yuquan
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120934): https://edk2.groups.io/g/devel/message/120934
Mute This Topic: https://groups.io/mt/110023229/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-