* [edk2-devel] [RFC PATCH edk2-platforms v4 0/1] add basic support for CXL on sbsa-ref
@ 2024-12-10 10:36 Yuquan Wang
2024-12-10 10:36 ` [edk2-devel] [RFC PATCH edk2-platforms v4 1/1] SbsaQemu: Support basic CXL enablement Yuquan Wang
2024-12-11 15:40 ` [edk2-devel] [RFC PATCH edk2-platforms v4 0/1] add basic support for CXL on sbsa-ref Alejandro Lucero Palau via groups.io
0 siblings, 2 replies; 6+ messages in thread
From: Yuquan Wang @ 2024-12-10 10:36 UTC (permalink / raw)
To: marcin.juszkiewicz, ardb+tianocore, quic_llindhol
Cc: Jonathan.Cameron, chenbaozi, devel, linux-cxl, Yuquan Wang
v3 -> v4:
- Align base addresses of CXL relevant Windows
v2 -> v3:
- PCDs values of pio, mmio32, mmio64 & ecam space for the independent cxl host
- CXL Bus range: 0x00 ~ 0xff
- Mcfg ecam structure for cxl
- Iort RC node for cxl
RFC because
- Many contents are ported from Jonathan' patch on qemu virt design
- Bring plenty of PCDs values
- Less experience and not particularly confident in ACPI area
This series leverages Jonathan's patches[1] to add acpi0016 & acpi0017 objects into the
previous DSDT table of sbsa-ref. Since my latest acpi0016 implementation model on qemu
side is a new host bridge qemu object rather than pxb-cxl, the cxl host(Segment 0001)
would have its own ECAM sapce. Meanwhile, this adds exclusive pio, mmio32 & mmio64 space
for cxl host.
As sbsa-ref cxl host has its own ecam space, this defines the bus range of cxl host from
0x0 to 0xff. Therefore, this adds relevant BASE_ADDRESS_ALLOCATION_STRUCTURE for cxl in Mcfg.
And to enable msi of cxl components, this add a new RC node in Iort.
Based on the new CEDT definitions patch on edk2[2], this series adds a static Cedt.aslc to
support the [SBSA_CXL_CHBCR] & [SBSA_CXL_FIXED_WINDOW] space on sbsa-ref.
Link:
[1]: https://lore.kernel.org/linux-cxl/20220616141950.23374-2-Jonathan.Cameron@huawei.com/
[2]: https://edk2.groups.io/g/devel/message/120851
Below are the new result of acpi tables (the DSDT contents could see the patch itself):
1) MCFG
[000h 0000 004h] Signature : "MCFG" [Memory Mapped Configuration Table]
[004h 0004 004h] Table Length : 0000004C
[008h 0008 001h] Revision : 01
[009h 0009 001h] Checksum : 1E
[00Ah 0010 006h] Oem ID : "LINARO"
[010h 0016 008h] Oem Table ID : "SBSAQEMU"
[018h 0024 004h] Oem Revision : 20240625
[01Ch 0028 004h] Asl Compiler ID : "LNRO"
[020h 0032 004h] Asl Compiler Revision : 00000001
[024h 0036 008h] Reserved : 0000000000000000
[02Ch 0044 008h] Base Address : 00000000F0000000
[034h 0052 002h] Segment Group Number : 0000
[036h 0054 001h] Start Bus Number : 00
[037h 0055 001h] End Bus Number : FF
[038h 0056 004h] Reserved : 00000000
[03Ch 0060 008h] Base Address : 0000000068500000
[044h 0068 002h] Segment Group Number : 0001
[046h 0070 001h] Start Bus Number : 00
[047h 0071 001h] End Bus Number : FF
[048h 0072 004h] Reserved : 00000000
2) IORT
[000h 0000 004h] Signature : "IORT" [IO Remapping Table]
[004h 0004 004h] Table Length : 00000118
[008h 0008 001h] Revision : 06
[009h 0009 001h] Checksum : D3
[00Ah 0010 006h] Oem ID : "LINARO"
[010h 0016 008h] Oem Table ID : "SBSAQEMU"
[018h 0024 004h] Oem Revision : 20240625
[01Ch 0028 004h] Asl Compiler ID : "LNRO"
[020h 0032 004h] Asl Compiler Revision : 00000001
[024h 0036 004h] Node Count : 00000004
[028h 0040 004h] Node Offset : 00000030
[02Ch 0044 004h] Reserved : 00000000
[030h 0048 001h] Type : 00
[031h 0049 002h] Length : 0018
[033h 0051 001h] Revision : 00
[034h 0052 004h] Identifier : 00000000
[038h 0056 004h] Mapping Count : 00000000
[03Ch 0060 004h] Mapping Offset : 00000000
[040h 0064 004h] ItsCount : 00000001
[044h 0068 004h] Identifiers : 00000000
[048h 0072 001h] Type : 04
[049h 0073 002h] Length : 0058
[04Bh 0075 001h] Revision : 05
[04Ch 0076 004h] Identifier : 00000000
[050h 0080 004h] Mapping Count : 00000001
[054h 0084 004h] Mapping Offset : 00000044
[058h 0088 008h] Base Address : 0000000060050000
[060h 0096 004h] Flags (decoded below) : 00000001
COHACC Override : 1
HTTU Override : 0
Proximity Domain Valid : 0
DeviceID Valid : 0
[064h 0100 004h] Reserved : 00000000
[068h 0104 008h] VATOS Address : 0000000000000000
[070h 0112 004h] Model : 00000000
[074h 0116 004h] Event GSIV : 0000004A
[078h 0120 004h] PRI GSIV : 0000004B
[07Ch 0124 004h] GERR GSIV : 0000004D
[080h 0128 004h] Sync GSIV : 0000004C
[084h 0132 004h] Proximity Domain : 00000000
[088h 0136 004h] Device ID Mapping Index : 00000001
[08Ch 0140 004h] Input base : 00000000
[090h 0144 004h] ID Count : 0000FFFF
[094h 0148 004h] Output Base : 00000000
[098h 0152 004h] Output Reference : 00000030
[09Ch 0156 004h] Flags (decoded below) : 00000000
Single Mapping : 0
[0A0h 0160 001h] Type : 02
[0A1h 0161 002h] Length : 003C
[0A3h 0163 001h] Revision : 00
[0A4h 0164 004h] Identifier : 00000000
[0A8h 0168 004h] Mapping Count : 00000001
[0ACh 0172 004h] Mapping Offset : 00000028
[0B0h 0176 008h] Memory Properties : [IORT Memory Access Properties]
[0B0h 0176 004h] Cache Coherency : 00000001
[0B4h 0180 001h] Hints (decoded below) : 00
Transient : 0
Write Allocate : 0
Read Allocate : 0
Override : 0
[0B5h 0181 002h] Reserved : 0000
[0B7h 0183 001h] Memory Flags (decoded below) : 01
Coherency : 1
Device Attribute : 0
Ensured Coherency of Accesses : 0
[0B8h 0184 004h] ATS Attribute : 00000000
[0BCh 0188 004h] PCI Segment Number : 00000000
[0C0h 0192 001h] Memory Size Limit : 00
[0C1h 0193 002h] PASID Capabilities : 0000
[0C3h 0195 001h] Reserved : 00
[0C8h 0200 004h] Input base : 00000000
[0CCh 0204 004h] ID Count : 0000FFFF
[0D0h 0208 004h] Output Base : 00000000
[0D4h 0212 004h] Output Reference : 00000048
[0D8h 0216 004h] Flags (decoded below) : 00000000
Single Mapping : 0
[0DCh 0220 001h] Type : 02
[0DDh 0221 002h] Length : 003C
[0DFh 0223 001h] Revision : 00
[0E0h 0224 004h] Identifier : 00000001
[0E4h 0228 004h] Mapping Count : 00000001
[0E8h 0232 004h] Mapping Offset : 00000028
[0ECh 0236 008h] Memory Properties : [IORT Memory Access Properties]
[0ECh 0236 004h] Cache Coherency : 00000001
[0F0h 0240 001h] Hints (decoded below) : 00
Transient : 0
Write Allocate : 0
Read Allocate : 0
Override : 0
[0F1h 0241 002h] Reserved : 0000
[0F3h 0243 001h] Memory Flags (decoded below) : 01
Coherency : 1
Device Attribute : 0
Ensured Coherency of Accesses : 0
[0F4h 0244 004h] ATS Attribute : 00000000
[0F8h 0248 004h] PCI Segment Number : 00000001
[0FCh 0252 001h] Memory Size Limit : 00
[0FDh 0253 002h] PASID Capabilities : 0000
[0FFh 0255 001h] Reserved : 00
[104h 0260 004h] Input base : 00000000
[108h 0264 004h] ID Count : 0000FFFF
[10Ch 0268 004h] Output Base : 00010000
[110h 0272 004h] Output Reference : 00000030
[114h 0276 004h] Flags (decoded below) : 00000000
Single Mapping : 0
3) CEDT
[000h 0000 004h] Signature : "CEDT" [CXL Early Discovery Table]
[004h 0004 004h] Table Length : 000000A8
[008h 0008 001h] Revision : 01
[009h 0009 001h] Checksum : 42
[00Ah 0010 006h] Oem ID : "LINARO"
[010h 0016 008h] Oem Table ID : "SBSAQEMU"
[018h 0024 004h] Oem Revision : 20240625
[01Ch 0028 004h] Asl Compiler ID : "LNRO"
[020h 0032 004h] Asl Compiler Revision : 00000001
[024h 0036 001h] Subtable Type : 00 [CXL Host Bridge Structure]
[025h 0037 001h] Reserved : 00
[026h 0038 002h] Length : 0020
[028h 0040 004h] Associated host bridge : 00000001
[02Ch 0044 004h] Specification version : 00000001
[030h 0048 004h] Reserved : 00000000
[034h 0052 008h] Register base : 0000000060200000
[03Ch 0060 008h] Register length : 0000000000010000
[044h 0068 001h] Subtable Type : 01 [CXL Fixed Memory Window Structure]
[045h 0069 001h] Reserved : 00
[046h 0070 002h] Length : 0064
[048h 0072 004h] Reserved : 00000000
[04Ch 0076 008h] Window base address : 00000A0000000000
[054h 0084 008h] Window size : 0000010000000000
[05Ch 0092 001h] Interleave Members : 00
[05Dh 0093 001h] Interleave Arithmetic : 00
[05Eh 0094 002h] Reserved : 0000
[060h 0096 004h] Granularity : 00000000
[064h 0100 002h] Restrictions : 000F
[066h 0102 002h] QtgId : 0001
[068h 0104 004h] First Target : 00000001
Yuquan Wang (1):
SbsaQemu: Support basic CXL enablement
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 21 ++
.../Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 24 ++
Silicon/Qemu/SbsaQemu/AcpiTables/Cedt.aslc | 69 ++++
Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 327 ++++++++++++++++++
Silicon/Qemu/SbsaQemu/AcpiTables/Mcfg.aslc | 9 +-
.../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 40 ++-
Silicon/Qemu/SbsaQemu/SbsaQemu.dec | 28 ++
7 files changed, 515 insertions(+), 3 deletions(-)
create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Cedt.aslc
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120889): https://edk2.groups.io/g/devel/message/120889
Mute This Topic: https://groups.io/mt/110023229/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 6+ messages in thread* [edk2-devel] [RFC PATCH edk2-platforms v4 1/1] SbsaQemu: Support basic CXL enablement 2024-12-10 10:36 [edk2-devel] [RFC PATCH edk2-platforms v4 0/1] add basic support for CXL on sbsa-ref Yuquan Wang @ 2024-12-10 10:36 ` Yuquan Wang 2024-12-11 15:40 ` [edk2-devel] [RFC PATCH edk2-platforms v4 0/1] add basic support for CXL on sbsa-ref Alejandro Lucero Palau via groups.io 1 sibling, 0 replies; 6+ messages in thread From: Yuquan Wang @ 2024-12-10 10:36 UTC (permalink / raw) To: marcin.juszkiewicz, ardb+tianocore, quic_llindhol Cc: Jonathan.Cameron, chenbaozi, devel, linux-cxl, Yuquan Wang This adds relevant definitions and descriptions of acpi0016, acpi0017 and CEDT to support CXL. 1) With the independent cxl host, this supplies exclusive pio, mmio32, mmio64 & ecam space descriptions for cxl host. 2) sbsa-ref cxl host has its own ecam space, so this defines the bus range of cxl host from 0x0 to 0xff. Therefore, this adds relevant structure in Mcfg. 3) To enable msi of cxl components, this add relevant descriptions in Iort. 4) Provide CXL Early Discovery Table that describes the static CXL Platform Components of sbsa-ref, which includes a static CXL Host Bridge structure and a CXL Fixed Memory Window structure. Signed-off-by: Yuquan Wang <wangyuquan1236@phytium.com.cn> --- Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 21 ++ .../Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 24 ++ Silicon/Qemu/SbsaQemu/AcpiTables/Cedt.aslc | 69 ++++ Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 327 ++++++++++++++++++ Silicon/Qemu/SbsaQemu/AcpiTables/Mcfg.aslc | 9 +- .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 40 ++- Silicon/Qemu/SbsaQemu/SbsaQemu.dec | 28 ++ 7 files changed, 515 insertions(+), 3 deletions(-) create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Cedt.aslc diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc index b2cd2529a966..e743bd30910e 100644 --- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc +++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc @@ -454,6 +454,21 @@ DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE gArmTokenSpaceGuid.PcdPciMmio64Size|0xFF00000000 gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPciMmio64Limit|0xFFFFFFFFFF + # + # CXL Host Bridge (pxb-cxl on PCI Root Complex) + # + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlBusMin|0 + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlBusMax|255 + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlIoBase|0x0 + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlIoSize|0x00010000 + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlIoLimit|0x0000ffff + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlMmio32Base|0x60400000 + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlMmio32Size|0x08000000 + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlMmio32Limit|0x683FFFFF + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlMmio64Base|0x90000000000 + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlMmio64Size|0x100000000 + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlMmio64Limit|0x900FFFFFFFF + # set PcdPciExpressBaseAddress to MAX_UINT64, which signifies that this # PCD and PcdPciDisableBusEnumeration have not been assigned yet # TODO: PcdPciExpressBaseAddress set to max_uint64 @@ -461,9 +476,15 @@ DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPciExpressBarSize|0x10000000 gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPciExpressBarLimit|0xFFFFFFFF + # PCDs complementing CXL ECAM Base & Size + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlBaseAddress|0x68500000 + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlBarSize|0x10000000 + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlBarLimit|0x784FFFFF + gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation|0x7fff0000 gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation|0x0 gEfiMdePkgTokenSpaceGuid.PcdPciMmio64Translation|0x0 + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlIoTranslation|0x60300000 ## If TRUE, OvmfPkg/AcpiPlatformDxe will not wait for PCI # enumeration to complete before installing ACPI tables. gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration|FALSE diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf b/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf index 8d4905362edc..fa1cca0ed16e 100644 --- a/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf +++ b/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf @@ -16,6 +16,7 @@ VERSION_STRING = 1.0 [Sources] + Cedt.aslc Dbg2.aslc Dsdt.asl Fadt.aslc @@ -44,6 +45,8 @@ gArmTokenSpaceGuid.PcdPciBusMin gArmTokenSpaceGuid.PcdPciBusMax + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlBusMin + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlBusMax gArmTokenSpaceGuid.PcdPciIoBase gArmTokenSpaceGuid.PcdPciIoSize @@ -60,10 +63,31 @@ gEfiMdePkgTokenSpaceGuid.PcdPciMmio64Translation gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPciMmio64Limit + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlIoBase + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlIoSize + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlIoTranslation + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlIoLimit + + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlMmio32Base + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlMmio32Size + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlMmio32Limit + + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlMmio64Base + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlMmio64Size + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlMmio64Limit + gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPciExpressBarSize gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPciExpressBarLimit + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlBaseAddress + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlBarSize + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlBarLimit + + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdChbcrBase + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCfmws0Base + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCfmws0Size + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPlatformAhciBase diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Cedt.aslc b/Silicon/Qemu/SbsaQemu/AcpiTables/Cedt.aslc new file mode 100644 index 000000000000..89ae4d95366f --- /dev/null +++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Cedt.aslc @@ -0,0 +1,69 @@ +/** @file +* CXL Early Discovery Table (CEDT) +* +* Copyright (c) 2024, Phytium Technology Co Ltd. All rights reserved. +* +**/ + +#include <IndustryStandard/Cxl30.h> +#include <IndustryStandard/SbsaQemuAcpi.h> + +#pragma pack(1) + +typedef struct +{ + CXL_EARLY_DISCOVERY_TABLE Header; + CXL_HOST_BRIDGE_STRUCTURE Chbs; + CXL_FIXED_MEMORY_WINDOW_STRUCTURE Cfmws; +} SBSA_REF_CEDT; + + +SBSA_REF_CEDT Cedt = +{ + // CXL_EARLY_DISCOVERY_TABLE(CEDT Header) + { + SBSAQEMU_ACPI_HEADER // EFI_ACPI_DESCRIPTION_HEADER + ( + CXL_EARLY_DISCOVERY_TABLE_SIGNATURE, + SBSA_REF_CEDT, + CXL_EARLY_DISCOVERY_TABLE_REVISION_01 + ), + }, + // CXL_HOST_BRIDGE_STRUCTURE + { + // CEDT_STRUCTURE + { + CEDT_TYPE_CHBS, // Type + 0, // Reserved + sizeof (CXL_HOST_BRIDGE_STRUCTURE), // Length + }, + 0x1, // UID + 0x1, // CXLVersion + 0, // Reserved + FixedPcdGet32 (PcdChbcrBase), // CHBCR Base + 0X10000, // Length + }, + // CXL_FIXED_MEMORY_WINDOW_STRUCTURE + { + // CEDT_STRUCTURE + { + CEDT_TYPE_CFMWS, // Type + 0, // Reserved + sizeof (CXL_FIXED_MEMORY_WINDOW_STRUCTURE), // Length + }, + 0, // Reserved + FixedPcdGet32 (PcdCfmws0Base), // BaseHPA + FixedPcdGet32 (PcdCfmws0Size), // WindowSize + 0, // InterleaveMembers + 0, // InterleaveArithmetic + 0, // Reserved1 + 0, // Granularity + 0xF, // Restrictions + 1, // QtgId + {0x1}, // TargetList + } +}; + +#pragma pack () + +VOID* CONST ReferenceAcpiTable = &Cedt; diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl index c134fb66e860..ec6decb79df5 100644 --- a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl +++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl @@ -483,5 +483,332 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", } } // End _OSC } + + // CXL Host Bridge (pxb-cxl) + Device (CXL0) + { + Name (_HID, "ACPI0016" /* Compute Express Link Host Bridge */) // _HID: Hardware ID + Name (_CID, Package (0x02) // _CID: Compatible ID + { + EisaId ("PNP0A08"), /* PCI Express Bus */ + EisaId ("PNP0A03") /* PCI Bus */ + }) + Name (_SEG, 0x1) // PCI Segment Group number + Name (_BBN, 0x0) // _BBN: BIOS Bus Number + Name (_UID, 0x1) // _UID: Unique ID + Name (_STR, Unicode ("pxb Device")) // _STR: Description String + Name (_CCA, One) // _CCA: Cache Coherency Attribute + + LINK_DEVICE(0, GSI0, 0x31) + LINK_DEVICE(1, GSI1, 0x32) + LINK_DEVICE(2, GSI2, 0x33) + LINK_DEVICE(3, GSI3, 0x34) + + Name (_PRT, Package (0x80) // _PRT: PCI Routing Table + { + PRT_ENTRY(0x0000FFFF, 0, GSI0), + PRT_ENTRY(0x0000FFFF, 0, GSI1), + PRT_ENTRY(0x0000FFFF, 0, GSI2), + PRT_ENTRY(0x0000FFFF, 0, GSI3), + + PRT_ENTRY(0x0001FFFF, 0, GSI1), + PRT_ENTRY(0x0001FFFF, 1, GSI2), + PRT_ENTRY(0x0001FFFF, 2, GSI3), + PRT_ENTRY(0x0001FFFF, 3, GSI0), + + PRT_ENTRY(0x0002FFFF, 0, GSI2), + PRT_ENTRY(0x0002FFFF, 1, GSI3), + PRT_ENTRY(0x0002FFFF, 2, GSI0), + PRT_ENTRY(0x0002FFFF, 3, GSI1), + + PRT_ENTRY(0x0003FFFF, 0, GSI3), + PRT_ENTRY(0x0003FFFF, 1, GSI0), + PRT_ENTRY(0x0003FFFF, 2, GSI1), + PRT_ENTRY(0x0003FFFF, 3, GSI2), + + PRT_ENTRY(0x0004FFFF, 0, GSI0), + PRT_ENTRY(0x0004FFFF, 1, GSI1), + PRT_ENTRY(0x0004FFFF, 2, GSI2), + PRT_ENTRY(0x0004FFFF, 3, GSI3), + + PRT_ENTRY(0x0005FFFF, 0, GSI1), + PRT_ENTRY(0x0005FFFF, 1, GSI2), + PRT_ENTRY(0x0005FFFF, 2, GSI3), + PRT_ENTRY(0x0005FFFF, 3, GSI0), + + PRT_ENTRY(0x0006FFFF, 0, GSI2), + PRT_ENTRY(0x0006FFFF, 1, GSI3), + PRT_ENTRY(0x0006FFFF, 2, GSI0), + PRT_ENTRY(0x0006FFFF, 3, GSI1), + + PRT_ENTRY(0x0007FFFF, 0, GSI3), + PRT_ENTRY(0x0007FFFF, 1, GSI0), + PRT_ENTRY(0x0007FFFF, 2, GSI1), + PRT_ENTRY(0x0007FFFF, 3, GSI2), + + PRT_ENTRY(0x0008FFFF, 0, GSI0), + PRT_ENTRY(0x0008FFFF, 1, GSI1), + PRT_ENTRY(0x0008FFFF, 2, GSI2), + PRT_ENTRY(0x0008FFFF, 3, GSI3), + + PRT_ENTRY(0x0009FFFF, 0, GSI1), + PRT_ENTRY(0x0009FFFF, 1, GSI2), + PRT_ENTRY(0x0009FFFF, 2, GSI3), + PRT_ENTRY(0x0009FFFF, 3, GSI0), + + PRT_ENTRY(0x000AFFFF, 0, GSI2), + PRT_ENTRY(0x000AFFFF, 1, GSI3), + PRT_ENTRY(0x000AFFFF, 2, GSI0), + PRT_ENTRY(0x000AFFFF, 3, GSI1), + + PRT_ENTRY(0x000BFFFF, 0, GSI3), + PRT_ENTRY(0x000BFFFF, 1, GSI0), + PRT_ENTRY(0x000BFFFF, 2, GSI1), + PRT_ENTRY(0x000BFFFF, 3, GSI2), + + PRT_ENTRY(0x000CFFFF, 0, GSI0), + PRT_ENTRY(0x000CFFFF, 1, GSI1), + PRT_ENTRY(0x000CFFFF, 2, GSI2), + PRT_ENTRY(0x000CFFFF, 3, GSI3), + + PRT_ENTRY(0x000DFFFF, 0, GSI1), + PRT_ENTRY(0x000DFFFF, 1, GSI2), + PRT_ENTRY(0x000DFFFF, 2, GSI3), + PRT_ENTRY(0x000DFFFF, 3, GSI0), + + PRT_ENTRY(0x000EFFFF, 0, GSI2), + PRT_ENTRY(0x000EFFFF, 1, GSI3), + PRT_ENTRY(0x000EFFFF, 2, GSI0), + PRT_ENTRY(0x000EFFFF, 3, GSI1), + + PRT_ENTRY(0x000FFFFF, 0, GSI3), + PRT_ENTRY(0x000FFFFF, 1, GSI0), + PRT_ENTRY(0x000FFFFF, 2, GSI1), + PRT_ENTRY(0x000FFFFF, 3, GSI2), + + PRT_ENTRY(0x0010FFFF, 0, GSI0), + PRT_ENTRY(0x0010FFFF, 1, GSI1), + PRT_ENTRY(0x0010FFFF, 2, GSI2), + PRT_ENTRY(0x0010FFFF, 3, GSI3), + + PRT_ENTRY(0x0011FFFF, 0, GSI1), + PRT_ENTRY(0x0011FFFF, 1, GSI2), + PRT_ENTRY(0x0011FFFF, 2, GSI3), + PRT_ENTRY(0x0011FFFF, 3, GSI0), + + PRT_ENTRY(0x0012FFFF, 0, GSI2), + PRT_ENTRY(0x0012FFFF, 1, GSI3), + PRT_ENTRY(0x0012FFFF, 2, GSI0), + PRT_ENTRY(0x0012FFFF, 3, GSI1), + + PRT_ENTRY(0x0013FFFF, 0, GSI3), + PRT_ENTRY(0x0013FFFF, 1, GSI0), + PRT_ENTRY(0x0013FFFF, 2, GSI1), + PRT_ENTRY(0x0013FFFF, 3, GSI2), + + PRT_ENTRY(0x0014FFFF, 0, GSI0), + PRT_ENTRY(0x0014FFFF, 1, GSI1), + PRT_ENTRY(0x0014FFFF, 2, GSI2), + PRT_ENTRY(0x0014FFFF, 3, GSI3), + + PRT_ENTRY(0x0015FFFF, 0, GSI1), + PRT_ENTRY(0x0015FFFF, 1, GSI2), + PRT_ENTRY(0x0015FFFF, 2, GSI3), + PRT_ENTRY(0x0015FFFF, 3, GSI0), + + PRT_ENTRY(0x0016FFFF, 0, GSI2), + PRT_ENTRY(0x0016FFFF, 1, GSI3), + PRT_ENTRY(0x0016FFFF, 2, GSI0), + PRT_ENTRY(0x0016FFFF, 3, GSI1), + + PRT_ENTRY(0x0017FFFF, 0, GSI3), + PRT_ENTRY(0x0017FFFF, 1, GSI0), + PRT_ENTRY(0x0017FFFF, 2, GSI1), + PRT_ENTRY(0x0017FFFF, 3, GSI2), + + PRT_ENTRY(0x0018FFFF, 0, GSI0), + PRT_ENTRY(0x0018FFFF, 1, GSI1), + PRT_ENTRY(0x0018FFFF, 2, GSI2), + PRT_ENTRY(0x0018FFFF, 3, GSI3), + + PRT_ENTRY(0x0019FFFF, 0, GSI1), + PRT_ENTRY(0x0019FFFF, 1, GSI2), + PRT_ENTRY(0x0019FFFF, 2, GSI3), + PRT_ENTRY(0x0019FFFF, 3, GSI0), + + PRT_ENTRY(0x001AFFFF, 0, GSI2), + PRT_ENTRY(0x001AFFFF, 1, GSI3), + PRT_ENTRY(0x001AFFFF, 2, GSI0), + PRT_ENTRY(0x001AFFFF, 3, GSI1), + + PRT_ENTRY(0x001BFFFF, 0, GSI3), + PRT_ENTRY(0x001BFFFF, 1, GSI0), + PRT_ENTRY(0x001BFFFF, 2, GSI1), + PRT_ENTRY(0x001BFFFF, 3, GSI2), + + PRT_ENTRY(0x001CFFFF, 0, GSI0), + PRT_ENTRY(0x001CFFFF, 1, GSI1), + PRT_ENTRY(0x001CFFFF, 2, GSI2), + PRT_ENTRY(0x001CFFFF, 3, GSI3), + + PRT_ENTRY(0x001DFFFF, 0, GSI1), + PRT_ENTRY(0x001DFFFF, 1, GSI2), + PRT_ENTRY(0x001DFFFF, 2, GSI3), + PRT_ENTRY(0x001DFFFF, 3, GSI0), + + PRT_ENTRY(0x001EFFFF, 0, GSI2), + PRT_ENTRY(0x001EFFFF, 1, GSI3), + PRT_ENTRY(0x001EFFFF, 2, GSI0), + PRT_ENTRY(0x001EFFFF, 3, GSI1), + + PRT_ENTRY(0x001FFFFF, 0, GSI3), + PRT_ENTRY(0x001FFFFF, 1, GSI0), + PRT_ENTRY(0x001FFFFF, 2, GSI1), + PRT_ENTRY(0x001FFFFF, 3, GSI2), + }) + + Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings + { + DWordMemory ( // 32-bit BAR Windows + ResourceProducer, PosDecode, + MinFixed, MaxFixed, + Cacheable, ReadWrite, + 0x00000000, // Granularity + FixedPcdGet32 (PcdCxlMmio32Base), // Min Base Address + FixedPcdGet32 (PcdCxlMmio32Limit), // Max Base Address + FixedPcdGet32 (PcdPciMmio32Translation), // Translate + FixedPcdGet32 (PcdCxlMmio32Size) // Length + ) + + QWordMemory ( // 64-bit BAR Windows + ResourceProducer, PosDecode, + MinFixed, MaxFixed, + Cacheable, ReadWrite, + 0x00000000, // Granularity + FixedPcdGet64 (PcdCxlMmio64Base), // Min Base Address + FixedPcdGet64 (PcdCxlMmio64Limit), // Max Base Address + FixedPcdGet64 (PcdPciMmio64Translation), // Translate + FixedPcdGet64 (PcdCxlMmio64Size) // Length + ) + + WordBusNumber ( // Bus numbers assigned to this root + ResourceProducer, + MinFixed, MaxFixed, PosDecode, + 0, // AddressGranularity + FixedPcdGet32 (PcdCxlBusMin), // AddressMinimum - Minimum Bus Number + FixedPcdGet32 (PcdCxlBusMax), // AddressMaximum - Maximum Bus Number + 0, // AddressTranslation - Set to 0 + 256 // RangeLength - Number of Busses + ) + + DWordIo ( // IO window + ResourceProducer, + MinFixed, + MaxFixed, + PosDecode, + EntireRange, + 0x00000000, // Granularity + FixedPcdGet32 (PcdCxlIoBase), // Min Base Address + FixedPcdGet32 (PcdCxlIoLimit), // Max Base Address + FixedPcdGet32 (PcdCxlIoTranslation), // Translate + FixedPcdGet32 (PcdCxlIoSize), // Length + ,,,TypeTranslation + ) + }) + + Device (RES1) + { + Name (_HID, "PNP0C02" /* PNP Motherboard Resources */) // _HID: Hardware ID + Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings + { + QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite, + 0x0000000000000000, // Granularity + FixedPcdGet64 (PcdCxlBaseAddress), // Range Minimum + FixedPcdGet64 (PcdCxlBarLimit), // Range Maximum + 0x0000000000000000, // Translation Offset + FixedPcdGet64 (PcdCxlBarSize), // Length + ,, , AddressRangeMemory, TypeStatic) + }) + Method (_STA) { + Return (0xF) + } + } + + Name (SUPP, Zero) + Name (CTRL, Zero) + Name (SUPC, Zero) + Name (CTRC, Zero) + + Method (_OSC, 4, NotSerialized) // _OSC: Operating System Capabilities + { + CreateDWordField (Arg3, Zero, CDW1) + If (((Arg0 == ToUUID ("33db4d5b-1ff7-401c-9657-7441c03dd766") /* PCI Host Bridge Device */) || (Arg0 == ToUUID ("68f2d50b-c469-4d8a-bd3d-941a103fd3fc") /* Unknown UUID */))) + { + CreateDWordField (Arg3, 0x04, CDW2) + CreateDWordField (Arg3, 0x08, CDW3) + Local0 = CDW3 /* \_SB_.PC0C._OSC.CDW3 */ + Local0 &= 0x1F + If ((Arg1 != One)) + { + CDW1 |= 0x08 + } + + If ((CDW3 != Local0)) + { + CDW1 |= 0x10 + } + + SUPP = CDW2 /* \_SB_.PC0C._OSC.CDW2 */ + CTRL = CDW3 /* \_SB_.PC0C._OSC.CDW3 */ + CDW3 = Local0 + If ((Arg0 == ToUUID ("68f2d50b-c469-4d8a-bd3d-941a103fd3fc") /* Unknown UUID */)) + { + CreateDWordField (Arg3, 0x0C, CDW4) + CreateDWordField (Arg3, 0x10, CDW5) + SUPC = CDW4 /* \_SB_.PC0C._OSC.CDW4 */ + CTRC = CDW5 /* \_SB_.PC0C._OSC.CDW5 */ + CDW5 |= One + } + + Return (Arg3) + } + Else + { + CDW1 |= 0x04 + Return (Arg3) + } + } + } + + Scope (\_SB) + { + // CXL Root for OS Driver + Device (CXLM) + { + Name (_HID, "ACPI0017") // _HID: Hardware ID + Method (_STA, 0, NotSerialized) // _STA: Status + { + Return (0x0B) + } + + Method (_DSM, 4, Serialized) // _DSM: Device-Specific Method + { + If ((Arg0 == ToUUID ("f365f9a6-a7de-4071-a66a-b40c0b4f8e52") /* Retrieve QTG ID */)) + { + If ((Arg2 == One)) + { + Return (Package (0x02) + { + One, + Package (0x01) + { + One + } + }) + } + } + } + } + } } // Scope (_SB) } diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Mcfg.aslc b/Silicon/Qemu/SbsaQemu/AcpiTables/Mcfg.aslc index 289f4ad4ea3a..c8b9a00a4eae 100644 --- a/Silicon/Qemu/SbsaQemu/AcpiTables/Mcfg.aslc +++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Mcfg.aslc @@ -14,7 +14,7 @@ typedef struct { EFI_ACPI_MEMORY_MAPPED_CONFIGURATION_BASE_ADDRESS_TABLE_HEADER Header; - EFI_ACPI_MEMORY_MAPPED_ENHANCED_CONFIGURATION_SPACE_BASE_ADDRESS_ALLOCATION_STRUCTURE Structure[1]; + EFI_ACPI_MEMORY_MAPPED_ENHANCED_CONFIGURATION_SPACE_BASE_ADDRESS_ALLOCATION_STRUCTURE Structure[2]; } EFI_ACPI_MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_DESCRIPTION_TABLE; EFI_ACPI_MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_DESCRIPTION_TABLE Mcfg = { @@ -32,6 +32,13 @@ EFI_ACPI_MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_DESCRIPTION_TABLE Mcfg = { FixedPcdGet32 (PcdPciBusMin), FixedPcdGet32 (PcdPciBusMax), EFI_ACPI_RESERVED_DWORD + }, + { + FixedPcdGet32 (PcdCxlBaseAddress), + 1, + FixedPcdGet32 (PcdCxlBusMin), + FixedPcdGet32 (PcdCxlBusMax), + EFI_ACPI_RESERVED_DWORD } } }; diff --git a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c index ddf4acdb7032..ffe10caf11c9 100644 --- a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c +++ b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c @@ -78,7 +78,7 @@ AddIortTable ( SBSA_IO_REMAPPING_STRUCTURE, EFI_ACPI_IO_REMAPPING_TABLE_REVISION_06 ), - 3, + 4, sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE), // NodeOffset 0 }; @@ -115,6 +115,7 @@ AddIortTable ( } }; + // Initialize Gpex Rc Structure SBSA_EFI_ACPI_6_0_IO_REMAPPING_RC_NODE Rc = { { { @@ -145,6 +146,37 @@ AddIortTable ( } }; + // Initialize Cxl Rc Structure + SBSA_EFI_ACPI_6_0_IO_REMAPPING_RC_NODE cxlRc = { + { + { + EFI_ACPI_IORT_TYPE_ROOT_COMPLEX, // Type + sizeof (SBSA_EFI_ACPI_6_0_IO_REMAPPING_RC_NODE), // Length + 0, // Revision + 1, // Identifier + 1, // NumIdMappings + OFFSET_OF (SBSA_EFI_ACPI_6_0_IO_REMAPPING_RC_NODE, RcIdMap) // IdReference + }, + 1, // CacheCoherentAttribute + 0, // AllocationHints + 0, // Reserved + 1, // MemoryAccessFlags + EFI_ACPI_IORT_ROOT_COMPLEX_ATS_UNSUPPORTED, // AtsAttribute + 0x1, // PciSegmentNumber + 0, // MemoryAddressSize + 0, // PasidCapabilities + { 0 }, // Reserved1[1] + 0, // Flags + }, + { + 0x0000, // InputBase + 0xffff, // NumIds + 0x10000, // OutputBase + OFFSET_OF (SBSA_IO_REMAPPING_STRUCTURE, ItsNode), // OutputReference + 0, // Flags + } + }; + SBSA_EFI_ACPI_6_0_IO_REMAPPING_ITS_NODE Its = { // EFI_ACPI_6_0_IO_REMAPPING_ITS_NODE { @@ -166,7 +198,7 @@ AddIortTable ( TableSize = sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE) + sizeof (SBSA_EFI_ACPI_6_0_IO_REMAPPING_ITS_NODE) + sizeof (SBSA_EFI_ACPI_6_0_IO_REMAPPING_SMMU3_NODE) + - sizeof (SBSA_EFI_ACPI_6_0_IO_REMAPPING_RC_NODE); + 2 * sizeof (SBSA_EFI_ACPI_6_0_IO_REMAPPING_RC_NODE); Status = gBS->AllocatePages ( AllocateAnyPages, @@ -199,6 +231,10 @@ AddIortTable ( CopyMem (New, &Rc, sizeof (SBSA_EFI_ACPI_6_0_IO_REMAPPING_RC_NODE)); New += sizeof (SBSA_EFI_ACPI_6_0_IO_REMAPPING_RC_NODE); + // CXL RC Node + CopyMem (New, &cxlRc, sizeof (SBSA_EFI_ACPI_6_0_IO_REMAPPING_RC_NODE)); + New += sizeof (SBSA_EFI_ACPI_6_0_IO_REMAPPING_RC_NODE); + AcpiPlatformChecksum ((UINT8 *)PageAddress, TableSize); Status = AcpiTable->InstallAcpiTable ( diff --git a/Silicon/Qemu/SbsaQemu/SbsaQemu.dec b/Silicon/Qemu/SbsaQemu/SbsaQemu.dec index 60daeff915c5..63a4f7a2066b 100644 --- a/Silicon/Qemu/SbsaQemu/SbsaQemu.dec +++ b/Silicon/Qemu/SbsaQemu/SbsaQemu.dec @@ -48,6 +48,34 @@ HardwareInfoLib|Include/Library/HardwareInfoLib.h gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPciExpressBarSize|0x10000000|UINT64|0x00000009 gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPciExpressBarLimit|0xFFFFFFFF|UINT64|0x00000010 + # PCDs complementing CXL layout pulled into ACPI tables + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlIoBase|0x0|UINT32|0x00000011 + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlIoTranslation|0x60300000|UINT32|0x00000012 + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlIoSize|0x00010000|UINT32|0x00000013 + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlMmio32Base|0x60400000|UINT32|0x00000014 + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlMmio32Size|0x08000000|UINT32|0x00000015 + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlMmio64Base|0x90000000000|UINT64|0x00000016 + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlMmio64Size|0x100000000|UINT64|0x00000017 + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlIoLimit|0x0000ffff|UINT32|0x00000018 + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlMmio32Limit|0x683FFFFF|UINT32|0x00000019 + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlMmio64Limit|0x900FFFFFFFF|UINT64|0x0000001a + + # PCDs complementing CXL ECAM Base & Size + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlBaseAddress|0x68500000|UINT64|0x0000001b + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlBarSize|0x10000000|UINT64|0x0000001c + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlBarLimit|0x784FFFFF|UINT64|0x0000001d + + # PCDs complementing CXL Bus Range + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlBusMin|0|UINT32|0x0000001e + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCxlBusMax|255|UINT32|0x0000001f + + # PCDs complementing base address for CXL CHBCR (CXL Host Bridge Component Registers) + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdChbcrBase|0x60200000|UINT64|0x00000020 + + # CXL Fixed Memory Window + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCfmws0Base|0xA0000000000|UINT64|0x00000021 + gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCfmws0Size|0x10000000000|UINT64|0x00000022 + [PcdsDynamic.common] gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdSystemManufacturer|L""|VOID*|0x00000110 gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdSystemSerialNumber|L""|VOID*|0x00000111 -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120890): https://edk2.groups.io/g/devel/message/120890 Mute This Topic: https://groups.io/mt/110023231/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [RFC PATCH edk2-platforms v4 0/1] add basic support for CXL on sbsa-ref 2024-12-10 10:36 [edk2-devel] [RFC PATCH edk2-platforms v4 0/1] add basic support for CXL on sbsa-ref Yuquan Wang 2024-12-10 10:36 ` [edk2-devel] [RFC PATCH edk2-platforms v4 1/1] SbsaQemu: Support basic CXL enablement Yuquan Wang @ 2024-12-11 15:40 ` Alejandro Lucero Palau via groups.io 2024-12-12 3:51 ` Yuquan Wang 1 sibling, 1 reply; 6+ messages in thread From: Alejandro Lucero Palau via groups.io @ 2024-12-11 15:40 UTC (permalink / raw) To: Yuquan Wang, marcin.juszkiewicz, ardb+tianocore, quic_llindhol Cc: Jonathan.Cameron, chenbaozi, devel, linux-cxl On 12/10/24 10:36, Yuquan Wang wrote: > v3 -> v4: > - Align base addresses of CXL relevant Windows > > v2 -> v3: > - PCDs values of pio, mmio32, mmio64 & ecam space for the independent cxl host > - CXL Bus range: 0x00 ~ 0xff > - Mcfg ecam structure for cxl > - Iort RC node for cxl > > RFC because > - Many contents are ported from Jonathan' patch on qemu virt design > > - Bring plenty of PCDs values > > - Less experience and not particularly confident in ACPI area > > This series leverages Jonathan's patches[1] to add acpi0016 & acpi0017 objects into the > previous DSDT table of sbsa-ref. Since my latest acpi0016 implementation model on qemu > side is a new host bridge qemu object rather than pxb-cxl, the cxl host(Segment 0001) > would have its own ECAM sapce. Meanwhile, this adds exclusive pio, mmio32 & mmio64 space > for cxl host. Hi Yuquan, Is there a roadmap for edk2 supporting other CXL features? I have noticed UEFI extensions are not supported yet, specifically EFI_ADAPTER_INFO_CDAT_TYPE_GUID as an instance of EFI_ADAPTER_INFORMATION_PROTOCOL. Any feedback would be welcome. Thanks > As sbsa-ref cxl host has its own ecam space, this defines the bus range of cxl host from > 0x0 to 0xff. Therefore, this adds relevant BASE_ADDRESS_ALLOCATION_STRUCTURE for cxl in Mcfg. > And to enable msi of cxl components, this add a new RC node in Iort. > > Based on the new CEDT definitions patch on edk2[2], this series adds a static Cedt.aslc to > support the [SBSA_CXL_CHBCR] & [SBSA_CXL_FIXED_WINDOW] space on sbsa-ref. > > Link: > [1]: https://lore.kernel.org/linux-cxl/20220616141950.23374-2-Jonathan.Cameron@huawei.com/ > [2]: https://edk2.groups.io/g/devel/message/120851 > > Below are the new result of acpi tables (the DSDT contents could see the patch itself): > > 1) MCFG > [000h 0000 004h] Signature : "MCFG" [Memory Mapped Configuration Table] > [004h 0004 004h] Table Length : 0000004C > [008h 0008 001h] Revision : 01 > [009h 0009 001h] Checksum : 1E > [00Ah 0010 006h] Oem ID : "LINARO" > [010h 0016 008h] Oem Table ID : "SBSAQEMU" > [018h 0024 004h] Oem Revision : 20240625 > [01Ch 0028 004h] Asl Compiler ID : "LNRO" > [020h 0032 004h] Asl Compiler Revision : 00000001 > > [024h 0036 008h] Reserved : 0000000000000000 > > [02Ch 0044 008h] Base Address : 00000000F0000000 > [034h 0052 002h] Segment Group Number : 0000 > [036h 0054 001h] Start Bus Number : 00 > [037h 0055 001h] End Bus Number : FF > [038h 0056 004h] Reserved : 00000000 > > [03Ch 0060 008h] Base Address : 0000000068500000 > [044h 0068 002h] Segment Group Number : 0001 > [046h 0070 001h] Start Bus Number : 00 > [047h 0071 001h] End Bus Number : FF > [048h 0072 004h] Reserved : 00000000 > > 2) IORT > [000h 0000 004h] Signature : "IORT" [IO Remapping Table] > [004h 0004 004h] Table Length : 00000118 > [008h 0008 001h] Revision : 06 > [009h 0009 001h] Checksum : D3 > [00Ah 0010 006h] Oem ID : "LINARO" > [010h 0016 008h] Oem Table ID : "SBSAQEMU" > [018h 0024 004h] Oem Revision : 20240625 > [01Ch 0028 004h] Asl Compiler ID : "LNRO" > [020h 0032 004h] Asl Compiler Revision : 00000001 > > [024h 0036 004h] Node Count : 00000004 > [028h 0040 004h] Node Offset : 00000030 > [02Ch 0044 004h] Reserved : 00000000 > > [030h 0048 001h] Type : 00 > [031h 0049 002h] Length : 0018 > [033h 0051 001h] Revision : 00 > [034h 0052 004h] Identifier : 00000000 > [038h 0056 004h] Mapping Count : 00000000 > [03Ch 0060 004h] Mapping Offset : 00000000 > > [040h 0064 004h] ItsCount : 00000001 > [044h 0068 004h] Identifiers : 00000000 > > [048h 0072 001h] Type : 04 > [049h 0073 002h] Length : 0058 > [04Bh 0075 001h] Revision : 05 > [04Ch 0076 004h] Identifier : 00000000 > [050h 0080 004h] Mapping Count : 00000001 > [054h 0084 004h] Mapping Offset : 00000044 > > [058h 0088 008h] Base Address : 0000000060050000 > [060h 0096 004h] Flags (decoded below) : 00000001 > COHACC Override : 1 > HTTU Override : 0 > Proximity Domain Valid : 0 > DeviceID Valid : 0 > [064h 0100 004h] Reserved : 00000000 > [068h 0104 008h] VATOS Address : 0000000000000000 > [070h 0112 004h] Model : 00000000 > [074h 0116 004h] Event GSIV : 0000004A > [078h 0120 004h] PRI GSIV : 0000004B > [07Ch 0124 004h] GERR GSIV : 0000004D > [080h 0128 004h] Sync GSIV : 0000004C > [084h 0132 004h] Proximity Domain : 00000000 > [088h 0136 004h] Device ID Mapping Index : 00000001 > > [08Ch 0140 004h] Input base : 00000000 > [090h 0144 004h] ID Count : 0000FFFF > [094h 0148 004h] Output Base : 00000000 > [098h 0152 004h] Output Reference : 00000030 > [09Ch 0156 004h] Flags (decoded below) : 00000000 > Single Mapping : 0 > > [0A0h 0160 001h] Type : 02 > [0A1h 0161 002h] Length : 003C > [0A3h 0163 001h] Revision : 00 > [0A4h 0164 004h] Identifier : 00000000 > [0A8h 0168 004h] Mapping Count : 00000001 > [0ACh 0172 004h] Mapping Offset : 00000028 > > [0B0h 0176 008h] Memory Properties : [IORT Memory Access Properties] > [0B0h 0176 004h] Cache Coherency : 00000001 > [0B4h 0180 001h] Hints (decoded below) : 00 > Transient : 0 > Write Allocate : 0 > Read Allocate : 0 > Override : 0 > [0B5h 0181 002h] Reserved : 0000 > [0B7h 0183 001h] Memory Flags (decoded below) : 01 > Coherency : 1 > Device Attribute : 0 > Ensured Coherency of Accesses : 0 > [0B8h 0184 004h] ATS Attribute : 00000000 > [0BCh 0188 004h] PCI Segment Number : 00000000 > [0C0h 0192 001h] Memory Size Limit : 00 > [0C1h 0193 002h] PASID Capabilities : 0000 > [0C3h 0195 001h] Reserved : 00 > > [0C8h 0200 004h] Input base : 00000000 > [0CCh 0204 004h] ID Count : 0000FFFF > [0D0h 0208 004h] Output Base : 00000000 > [0D4h 0212 004h] Output Reference : 00000048 > [0D8h 0216 004h] Flags (decoded below) : 00000000 > Single Mapping : 0 > > [0DCh 0220 001h] Type : 02 > [0DDh 0221 002h] Length : 003C > [0DFh 0223 001h] Revision : 00 > [0E0h 0224 004h] Identifier : 00000001 > [0E4h 0228 004h] Mapping Count : 00000001 > [0E8h 0232 004h] Mapping Offset : 00000028 > > [0ECh 0236 008h] Memory Properties : [IORT Memory Access Properties] > [0ECh 0236 004h] Cache Coherency : 00000001 > [0F0h 0240 001h] Hints (decoded below) : 00 > Transient : 0 > Write Allocate : 0 > Read Allocate : 0 > Override : 0 > [0F1h 0241 002h] Reserved : 0000 > [0F3h 0243 001h] Memory Flags (decoded below) : 01 > Coherency : 1 > Device Attribute : 0 > Ensured Coherency of Accesses : 0 > [0F4h 0244 004h] ATS Attribute : 00000000 > [0F8h 0248 004h] PCI Segment Number : 00000001 > [0FCh 0252 001h] Memory Size Limit : 00 > [0FDh 0253 002h] PASID Capabilities : 0000 > [0FFh 0255 001h] Reserved : 00 > > [104h 0260 004h] Input base : 00000000 > [108h 0264 004h] ID Count : 0000FFFF > [10Ch 0268 004h] Output Base : 00010000 > [110h 0272 004h] Output Reference : 00000030 > [114h 0276 004h] Flags (decoded below) : 00000000 > Single Mapping : 0 > > 3) CEDT > [000h 0000 004h] Signature : "CEDT" [CXL Early Discovery Table] > [004h 0004 004h] Table Length : 000000A8 > [008h 0008 001h] Revision : 01 > [009h 0009 001h] Checksum : 42 > [00Ah 0010 006h] Oem ID : "LINARO" > [010h 0016 008h] Oem Table ID : "SBSAQEMU" > [018h 0024 004h] Oem Revision : 20240625 > [01Ch 0028 004h] Asl Compiler ID : "LNRO" > [020h 0032 004h] Asl Compiler Revision : 00000001 > > > [024h 0036 001h] Subtable Type : 00 [CXL Host Bridge Structure] > [025h 0037 001h] Reserved : 00 > [026h 0038 002h] Length : 0020 > [028h 0040 004h] Associated host bridge : 00000001 > [02Ch 0044 004h] Specification version : 00000001 > [030h 0048 004h] Reserved : 00000000 > [034h 0052 008h] Register base : 0000000060200000 > [03Ch 0060 008h] Register length : 0000000000010000 > > [044h 0068 001h] Subtable Type : 01 [CXL Fixed Memory Window Structure] > [045h 0069 001h] Reserved : 00 > [046h 0070 002h] Length : 0064 > [048h 0072 004h] Reserved : 00000000 > [04Ch 0076 008h] Window base address : 00000A0000000000 > [054h 0084 008h] Window size : 0000010000000000 > [05Ch 0092 001h] Interleave Members : 00 > [05Dh 0093 001h] Interleave Arithmetic : 00 > [05Eh 0094 002h] Reserved : 0000 > [060h 0096 004h] Granularity : 00000000 > [064h 0100 002h] Restrictions : 000F > [066h 0102 002h] QtgId : 0001 > [068h 0104 004h] First Target : 00000001 > > Yuquan Wang (1): > SbsaQemu: Support basic CXL enablement > > Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 21 ++ > .../Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 24 ++ > Silicon/Qemu/SbsaQemu/AcpiTables/Cedt.aslc | 69 ++++ > Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 327 ++++++++++++++++++ > Silicon/Qemu/SbsaQemu/AcpiTables/Mcfg.aslc | 9 +- > .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 40 ++- > Silicon/Qemu/SbsaQemu/SbsaQemu.dec | 28 ++ > 7 files changed, 515 insertions(+), 3 deletions(-) > create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Cedt.aslc > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120896): https://edk2.groups.io/g/devel/message/120896 Mute This Topic: https://groups.io/mt/110023229/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [RFC PATCH edk2-platforms v4 0/1] add basic support for CXL on sbsa-ref 2024-12-11 15:40 ` [edk2-devel] [RFC PATCH edk2-platforms v4 0/1] add basic support for CXL on sbsa-ref Alejandro Lucero Palau via groups.io @ 2024-12-12 3:51 ` Yuquan Wang 2024-12-18 3:23 ` Yuquan Wang 0 siblings, 1 reply; 6+ messages in thread From: Yuquan Wang @ 2024-12-12 3:51 UTC (permalink / raw) To: Alejandro Lucero Palau Cc: marcin.juszkiewicz, ardb+tianocore, quic_llindhol, Jonathan.Cameron, chenbaozi, devel, linux-cxl On Wed, Dec 11, 2024 at 03:40:03PM +0000, Alejandro Lucero Palau wrote: > > On 12/10/24 10:36, Yuquan Wang wrote: > > v3 -> v4: > > - Align base addresses of CXL relevant Windows > > > > v2 -> v3: > > - PCDs values of pio, mmio32, mmio64 & ecam space for the independent cxl host > > - CXL Bus range: 0x00 ~ 0xff > > - Mcfg ecam structure for cxl > > - Iort RC node for cxl > > > > RFC because > > - Many contents are ported from Jonathan' patch on qemu virt design > > > > - Bring plenty of PCDs values > > > > - Less experience and not particularly confident in ACPI area > > > > This series leverages Jonathan's patches[1] to add acpi0016 & acpi0017 objects into the > > previous DSDT table of sbsa-ref. Since my latest acpi0016 implementation model on qemu > > side is a new host bridge qemu object rather than pxb-cxl, the cxl host(Segment 0001) > > would have its own ECAM sapce. Meanwhile, this adds exclusive pio, mmio32 & mmio64 space > > for cxl host. > > > Hi Yuquan, > > > Is there a roadmap for edk2 supporting other CXL features? > Hi, Alejandro Emmm. I have not find such edk2 roadmap (docs/webs/blog) yet. According to what I've learnd, the edk2 upstream only support some head files which define cxl registers structs and no cxl drivers have merged into upstream now, and mostly system software's work haved been done in linux kernel. Regard to cxl patches in edk2, there is a series of patches in reviewing to support enabling cxl-type3 device as memory expander on Arm/RD platform[1]. Link: [1]: https://edk2.groups.io/g/devel/message/109488 > > I have noticed UEFI extensions are not supported yet, specifically > EFI_ADAPTER_INFO_CDAT_TYPE_GUID as an instance of > EFI_ADAPTER_INFORMATION_PROTOCOL. > > > Any feedback would be welcome. > > > Thanks > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120897): https://edk2.groups.io/g/devel/message/120897 Mute This Topic: https://groups.io/mt/110023229/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [RFC PATCH edk2-platforms v4 0/1] add basic support for CXL on sbsa-ref 2024-12-12 3:51 ` Yuquan Wang @ 2024-12-18 3:23 ` Yuquan Wang 2024-12-24 16:06 ` Jonathan Cameron via groups.io 0 siblings, 1 reply; 6+ messages in thread From: Yuquan Wang @ 2024-12-18 3:23 UTC (permalink / raw) To: jonathan.cameron, Benjamin.Cheatham Cc: marcin.juszkiewicz, ardb+tianocore, quic_llindhol, Jonathan.Cameron, chenbaozi, devel, linux-cxl On Thu, Dec 12, 2024 at 11:51:54AM +0800, Yuquan Wang wrote: > On Wed, Dec 11, 2024 at 03:40:03PM +0000, Alejandro Lucero Palau wrote: > > > > On 12/10/24 10:36, Yuquan Wang wrote: > > > v3 -> v4: > > > - Align base addresses of CXL relevant Windows > > > > > > v2 -> v3: > > > - PCDs values of pio, mmio32, mmio64 & ecam space for the independent cxl host > > > - CXL Bus range: 0x00 ~ 0xff > > > - Mcfg ecam structure for cxl > > > - Iort RC node for cxl > > > > > > RFC because > > > - Many contents are ported from Jonathan' patch on qemu virt design > > > > > > - Bring plenty of PCDs values > > > > > > - Less experience and not particularly confident in ACPI area > > > > > > This series leverages Jonathan's patches[1] to add acpi0016 & acpi0017 objects into the > > > previous DSDT table of sbsa-ref. Since my latest acpi0016 implementation model on qemu > > > side is a new host bridge qemu object rather than pxb-cxl, the cxl host(Segment 0001) > > > would have its own ECAM sapce. Meanwhile, this adds exclusive pio, mmio32 & mmio64 space > > > for cxl host. > > > > > > Hi Yuquan, > > > > > > Is there a roadmap for edk2 supporting other CXL features? > > > Hi, Alejandro > > Emmm. I have not find such edk2 roadmap (docs/webs/blog) yet. According to > what I've learnd, the edk2 upstream only support some head files which > define cxl registers structs and no cxl drivers have merged into upstream > now, and mostly system software's work haved been done in linux kernel. > > Regard to cxl patches in edk2, there is a series of patches in reviewing to > support enabling cxl-type3 device as memory expander on Arm/RD platform[1]. > > Link: > [1]: https://edk2.groups.io/g/devel/message/109488 > > > > I have noticed UEFI extensions are not supported yet, specifically > > EFI_ADAPTER_INFO_CDAT_TYPE_GUID as an instance of > > EFI_ADAPTER_INFORMATION_PROTOCOL. > > > > > > Any feedback would be welcome. > > > > > > Thanks > > > > > Hi, Jonathan & Ben Recently I am trying to test EINJ for cxl error on sbsa-ref based on Ben Cheatham's patches, but there seems no sample for cxl EINJ table in edk2. Hence, I manage to write the EINJ table by what I have learnd in ACPI SPEC, but I am struggling with which error injection actions need me to build. Do you know some limitations on this mechanism in QEMU or any suggestions? Many thanks Yuquan -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120909): https://edk2.groups.io/g/devel/message/120909 Mute This Topic: https://groups.io/mt/110023229/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [RFC PATCH edk2-platforms v4 0/1] add basic support for CXL on sbsa-ref 2024-12-18 3:23 ` Yuquan Wang @ 2024-12-24 16:06 ` Jonathan Cameron via groups.io 0 siblings, 0 replies; 6+ messages in thread From: Jonathan Cameron via groups.io @ 2024-12-24 16:06 UTC (permalink / raw) To: Yuquan Wang Cc: devel, Benjamin.Cheatham, marcin.juszkiewicz, ardb+tianocore, quic_llindhol, chenbaozi, linux-cxl On Wed, 18 Dec 2024 11:23:53 +0800 "Yuquan Wang" <wangyuquan1236@phytium.com.cn> wrote: > On Thu, Dec 12, 2024 at 11:51:54AM +0800, Yuquan Wang wrote: > > On Wed, Dec 11, 2024 at 03:40:03PM +0000, Alejandro Lucero Palau wrote: > > > > > > On 12/10/24 10:36, Yuquan Wang wrote: > > > > v3 -> v4: > > > > - Align base addresses of CXL relevant Windows > > > > > > > > v2 -> v3: > > > > - PCDs values of pio, mmio32, mmio64 & ecam space for the independent cxl host > > > > - CXL Bus range: 0x00 ~ 0xff > > > > - Mcfg ecam structure for cxl > > > > - Iort RC node for cxl > > > > > > > > RFC because > > > > - Many contents are ported from Jonathan' patch on qemu virt design > > > > > > > > - Bring plenty of PCDs values > > > > > > > > - Less experience and not particularly confident in ACPI area > > > > > > > > This series leverages Jonathan's patches[1] to add acpi0016 & acpi0017 objects into the > > > > previous DSDT table of sbsa-ref. Since my latest acpi0016 implementation model on qemu > > > > side is a new host bridge qemu object rather than pxb-cxl, the cxl host(Segment 0001) > > > > would have its own ECAM sapce. Meanwhile, this adds exclusive pio, mmio32 & mmio64 space > > > > for cxl host. > > > > > > > > > Hi Yuquan, > > > > > > > > > Is there a roadmap for edk2 supporting other CXL features? > > > > > Hi, Alejandro > > > > Emmm. I have not find such edk2 roadmap (docs/webs/blog) yet. According to > > what I've learnd, the edk2 upstream only support some head files which > > define cxl registers structs and no cxl drivers have merged into upstream > > now, and mostly system software's work haved been done in linux kernel. > > > > Regard to cxl patches in edk2, there is a series of patches in reviewing to > > support enabling cxl-type3 device as memory expander on Arm/RD platform[1]. > > > > Link: > > [1]: https://edk2.groups.io/g/devel/message/109488 > > > > > > I have noticed UEFI extensions are not supported yet, specifically > > > EFI_ADAPTER_INFO_CDAT_TYPE_GUID as an instance of > > > EFI_ADAPTER_INFORMATION_PROTOCOL. > > > > > > > > > Any feedback would be welcome. > > > > > > > > > Thanks > > > > > > > > > Hi, Jonathan & Ben > > Recently I am trying to test EINJ for cxl error on sbsa-ref based on Ben > Cheatham's patches, but there seems no sample for cxl EINJ table in edk2. > Hence, I manage to write the EINJ table by what I have learnd in ACPI > SPEC, but I am struggling with which error injection actions need me to > build. > > Do you know some limitations on this mechanism in QEMU or any suggestions? Sorry no idea. For error injection I've always focused on doing it from QEMU, not in firmware and on arm/virt not sbsa-ref so I have complete control of the ACPI tables. Not sure what's needed to make the EDK2 / SBSAref version work. Jonathan > > Many thanks > Yuquan > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120934): https://edk2.groups.io/g/devel/message/120934 Mute This Topic: https://groups.io/mt/110023229/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-12-24 16:07 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-12-10 10:36 [edk2-devel] [RFC PATCH edk2-platforms v4 0/1] add basic support for CXL on sbsa-ref Yuquan Wang 2024-12-10 10:36 ` [edk2-devel] [RFC PATCH edk2-platforms v4 1/1] SbsaQemu: Support basic CXL enablement Yuquan Wang 2024-12-11 15:40 ` [edk2-devel] [RFC PATCH edk2-platforms v4 0/1] add basic support for CXL on sbsa-ref Alejandro Lucero Palau via groups.io 2024-12-12 3:51 ` Yuquan Wang 2024-12-18 3:23 ` Yuquan Wang 2024-12-24 16:06 ` Jonathan Cameron via groups.io
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox