From: Breno Leitao <leitao@debian.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Usama Arif <usamaarif642@gmail.com>,
linux-efi@vger.kernel.org, devel@edk2.groups.io,
kexec@lists.infradead.org, hannes@cmpxchg.org, dyoung@redhat.com,
x86@kernel.org, linux-kernel@vger.kernel.org, gourry@gourry.net,
kernel-team@meta.com
Subject: Re: [edk2-devel] [RFC 2/2] efi/memattr: add efi_mem_attr_table as a reserved region in 820_table_firmware
Date: Fri, 10 Jan 2025 03:36:38 -0800 [thread overview]
Message-ID: <20250110-tricky-grasshopper-of-maturity-21771f@leitao> (raw)
In-Reply-To: <CAMj1kXFwgnQT4jQF8zsX05PdrF_QDXK0+Z-6DD6LiSgjqY738A@mail.gmail.com>
Hello Ard,
On Fri, Jan 10, 2025 at 08:32:08AM +0100, Ard Biesheuvel wrote:
> On Thu, 9 Jan 2025 at 17:32, Usama Arif <usamaarif642@gmail.com> wrote:
> > I think in the end whoevers' responsibility it is, the easiest path forward
> > seems to be in kernel? (and not firmware or libstub)
> >
>
> Agreed. But as I pointed out in the other thread, the memory
> attributes table only augments the memory map with permission
> information, and can be disregarded, and given how badly we mangle the
> memory map on x86, maybe this is the right choice here.
If this augmented memory is not preserved accross kexec, then the next
kexec'ed kernel will be able to find the original table?
I understand that the memattr region(s) need to be always (in each kexec
instances) `memblocked_reserved` to protect it from being used as a
System RAM, right?
Thus, if it is not passed throught e820, kexec'ed kernel needs to fetch
it again from original EFI table at kexec/boot time.
This brings me another question.
If the kexec'ed kernel sees the original memory, why can't it
augment/update the RX permissions *again*, instead of passing the
previous augmented version from previous kernel in this crazy dance.
> This is a kexec problem (on x86 only) so let's fix it there.
Would you mind explaining what kexec needs to be done differently?
Should it preserve the augmented memattr table independently if it is
mapped in e820?
Thank you!
--breno
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#121011): https://edk2.groups.io/g/devel/message/121011
Mute This Topic: https://groups.io/mt/110518541/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2025-01-15 18:53 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 21:53 [edk2-devel] [RFC 0/2] efi/memattr: Fix memory corruption and warning issues Usama Arif via groups.io
2025-01-08 21:53 ` [edk2-devel] [RFC 1/2] efi/memattr: Use desc_size instead of total size to check for corruption Usama Arif via groups.io
2025-01-09 15:45 ` Ard Biesheuvel via groups.io
2025-01-09 16:36 ` Usama Arif via groups.io
2025-01-10 7:21 ` Ard Biesheuvel via groups.io
2025-01-10 10:53 ` Usama Arif via groups.io
2025-01-10 17:25 ` Ard Biesheuvel via groups.io
2025-01-13 2:33 ` Dave Young via groups.io
2025-01-13 11:27 ` Usama Arif via groups.io
2025-01-13 12:00 ` Usama Arif via groups.io
2025-01-20 10:27 ` Usama Arif via groups.io
2025-01-20 10:32 ` Ard Biesheuvel via groups.io
2025-01-20 10:50 ` Usama Arif via groups.io
2025-01-20 11:29 ` Ard Biesheuvel via groups.io
2025-01-20 11:48 ` Usama Arif via groups.io
2025-01-22 5:36 ` Dave Young via groups.io
2025-01-22 11:50 ` Usama Arif via groups.io
2025-01-08 21:53 ` [edk2-devel] [RFC 2/2] efi/memattr: add efi_mem_attr_table as a reserved region in 820_table_firmware Usama Arif via groups.io
2025-01-09 16:15 ` Ard Biesheuvel via groups.io
2025-01-09 16:32 ` Usama Arif via groups.io
2025-01-09 16:47 ` Gregory Price
2025-01-10 7:32 ` Ard Biesheuvel via groups.io
2025-01-10 11:36 ` Breno Leitao [this message]
2025-01-10 17:33 ` Ard Biesheuvel via groups.io
2025-01-10 14:31 ` Usama Arif via groups.io
2025-01-10 15:50 ` Usama Arif via groups.io
2025-01-10 2:50 ` Dave Young via groups.io
2025-01-10 11:12 ` Usama Arif via groups.io
2025-01-10 11:18 ` Dave Young via groups.io
2025-01-10 11:20 ` Dave Young via groups.io
2025-01-10 11:42 ` Usama Arif via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250110-tricky-grasshopper-of-maturity-21771f@leitao \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox