[edk2-devel] [PATCH v1 0/1] uefi-sct/SctPkg: TCG2 Protocol: Expand BSCap.HashAlgorithmBitmap check

[edk2-devel] [PATCH v1 0/1] uefi-sct/SctPkg: TCG2 Protocol: Expand BSCap.HashAlgorithmBitmap check

[Amrathesh via groups.io]

Previously, the test only validated SHA-256 in
EFI_TCG2_BOOT_SERVICE_CAPABILITY.HashAlgorithmBitmap, This update checks
all supported SHA256-or-stronger algorithms.

REF: https://github.com/amrathesh/edk2-test/tree/tcg-upd

Amrathesh (1):
  uefi-sct/SctPkg: TCG2 Protocol: Expand BSCap.HashAlgorithmBitmap check

 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTestConformance.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

--
2.25.1

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#121030): https://edk2.groups.io/g/devel/message/121030
Mute This Topic: https://groups.io/mt/110712301/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: TCG2 Protocol: Expand BSCap.HashAlgorithmBitmap check

[Amrathesh via groups.io]

Previously, the test only validated SHA-256 in
EFI_TCG2_BOOT_SERVICE_CAPABILITY.HashAlgorithmBitmap,
This update checks all supported SHA256-or-stronger algorithms.

Signed-off-by: Amrathesh <amrathesh@arm.com>
---
 uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTestConformance.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTestConformance.c
index 2a3cd6aa4f23..2f2314386f5f 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTestConformance.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTestConformance.c
@@ -1,7 +1,7 @@
 /** @file

   Copyright 2006 - 2016 Unified EFI, Inc.<BR>
-  Copyright (c) 2021 - 2023, Arm Inc. All rights reserved.<BR>
+  Copyright (c) 2021 - 2023, 2025 Arm Inc. All rights reserved.<BR>

   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
@@ -346,7 +346,10 @@ BBTestGetCapabilityConformanceTestCheckpoint2 (
     AssertionType = EFI_TEST_ASSERTION_FAILED;
   }

-  if (!(BootServiceCap.HashAlgorithmBitmap & EFI_TCG2_BOOT_HASH_ALG_SHA256)) {
+  // Verify if system supports SHA256, SHA384, or SHA512 hashing algorithm
+  EFI_TCG2_EVENT_ALGORITHM_BITMAP HashAlgoSupportBitmap = EFI_TCG2_BOOT_HASH_ALG_SHA256 | EFI_TCG2_BOOT_HASH_ALG_SHA384 | EFI_TCG2_BOOT_HASH_ALG_SHA512;
+
+  if (!(BootServiceCap.HashAlgorithmBitmap & HashAlgoSupportBitmap)) {
     StandardLib->RecordMessage (
                      StandardLib,
                      EFI_VERBOSE_LEVEL_DEFAULT,
--
2.25.1

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#121029): https://edk2.groups.io/g/devel/message/121029
Mute This Topic: https://groups.io/mt/110712300/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: TCG2 Protocol: Expand BSCap.HashAlgorithmBitmap check

[G Edhaya Chandran via groups.io]

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

Changes look OK. Thank you Amrathesh.

Reviewed-by: G Edhaya Chandran <edhaya.chandran@arm.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#121035): https://edk2.groups.io/g/devel/message/121035
Mute This Topic: https://groups.io/mt/110712300/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 1071 bytes --]