[edk2-devel] [PATCH 2/4] NetworkPkg/HttpUtilitiesDxe: Free handle buffers after LocateHandleBuffer

["Dongyan Qian" <qiandongyan@loongson.cn>]

Fix memory leaks by adding missing FreePool calls:
free HandleBuffer in HttpUtilitiesDxeUnload.

REF: https://uefi.org/sites/default/files/resources/UEFI_Spec_Final_2.11.pdf
Chapter 7.3.15: "Services - Boot Services.LocateHandleBuffer":
It is the caller's responsibility to call the Boot Service.FreePool when
the caller no longer requires the contents of Buffer.

Signed-off-by: Dongyan Qian <qiandongyan@loongson.cn>
---
 NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.c b/NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.c
index a3e1ea4691..308d3b1ce9 100644
--- a/NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.c
+++ b/NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.c
@@ -59,7 +59,7 @@ HttpUtilitiesDxeUnload (
                     EFI_OPEN_PROTOCOL_BY_HANDLE_PROTOCOL
                     );
     if (EFI_ERROR (Status)) {
-      return Status;
+      goto Exit;
     }
 
     //
@@ -72,10 +72,15 @@ HttpUtilitiesDxeUnload (
                     NULL
                     );
     if (EFI_ERROR (Status)) {
-      return Status;
+      goto Exit;
     }
   }
 
+Exit:
+  if (HandleBuffer != NULL) {
+    gBS->FreePool (HandleBuffer);
+  }
+
   return EFI_SUCCESS;
 }
 
-- 
2.49.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#121416): https://edk2.groups.io/g/devel/message/121416
Mute This Topic: https://groups.io/mt/113583368/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-