[edk2-devel] [PATCH 4/4] RedfishPkg/RedfishConfigHandler: Free handle buffers after LocateHandleBuffer

["Dongyan Qian" <qiandongyan@loongson.cn>]

Fix memory leaks by adding missing FreePool calls:
free handle buffers in Stop and initialization routines.

REF: https://uefi.org/sites/default/files/resources/UEFI_Spec_Final_2.11.pdf
Chapter 7.3.15: "Services - Boot Services.LocateHandleBuffer":
It is the caller's responsibility to call the Boot Service.FreePool when
the caller no longer requires the contents of Buffer.

Signed-off-by: Dongyan Qian <qiandongyan@loongson.cn>
---
 .../RedfishConfigHandler/RedfishConfigHandlerCommon.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c
index bc1ba59835..d0e6a1aca7 100644
--- a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c
+++ b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c
@@ -189,7 +189,7 @@ RedfishConfigCommonStop (
                   &HandleBuffer
                   );
   if (EFI_ERROR (Status) && (Status != EFI_NOT_FOUND)) {
-    return Status;
+    goto Exit;
   }
 
   Status = EFI_SUCCESS;
@@ -208,6 +208,11 @@ RedfishConfigCommonStop (
     }
   }
 
+Exit:
+  if (HandleBuffer != NULL) {
+    FreePool (HandleBuffer);
+  }
+
   return Status;
 }
 
@@ -272,4 +277,8 @@ RedfishConfigHandlerInitialization (
                     );
     ASSERT_EFI_ERROR (Status);
   }
+
+  if (HandleBuffer != NULL) {
+    gBS->FreePool (HandleBuffer);
+  }
 }
-- 
2.49.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#121413): https://edk2.groups.io/g/devel/message/121413
Mute This Topic: https://groups.io/mt/113583365/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-