public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH edk2-platforms v1 1/1] Platform/ARM/VExpressPkg: Remove non-ASCII characters
@ 2021-02-17 16:10 Sami Mujawar
  2021-02-17 16:21 ` [edk2-devel] " Thomas Abraham
  0 siblings, 1 reply; 2+ messages in thread
From: Sami Mujawar @ 2021-02-17 16:10 UTC (permalink / raw)
  To: devel
  Cc: Sami Mujawar, ardb+tianocore, thomas.abraham, leif,
	Matteo.Carlini, Ben.Adderson, nd

The patch at "4be8625ab1b008057ae9a500aa8978be2a02d6e2
Platform/ARM/VExpressPkg: Add support for FVP RevC model"
introduced a new file SsdtPci.asl. The file SsdtPci.asl
had a few non-ASCII characters in the code comments.
These resulted in the Trim utility generating a warning
that caused the firmware build to fail on a Linux
development PC.

Therefore, remove the non-ASCII characters as it results
in builds failures on a Linux development PC.

Note: This issue was not observed on a Windows development
PC.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---

The changes can be seen at:
https://github.com/samimujawar/edk2-platforms/tree/1650_fix_non_ascii_chars_v1


 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl
index e4b5a02cc9571743c4a0300a0657f090ae996326..deabeb08c848d7d66f11fa53f7001ed14b74f193 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl
@@ -51,7 +51,7 @@
 
 /*
   See Reference [1] 6.1.1
-  "High word�Device #, Low word�Function #. (for example, device 3,
+  "High word Device #, Low word Function #. (for example, device 3,
   function 2 is 0x00030002). To refer to all the functions on a device #,
   use a function number of FFFF)."
 */
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-02-17 16:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-17 16:10 [PATCH edk2-platforms v1 1/1] Platform/ARM/VExpressPkg: Remove non-ASCII characters Sami Mujawar
2021-02-17 16:21 ` [edk2-devel] " Thomas Abraham

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox