public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sean" <sean.brogan@microsoft.com>
To: Bob Feng <bob.c.feng@intel.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] BaseTools/Scripts: Add scripts to set PACKAGES_PATH environment
Date: Mon, 06 Apr 2020 22:56:44 -0700	[thread overview]
Message-ID: <2040.1586239004752437525@groups.io> (raw)
In-Reply-To: <3c95986ac78541deafb786d1ae75a1ed@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1483 bytes --]

Bob and Ray,

My point isn't that there is anything wrong with script.  This script is designed to work with edk2-platforms repo or other repos of similar layout.   This is a "platform" thing that is needed on some platforms (not edk2 core platforms).  To me this means it does't belong in edk2 repo.

Anytime new functionality is proposed I think it is important to evaluate the stakeholders of the given repository that is targeted and make sure the functionality is aligned.  In my opinion when edk2 get too prescriptive about how to do things outside of edk2 or tries to prematurely provide functionality for all consumers to use then we often see this overhead added to the tree and low adoption rate.

I would propose to add this to edk2-platforms since that is where this is needed and build up a nice "platform" design pattern.   If it provides great value then talk about moving up in the repository stack.

Finally, I know this is a trivial and small script.  The overhead is minimal but i see this as a barometer for how the community aligns to support all isn't consumers.  Many of us have to maintain forks with significant changes because edk2 carries too many prescriptive ideas.  I want to push Tianocore to have better alignment with different repositories, their functionality and focus.  I want to see downstream consumers spend less time maintaining their fork and shipping code more closely aligned with the open source edk2.

thanks
Sean

[-- Attachment #2: Type: text/html, Size: 1615 bytes --]

      reply	other threads:[~2020-04-07  5:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-02  8:08 [PATCH] BaseTools/Scripts: Add scripts to set PACKAGES_PATH environment Heng Luo
2020-04-02 15:59 ` [edk2-devel] " Sean
2020-04-07  2:15   ` Ni, Ray
2020-04-07  3:37     ` Bob Feng
2020-04-07  5:56       ` Sean [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2040.1586239004752437525@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox