From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [PATCH] BaseTools/Scripts: Add scripts to set PACKAGES_PATH environment To: Bob Feng ,devel@edk2.groups.io From: "Sean" X-Originating-Location: Redmond, Washington, US (50.35.74.15) X-Originating-Platform: Windows Chrome 80 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Mon, 06 Apr 2020 22:56:44 -0700 References: <3c95986ac78541deafb786d1ae75a1ed@intel.com> In-Reply-To: <3c95986ac78541deafb786d1ae75a1ed@intel.com> Message-ID: <2040.1586239004752437525@groups.io> Content-Type: multipart/alternative; boundary="1KQW7Bi2t94OWIZSKlAI" --1KQW7Bi2t94OWIZSKlAI Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Bob and Ray, My point isn't that there is anything wrong with script.=C2=A0 This script= is designed to work with edk2-platforms repo or other repos of similar lay= out.=C2=A0 =C2=A0This is a "platform" thing that is needed on some platform= s (not edk2 core platforms).=C2=A0 To me this means it does't belong in edk= 2 repo. Anytime new functionality is proposed I think it is important to evaluate = the stakeholders of the given repository that is targeted and make sure the= functionality is aligned.=C2=A0 In my opinion when edk2 get too prescripti= ve about how to do things outside of edk2 or tries to prematurely provide f= unctionality for all consumers to use then we often see this overhead added= to the tree and low adoption rate. I would propose to add this to edk2-platforms since that is where this is = needed and build up a nice "platform" design pattern.=C2=A0 =C2=A0If it pro= vides great value then talk about moving up in the repository stack. Finally, I know this is a trivial and small script.=C2=A0 The overhead is = minimal but i see this as a barometer for how the community aligns to suppo= rt all isn't consumers.=C2=A0 Many of us have to maintain forks with signif= icant changes because edk2 carries too many prescriptive ideas.=C2=A0 I wan= t to push Tianocore to have better alignment with different repositories, t= heir functionality and focus.=C2=A0 I want to see downstream consumers spen= d less time maintaining their fork and shipping code more closely aligned w= ith the open source edk2. thanks Sean --1KQW7Bi2t94OWIZSKlAI Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Bob and Ray,

My point isn't that there is anything wrong with sc= ript.  This script is designed to work with edk2-platforms repo or oth= er repos of similar layout.   This is a "platform" thing that is = needed on some platforms (not edk2 core platforms).  To me this means = it does't belong in edk2 repo. 

Anytime new functionality = is proposed I think it is important to evaluate the stakeholders of the giv= en repository that is targeted and make sure the functionality is aligned.&= nbsp; In my opinion when edk2 get too prescriptive about how to do things o= utside of edk2 or tries to prematurely provide functionality for all consum= ers to use then we often see this overhead added to the tree and low adopti= on rate.   

I would propose to add this to edk2-platfo= rms since that is where this is needed and build up a nice "platform" desig= n pattern.   If it provides great value then talk about moving up= in the repository stack.  

Finally, I know this is a = trivial and small script.  The overhead is minimal but i see this as a= barometer for how the community aligns to support all isn't consumers.&nbs= p; Many of us have to maintain forks with significant changes because edk2 = carries too many prescriptive ideas.  I want to push Tianocore to have= better alignment with different repositories, their functionality and focu= s.  I want to see downstream consumers spend less time maintaining the= ir fork and shipping code more closely aligned with the open source edk2.&n= bsp; 

thanks
Sean --1KQW7Bi2t94OWIZSKlAI--