From: "Ni, Ray" <ray.ni@intel.com>
To: Chang, Abner <abner.chang@amd.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II C Coding Standard: Updates 4.2 and 4.3 sections
Date: Mon, 17 Oct 2022 23:01:36 -0700 [thread overview]
Message-ID: <20513.1666072896702226815@groups.io> (raw)
In-Reply-To: <20221015114757.383-1-abner.chang@amd.com>
[-- Attachment #1: Type: text/plain, Size: 395 bytes --]
All look good to me. Thanks for addressing my comments regarding simplifying the rules.
Except for one minor comment: I still don't think we need to define rules for source file names (4.3.5.4 EDK II source files within a Library/Module instance).
And the rule "[<CpuArch>][<Vendor>]<FileName>.*" doesn't specify what <FileName> could be. That leads to allowing any style of the file name.
[-- Attachment #2: Type: text/html, Size: 419 bytes --]
next prev parent reply other threads:[~2022-10-18 6:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 11:47 [tianocore-docs][PATCH V2 2/2] edk II C Coding Standard: Updates 4.2 and 4.3 sections Chang, Abner
2022-10-18 6:01 ` Ni, Ray [this message]
2022-10-18 9:50 ` [edk2-devel] " Chang, Abner
2022-10-19 1:31 ` Chang, Abner
2022-10-19 3:34 ` Ni, Ray
2022-10-19 4:17 ` Chang, Abner
2022-10-18 13:33 ` Sunil V L
2022-10-18 15:23 ` Chang, Abner
2022-10-19 2:24 ` Attar, AbdulLateef (Abdul Lateef)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20513.1666072896702226815@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox