From mboxrd@z Thu Jan  1 00:00:00 1970
Subject: Re: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II C Coding Standard: Updates 4.2 and 4.3 sections
To: Chang, Abner <abner.chang@amd.com>,devel@edk2.groups.io
From: "Ni, Ray" <ray.ni@intel.com>
X-Originating-Location: CN (192.55.46.52)
X-Originating-Platform: Windows Chrome 106
User-Agent: GROUPS.IO Web Poster
MIME-Version: 1.0
Date: Mon, 17 Oct 2022 23:01:36 -0700
References: <20221015114757.383-1-abner.chang@amd.com>
In-Reply-To: <20221015114757.383-1-abner.chang@amd.com>
Message-ID: <20513.1666072896702226815@groups.io>
Content-Type: multipart/alternative; boundary="Ja8Qjt5MHwYsGestxiOl"

--Ja8Qjt5MHwYsGestxiOl
Content-Type: text/plain; charset="utf-8"; markup=markdown
Content-Transfer-Encoding: quoted-printable

All look good to me. Thanks for addressing my comments regarding simplifyin=
g the rules.

Except for one minor comment: I still don't think we need to define rules f=
or source file names (4.3.5.4 EDK II source files within a Library/Module i=
nstance).
And the rule "[<CpuArch>][<Vendor>]<FileName>.*" doesn't specify what <File=
Name> could be. That leads to allowing any style of the file name.

--Ja8Qjt5MHwYsGestxiOl
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

<p>All look good to me. Thanks for addressing my comments regarding simplif=
ying the rules.</p>

<p>Except for one minor comment: I still don't think we need to define rule=
s for source file names (4.3.5.4 EDK II source files within a Library/Modul=
e instance).
And the rule &quot;[<CpuArch>][<Vendor>]<FileName>.*&quot; doesn't specify =
what <FileName> could be. That leads to allowing any style of the file name=
.</p>

--Ja8Qjt5MHwYsGestxiOl--