public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Benjamin Doron" <benjamin.doron00@gmail.com>
To: "JamesWang [王家明]" <JamesWang@ami.com>, devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v2 1/1] BoardModulePkg/BoardBdsHookLib: Fix F7 overwrites Boot0000
Date: Tue, 13 Sep 2022 20:03:32 -0700	[thread overview]
Message-ID: <20766.1663124612326533866@groups.io> (raw)
In-Reply-To: <20220913093457.14644-2-jameswang@ami.com>

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

I agree this is good, but an alternate option is to EfiBootManagerGetBootManagerMenu(), as I've implemented here: https://edk2.groups.io/g/devel/topic/84876596. Then, the boot menu is guaranteed to have it's boot option.

However, as Nate mentioned, there's the issue of https://github.com/tianocore/edk2-platforms/blob/784f7739f5afd268042d4d9e8ef570131620c82c/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc#L323 and https://github.com/tianocore/edk2-platforms/blob/784f7739f5afd268042d4d9e8ef570131620c82c/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc#L210. So, might we prefer this implementation?

[-- Attachment #2: Type: text/html, Size: 1127 bytes --]

  reply	other threads:[~2022-09-14  3:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-13  9:36 [PATCH v2 0/1] BoardModulePkg/BoardBdsHookLib: Fix F7 overwrites Boot0000 JamesWang [王家明]
2022-09-13  9:36 ` [PATCH v2 1/1] " JamesWang [王家明]
2022-09-14  3:03   ` Benjamin Doron [this message]
2022-09-16  0:05   ` Isaac Oram
     [not found]   ` <17152E7C7C5C0A9D.29000@groups.io>
2022-09-16  0:08     ` [edk2-devel] " Isaac Oram
2022-09-16  6:21       ` JamesWang [王家明]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20766.1663124612326533866@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox