From mboxrd@z Thu Jan  1 00:00:00 1970
Subject: Re: [edk2-devel] [PATCH v2 1/1] BoardModulePkg/BoardBdsHookLib: Fix F7 overwrites Boot0000
To: =?UTF-8?B?SmFtZXNXYW5nIFvnjovlrrbmmI5d?= <JamesWang@ami.com>,devel@edk2.groups.io
From: "Benjamin Doron" <benjamin.doron00@gmail.com>
X-Originating-Location: Richmond Hill, Ontario, CA (24.52.200.135)
X-Originating-Platform: Linux Firefox 104
User-Agent: GROUPS.IO Web Poster
MIME-Version: 1.0
Date: Tue, 13 Sep 2022 20:03:32 -0700
References: <20220913093457.14644-2-jameswang@ami.com>
In-Reply-To: <20220913093457.14644-2-jameswang@ami.com>
Message-ID: <20766.1663124612326533866@groups.io>
Content-Type: multipart/alternative; boundary="Ea4eRTdzOnpYumAr5WtW"

--Ea4eRTdzOnpYumAr5WtW
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

I agree this is good, but an alternate option is to EfiBootManagerGetBootMa=
nagerMenu(), as I've implemented here: https://edk2.groups.io/g/devel/topic=
/84876596. Then, the boot menu is guaranteed to have it's boot option.

However, as Nate mentioned, there's the issue of https://github.com/tianoco=
re/edk2-platforms/blob/784f7739f5afd268042d4d9e8ef570131620c82c/Platform/In=
tel/WhitleyOpenBoardPkg/PlatformPkg.dsc#L323 and https://github.com/tianoco=
re/edk2-platforms/blob/784f7739f5afd268042d4d9e8ef570131620c82c/Platform/In=
tel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc#L210. So, might we=
 prefer this implementation?

--Ea4eRTdzOnpYumAr5WtW
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

I agree this is good, but an alternate option is to EfiBootManagerGetBootMa=
nagerMenu(), as I've implemented here: <a href=3D"https://edk2.groups.io/g/=
devel/topic/84876596" target=3D"_blank" rel=3D"noopener">https://edk2.group=
s.io/g/devel/topic/84876596</a>. Then, the boot menu is guaranteed to have =
it's boot option.<br /><br />However, as Nate mentioned, there's the issue =
of <a href=3D"https://github.com/tianocore/edk2-platforms/blob/784f7739f5af=
d268042d4d9e8ef570131620c82c/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg=
.dsc#L323" target=3D"_blank" rel=3D"noopener">https://github.com/tianocore/=
edk2-platforms/blob/784f7739f5afd268042d4d9e8ef570131620c82c/Platform/Intel=
/WhitleyOpenBoardPkg/PlatformPkg.dsc#L323</a> and <a href=3D"https://github=
.com/tianocore/edk2-platforms/blob/784f7739f5afd268042d4d9e8ef570131620c82c=
/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc#L210" =
target=3D"_blank" rel=3D"noopener">https://github.com/tianocore/edk2-platfo=
rms/blob/784f7739f5afd268042d4d9e8ef570131620c82c/Platform/Intel/SimicsOpen=
BoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc#L210</a>. So, might we prefer th=
is implementation?

--Ea4eRTdzOnpYumAr5WtW--