public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: "levi.yun" <yeoreum.yun@arm.com>, devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH edk2-platform v1 1/2] ARM/VExpressPkg: Use BaseRngLib for NetworkPkg as default
Date: Fri, 02 Aug 2024 09:49:03 -0700	[thread overview]
Message-ID: <20829.1722617343489581581@groups.io> (raw)
In-Reply-To: <20240722151025.936649-2-yeoreum.yun@arm.com>

[-- Attachment #1: Type: text/plain, Size: 774 bytes --]

Hi Levi,

Thank you for this patch.

It looks like your git settings may not be right. I was not able to apply your patch cleanly and the updated files had mixed line endings.
You may want to try running edk2\BaseTools\Scripts\SetupGit.py script in edk2 & edk2-platforms folder.

I will fix this locally before merging.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120215): https://edk2.groups.io/g/devel/message/120215
Mute This Topic: https://groups.io/mt/107486797/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 1416 bytes --]

      reply	other threads:[~2024-08-02 16:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-22 15:10 [edk2-devel] [PATCH edk2-platform v1 0/2] Fix NetworkPkg load failure on ArmJuno levi.yun
2024-07-22 15:10 ` [edk2-devel] [PATCH edk2-platform v1 1/2] ARM/VExpressPkg: Use BaseRngLib for NetworkPkg as default levi.yun
2024-08-02 16:49   ` Sami Mujawar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20829.1722617343489581581@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox