public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: devel@edk2.groups.io, zhichao.gao@intel.com
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <liming.gao@intel.com>,
	Dandan Bi <dandan.bi@intel.com>
Subject: Re: [edk2-devel] [PATCH 0/3] MdePkg/DebugLib: Change the global variable name
Date: Tue, 23 Apr 2019 09:50:14 +0200	[thread overview]
Message-ID: <2088964c-f2dc-d854-7140-0b2daa4cc79a@redhat.com> (raw)
In-Reply-To: <20190423023507.16952-1-zhichao.gao@intel.com>

On 4/23/19 4:35 AM, Gao, Zhichao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740
> 
> The DebugLib instances of DebugPortProtocol, ConOut and StdErr
> use a global variable "mExitBootServicesEvent" which is in
> conflict with the same variable in StatusCodeHandlerRuntimeDxe.inf.
> That would cause a build error through GCC5. So change the
> name to the "mDebugLibExitBootServicesEvent".
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> 
> Zhichao Gao (3):
>   MdePkg/UefiDebugLibConOut: Change the global variable name
>   MdePkg/UefiDebugLibStdErr: Change the global variable name
>   MdePkg/UefiDebugLibDebugPortProtocol: Change the global variable name
> 
>  MdePkg/Library/UefiDebugLibConOut/DebugLibConstructor.c       | 4 ++--
>  .../UefiDebugLibDebugPortProtocol/DebugLibConstructor.c       | 4 ++--
>  MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c       | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

  parent reply	other threads:[~2019-04-23  7:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-23  2:35 [PATCH 0/3] MdePkg/DebugLib: Change the global variable name Gao, Zhichao
2019-04-23  2:35 ` [PATCH 1/3] MdePkg/UefiDebugLibConOut: " Gao, Zhichao
2019-04-23  2:35 ` [PATCH 2/3] MdePkg/UefiDebugLibStdErr: " Gao, Zhichao
2019-04-23  2:35 ` [PATCH 3/3] MdePkg/UefiDebugLibDebugPortProtocol: " Gao, Zhichao
2019-04-23  2:37 ` [edk2-devel] [PATCH 0/3] MdePkg/DebugLib: " Liming Gao
2019-04-23  7:50 ` Philippe Mathieu-Daudé [this message]
2019-04-23 14:07 ` Laszlo Ersek
2019-04-24  2:54   ` Gao, Zhichao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2088964c-f2dc-d854-7140-0b2daa4cc79a@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox