From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.221.66, mailfrom: philmd@redhat.com) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by groups.io with SMTP; Tue, 23 Apr 2019 00:50:23 -0700 Received: by mail-wr1-f66.google.com with SMTP id t17so18796719wrw.13 for ; Tue, 23 Apr 2019 00:50:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UrZNB4V7V1BqZZQmK/ToRys03H7G+QK2wPdv9QNSJas=; b=mOdES0rIHM/7xm79Kzjxx1FH0p8CHuKitn4kH/R4m69ExHfa1EnEBQSyqhXKMSmOFU 3HnqU5ibqUhyCLqkcNf9CtWiSO9poG4nAiWb8rDwUN1lquoQOJIkH+aLhq3z3AVN1oep c+B3dotwydd2kXtrLCKWlEeYQhO5WQqKt9GwQhQs6IMwCiOoBjwNUBbpWwByKcSXc8DS frDU/35jGRkz4HCWu5TH7u2VvPIBJkmvBkieZ0Xn4TdHH/mIYh6tRuXG6Ylo4lfzCCli vigh3UyTjWhRBRT3pGiTO6ps9otUvoN/HXGjLIQA8U+McKwSqUetWvDD2xULMuRfcZkA 0RiQ== X-Gm-Message-State: APjAAAVkm8QJ7tS4zm8hQ2n0tqYSgfuplwT33ml0pLfQdod3rRCBRQIB hIYc09E7dkB/idHK0k/wAUhsaw== X-Google-Smtp-Source: APXvYqwhk4n8iUJ3paQMYovdPTsrKIgc/kl+5PRNyvZw5E81knKUFS7wTRUDyjtJg7kPZ7rLZxaJKg== X-Received: by 2002:adf:cf0e:: with SMTP id o14mr15246387wrj.182.1556005822015; Tue, 23 Apr 2019 00:50:22 -0700 (PDT) Return-Path: Received: from [192.168.1.25] (atoulouse-656-1-803-163.w86-221.abo.wanadoo.fr. [86.221.12.163]) by smtp.gmail.com with ESMTPSA id n18sm10931773wrt.16.2019.04.23.00.50.17 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 23 Apr 2019 00:50:21 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 0/3] MdePkg/DebugLib: Change the global variable name To: devel@edk2.groups.io, zhichao.gao@intel.com Cc: Michael D Kinney , Liming Gao , Dandan Bi References: <20190423023507.16952-1-zhichao.gao@intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <2088964c-f2dc-d854-7140-0b2daa4cc79a@redhat.com> Date: Tue, 23 Apr 2019 09:50:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190423023507.16952-1-zhichao.gao@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 4/23/19 4:35 AM, Gao, Zhichao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 > > The DebugLib instances of DebugPortProtocol, ConOut and StdErr > use a global variable "mExitBootServicesEvent" which is in > conflict with the same variable in StatusCodeHandlerRuntimeDxe.inf. > That would cause a build error through GCC5. So change the > name to the "mDebugLibExitBootServicesEvent". > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Dandan Bi > > Zhichao Gao (3): > MdePkg/UefiDebugLibConOut: Change the global variable name > MdePkg/UefiDebugLibStdErr: Change the global variable name > MdePkg/UefiDebugLibDebugPortProtocol: Change the global variable name > > MdePkg/Library/UefiDebugLibConOut/DebugLibConstructor.c | 4 ++-- > .../UefiDebugLibDebugPortProtocol/DebugLibConstructor.c | 4 ++-- > MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > Reviewed-by: Philippe Mathieu-Daude