public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Purma, Kondal R" <kondal.r.purma@intel.com>
To: Sean <sean.brogan@microsoft.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] EDK II Python development process specification -draft
Date: Sat, 07 Mar 2020 15:26:13 -0800	[thread overview]
Message-ID: <2090.1583623573262214944@groups.io> (raw)
In-Reply-To: <10736.1583616938364039740@groups.io>

[-- Attachment #1: Type: text/plain, Size: 627 bytes --]

Thanks for feedback an your are exactly right. This applies for new module/project and every point you mentioned is valid.

We should also make sure these rules applies to bug fixes, or code adding as feature in existing files.

I raised all these question my self and taken initial step.

As a first step,  developed wrapper tool (POC) to apply flake8 on patches only which we can immediately adopt to Basetools etc..

Along with the POC tool(if possible we can make as flake8 plugin) , I will come up with presentation to address all our concerns. We can review and finalize the best practices.

Thanks,
Kondal.

[-- Attachment #2: Type: text/html, Size: 675 bytes --]

  reply	other threads:[~2020-03-07 23:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-07  0:27 EDK II Python development process specification -draft Purma, Kondal R
2020-03-07 21:35 ` [edk2-devel] " Sean
2020-03-07 23:26   ` Purma, Kondal R [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-03-10 20:05 Rebecca Cran
2020-03-11 16:52 ` Purma, Kondal R
2020-03-14 19:07   ` Purma, Kondal R
2020-03-16 10:21     ` Bob Feng
2020-03-24 20:22       ` Purma, Kondal R
2020-03-25 21:23         ` Purma, Kondal R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2090.1583623573262214944@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox