Re: [edk2-devel] [PATCH v1 0/7] Uncrustify GoogleTest update

["Michael Kubacki" <mikuback@linux.microsoft.com>]

I don't see the package maintainers actually in Cc for these patches. 
You might want to resend the series with them copied as their email 
rules might otherwise not bring the emails to their attention.

Thanks,
Michael

On 8/9/2023 5:32 PM, VivianNK wrote:
> Introduce cpp-specific formatting rules to Uncrustify for readability:
>   * indent_class: indent lines inside of a class
>   * indent_extern: indent lines inside of an extern
> 
> Apply all Uncrustify formatting rules defined in the config to existing
> cpp and header files (GoogleTest files).
> 
> Moving forward all GoogleTest files will be included in uncrustify
> formatting checks, leading to more consistency and greater readability.
> 
> VivianNK (7):
>    .pytool: Set uncrustify check to audit only
>    .pytool: Add cpp support to uncrustify plugin
>    MdeModulePkg: Applyy uncrustify formatting to relevant files.
>    MdePkg: Apply uncrustify formatting to relevant files
>    SecurityPkg: Apply uncrustify formatting to relevant files
>    UnitTestFrameworkPkg: Apply uncrustify formatting to relevant files
>    .pytool: Undo uncrustify check change
> 
>   .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py                                                       |   2 +-
>   .pytool/Plugin/UncrustifyCheck/uncrustify.cfg                                                           |   4 +-
>   MdeModulePkg/Library/UefiSortLib/GoogleTest/UefiSortLibGoogleTest.cpp                                   |  37 +-
>   MdeModulePkg/Test/Mock/Include/GoogleTest/Library/MockPciHostBridgeLib.h                                |   4 +-
>   MdeModulePkg/Test/Mock/Library/GoogleTest/MockPciHostBridgeLib/MockPciHostBridgeLib.cpp                 |   8 +-
>   MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTests32.cpp                        | 114 ++--
>   MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTests64.cpp                        | 114 ++--
>   MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/TestBaseSafeIntLib.cpp                                    | 563 ++++++++++----------
>   MdePkg/Test/Mock/Include/GoogleTest/Library/MockHobLib.h                                                |   6 +-
>   MdePkg/Test/Mock/Include/GoogleTest/Library/MockPeiServicesLib.h                                        |   6 +-
>   MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiLib.h                                               |   4 +-
>   MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiRuntimeServicesTableLib.h                           |   4 +-
>   MdePkg/Test/Mock/Library/GoogleTest/MockHobLib/MockHobLib.cpp                                           |  40 +-
>   MdePkg/Test/Mock/Library/GoogleTest/MockPeiServicesLib/MockPeiServicesLib.cpp                           |  52 +-
>   MdePkg/Test/Mock/Library/GoogleTest/MockUefiLib/MockUefiLib.cpp                                         |   6 +-
>   MdePkg/Test/Mock/Library/GoogleTest/MockUefiRuntimeServicesTableLib/MockUefiRuntimeServicesTableLib.cpp |  12 +-
>   SecurityPkg/Library/SecureBootVariableLib/GoogleTest/SecureBootVariableLibGoogleTest.cpp                | 205 ++++---
>   SecurityPkg/Test/Mock/Include/GoogleTest/Library/MockPlatformPKProtectionLib.h                          |   4 +-
>   SecurityPkg/Test/Mock/Library/GoogleTest/MockPlatformPKProtectionLib/MockPlatformPKProtectionLib.cpp    |   4 +-
>   UnitTestFrameworkPkg/Include/Library/GoogleTestLib.h                                                    |   2 +-
>   UnitTestFrameworkPkg/Test/GoogleTest/Sample/SampleGoogleTest/SampleGoogleTest.cpp                       |  76 +--
>   21 files changed, 664 insertions(+), 603 deletions(-)
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107758): https://edk2.groups.io/g/devel/message/107758
Mute This Topic: https://groups.io/mt/100655288/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-