From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C2F4D740032 for ; Tue, 15 Aug 2023 01:32:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=68f8U4hRguuBGXQ/tSOugoVg5/i2DGOB3vMPzALhImw=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1692063174; v=1; b=r6nivLbuD8WGM4qu0IK8B9icO813monEVow03zqF2IbAw4PF6eA2hxPJ+WsBXOa0Zc4wus1O R2iQLjc4/0PR225RaUhPuTcMqTnFWEPAq1NaviQYzH7QZTDTaw/GEVqwvBAbETOAO7sK1osRzRT dIfrZIdUebIxFMOoqWZ0nsC0= X-Received: by 127.0.0.2 with SMTP id lhcDYY7687511xpdL92IHuVq; Mon, 14 Aug 2023 18:32:54 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.124716.1692063173966795726 for ; Mon, 14 Aug 2023 18:32:54 -0700 X-Received: from [192.168.4.22] (unknown [47.201.241.95]) by linux.microsoft.com (Postfix) with ESMTPSA id 1F4A22109443; Mon, 14 Aug 2023 18:32:53 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1F4A22109443 Message-ID: <20948e55-edab-7d27-fbe3-cb890315e4bf@linux.microsoft.com> Date: Mon, 14 Aug 2023 21:32:51 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 0/7] Uncrustify GoogleTest update To: devel@edk2.groups.io, vnowkakeane@linux.microsoft.com References: <20230809213226.1387-1-vnowkakeane@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: <20230809213226.1387-1-vnowkakeane@linux.microsoft.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: OaM4TLnSFPl0OtQUwg7VeoDKx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=r6nivLbu; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io I don't see the package maintainers actually in Cc for these patches.=20 You might want to resend the series with them copied as their email=20 rules might otherwise not bring the emails to their attention. Thanks, Michael On 8/9/2023 5:32 PM, VivianNK wrote: > Introduce cpp-specific formatting rules to Uncrustify for readability: > * indent_class: indent lines inside of a class > * indent_extern: indent lines inside of an extern >=20 > Apply all Uncrustify formatting rules defined in the config to existing > cpp and header files (GoogleTest files). >=20 > Moving forward all GoogleTest files will be included in uncrustify > formatting checks, leading to more consistency and greater readability. >=20 > VivianNK (7): > .pytool: Set uncrustify check to audit only > .pytool: Add cpp support to uncrustify plugin > MdeModulePkg: Applyy uncrustify formatting to relevant files. > MdePkg: Apply uncrustify formatting to relevant files > SecurityPkg: Apply uncrustify formatting to relevant files > UnitTestFrameworkPkg: Apply uncrustify formatting to relevant files > .pytool: Undo uncrustify check change >=20 > .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py = | 2 +- > .pytool/Plugin/UncrustifyCheck/uncrustify.cfg = | 4 +- > MdeModulePkg/Library/UefiSortLib/GoogleTest/UefiSortLibGoogleTest.cpp = | 37 +- > MdeModulePkg/Test/Mock/Include/GoogleTest/Library/MockPciHostBridgeLib.= h | 4 +- > MdeModulePkg/Test/Mock/Library/GoogleTest/MockPciHostBridgeLib/MockPciH= ostBridgeLib.cpp | 8 +- > MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTe= sts32.cpp | 114 ++-- > MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTe= sts64.cpp | 114 ++-- > MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/TestBaseSafeIntLib.cpp = | 563 ++++++++++---------- > MdePkg/Test/Mock/Include/GoogleTest/Library/MockHobLib.h = | 6 +- > MdePkg/Test/Mock/Include/GoogleTest/Library/MockPeiServicesLib.h = | 6 +- > MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiLib.h = | 4 +- > MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiRuntimeServicesTabl= eLib.h | 4 +- > MdePkg/Test/Mock/Library/GoogleTest/MockHobLib/MockHobLib.cpp = | 40 +- > MdePkg/Test/Mock/Library/GoogleTest/MockPeiServicesLib/MockPeiServicesL= ib.cpp | 52 +- > MdePkg/Test/Mock/Library/GoogleTest/MockUefiLib/MockUefiLib.cpp = | 6 +- > MdePkg/Test/Mock/Library/GoogleTest/MockUefiRuntimeServicesTableLib/Moc= kUefiRuntimeServicesTableLib.cpp | 12 +- > SecurityPkg/Library/SecureBootVariableLib/GoogleTest/SecureBootVariable= LibGoogleTest.cpp | 205 ++++--- > SecurityPkg/Test/Mock/Include/GoogleTest/Library/MockPlatformPKProtecti= onLib.h | 4 +- > SecurityPkg/Test/Mock/Library/GoogleTest/MockPlatformPKProtectionLib/Mo= ckPlatformPKProtectionLib.cpp | 4 +- > UnitTestFrameworkPkg/Include/Library/GoogleTestLib.h = | 2 +- > UnitTestFrameworkPkg/Test/GoogleTest/Sample/SampleGoogleTest/SampleGoog= leTest.cpp | 76 +-- > 21 files changed, 664 insertions(+), 603 deletions(-) >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107758): https://edk2.groups.io/g/devel/message/107758 Mute This Topic: https://groups.io/mt/100655288/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-