public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Wang, Jian J" <jian.j.wang@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Sukerkar, Amol N" <amol.n.sukerkar@intel.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>
Subject: Re: [edk2-devel] [Patch v10 2/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API
Date: Wed, 5 Feb 2020 22:23:30 +0100	[thread overview]
Message-ID: <20c793e1-82ea-c360-36ed-bfb703c491fa@redhat.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9E86F1A@ORSMSX113.amr.corp.intel.com>

On 02/05/20 17:18, Kinney, Michael D wrote:
> Jian,
> 
> I agree.  If the PCD type is anything but FixedAtBuild,
> the compiler can not optimize away the unused BaseCryptLib
> functions.
> 
> I think the best solution is to limit this PCD to only
> FixedAtBuild.

I agree that that technically solves the problem, and it also seems like
a justifiable design decision.

> Thank you for noticing this issue Laszlo!

Whenever I pull from master, I tend to skim the new commits quickly in
"gitk". Nothing resembling real patch review, I just have a few
"favorite" :) areas that stand out to me on occasion (not always, of
course).

Thanks!
Laszlo


      reply	other threads:[~2020-02-05 21:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-03 23:35 [Patch v10 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API Michael D Kinney
2020-02-03 23:35 ` [Patch v10 1/2] CryptoPkg: Add CryptoPkg Token Space GUID Michael D Kinney
2020-02-03 23:35 ` [Patch v10 2/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API Michael D Kinney
2020-02-04  2:53   ` Yao, Jiewen
2020-02-04  5:24     ` [edk2-devel] " Zhang, Chao B
2020-02-04 16:29       ` Michael D Kinney
2020-02-04 16:26     ` Michael D Kinney
2020-02-04 17:10       ` Sukerkar, Amol N
2020-02-04 18:30         ` Sukerkar, Amol N
2020-02-04 23:06         ` Yao, Jiewen
2020-02-04 23:15           ` Sukerkar, Amol N
2020-02-04 23:20             ` Yao, Jiewen
2020-02-04 23:22               ` Sukerkar, Amol N
2020-02-04 22:54       ` Yao, Jiewen
2020-02-05  1:04         ` Michael D Kinney
2020-02-05  1:32           ` Yao, Jiewen
2020-02-05 11:00   ` [edk2-devel] " Laszlo Ersek
2020-02-05 13:53     ` Wang, Jian J
2020-02-05 16:18       ` Michael D Kinney
2020-02-05 21:23         ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20c793e1-82ea-c360-36ed-bfb703c491fa@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox