From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61])
 by mx.groups.io with SMTP id smtpd.web12.2163.1580937823388820881
 for <devel@edk2.groups.io>;
 Wed, 05 Feb 2020 13:23:43 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AkDmA8g/;
 spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1580937822;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=IGmvi727RFIdawHEOanWbvDAowcbK9/4gxja/d+PdrE=;
	b=AkDmA8g/+v1PvrAipki+CUJlqdlp5l+2vb5WPEzCPRwM7yApJoFe30TYYMrjEJ2KGqwNiA
	yPqFt2TiA+k6GELUEVobwSwyAuix6o1Ba7ZNOpkuFWoYowZxRRrWJgsAJfNqYw274IpjN3
	jo7mJwag7BB+WNZSDp3LngCkV/OqjLA=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-266-k2jxsY8HO3WzhgXYBCLEtw-1; Wed, 05 Feb 2020 16:23:34 -0500
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E37F9107B0E1;
	Wed,  5 Feb 2020 21:23:32 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-248.ams2.redhat.com [10.36.116.248])
	by smtp.corp.redhat.com (Postfix) with ESMTP id A92F38DC0F;
	Wed,  5 Feb 2020 21:23:31 +0000 (UTC)
Subject: Re: [edk2-devel] [Patch v10 2/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
 "Wang, Jian J" <jian.j.wang@intel.com>,
 "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Sukerkar, Amol N" <amol.n.sukerkar@intel.com>,
 "Yao, Jiewen" <jiewen.yao@intel.com>
References: <20200203233548.7616-1-michael.d.kinney@intel.com>
 <20200203233548.7616-3-michael.d.kinney@intel.com>
 <7a85ca5b-c083-959d-0064-73d45a422396@redhat.com>
 <D827630B58408649ACB04F44C510003625A0815E@SHSMSX107.ccr.corp.intel.com>
 <E92EE9817A31E24EB0585FDF735412F5B9E86F1A@ORSMSX113.amr.corp.intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <20c793e1-82ea-c360-36ed-bfb703c491fa@redhat.com>
Date: Wed, 5 Feb 2020 22:23:30 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9E86F1A@ORSMSX113.amr.corp.intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-MC-Unique: k2jxsY8HO3WzhgXYBCLEtw-1
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 02/05/20 17:18, Kinney, Michael D wrote:
> Jian,
> 
> I agree.  If the PCD type is anything but FixedAtBuild,
> the compiler can not optimize away the unused BaseCryptLib
> functions.
> 
> I think the best solution is to limit this PCD to only
> FixedAtBuild.

I agree that that technically solves the problem, and it also seems like
a justifiable design decision.

> Thank you for noticing this issue Laszlo!

Whenever I pull from master, I tend to skim the new commits quickly in
"gitk". Nothing resembling real patch review, I just have a few
"favorite" :) areas that stand out to me on occasion (not always, of
course).

Thanks!
Laszlo