Re: [edk2-CCodingStandardsSpecification PATCH 0/2] improvements related to line wrapping

[Laszlo Ersek <lersek@redhat.com>]

Mike,

On 08/11/17 19:07, Kinney, Michael D wrote:
> Laszlo,
> 
> You can also provide links to the GitHub commits with "?w=1"
> flag appended.  If you select the "Display the rich diff" button
> above each changed file, GitHub renders a view with change bars.
> 
> https://github.com/lersek/edk2-CCodingStandardsSpecification/commit/2c5534a24b15616fdaa02478858ed1d8908dc653?w=1

I opened two browser tabs with this link, one without "?w=1" and another
with "?w=1", and compared the contents visually (by switching back and
forth between the tabs), checking each screen-ful. I'm not seeing any
differences.

When I click the button that you mention, I do get a rendered diff as
well. I wonder if this feature is javascript-only, or if it can be
triggered with URL changes.

Thanks
Laszlo

> 
> https://github.com/lersek/edk2-CCodingStandardsSpecification/commit/e3797dc48316052005cefa26246ab2fd32641881?w=1
> 
> Best regards,
> 
> Mike
> 
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>> Sent: Friday, August 11, 2017 9:49 AM
>> To: edk2-devel-01 <edk2-devel@lists.01.org>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Justen, Jordan L
>> <jordan.l.justen@intel.com>; Leif Lindholm
>> <leif.lindholm@linaro.org>; Kinney, Michael D
>> <michael.d.kinney@intel.com>
>> Subject: [edk2-CCodingStandardsSpecification PATCH 0/2]
>> improvements related to line wrapping
>>
>> We've discussed these ideas repeatedly over time; I'm now
>> attempting to
>> formalize them. Also test-driving the documentation contribution
>> process.
>>
>> - Repo: https://github.com/lersek/edk2-
>> CCodingStandardsSpecification.git
>> - Branch: line_wrapping
>> - Rendered views of the pages modified:
>>   - https://lersek.gitbooks.io/laszlo-s-fork-of-the-edk-ii-c-
>> coding-standards-sp/content/v/line_wrapping/#edk-ii-c-coding-
>> standards-specification
>>   - https://lersek.gitbooks.io/laszlo-s-fork-of-the-edk-ii-c-
>> coding-standards-sp/content/v/line_wrapping/5_source_files/#51-
>> general-rules
>>   - https://lersek.gitbooks.io/laszlo-s-fork-of-the-edk-ii-c-
>> coding-standards-
>> sp/content/v/line_wrapping/5_source_files/52_spacing.html#52-
>> spacing
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>
>> Thanks
>> Laszlo
>>
>> Laszlo Ersek (2):
>>   Source Files / General Rules: limit line lengths to 80 columns
>>   Source Files / Spacing / Multi-line func. calls: allow
>> condensed
>>     arguments
>>
>>  5_source_files/52_spacing.md | 29 +++++++++++++++++++-
>>  5_source_files/README.md     | 17 ++++++++----
>>  README.md                    |  2 ++
>>  3 files changed, 42 insertions(+), 6 deletions(-)
>>
>> --
>> 2.13.1.3.g8be5a757fa67
>